jankratochvil updated this revision to Diff 149037.
jankratochvil edited the summary of this revision.
https://reviews.llvm.org/D40470
Files:
source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
source/Plugins/SymbolFile/DWARF/DWARFUnit.h
Index: source/Plugins/SymbolFile/DWARF/DWARFUnit.h
I would like to apologize, I forgot to `git add `the Makefile and this
broke the bots. It should be fixed now. I'll keep an eye to make sure
everything stays green.
Sorry for the disruption, folks!
--
Davide
On Tue, May 29, 2018 at 3:08 PM, Davide Italiano via lldb-commits
wrote:
> Author:
Pavel, this should be fixed now that I added a Makefile.
Don't hesitate to revert in case it stays red (or fix it yourself,
even better :)
--
Davide
On Tue, May 29, 2018 at 3:26 PM, wrote:
> The Buildbot has detected a new failure on builder
> lldb-x86_64-ubuntu-14.04-cmake while building
Author: davide
Date: Tue May 29 15:20:05 2018
New Revision: 333466
URL: http://llvm.org/viewvc/llvm-project?rev=333466=rev
Log:
[ObjC] Add a Makefile for the test added in r333465.
Not strictly necessary, but makes the test more robust in case
we end up changing the defaults.
Added:
Author: davide
Date: Tue May 29 15:08:07 2018
New Revision: 333465
URL: http://llvm.org/viewvc/llvm-project?rev=333465=rev
Log:
[ObjC] Fix the formatter for NSOrderedSet.
While I'm here, delete some dead code.
Added:
lldb/trunk/packages/Python/lldbsuite/test/lang/objc/orderedset/
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D47495
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
JDevlieghere updated this revision to Diff 148986.
JDevlieghere edited the summary of this revision.
JDevlieghere added a comment.
- Address Greg's feedback
https://reviews.llvm.org/D47495
Files:
source/Utility/FileSpec.cpp
Index: source/Utility/FileSpec.cpp
JDevlieghere added inline comments.
Comment at: include/lldb/Utility/FileSpec.h:535
- void RemoveLastPathComponent();
+ void RemoveLastPathComponent(bool keep_dot = false);
clayborg wrote:
> Why add this? If the path is just "." to begin with, there is
clayborg added inline comments.
Comment at: source/Utility/FileSpec.cpp:821
}
+
//--
revert whitespace change.
https://reviews.llvm.org/D47495
___
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Remove the argument since we don't need it. Just assume we keep ".".
Comment at: include/lldb/Utility/FileSpec.h:535
- void RemoveLastPathComponent();
+
jasonmolenda added a comment.
This looks good. My original change in r311622 to add this "remove the last
two file path components" should have explicitly said that this is only done
for DBGVersion == 2 to make it clearer for people reading the code.
At this point the parsing code behaves
JDevlieghere created this revision.
JDevlieghere added reviewers: jasonmolenda, clayborg, labath.
When reading DBGSourcePathRemapping from a dSYM, we remove the last two path
components to make the source lookup more general. However, when dealing with a
relative path that has less than 2
jankratochvil created this revision.
jankratochvil added a reviewer: clayborg.
Herald added a subscriber: JDevlieghere.
https://reviews.llvm.org/rL145086 introduced `m_die_array.shrink_to_fit()`
implemented by `exact_size_die_array.swap`, it was before LLVM became written
in C++11.
That is
Author: jankratochvil
Date: Tue May 29 12:14:46 2018
New Revision: 333452
URL: http://llvm.org/viewvc/llvm-project?rev=333452=rev
Log:
Remove unused DWARFUnit::HasDIEsParsed()
It was not implemented correctly after https://reviews.llvm.org/D46810 but then
it has not been used anywhere anyway.
jankratochvil marked an inline comment as done.
jankratochvil added inline comments.
Comment at: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:208
+void DWARFUnit::ExtractDIEsEndCheck(lldb::offset_t offset) const {
+ lldb::offset_t next_cu_offset =
Author: jankratochvil
Date: Tue May 29 11:53:25 2018
New Revision: 333449
URL: http://llvm.org/viewvc/llvm-project?rev=333449=rev
Log:
Fix compiler unused variable warning in DWARFUnit
Alex Langford has reported it from: https://reviews.llvm.org/D46810
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL333444: Remove lldb-private headers when building
LLDB.framework with CMake (authored by xiaobai, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
Author: xiaobai
Date: Tue May 29 11:09:09 2018
New Revision: 333444
URL: http://llvm.org/viewvc/llvm-project?rev=333444=rev
Log:
Remove lldb-private headers when building LLDB.framework with CMake
Summary:
Generating LLDB.framework when building with CMake+Ninja will copy the
lldb-private
clayborg added a comment.
So my previous code suggestion might not work as we would want to recurse
through the specification or abstract origin chain.
https://reviews.llvm.org/D47470
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
clayborg added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFDIE.cpp:222
+return true;
+ return GetReferencedDIE(DW_AT_specification)
+ .GetParent()
labath wrote:
> clayborg wrote:
> > I can never remember when a
Author: jankratochvil
Date: Tue May 29 10:17:46 2018
New Revision: 333437
URL: http://llvm.org/viewvc/llvm-project?rev=333437=rev
Log:
Fix DWARFUnit::GetUnitDIEPtrOnly stale pointer
GetUnitDIEPtrOnly() needs to return pointer to the first DIE.
But the first element of m_die_array after
labath added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFDIE.cpp:222
+return true;
+ return GetReferencedDIE(DW_AT_specification)
+ .GetParent()
clayborg wrote:
> I can never remember when a DW_AT_abstract_origin might be used.
Author: jdevlieghere
Date: Tue May 29 09:49:07 2018
New Revision: 333432
URL: http://llvm.org/viewvc/llvm-project?rev=333432=rev
Log:
[lit] Add support for passing arguments to dotest.py via lit.
The lldb test suite is highly configurable. While part of this
configuration takes place at
jankratochvil marked an inline comment as done.
jankratochvil added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:86
// Keep a flat array of the DIE for binary lookup by DIE offset
- if (!cu_die_only) {
+ {
Log *log(
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Only question is if we remove the extra empty scope as noted in inline
comments. Looks good.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:86
// Keep a
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
So nice to get rid of these HandleCommand hacks!
Repository:
rL LLVM
https://reviews.llvm.org/D47415
___
lldb-commits mailing list
clayborg added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp:153
+return true;
+ bool looking_for_methods = name_type_mask & eFunctionNameTypeMethod;
+ return looking_for_methods == die.IsMethod();
move up to line 150 and
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
Thanks Pavel, LGTM.
https://reviews.llvm.org/D47470
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
Author: jdevlieghere
Date: Tue May 29 05:30:27 2018
New Revision: 333412
URL: http://llvm.org/viewvc/llvm-project?rev=333412=rev
Log:
[test] Fix --framework argument passed to dotest.
The framework argument was broken when I removed the generator
expressions upstream. I replaced $ with
labath created this revision.
labath added reviewers: clayborg, JDevlieghere.
Herald added a subscriber: aprantl.
When searching for methods only, we need to do extra work to make sure
the functions we get from the apple tables are indeed methods.
Previously we were resolving the DIE into a
Author: labath
Date: Tue May 29 02:22:58 2018
New Revision: 333401
URL: http://llvm.org/viewvc/llvm-project?rev=333401=rev
Log:
XFAIL TestMachCore for windows hosts
It's been failing since I enabled the test for non-darwin targets. I
made it reference the same bug as the linux core, as it's
This revision was automatically updated to reflect the committed changes.
Closed by commit rL333400: Remove Linux-specific includes for
posix/FileSystem.cpp (authored by brucem, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D47420
Author: brucem
Date: Tue May 29 02:14:40 2018
New Revision: 333400
URL: http://llvm.org/viewvc/llvm-project?rev=333400=rev
Log:
Remove Linux-specific includes for posix/FileSystem.cpp
Summary:
This improves the process of cross-compiling from macOS to Linux
since these files aren't used / needed
This revision was automatically updated to reflect the committed changes.
Closed by commit rL99: Typo fixes. (authored by brucem, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D47421
Files:
Author: brucem
Date: Tue May 29 02:10:46 2018
New Revision: 99
URL: http://llvm.org/viewvc/llvm-project?rev=99=rev
Log:
Typo fixes.
Reviewers: javed.absar
Subscribers: ki.stfu, JDevlieghere, lldb-commits
Differential Revision: https://reviews.llvm.org/D47421
Modified:
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
I bet this stopped being necessary when most of the filesystem code was moved
into llvm.
https://reviews.llvm.org/D47420
___
lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL98: ManualDWARFIndex: Treat DW_TAG_subprogram and
DW_TAG_inlined_subroutine the… (authored by labath, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
Author: labath
Date: Tue May 29 01:16:22 2018
New Revision: 98
URL: http://llvm.org/viewvc/llvm-project?rev=98=rev
Log:
ManualDWARFIndex: Treat DW_TAG_subprogram and DW_TAG_inlined_subroutine the
same way
Summary:
We were treating subprograms and inlined subroutines differently when
38 matches
Mail list logo
