[Lldb-commits] [lldb] r333974 - Fix Expression unittests on Darwin

Author: jdevlieghere Date: Mon Jun 4 17:32:41 2018 New Revision: 333974 URL: http://llvm.org/viewvc/llvm-project?rev=333974=rev Log: Fix Expression unittests on Darwin Fixes the Expression unittests on Darwin after r333933 was landed. Modified:

[Lldb-commits] [lldb] r333971 - Add ClangHost.cpp to the Xcode project.

Author: jingham Date: Mon Jun 4 17:19:03 2018 New Revision: 333971 URL: http://llvm.org/viewvc/llvm-project?rev=333971=rev Log: Add ClangHost.cpp to the Xcode project. Also add an include that was needed for the if APPLE branch of the function. Modified:

[Lldb-commits] [lldb] r333968 - Change SWIG output directory when building LLDB.framework with CMake

Author: xiaobai Date: Mon Jun 4 16:47:36 2018 New Revision: 333968 URL: http://llvm.org/viewvc/llvm-project?rev=333968=rev Log: Change SWIG output directory when building LLDB.framework with CMake Instead of assuming that SWIG generated files (e.g. lldb.py) will live in scripts, we should set

[Lldb-commits] [PATCH] D47742: Change SWIG output directory when building LLDB.framework with CMake

This revision was automatically updated to reflect the committed changes. Closed by commit rL333968: Change SWIG output directory when building LLDB.framework with CMake (authored by xiaobai, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[Lldb-commits] [PATCH] D47629: [DWARF] Add (empty) DebugNamesDWARFIndex class and a setting to control its use

clayborg added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:122 +PropertyDefinition g_experimental_properties[] = { +{"use-debug-names", OptionValue::eTypeBoolean, true, 0, nullptr, nullptr, + "Use .debug_names index section."},

[Lldb-commits] [PATCH] D47147: DWARFIndex: Reduce duplication in the GetFunctions methods

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Some if statements simplifications if you want to, but looks good. Comment at: source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp:193-195 + if

[Lldb-commits] [PATCH] D47742: Change SWIG output directory when building LLDB.framework with CMake

sas added inline comments. Comment at: scripts/CMakeLists.txt:38 OUTPUT ${LLDB_WRAP_PYTHON} - OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/lldb.py DEPENDS ${SWIG_SOURCES} xiaobai wrote: > sas wrote: > > ...and this path were not the same before your change. Was

[Lldb-commits] [lldb] r333963 - [lldb, lldb-mi] Enable lldb-mi -break-insert test on Windows.

Author: apolyakov Date: Mon Jun 4 15:39:40 2018 New Revision: 333963 URL: http://llvm.org/viewvc/llvm-project?rev=333963=rev Log: [lldb, lldb-mi] Enable lldb-mi -break-insert test on Windows. Summary: The default name for a compiler output on Linux is `a.out`, while on Windows it's `a.exe`. But

[Lldb-commits] [PATCH] D47679: [lldb, lldb-mi] Enable lldb-mi -break-insert test on Windows.

This revision was automatically updated to reflect the committed changes. Closed by commit rL333963: [lldb, lldb-mi] Enable lldb-mi -break-insert test on Windows. (authored by apolyakov, committed by ). Changed prior to commit: https://reviews.llvm.org/D47679?vs=149629=149863#toc Repository:

[Lldb-commits] [PATCH] D47742: Change SWIG output directory when building LLDB.framework with CMake

xiaobai added inline comments. Comment at: scripts/CMakeLists.txt:38 OUTPUT ${LLDB_WRAP_PYTHON} - OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/lldb.py DEPENDS ${SWIG_SOURCES} sas wrote: > ...and this path were not the same before your change. Was that a bug that >

[Lldb-commits] [PATCH] D47742: Change SWIG output directory when building LLDB.framework with CMake

sas accepted this revision. sas added inline comments. This revision is now accepted and ready to land. Comment at: CMakeLists.txt:149 DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/scripts/finishSwigWrapperClasses.py -DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/scripts/lldb.py

[Lldb-commits] [PATCH] D47742: Change SWIG output directory when building LLDB.framework with CMake

xiaobai added reviewers: labath, sas. xiaobai added a comment. I'm not sure who else would be interested in reviewing this. If you know somebody, please add them. :) https://reviews.llvm.org/D47742 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D47742: Change SWIG output directory when building LLDB.framework with CMake

xiaobai created this revision. xiaobai added a reviewer: clayborg. Herald added a subscriber: mgorny. Instead of assuming that SWIG generated files (e.g. lldb.py) will live in scripts, we should set it to $LLDB_PYTHON_TARGET_DIR. This variable is set to scripts, except when building

[Lldb-commits] [PATCH] D47492: DWARFUnit::m_die_array swap()->shrink_to_fit()

dblaikie added a comment. In https://reviews.llvm.org/D47492#1120599, @jankratochvil wrote: > FYI I have filed it for libstdc++ but I did not really understand their > reaction: Bug 86013 - std::vector::shrink_to_fit() could sometimes use > realloc()

[Lldb-commits] [PATCH] D47679: [lldb, lldb-mi] Enable lldb-mi -break-insert test on Windows.

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. I stand corrected. The test didn't hang. https://reviews.llvm.org/D47679 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D47384: Remove dependency from Host to clang

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL333933: Remove dependency from Host to clang. (authored by zturner, committed by ). Herald added a subscriber:

[Lldb-commits] [lldb] r333933 - Remove dependency from Host to clang.

Author: zturner Date: Mon Jun 4 10:41:00 2018 New Revision: 333933 URL: http://llvm.org/viewvc/llvm-project?rev=333933=rev Log: Remove dependency from Host to clang. Host depended on clang because HostInfo had a function to get the directory where clang was installed. We move this over to the

[Lldb-commits] [PATCH] D47646: [IRMemoryMap] Use labels in the "malloc" and "free" lldb-test commands

This revision was automatically updated to reflect the committed changes. Closed by commit rL333930: [IRMemoryMap] Use labels in the malloc and free lldb-test commands (authored by vedantk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r333930 - [IRMemoryMap] Use labels in the "malloc" and "free" lldb-test commands

Author: vedantk Date: Mon Jun 4 10:11:15 2018 New Revision: 333930 URL: http://llvm.org/viewvc/llvm-project?rev=333930=rev Log: [IRMemoryMap] Use labels in the "malloc" and "free" lldb-test commands Change the syntax of the malloc and free commands in lldb-test's ir-memory-map subcommand to:

[Lldb-commits] [PATCH] D47646: [IRMemoryMap] Use labels in the "malloc" and "free" lldb-test commands

stella.stamenova added a comment. In https://reviews.llvm.org/D47646#1120498, @labath wrote: > Looks great, thanks for doing this. > > As far as windows goes, I believe that there we simply don't have the memory > allocation part implemented, so it's not surprising that these tests fail. It >

[Lldb-commits] [PATCH] D47579: dotest: make inline tests compatible with -f

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM > Can you try inserting something like this instead of the > `ApplyDecoratorsToFunction` line and see if your problems go away? > > @wraps(InlineTest._test) > def

[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: asmith, zturner. Herald added a subscriber: mgorny. The patch adds support of splitted functions (when MSVC is used with PGO) and function-level linking feature. SymbolFilePDB::ParseCompileUnitLineTable function relies on

[Lldb-commits] [lldb] r333889 - [LLDB] Unit tests basic support for OpenBSD

Author: devnexen Date: Mon Jun 4 04:59:18 2018 New Revision: 333889 URL: http://llvm.org/viewvc/llvm-project?rev=333889=rev Log: [LLDB] Unit tests basic support for OpenBSD OpenBSD python module. Added: lldb/trunk/packages/Python/lldbsuite/test/plugins/builder_openbsd.py Added:

[Lldb-commits] [lldb] r333888 - [LLDB] Unit tests basic support for OpenBSD

Author: devnexen Date: Mon Jun 4 04:57:12 2018 New Revision: 333888 URL: http://llvm.org/viewvc/llvm-project?rev=333888=rev Log: [LLDB] Unit tests basic support for OpenBSD Add OpenBSD python module in order to support unit tests. Reviewers: labath, zturner Reviewed By: labath Differential

[Lldb-commits] [PATCH] D47492: DWARFUnit::m_die_array swap()->shrink_to_fit()

jankratochvil added a comment. FYI I have filed it for libstdc++ but I did not really understand their reaction: Bug 86013 - std::vector::shrink_to_fit() could sometimes use realloc() Repository: rL LLVM https://reviews.llvm.org/D47492

[Lldb-commits] [PATCH] D47147: DWARFIndex: Reduce duplication in the GetFunctions methods

labath updated this revision to Diff 149702. labath added a comment. This is a rewrite of the original patch with the same idea but different approach. Now that Apple index determines method-ness straight from the debug info, we don't need to resolve the functions into SymbolContexts. This

[Lldb-commits] [PATCH] D47470: AppleDWARFIndex: Get function method-ness directly from debug info

This revision was automatically updated to reflect the committed changes. Closed by commit rL333878: AppleDWARFIndex: Get function method-ness directly from debug info (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[Lldb-commits] [lldb] r333878 - AppleDWARFIndex: Get function method-ness directly from debug info

Author: labath Date: Mon Jun 4 02:05:27 2018 New Revision: 333878 URL: http://llvm.org/viewvc/llvm-project?rev=333878=rev Log: AppleDWARFIndex: Get function method-ness directly from debug info Summary: When searching for methods only, we need to do extra work to make sure the functions we get

[Lldb-commits] [PATCH] D47646: [IRMemoryMap] Use labels in the "malloc" and "free" lldb-test commands

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks great, thanks for doing this. As far as windows goes, I believe that there we simply don't have the memory allocation part implemented, so it's not surprising that these tests fail. It

[Lldb-commits] [PATCH] D47625: [cmake] Detect presence of wide-char libedit at build time

labath added inline comments. Comment at: include/lldb/Host/Editline.h:72-76 #ifdef EL_CLIENTDATA /* editline with wide support + wide char read function */ using EditLineGetCharType = wchar_t; #else using EditLineGetCharType = char; #endif christos