[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

asmith added a comment. Thanks! Much better without the binaries. https://reviews.llvm.org/D47708 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D47923: Added missing include to LoadedModuleInfoList.h

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL334259: Added missing include to LoadedModuleInfoList.h (authored by teemperor, committed by ). Herald added a

[Lldb-commits] [lldb] r334259 - Added missing include to LoadedModuleInfoList.h

Author: teemperor Date: Thu Jun 7 19:00:27 2018 New Revision: 334259 URL: http://llvm.org/viewvc/llvm-project?rev=334259=rev Log: Added missing include to LoadedModuleInfoList.h Subscribers: lldb-commits Differential Revision: https://reviews.llvm.org/D47923 Modified:

[Lldb-commits] [PATCH] D47923: Added missing include to LoadedModuleInfoList.h

teemperor created this revision. https://reviews.llvm.org/D47923 Files: include/lldb/Core/LoadedModuleInfoList.h Index: include/lldb/Core/LoadedModuleInfoList.h === --- include/lldb/Core/LoadedModuleInfoList.h +++

[Lldb-commits] [PATCH] D47914: [lldb-mi] Add overloaded method for setting an error.

This revision was automatically updated to reflect the committed changes. Closed by commit rL334245: [lldb-mi] Add overloaded method for setting an error. (authored by apolyakov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r334245 - [lldb-mi] Add overloaded method for setting an error.

Author: apolyakov Date: Thu Jun 7 16:03:49 2018 New Revision: 334245 URL: http://llvm.org/viewvc/llvm-project?rev=334245=rev Log: [lldb-mi] Add overloaded method for setting an error. Reviewers: aprantl, clayborg Reviewed By: clayborg Subscribers: ki.stfu, lldb-commits Differential Revision:

[Lldb-commits] [PATCH] D47914: [lldb-mi] Add overloaded method for setting an error.

apolyakov created this revision. apolyakov added reviewers: aprantl, clayborg. Herald added a subscriber: ki.stfu. https://reviews.llvm.org/D47914 Files: tools/lldb-mi/MICmdBase.cpp tools/lldb-mi/MICmdBase.h Index: tools/lldb-mi/MICmdBase.h

[Lldb-commits] [PATCH] D47415: [lldb, lldb-mi] Re-implement MI -exec-continue command.

polyakov.alex added inline comments. Comment at: tools/lldb-mi/MICmdCmdExec.cpp:248 } - } else { -// ToDo: Re-evaluate if this is required when application near finished as -// this is parsing LLDB error message -// which seems a hack and is code brittle -

[Lldb-commits] [PATCH] D47415: [lldb, lldb-mi] Re-implement MI -exec-continue command.

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Also need to remove m_lldbResult from the CMICmdCmdExecContinue class. Comment at: tools/lldb-mi/MICmdCmdExec.cpp:248 } - } else { -// ToDo:

[Lldb-commits] [PATCH] D47415: [lldb, lldb-mi] Re-implement MI -exec-continue command.

clayborg added inline comments. Comment at: tools/lldb-mi/MICmdCmdExec.cpp:248 } - } else { -// ToDo: Re-evaluate if this is required when application near finished as -// this is parsing LLDB error message -// which seems a hack and is code brittle -const

[Lldb-commits] [PATCH] D47415: [lldb, lldb-mi] Re-implement MI -exec-continue command.

clayborg added inline comments. Comment at: tools/lldb-mi/MICmdCmdExec.cpp:248 } - } else { -// ToDo: Re-evaluate if this is required when application near finished as -// this is parsing LLDB error message -// which seems a hack and is code brittle -const

[Lldb-commits] [PATCH] D47415: [lldb, lldb-mi] Re-implement MI -exec-continue command.

polyakov.alex added inline comments. Comment at: tools/lldb-mi/MICmdCmdExec.cpp:248 } - } else { -// ToDo: Re-evaluate if this is required when application near finished as -// this is parsing LLDB error message -// which seems a hack and is code brittle -

[Lldb-commits] [PATCH] D47415: [lldb, lldb-mi] Re-implement MI -exec-continue command.

clayborg added inline comments. Comment at: tools/lldb-mi/MICmdCmdExec.cpp:248 } - } else { -// ToDo: Re-evaluate if this is required when application near finished as -// this is parsing LLDB error message -// which seems a hack and is code brittle -const

[Lldb-commits] [lldb] r334225 - Remove commented out line from top-level CMakeLists.txt

Author: xiaobai Date: Thu Jun 7 13:17:46 2018 New Revision: 334225 URL: http://llvm.org/viewvc/llvm-project?rev=334225=rev Log: Remove commented out line from top-level CMakeLists.txt Modified: lldb/trunk/CMakeLists.txt Modified: lldb/trunk/CMakeLists.txt URL:

[Lldb-commits] [lldb] r334221 - [FileSystem] Split up the OpenFlags enumeration.

Author: zturner Date: Thu Jun 7 12:58:58 2018 New Revision: 334221 URL: http://llvm.org/viewvc/llvm-project?rev=334221=rev Log: [FileSystem] Split up the OpenFlags enumeration. This breaks the OpenFlags enumeration into two separate enumerations: OpenFlags and CreationDisposition. The first

[Lldb-commits] [lldb] r334219 - Check for process_vm_readv using CheckSymbolExists

Author: xiaobai Date: Thu Jun 7 12:53:25 2018 New Revision: 334219 URL: http://llvm.org/viewvc/llvm-project?rev=334219=rev Log: Check for process_vm_readv using CheckSymbolExists Instead of checking if code compiles, I think it is a better to check if the symbol exists. This is simpler and

[Lldb-commits] [PATCH] D47897: Check for process_vm_readv using CheckSymbolExists

This revision was automatically updated to reflect the committed changes. Closed by commit rL334219: Check for process_vm_readv using CheckSymbolExists (authored by xiaobai, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D47897 Files:

[Lldb-commits] [PATCH] D47897: Check for process_vm_readv using CheckSymbolExists

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. This should be functionally identical and is much cleaner. Thanks! https://reviews.llvm.org/D47897 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D47415: [lldb, lldb-mi] Re-implement MI -exec-continue command.

polyakov.alex updated this revision to Diff 150391. polyakov.alex added a comment. Updated because of commited -exec-next and -exec-step commands. https://reviews.llvm.org/D47415 Files: lit/tools/lldb-mi/exec/exec-continue.test tools/lldb-mi/MICmdCmdExec.cpp Index:

[Lldb-commits] [PATCH] D47625: [cmake] Detect presence of wide-char libedit at build time

christos added inline comments. Comment at: include/lldb/Host/Editline.h:72-76 #ifdef EL_CLIENTDATA /* editline with wide support + wide char read function */ using EditLineGetCharType = wchar_t; #else using EditLineGetCharType = char; #endif labath

[Lldb-commits] [PATCH] D47797: [lldb-mi] Re-implement MI -exec-next command.

This revision was automatically updated to reflect the committed changes. Closed by commit rL334215: [lldb-mi] Re-implement MI -exec-next command. (authored by apolyakov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r334215 - [lldb-mi] Re-implement MI -exec-next command.

Author: apolyakov Date: Thu Jun 7 12:09:01 2018 New Revision: 334215 URL: http://llvm.org/viewvc/llvm-project?rev=334215=rev Log: [lldb-mi] Re-implement MI -exec-next command. Summary: Now -exec-next command uses SB API for stepping over. Reviewers: aprantl, clayborg, stella.stamenova, labath

[Lldb-commits] [PATCH] D47897: Check for process_vm_readv using CheckSymbolExists

xiaobai created this revision. xiaobai added reviewers: eugene, labath, beanz. Herald added a subscriber: mgorny. Instead of checking if code compiles, I think it is a better to check if the symbol exists. This is simpler and should do the same thing. https://reviews.llvm.org/D47897 Files:

[Lldb-commits] [lldb] r334210 - [lit, windows] Disable a number of tests that are failing on Windows

Author: stella.stamenova Date: Thu Jun 7 10:49:22 2018 New Revision: 334210 URL: http://llvm.org/viewvc/llvm-project?rev=334210=rev Log: [lit, windows] Disable a number of tests that are failing on Windows Summary: They all correspond to bugs that are already logged and I've added the

[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

aleksandr.urakov added a comment. I replaced all binaries by a lit-based test, as you told. The only thing, I have made it more like other PDB tests. https://reviews.llvm.org/D47708 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

aleksandr.urakov updated this revision to Diff 150356. aleksandr.urakov added a comment. Avoid binaries in tests. https://reviews.llvm.org/D47708 Files: lit/SymbolFile/PDB/Inputs/FunctionLevelLinkingTest.cpp lit/SymbolFile/PDB/Inputs/FunctionLevelLinkingTest.h

[Lldb-commits] [PATCH] D47539: [Platform] Accept arbitrary kext variants

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL334205: [Platform] Accept arbitrary kext variants (authored by JDevlieghere, committed by ). Herald added a subscriber:

[Lldb-commits] [lldb] r334205 - [Platform] Accept arbitrary kext variants

Author: jdevlieghere Date: Thu Jun 7 09:10:42 2018 New Revision: 334205 URL: http://llvm.org/viewvc/llvm-project?rev=334205=rev Log: [Platform] Accept arbitrary kext variants When loading kexts in PlatformDarwinKernel, we use the BundleID as the filename to to create shared modules. In

[Lldb-commits] [PATCH] D47889: Use llvm::VersionTuple instead of manual version marshalling

labath created this revision. labath added reviewers: zturner, friss, clayborg, jingham. Herald added a subscriber: emaste. This has multiple advantages: - we need only one function argument/instance variable instead of three - no need to default initialize variables - no custom parsing code -

[Lldb-commits] [PATCH] D47838: [lldb-mi] Re-implement MI -exec-step command.

polyakov.alex updated this revision to Diff 150332. polyakov.alex added a comment. Changes for using thread ids in a gdb way. Also added case of specified thread into test case. https://reviews.llvm.org/D47838 Files: lit/tools/lldb-mi/exec/exec-step.test tools/lldb-mi/MICmdCmdExec.cpp

[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

aleksandr.urakov added a comment. In https://reviews.llvm.org/D47708#1125029, @labath wrote: > Thank you for implementing the lldb-test extension. Now that we have that, > and the `/order`, we should be able to get rid of the binaries for the > function-level-linking test. You should be able

[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

labath added a comment. In https://reviews.llvm.org/D47708#1125030, @aleksandr.urakov wrote: > In https://reviews.llvm.org/D47708#1124994, @zturner wrote: > > > As a general rule, lld-link is command line compatible with MSVC and > > clang-cl is command line compatible with cl. So, the /order

[Lldb-commits] [PATCH] D47797: [lldb-mi] Re-implement MI -exec-next command.

labath accepted this revision. labath added a comment. looks good to me https://reviews.llvm.org/D47797 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

aleksandr.urakov added a comment. In https://reviews.llvm.org/D47708#1124994, @zturner wrote: > As a general rule, lld-link is command line compatible with MSVC and > clang-cl is command line compatible with cl. So, the /order option should > work exactly the same with lld-link as it does

[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

labath added a comment. Thank you for implementing the lldb-test extension. Now that we have that, and the `/order`, we should be able to get rid of the binaries for the function-level-linking test. You should be able to rewrite it into something like this:

[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

zturner added a comment. As a general rule, lld-link is command line compatible with MSVC and clang-cl is command line compatible with cl. So, the /order option should work exactly the same with lld-link as it does with link. https://reviews.llvm.org/D47708

Re: [Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

As a general rule, lld-link is command line compatible with MSVC and clang-cl is command line compatible with cl. So, the /order option should work exactly the same with lld-link as it does with link. On Thu, Jun 7, 2018 at 7:00 AM Aleksandr Urakov via Phabricator < revi...@reviews.llvm.org>

[Lldb-commits] [PATCH] D47797: [lldb-mi] Re-implement MI -exec-next command.

polyakov.alex updated this revision to Diff 150328. polyakov.alex added a comment. Changes for using thread ids in a gdb way. Also added case of specified thread into test case. https://reviews.llvm.org/D47797 Files: lit/tools/lldb-mi/exec/exec-next.test

[Lldb-commits] [PATCH] D47881: DebugNamesDWARFIndex: Implement GetFunctions method

labath created this revision. labath added reviewers: clayborg, JDevlieghere. Herald added a subscriber: aprantl. This patch implements the non-regex variant of GetFunctions. To share more code with the Apple implementation, I've extracted the common filtering code from that class into a utility

[Lldb-commits] [lldb] r334198 - DIERef: move trivial constructors into the header

Author: labath Date: Thu Jun 7 07:03:30 2018 New Revision: 334198 URL: http://llvm.org/viewvc/llvm-project?rev=334198=rev Log: DIERef: move trivial constructors into the header This enables more inlining/optimization opportunities for a fairly critical class. NFCI Modified:

[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

aleksandr.urakov added a comment. > Function level linking is a compiler feature, not a linker feature. It's > enabled via the /Gy option in the compiler and causes the compiler to put > each function into its own COMDAT. The linker can then use this to discard > more functions (e.g. during

[Lldb-commits] [PATCH] D47838: [lldb-mi] Re-implement MI -exec-step command.

polyakov.alex added a comment. In https://reviews.llvm.org/D47838#1124730, @labath wrote: > I don't know if there is any spec about what the gdb-mi protocol should use > for thread identification, but I think the most important part is to be > consistent. If you use indexes in one place and

[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

aleksandr.urakov updated this revision to Diff 150322. aleksandr.urakov added a comment. The implementation of lldb-test symbols -verify option. https://reviews.llvm.org/D47708 Files: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp tools/lldb-test/lldb-test.cpp

Re: [Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

On Thu, Jun 7, 2018 at 2:53 AM Aleksandr Urakov via Phabricator < revi...@reviews.llvm.org> wrote: > aleksandr.urakov added a comment. > > Yes, it does really need to be a VS PDB. Function-level linking is a > linker's feature and I can't found support of this feature in lld, so I > think module

[Lldb-commits] [lldb] r334190 - DebugNamesDWARFIndex: Add type lookup suport

Author: labath Date: Thu Jun 7 05:26:18 2018 New Revision: 334190 URL: http://llvm.org/viewvc/llvm-project?rev=334190=rev Log: DebugNamesDWARFIndex: Add type lookup suport This implements just one of the GetTypes overloads. The other is not testable from lldb-test so I'm leaving it

[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

aleksandr.urakov updated this revision to Diff 150295. aleksandr.urakov added a comment. Use /ORDER switch to reduce test binaries size. https://reviews.llvm.org/D47708 Files: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp unittests/SymbolFile/PDB/CMakeLists.txt

[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

aleksandr.urakov added a comment. In https://reviews.llvm.org/D47708#1124749, @labath wrote: > Btw, would it be possible to use the `/order` directive to achive what you > want? > (/order:function_from_first_file,function_from_second_file,another_function_from_first_file) Yes, thanks for

[Lldb-commits] [lldb] r334186 - DebugNamesDWARFIndex: add namespace lookup support

Author: labath Date: Thu Jun 7 03:56:16 2018 New Revision: 334186 URL: http://llvm.org/viewvc/llvm-project?rev=334186=rev Log: DebugNamesDWARFIndex: add namespace lookup support Modified: lldb/trunk/lit/SymbolFile/DWARF/find-basic-namespace.cpp

[Lldb-commits] [PATCH] D47832: DebugNamesDWARFIndex: Add support for partial indexes

This revision was automatically updated to reflect the committed changes. Closed by commit rL334185: DebugNamesDWARFIndex: Add support for partial indexes (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r334185 - DebugNamesDWARFIndex: Add support for partial indexes

Author: labath Date: Thu Jun 7 03:35:28 2018 New Revision: 334185 URL: http://llvm.org/viewvc/llvm-project?rev=334185=rev Log: DebugNamesDWARFIndex: Add support for partial indexes Summary: It possible that a single module has indexed and non-indexed compile units. In this case, we can use the

[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

labath added a comment. Btw, would it be possible to use the `/order` directive to achive what you want? (/order:function_from_first_file,function_from_second_file,another_function_from_first_file) https://reviews.llvm.org/D47708 ___ lldb-commits

[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

labath added a comment. I don't think that's necessary. The actual fix is really simple and this whole discussion is just about figuring out what to do with tests. https://reviews.llvm.org/D47708 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

aleksandr.urakov added a comment. In https://reviews.llvm.org/D47708#1124743, @labath wrote: > We have an lldb-test executable, which we use for writing tests (see tests in > lit/SymbolFile). It's `symbols` subcommand currently just dumps their > contents and then we match that. > > Your

[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

labath added a comment. In https://reviews.llvm.org/D47708#1124733, @aleksandr.urakov wrote: > > I think these kinds of checks would be a nice fit for a lldb-test symbols > > --verify option. > > Can you explain this in detail, please? We have an lldb-test executable, which we use for writing

[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

aleksandr.urakov updated this revision to Diff 150287. aleksandr.urakov added a comment. Formatted test sources corresponding to LLVM rules. https://reviews.llvm.org/D47708 Files: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp unittests/SymbolFile/PDB/CMakeLists.txt

[Lldb-commits] [PATCH] D47781: DebugNamesDWARFIndex: Add ability to lookup variables

This revision was automatically updated to reflect the committed changes. Closed by commit rL334181: DebugNamesDWARFIndex: Add ability to lookup variables (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D47781 Files:

[Lldb-commits] [lldb] r334181 - DebugNamesDWARFIndex: Add ability to lookup variables

Author: labath Date: Thu Jun 7 03:04:44 2018 New Revision: 334181 URL: http://llvm.org/viewvc/llvm-project?rev=334181=rev Log: DebugNamesDWARFIndex: Add ability to lookup variables Summary: This patch adds the ability to lookup variables to the DWARF v5 index class. During review we discovered

[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

aleksandr.urakov added a comment. > I suppose the reason you can't do the same yaml2obj trick on the .exe is > because yaml2obj does not support serializing exe's yet? Yes, it's so. > Could we shrink the size of these binaries by not using c and c++ standard > library features? The problem

[Lldb-commits] [PATCH] D47838: [lldb-mi] Re-implement MI -exec-step command.

labath added a comment. I don't know if there is any spec about what the gdb-mi protocol should use for thread identification, but I think the most important part is to be consistent. If you use indexes in one place and tid's in another you'll confuse the hell out of clients trying to talk to

[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

aleksandr.urakov added a comment. Yes, it does really need to be a VS PDB. Function-level linking is a linker's feature and I can't found support of this feature in lld, so I think module addresses inconsistency will not be reproducible with lld. I've tried to convert a VS PDB to YAML and back

[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

labath added a comment. In https://reviews.llvm.org/D47708#1124429, @zturner wrote: > Do you just need a pdb, or does it really need to be a vs pdb? lld can > generate high quality pdbs now. So it might be possible to use lld to link > and produce a pdb when you run the test. > > Pavel’s

[Lldb-commits] [lldb] r334177 - [LLDB] Unit tests / typo fix

Author: devnexen Date: Thu Jun 7 01:58:34 2018 New Revision: 334177 URL: http://llvm.org/viewvc/llvm-project?rev=334177=rev Log: [LLDB] Unit tests / typo fix removing unnecessary comma. Modified: lldb/trunk/unittests/Symbol/TestType.cpp Modified: lldb/trunk/unittests/Symbol/TestType.cpp

[Lldb-commits] [PATCH] D47797: [lldb-mi] Re-implement MI -exec-next command.

labath added inline comments. Comment at: lit/tools/lldb-mi/exec/exec-next.test:19 + +-exec-next --thread 0 +# Check that exec-next can process the case of invalid thread ID. aprantl wrote: > 0 feels like it might actually be a valid thread id on some systems..