kubamracek added inline comments.
Comment at: source/Commands/CommandObjectFrame.cpp:833
+bool CommandObjectFrameRecognizerAdd::DoExecute(Args ,
CommandReturnObject ) {
+ if (m_options.m_class_name.empty()) {
+result.AppendErrorWithFormat("%s needs a Python class name.\n",
kubamracek added a comment.
@jingham, @jasonmolenda, I haven't addresses the comments yet, but I'll do that
in the next round. I'd seeking approval of the high-level approach first. The
patch is getting a bit large, but the added test (and the Python implementation
of a recognizer) should
kubamracek updated this revision to Diff 150891.
kubamracek edited the summary of this revision.
kubamracek added a comment.
Updating StackFrameRecognizer with a Python plugin implementation and a
testcase using a Python recognizer. Also removing the Darwin-specific parts.
>
> > There was no way to find out what's wrong if SBProcess
> SBTarget::LoadCore(const char *core_file) failed.
> > Additionally, the implementation was unconditionally setting sb_process,
> so it wasn't even possible to check if the return SBProcess is valid.
>
> Not terribly important, but:
>
>
>
> > There was no way to find out what's wrong if SBProcess
> SBTarget::LoadCore(const char *core_file) failed.
> > Additionally, the implementation was unconditionally setting sb_process,
> so it wasn't even possible to check if the return SBProcess is valid.
>
> Not terribly important, but:
>
>
lemo added subscribers: clayborg, jingham, labath, apolyakov.
lemo added a comment.
> Ah I see. That's because the last argument is a C++ default argument. It
> looks like the convention in this file is that the error argument should be
> the last non-defaulted argument.
I think it should be:
>
> Ah I see. That's because the last argument is a C++ default argument. It
> looks like the convention in this file is that the error argument should be
> the last non-defaulted argument.
I think it should be:
void StepOver(lldb::RunMode stop_other_threads, lldb::SBError ); //
no default
xiaobai created this revision.
xiaobai added reviewers: clayborg, labath, sas.
Herald added a subscriber: mgorny.
Currently, the liblldb target is treated as the entire framework when
building LLDB.framework with CMake, and treated only as the actual liblldb
library otherwise. In this patch I aim
aprantl accepted this revision.
aprantl added a comment.
Ah I see. That's because the last argument is a C++ default argument. It looks
like the convention in this file is that the error argument should be the last
non-defaulted argument.
https://reviews.llvm.org/D47991
> On Jun 11, 2018, at 2:19 PM, Leonard Mosescu via lldb-commits
> wrote:
>
> Author: lemo
> Date: Mon Jun 11 14:19:26 2018
> New Revision: 334439
>
> URL: http://llvm.org/viewvc/llvm-project?rev=334439=rev
> Log:
> Add a new SBTarget::LoadCore() overload which surfaces errors if the load
>
Author: jdevlieghere
Date: Mon Jun 11 17:15:59 2018
New Revision: 334456
URL: http://llvm.org/viewvc/llvm-project?rev=334456=rev
Log:
Exempt some compilers from new static variable test.
Apparently some compilers generate incomplete debug information which
caused the updated test to fail.
Author: jdevlieghere
Date: Mon Jun 11 16:26:15 2018
New Revision: 334454
URL: http://llvm.org/viewvc/llvm-project?rev=334454=rev
Log:
[Test] Update static variable test.
Before Pavel's change in r334181, we were printing too many global
variables. This patch updates the test suite to ensure we
apolyakov added a comment.
By the way, we can do something like:
void StepOver() {
StepOver(lldb:eOnlyDuringStepping);
}
void StepOver(lldb::RunMode stop_other_threads) {
SBError error;
StepOver(stop_other_threads, error);
}
and so on.
https://reviews.llvm.org/D47991
Author: jmolenda
Date: Mon Jun 11 14:36:40 2018
New Revision: 334442
URL: http://llvm.org/viewvc/llvm-project?rev=334442=rev
Log:
Document how lldb uses the DBGSourcePathRemapping
source path remapping src/dest path pairs with
respect to the DBGVersion number in the plist.
Modified:
Author: jmolenda
Date: Mon Jun 11 14:35:36 2018
New Revision: 334441
URL: http://llvm.org/viewvc/llvm-project?rev=334441=rev
Log:
Add DebugNamesDWARFIndex.cpp.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334439: Add a new SBTarget::LoadCore() overload which
surfaces errors if the load fails (authored by lemo, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
Author: lemo
Date: Mon Jun 11 14:19:26 2018
New Revision: 334439
URL: http://llvm.org/viewvc/llvm-project?rev=334439=rev
Log:
Add a new SBTarget::LoadCore() overload which surfaces errors if the load fails
There was no way to find out what's wrong if SBProcess SBTarget::LoadCore(const
char
lemo marked 3 inline comments as done.
lemo added a comment.
spaces removed :)
https://reviews.llvm.org/D48049
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
lemo updated this revision to Diff 150844.
https://reviews.llvm.org/D48049
Files:
include/lldb/API/SBTarget.h
packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpNew.py
scripts/interface/SBTarget.i
source/API/SBTarget.cpp
Index: source/API/SBTarget.cpp
lemo updated this revision to Diff 150843.
https://reviews.llvm.org/D48049
Files:
include/lldb/API/SBTarget.h
packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpNew.py
scripts/interface/SBTarget.i
source/API/SBTarget.cpp
Index: source/API/SBTarget.cpp
Should not have spaces before any ( characters. What you typed looks good.
> On Jun 11, 2018, at 2:00 PM, Leonard Mosescu wrote:
>
> remove space before (
>
> I'd be happy to make the change, but looking at the rest of the file it seems
> that almost everything uses the opposite convention:
apolyakov added a comment.
In https://reviews.llvm.org/D47991#1128831, @aprantl wrote:
> Have you looked into making the error the first vs the last argument? If the
> majority of all SBAPI calls put the error last, we should do this here, too.
As you could see, SBError is on first place only
lemo added subscribers: amccarth, clayborg, zturner.
lemo added a comment.
> remove space before (
I'd be happy to make the change, but looking at the rest of the file it
seems that almost everything uses the opposite convention: Foo (...).
So, to make sure I'm making the right change, is this
>
> remove space before (
>
I'd be happy to make the change, but looking at the rest of the file it
seems that almost everything uses the opposite convention: Foo (...).
So, to make sure I'm making the right change, is this how it should look?
lldb::SBProcess
LoadCore(const char
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Remove extra spaces before ( and good to go.
Comment at: scripts/interface/SBTarget.i:282
lldb::SBProcess
-LoadCore(const char *core_file);
-
+LoadCore
lemo updated this revision to Diff 150835.
lemo added a comment.
Adding test cases for the new overload.
https://reviews.llvm.org/D48049
Files:
include/lldb/API/SBTarget.h
packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpNew.py
lemo created this revision.
lemo added reviewers: zturner, clayborg, amccarth.
There was no way to find out what's wrong if SBProcess SBTarget::LoadCore(const
char *core_file) failed.
Additionally, the implementation was unconditionally setting sb_process, so it
wasn't even possible to check
aprantl added a comment.
Have you looked into making the error the first vs the last argument? If the
majority of all SBAPI calls put the error last, we should do this here, too.
https://reviews.llvm.org/D47991
___
lldb-commits mailing list
apolyakov updated this revision to Diff 150814.
apolyakov retitled this revision from "Add method SBThread::StepOver with
SBError parameter." to "Improve SBThread's stepping API using SBError
parameter.".
apolyakov edited the summary of this revision.
apolyakov added a comment.
Documented
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D47929
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
lemo added inline comments.
Comment at: include/lldb/API/SBThread.h:96
+ void StepOver(SBError ,
+lldb::RunMode stop_other_threads = lldb::eOnlyDuringStepping);
apolyakov wrote:
> aprantl wrote:
> > Where is the SBAPI documentation that is
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
Sorry for coming in late (WWDC...) It does seem asymmetric to only have one
stepping API take an error. If one is going to they all should.
You need to add the new API to the
aprantl added a comment.
No, but I found this: http://www.swig.org/Doc1.3/Python.html#Python_nn67
https://reviews.llvm.org/D47991
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
apolyakov added a comment.
In https://reviews.llvm.org/D47991#1128477, @labath wrote:
> In https://reviews.llvm.org/D47991#1128433, @aprantl wrote:
>
> > Hmm.. it looks like most C++ API calls don't have any documentation.
> >
> >
labath added a comment.
In https://reviews.llvm.org/D47991#1128433, @aprantl wrote:
> Hmm.. it looks like most C++ API calls don't have any documentation.
>
> http://lldb.llvm.org/cpp_reference/html/classlldb_1_1SBThread.html#a42755a170e127881a5dd65162217f68b
>
> It does look like the python API
aprantl added a comment.
It would be good to add documentation for the new API call there, then.
https://reviews.llvm.org/D47991
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
apolyakov added a comment.
I found it out. Info about each method is located in header file. For example,
you may look at `include/lldb/API/SBThread.h` and find text from docs.
https://reviews.llvm.org/D47991
___
lldb-commits mailing list
aprantl added a comment.
Hmm.. it looks like most C++ API calls don't have any documentation.
http://lldb.llvm.org/cpp_reference/html/classlldb_1_1SBThread.html#a42755a170e127881a5dd65162217f68b
It does look like the python API has more documentation.. where does that come
from?
polyakov.alex added inline comments.
Comment at: lldb/trunk/tools/lldb-mi/MICmdCmdExec.cpp:524
bool CMICmdCmdExecStep::Acknowledge() {
- if (m_lldbResult.GetErrorSize() > 0) {
-const char *pLldbErr = m_lldbResult.GetError();
-MIunused(pLldbErr);
-const
clayborg added a comment.
It is unfortunate that we can't overload with the return value and return an
SBError...
https://reviews.llvm.org/D47991
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
This is fine. Make sure all other steps have error overloads.
https://reviews.llvm.org/D47991
___
lldb-commits mailing list
clayborg added inline comments.
Comment at: lldb/trunk/tools/lldb-mi/MICmdCmdExec.cpp:505-509
+ if (error.Success())
+return MIstatus::success;
+
+ SetError(error.GetCString());
+ return MIstatus::failure;
Utility funciton for these last four line? I
clayborg added inline comments.
Comment at: tools/lldb-mi/MICmdCmdExec.cpp:373-377
+ if (error.Success())
+return MIstatus::success;
+
+ SetError(error.GetCString());
+ return MIstatus::failure;
Maybe these four lines should be put into a utility
aprantl added a comment.
This looks reasonable to me, but I'd like to also hear from Greg and Jim since
SBAPI changes are kind of final.
Comment at: include/lldb/API/SBThread.h:96
+ void StepOver(SBError ,
+lldb::RunMode stop_other_threads =
Author: labath
Date: Mon Jun 11 07:52:52 2018
New Revision: 334411
URL: http://llvm.org/viewvc/llvm-project?rev=334411=rev
Log:
Fix tuple getter in std unique pointer pretty-printer
Summary: Check case when _M_t child member is not present.
Reviewers: labath, tberghammer
Reviewed By: labath,
Author: labath
Date: Mon Jun 11 06:22:31 2018
New Revision: 334402
URL: http://llvm.org/viewvc/llvm-project?rev=334402=rev
Log:
DWARFDebugNames: Fix lookup in dwo files
The getDIESectionOffset function is not correct for split dwarf files
(and will probably be removed in D48009).
This patch
Author: labath
Date: Mon Jun 11 03:28:04 2018
New Revision: 334399
URL: http://llvm.org/viewvc/llvm-project?rev=334399=rev
Log:
Move VersionTuple from clang/Basic to llvm/Support
Summary:
This kind of functionality is useful to other project apart from clang.
LLDB works with version numbers a
Author: labath
Date: Mon Jun 11 02:32:58 2018
New Revision: 334397
URL: http://llvm.org/viewvc/llvm-project?rev=334397=rev
Log:
Editline: make #include conditional
My previous patch made this include unconditional. However, it seems it
is not available everywhere. This patch makes us include it
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334393: [cmake] Detect presence of wide-char libedit at
build time (authored by labath, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
labath added inline comments.
Comment at: include/lldb/Host/Editline.h:72-76
#ifdef EL_CLIENTDATA /* editline with wide support + wide char read function
*/
using EditLineGetCharType = wchar_t;
#else
using EditLineGetCharType = char;
#endif
christos
Author: labath
Date: Mon Jun 11 02:14:26 2018
New Revision: 334393
URL: http://llvm.org/viewvc/llvm-project?rev=334393=rev
Log:
[cmake] Detect presence of wide-char libedit at build time
Summary:
Instead of hardcoding a list of platforms where libedit is known to have
wide char support we detect
51 matches
Mail list logo
