[Lldb-commits] [PATCH] D51253: Let the CompilerInstance create our clang ASTContext

teemperor updated this revision to Diff 162538. teemperor added a comment. - clang-format. https://reviews.llvm.org/D51253 Files: source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp Index: source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp ==

[Lldb-commits] [PATCH] D51253: Let the CompilerInstance create our clang ASTContext

teemperor created this revision. teemperor added reviewers: vsk, aprantl. Herald added a subscriber: lldb-commits. Now that we moved the BuiltinContext and SelectorTable to the CompilerInstance, we can also get rid of manually creating our own ASTContext, but just use the one from the CompilerInst

[Lldb-commits] [PATCH] D51243: Disable use-color if the output stream is not a terminal with color support.

teemperor added inline comments. Comment at: source/Core/Debugger.cpp:805 const char *term = getenv("TERM"); if (term && !strcmp(term, "dumb")) SetUseColor(false); teemperor wrote: > aprantl wrote: > > aprantl wrote: > > > Shouldn't this check be obsol

[Lldb-commits] [lldb] r340676 - Disable exceptions for TestDataFormatterLibcxxOptional.py

Author: friss Date: Fri Aug 24 18:25:24 2018 New Revision: 340676 URL: http://llvm.org/viewvc/llvm-project?rev=340676&view=rev Log: Disable exceptions for TestDataFormatterLibcxxOptional.py On macOS, some of the APIs used by the test are available only starting on macOS 10.14 when using exception

[Lldb-commits] [PATCH] D51245: Allow IRInterpreter to deal with non-power-of-2 sized types to support some bitfield accesses.

friss created this revision. friss added reviewers: jingham, clayborg. For some bitfield patterns (like the one added by this commit), Clang will generate non-regular data types like i24 or i48. This patch follows a pretty naive approach of just bumping the type size to the next power of 2. DataEx

[Lldb-commits] [PATCH] D51243: Disable use-color if the output stream is not a terminal with color support.

teemperor added inline comments. Comment at: source/Core/Debugger.cpp:805 const char *term = getenv("TERM"); if (term && !strcmp(term, "dumb")) SetUseColor(false); aprantl wrote: > aprantl wrote: > > Shouldn't this check be obsolete now? > You can prob

[Lldb-commits] [PATCH] D51243: Disable use-color if the output stream is not a terminal with color support.

aprantl added inline comments. Comment at: source/Core/Debugger.cpp:805 const char *term = getenv("TERM"); if (term && !strcmp(term, "dumb")) SetUseColor(false); aprantl wrote: > Shouldn't this check be obsolete now? You can probably test that by runni

[Lldb-commits] [PATCH] D51243: Disable use-color if the output stream is not a terminal with color support.

aprantl added inline comments. Comment at: source/Core/Debugger.cpp:805 const char *term = getenv("TERM"); if (term && !strcmp(term, "dumb")) SetUseColor(false); Shouldn't this check be obsolete now? Repository: rLLDB LLDB https://reviews.llvm.org

[Lldb-commits] [PATCH] D51243: Disable use-color if the output stream is not a terminal with color support.

teemperor created this revision. teemperor added a reviewer: aprantl. Herald added a reviewer: javed.absar. Herald added subscribers: lldb-commits, abidh, kristof.beyls. LLDB currently only checks the output terminal for color support by looking at the `TERM` environment variable and comparing it

[Lldb-commits] [PATCH] D50751: Allow use of self.filecheck in LLDB tests (c.f self.expect)

vsk updated this revision to Diff 162491. vsk retitled this revision from "WIP: Expose FileCheck-style testing within lldb inline tests" to "Allow use of self.filecheck in LLDB tests (c.f self.expect)". vsk edited the summary of this revision. vsk added reviewers: teemperor, aprantl, zturner. vsk

[Lldb-commits] [PATCH] D51227: [vscode] Skip some of the vscode tests on Linux and fix one

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL340658: [vscode] Skip some of the vscode tests on Linux and fix one (authored by stella.stamenova, committed by ). Herald

[Lldb-commits] [lldb] r340658 - [vscode] Skip some of the vscode tests on Linux and fix one

Author: stella.stamenova Date: Fri Aug 24 14:42:53 2018 New Revision: 340658 URL: http://llvm.org/viewvc/llvm-project?rev=340658&view=rev Log: [vscode] Skip some of the vscode tests on Linux and fix one Summary: These are already skipped on Darwin because they cause build bot failures. Both on t

[Lldb-commits] [lldb] r340652 - Fixed windows bots that were failing because of PATH_MAX

Author: teemperor Date: Fri Aug 24 13:55:23 2018 New Revision: 340652 URL: http://llvm.org/viewvc/llvm-project?rev=340652&view=rev Log: Fixed windows bots that were failing because of PATH_MAX As we only use PATH_MAX for an assert in a unit test that is supposed to catch the random failures on th

[Lldb-commits] [PATCH] D51208: [DWARF] Fix dwarf5-index-is-used.cpp

dblaikie added a comment. Herald added a subscriber: teemperor. In https://reviews.llvm.org/D51208#1212320, @labath wrote: > As far as the strict intention of this test goes, the change is fine, as it > is meant to check that the accelerator tables get used *when* they are > generated. How do y

[Lldb-commits] [PATCH] D51227: [vscode] Skip some of the vscode tests on Linux and fix one

stella.stamenova updated this revision to Diff 162467. stella.stamenova retitled this revision from "[vscode] Skip the vscode tests on Linux" to "[vscode] Skip some of the vscode tests on Linux and fix one". stella.stamenova edited the summary of this revision. stella.stamenova added a comment. I

[Lldb-commits] [PATCH] D51227: [vscode] Skip the vscode tests on Linux

stella.stamenova added a comment. In https://reviews.llvm.org/D51227#1212838, @aprantl wrote: > Looks like we *really* need to figure out what the underlying bug is here, > because there's not many platforms left after this patch. > This patch is fine as a stopgap, but we can't have a feature l

[Lldb-commits] [PATCH] D51227: [vscode] Skip the vscode tests on Linux

aprantl added a comment. Looks like we *really* need to figure out what the underlying bug is here, because there's not many platforms left after this patch. This patch is fine as a stopgap, but we can't have a feature like this be in the source code while being virtually untested, that's just a

[Lldb-commits] [PATCH] D51227: [vscode] Skip the vscode tests on Linux

stella.stamenova marked an inline comment as done. stella.stamenova added inline comments. Comment at: packages/Python/lldbsuite/test/tools/lldb-vscode/attach/TestVSCode_attach.py:50 @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on

[Lldb-commits] [PATCH] D51227: [vscode] Skip the vscode tests on Linux

stella.stamenova updated this revision to Diff 162444. Repository: rLLDB LLDB https://reviews.llvm.org/D51227 Files: packages/Python/lldbsuite/test/tools/lldb-vscode/attach/TestVSCode_attach.py packages/Python/lldbsuite/test/tools/lldb-vscode/breakpoint/TestVSCode_setBreakpoints.py pac

[Lldb-commits] [PATCH] D51227: [vscode] Skip the vscode tests on Linux

teemperor added inline comments. Comment at: packages/Python/lldbsuite/test/tools/lldb-vscode/attach/TestVSCode_attach.py:50 @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots +@skipIfLinux # This test is timing out an

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

jankratochvil added a comment. Just a ping, that `ConcatenatingDataExtractor` is still not coded, even as some draft patch? Just checking to prevent duplicating some existing work. FYI providing a rebase with few simple conflicts resolved . I

[Lldb-commits] [PATCH] D51227: [vscode] Skip the vscode tests on Linux

stella.stamenova created this revision. stella.stamenova added reviewers: asmith, clayborg. Herald added a subscriber: lldb-commits. These are already skipped on Darwin because they cause build bot failures. Both on the build bots as well as in our testing we have seen a number of these tests fa

[Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

aprantl added inline comments. Comment at: lldb/include/lldb/Symbol/Function.h:331 + /// \ref resolved. + union { +const char *mangled_name; vsk wrote: > aprantl wrote: > > `llvm::PointerUnion` ? > It's not possible to use PointerUnion here because `const c

[Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

vsk updated this revision to Diff 162416. vsk marked 4 inline comments as done. vsk added a comment. Thanks for the feedback! https://reviews.llvm.org/D50478 Files: lldb/include/lldb/Symbol/Block.h lldb/include/lldb/Symbol/Function.h lldb/include/lldb/Symbol/SymbolFile.h lldb/include/ll

[Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

vsk added inline comments. Comment at: lldb/include/lldb/Symbol/Function.h:331 + /// \ref resolved. + union { +const char *mangled_name; aprantl wrote: > `llvm::PointerUnion` ? It's not possible to use PointerUnion here because `const char *` has 1-byte al

[Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

aprantl added inline comments. Comment at: lldb/include/lldb/Symbol/Function.h:331 + /// \ref resolved. + union { +const char *mangled_name; `llvm::PointerUnion` ? https://reviews.llvm.org/D50478 ___ lldb-com

[Lldb-commits] [PATCH] D51208: [DWARF] Fix dwarf5-index-is-used.cpp

labath added a comment. As far as the strict intention of this test goes, the change is fine, as it is meant to check that the accelerator tables get used *when* they are generated. How do you achieve them being generated is not important. However, I am not sure now under what circumstances wil

[Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

sgraenitz added a comment. Interesting topic and very well-written patch. Semantics look reasonable, but can't say much about the details. Added a few minor notes inline. Comment at: lldb/include/lldb/Symbol/Function.h:456 + //-

[Lldb-commits] [lldb] r340597 - [PDB] Make variables.test to pass using a 32-bit compiler too

Author: aleksandr.urakov Date: Fri Aug 24 00:24:52 2018 New Revision: 340597 URL: http://llvm.org/viewvc/llvm-project?rev=340597&view=rev Log: [PDB] Make variables.test to pass using a 32-bit compiler too Summary: `variables.test` depends on mangled names, but the mangling depends on the bitness.