[Lldb-commits] [PATCH] D51387: Allow Template argument accessors to automatically unwrap parameter packs

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. I'm a little worried that we have asserts with no backstops here. We ship in general with asserts off, so if some type is not copasetic we will probably crash shortly afterwards (

[Lldb-commits] [PATCH] D52065: WWW docs for scripted breakpoint resolvers

jingham created this revision. jingham added a reviewer: clayborg. Herald added subscribers: lldb-commits, abidh. These are the promised docs for https://reviews.llvm.org/D51830. Repository: rLLDB LLDB https://reviews.llvm.org/D52065 Files: www/python-reference.html Index: www/python-refe

[Lldb-commits] [PATCH] D51387: Allow Template argument accessors to automatically unwrap parameter packs

friss added a comment. @jingham ping https://reviews.llvm.org/D51387 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [lldb] r342190 - svn add the new files...

Thank you! On Thu, Sep 13, 2018 at 3:00 PM Jim Ingham via lldb-commits wrote: > > Author: jingham > Date: Thu Sep 13 14:59:16 2018 > New Revision: 342190 > > URL: http://llvm.org/viewvc/llvm-project?rev=342190&view=rev > Log: > svn add the new files... > > I started from a clean slate to do the ch

[Lldb-commits] [lldb] r342190 - svn add the new files...

Author: jingham Date: Thu Sep 13 14:59:16 2018 New Revision: 342190 URL: http://llvm.org/viewvc/llvm-project?rev=342190&view=rev Log: svn add the new files... I started from a clean slate to do the checkin, but forgot to svn add the new files. Do that now. Also add the one new source file to CM

[Lldb-commits] [lldb] r342188 - Remember to sort the Xcode project file. NFC.

Author: jingham Date: Thu Sep 13 14:55:00 2018 New Revision: 342188 URL: http://llvm.org/viewvc/llvm-project?rev=342188&view=rev Log: Remember to sort the Xcode project file. NFC. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj ___ lldb-commit

Re: [Lldb-commits] [lldb] r342185 - Add a "scripted" breakpoint type to lldb.

This last commit broke the build: [56/997] : && /Users/buildslave/jenkins/workspace/lldb-cmake/host-compiler/bin/clang++ -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -std=c++11 -fmodules -fmodules-cache-path=/Users/buildslave/jenkins/workspace/lldb-cmak

[Lldb-commits] [PATCH] D51830: Add a way to make scripted breakpoints

This revision was automatically updated to reflect the committed changes. Closed by commit rL342185: Add a "scripted" breakpoint type to lldb. (authored by jingham, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51830?vs=165184&id=165

[Lldb-commits] [PATCH] D51830: Add a way to make scripted breakpoints

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB342185: Add a "scripted" breakpoint type to lldb. (authored by jingham, committed by ). Changed prior to commit: https://reviews.llvm.org/D51830?vs=165184&id=165386#toc Repository: rLLDB LLDB htt

[Lldb-commits] [lldb] r342185 - Add a "scripted" breakpoint type to lldb.

Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbutil.py URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lldbutil.py?rev=342185&r1=342184&r2=342185&view=diff == --- lldb/trunk/pack

[Lldb-commits] [lldb] r342185 - Add a "scripted" breakpoint type to lldb.

Author: jingham Date: Thu Sep 13 14:35:32 2018 New Revision: 342185 URL: http://llvm.org/viewvc/llvm-project?rev=342185&view=rev Log: Add a "scripted" breakpoint type to lldb. This change allows you to write a new breakpoint type where the logic for setting breakpoints is determined by a Python c

[Lldb-commits] [lldb] r342181 - Add support for descriptions with command completions.

Author: teemperor Date: Thu Sep 13 14:26:00 2018 New Revision: 342181 URL: http://llvm.org/viewvc/llvm-project?rev=342181&view=rev Log: Add support for descriptions with command completions. Summary: This patch adds a framework for adding descriptions to the command completions we provide. It al

[Lldb-commits] [PATCH] D51175: Add support for descriptions with command completions.

This revision was automatically updated to reflect the committed changes. Closed by commit rL342181: Add support for descriptions with command completions. (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51175?v

[Lldb-commits] [PATCH] D51175: Add support for descriptions with command completions.

teemperor updated this revision to Diff 165379. teemperor added a comment. - Rebasing before merging. https://reviews.llvm.org/D51175 Files: include/lldb/API/SBCommandInterpreter.h include/lldb/Core/IOHandler.h include/lldb/Expression/REPL.h include/lldb/Host/Editline.h include/lldb/I

[Lldb-commits] [lldb] r342167 - NativeProcessProtocol: Sink ReadMemoryWithoutTrap into base class

Author: labath Date: Thu Sep 13 13:17:40 2018 New Revision: 342167 URL: http://llvm.org/viewvc/llvm-project?rev=342167&view=rev Log: NativeProcessProtocol: Sink ReadMemoryWithoutTrap into base class The two existing implementations have the function implemented identically, and there's no reason

[Lldb-commits] [PATCH] D40474: DWZ 03/06: Main functionality

jankratochvil updated this revision to Diff 165347. Repository: rLLDB LLDB https://reviews.llvm.org/D40474 Files: include/lldb/Utility/ConstString.h include/lldb/Utility/FileSpec.h source/Plugins/SymbolFile/DWARF/DWARFDataExtractor.h source/Plugins/SymbolFile/DWARF/DWARFDebugAranges.cp

[Lldb-commits] [PATCH] D51520: Add libc++ data formatter for std::variant

shafik added a comment. @vsk Interesting I ran git clang-format before generating the diff and it made changes, so I am not sure what happened https://reviews.llvm.org/D51520 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.ll

[Lldb-commits] [PATCH] D51520: Add libc++ data formatter for std::variant

vsk added a comment. Please clang-format your diffs. https://reviews.llvm.org/D51520 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D51520: Add libc++ data formatter for std::variant

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Yes, that's a good way to do it. https://reviews.llvm.org/D51520 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.or

[Lldb-commits] [PATCH] D51175: Add support for descriptions with command completions.

jingham accepted this revision. jingham added inline comments. This revision is now accepted and ready to land. Comment at: source/Utility/CompletionRequest.cpp:79 + // Add the completion if we haven't seen the same value before. + if (m_added_values.insert(r.GetUniqueKey()).se

[Lldb-commits] [PATCH] D51935: [LLDB] - Improved DWARF5 support.

This revision was automatically updated to reflect the committed changes. Closed by commit rL342153: [LLDB] - Improved DWARF5 support. (authored by grimar, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51935?vs=165289&id=165322#toc

[Lldb-commits] [PATCH] D51967: [PDB] Use the raw PDB symbol interface more accurately

zturner accepted this revision. zturner added a comment. Maybe I can improve this in the native implementation of our PDB reader which I'm currently working on, so that the results can be more consistent. https://reviews.llvm.org/D51967 ___ lldb-co

[Lldb-commits] [PATCH] D51578: DWARFConcatenatingDataExtractor for D32167

jankratochvil added a comment. In https://reviews.llvm.org/D51578#1233518, @clayborg wrote: > Is there a reason we need DWARFConcatenatingDataExtractor? Can we just put > all functionality into DWARFDataExtractor? OK, I will try it that way. > Also is there a reason we need to pass the block

[Lldb-commits] [PATCH] D51935: [LLDB] - Improve reporting source lines and variables (improved DWARF5 support).

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Thanks for doing all requested changes! Looks great. Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugLine.cpp:442 +ReadDescriptors(debug_line_data, offset_p

[Lldb-commits] [PATCH] D51578: DWARFConcatenatingDataExtractor for D32167

clayborg added a comment. Overall I am ok with minimal regression in speed if a few percent is all that it is costing us. I am generally ok with this patch. A few questions below. Is there a reason we need DWARFConcatenatingDataExtractor? Can we just put all functionality into DWARFDataExtracto

[Lldb-commits] [PATCH] D51730: [DWARFExpression] Read literars as unsigned values.

This revision was automatically updated to reflect the committed changes. Closed by commit rL342142: [DWARFExpression] Read literars as unsigned values. (authored by JDevlieghere, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51730?v

[Lldb-commits] [lldb] r342142 - [DWARFExpression] Read literars as unsigned values.

Author: jdevlieghere Date: Thu Sep 13 08:18:39 2018 New Revision: 342142 URL: http://llvm.org/viewvc/llvm-project?rev=342142&view=rev Log: [DWARFExpression] Read literars as unsigned values. After landing r341457, we started seeing a failure on the swift-lldb bots. The change was correct and pret

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

jankratochvil added a comment. BTW I would welcome some direction forward (for our internal yearly team meeting) how to unblock this patch (and assuming DWZ https://reviews.llvm.org/D40474). I can code some other of the solutions described above by Pavel Labath

[Lldb-commits] [PATCH] D51935: [LLDB] - Improve reporting source lines and variables (improved DWARF5 support).

grimar updated this revision to Diff 165289. grimar marked 2 inline comments as done. grimar added a comment. - Addressed comments. - Changed test case to use yaml2obj. https://reviews.llvm.org/D51935 Files: include/lldb/lldb-enumerations.h packages/Python/lldbsuite/test/functionalities/sh

[Lldb-commits] [PATCH] D51730: [DWARFExpression] Read literars as unsigned values.

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. The test really should encode actual DWARF that contains a DW_OP_litXXX opcode (using obj2yaml/yaml2obj or llvm-mc) as compiling the code for the test won't always produce the needed DWARF

[Lldb-commits] [PATCH] D51999: build: add libedit to include paths

tatyana-krasnukha added a comment. TBC, I pass libedit_INCLUDE_DIRS and libedit_LIBRARIES manually to CMake. Repository: rLLDB LLDB https://reviews.llvm.org/D51999 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cg

[Lldb-commits] [PATCH] D51967: [PDB] Use the raw PDB symbol interface more accurately

aleksandr.urakov added a comment. In https://reviews.llvm.org/D51967#1232534, @zturner wrote: > I've been experimenting with DIA locally and after some investigation I'm not > sure this is going to be reliable. Let's say we have a class, we want the > decl context containing the class. For ex

[Lldb-commits] [PATCH] D51935: [LLDB] - Improve reporting source lines and variables (improved DWARF5 support).

grimar added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugLine.cpp:442 +ReadDescriptors(debug_line_data, offset_ptr); +uint8_t dirCount = debug_line_data.GetU8(offset_ptr); +for (int i = 0; i < dirCount; ++i) { probinson

[Lldb-commits] [PATCH] D51935: [LLDB] - Improve reporting source lines and variables (improved DWARF5 support).

probinson added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugLine.cpp:442 +ReadDescriptors(debug_line_data, offset_ptr); +uint8_t dirCount = debug_line_data.GetU8(offset_ptr); +for (int i = 0; i < dirCount; ++i) { claybor

[Lldb-commits] [PATCH] D51967: [PDB] Use the raw PDB symbol interface more accurately

aleksandr.urakov updated this revision to Diff 165231. aleksandr.urakov added a comment. Apply recommended fixes. https://reviews.llvm.org/D51967 Files: source/Plugins/SymbolFile/PDB/PDBASTParser.cpp Index: source/Plugins/SymbolFile/PDB/PDBASTParser.cpp =

[Lldb-commits] [PATCH] D51730: [DWARFExpression] Read literars as unsigned values.

JDevlieghere added a comment. ping (I'd like to land this so I can un-revert the `DW_OP_constu` normalization for Swift) https://reviews.llvm.org/D51730 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

[Lldb-commits] [PATCH] D50809: Remove byte counting from SourceManager [NFC]

This revision was automatically updated to reflect the committed changes. Closed by commit rL342121: Remove byte counting from SourceManager [NFC] (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D50809?vs=165225&

[Lldb-commits] [lldb] r342121 - Remove byte counting from SourceManager [NFC]

Author: teemperor Date: Thu Sep 13 02:19:40 2018 New Revision: 342121 URL: http://llvm.org/viewvc/llvm-project?rev=342121&view=rev Log: Remove byte counting from SourceManager [NFC] Summary: Similar to what we did in D50681, we now stop manually byte counting here in the SourceManager. Reviewers

[Lldb-commits] [PATCH] D50809: Remove byte counting from SourceManager [NFC]

teemperor updated this revision to Diff 165225. teemperor added a comment. - Fixed conflicts before merging. https://reviews.llvm.org/D50809 Files: source/Core/SourceManager.cpp Index: source/Core/SourceManager.cpp === --- sour

[Lldb-commits] [PATCH] D51175: Add support for descriptions with command completions.

teemperor added a comment. @jingham I'm confused, what are the requested changes? Because the behavior we seem to agree on is that we keep completions with the same value but different descriptions which is already the current implementation (see lines 138 and 148 in CompletionRequestTest.cpp)