[Lldb-commits] [PATCH] D50155: Delete MacOSXFrameBackchain unwind logic (NFC)

2018-10-04 Thread Vedant Kumar via Phabricator via lldb-commits
vsk added a comment. Ping? https://reviews.llvm.org/D50155 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D52884: Fix typos.

2018-10-04 Thread Bruce Mitchener via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL343825: Fix typos. (authored by brucem, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D52884 Files:

[Lldb-commits] [PATCH] D52884: Fix typos.

2018-10-04 Thread Bruce Mitchener via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB343825: Fix typos. (authored by brucem, committed by ). Changed prior to commit: https://reviews.llvm.org/D52884?vs=168279=168398#toc Repository: rL LLVM https://reviews.llvm.org/D52884 Files:

[Lldb-commits] [lldb] r343825 - Fix typos.

2018-10-04 Thread Bruce Mitchener via lldb-commits
Author: brucem Date: Thu Oct 4 15:33:39 2018 New Revision: 343825 URL: http://llvm.org/viewvc/llvm-project?rev=343825=rev Log: Fix typos. Reviewers: lldb-commits Subscribers: srhines, ki.stfu Differential Revision: https://reviews.llvm.org/D52884 Modified:

[Lldb-commits] [PATCH] D52851: Adding support to step into the callable wrapped by libc++ std::function

2018-10-04 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik updated this revision to Diff 168389. shafik marked 6 inline comments as done. shafik added a comment. Addressing comments and fixing a bug in ThreadPlanStepThrough.cpp where I would overwrite the result of objc_runtime. https://reviews.llvm.org/D52851 Files:

[Lldb-commits] [PATCH] D52884: Fix typos.

2018-10-04 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. This looks all good to me. I'm a bit worried about the changes to AppleObjCTrampolineHandler.cpp, but from what I can see we don't actually rely on this specific field name anywhere in

[Lldb-commits] [PATCH] D52884: Fix typos.

2018-10-04 Thread Bruce Mitchener via Phabricator via lldb-commits
brucem created this revision. brucem added a reviewer: lldb-commits. Herald added subscribers: ki.stfu, srhines. https://reviews.llvm.org/D52884 Files: include/lldb/Utility/ConstString.h packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py source/Host/common/MainLoop.cpp

[Lldb-commits] [lldb] r343769 - Re-commit r343500 "Fix build with GCC < 5.0 (PR39131)"

2018-10-04 Thread Tatyana Krasnukha via lldb-commits
Author: tkrasnukha Date: Thu Oct 4 04:39:55 2018 New Revision: 343769 URL: http://llvm.org/viewvc/llvm-project?rev=343769=rev Log: Re-commit r343500 "Fix build with GCC < 5.0 (PR39131)" Occasionally didn't commit actual fix the first time. Modified: