zturner added a comment.
In https://reviews.llvm.org/D54072#1286811, @zturner wrote:
> So I tried to go down this route, but alas, I still can't come up with a good
> way to make color output work, because the Stream is not a `StreamFile`
> object, it is a `StreamString` object, even when the o
Author: devnexen
Date: Sun Nov 4 15:19:25 2018
New Revision: 346109
URL: http://llvm.org/viewvc/llvm-project?rev=346109&view=rev
Log:
[LLDB] Fix FreeBSD/Darwin build
Reviewers: JDevlieghere, tatyana-krasnukha
Reviwed By: tatyana-krasnukha
Differential Revision: https://reviews.llvm.org/D54084
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB346109: [LLDB] Fix FreeBSD/Darwin build (authored by
devnexen, committed by ).
Repository:
rLLDB LLDB
https://reviews.llvm.org/D54084
Files:
source/Plugins/Process/Darwin/NativeProcessDarwin.cpp
tatyana-krasnukha accepted this revision.
tatyana-krasnukha added a comment.
This revision is now accepted and ready to land.
Thank you!
LGTM, though I'm not able to test it under any of these systems.
https://reviews.llvm.org/D54084
___
lldb-commit
devnexen updated this revision to Diff 172535.
devnexen retitled this revision from "[LLDB] Fix FreeBSD build" to "[LLDB] Fix
FreeBSD/Darwin build".
https://reviews.llvm.org/D54084
Files:
source/Plugins/Process/Darwin/NativeProcessDarwin.cpp
source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp
devnexen added a comment.
Can't test under Darwin but reproduced similar changes.
https://reviews.llvm.org/D54084
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tatyana-krasnukha added a comment.
Could you please make the same fix for NativeProcessDarwin
(`NativeProcessProtocol::Launch`) as well?
Repository:
rLLDB LLDB
https://reviews.llvm.org/D54084
___
lldb-commits mailing list
lldb-commits@lists.llvm
tatyana-krasnukha added inline comments.
Comment at: source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp:378
namespace fs = llvm::sys::fs;
- if (working_dir && (!working_dir.ResolvePath() ||
- !fs::is_directory(working_dir.GetPath( {
+ if (working_dir
devnexen created this revision.
devnexen added reviewers: JDevlieghere, tatyana-krasnukha.
devnexen created this object with visibility "All Users".
Herald added subscribers: lldb-commits, emaste.
ResolvePath is no longer into FileSpec class
Repository:
rLLDB LLDB
https://reviews.llvm.org/D54
zturner added a comment.
So I tried to go down this route, but alas, I still can't come up with a good
way to make color output work, because the Stream is not a `StreamFile` object,
it is a `StreamString` object, even when the output is going to a terminal. We
could have an argument such as `-
zturner added a comment.
So I tried to go down this route, but alas, I still can't come up with a good
way to make color output work, because the Stream is not a `StreamFile` object,
it is a `StreamString` object, even when the output is going to a terminal.
We could have an argument such as
Author: kamil
Date: Sun Nov 4 08:53:16 2018
New Revision: 346100
URL: http://llvm.org/viewvc/llvm-project?rev=346100&view=rev
Log:
Fix NetBSD build after "Move path resolution logic out of FileSpec"
D53915
Modified:
lldb/trunk/source/Host/netbsd/Host.cpp
lldb/trunk/source/Host/netbsd/Ho
keith added a subscriber: kastiglione.
keith added a comment.
No worries, thanks!
-
Keith Smiley
Repository:
rL LLVM
https://reviews.llvm.org/D49776
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
kastiglione added a comment.
@Keith I screwed up and committed without amending the commit message to
attribute you as the author :(
Repository:
rL LLVM
https://reviews.llvm.org/D49776
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
This revision was automatically updated to reflect the committed changes.
Closed by commit rL346099: Update framework-header-fix to force system sed
(authored by kastiglione, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D49776?vs=157
Author: kastiglione
Date: Sun Nov 4 07:55:28 2018
New Revision: 346099
URL: http://llvm.org/viewvc/llvm-project?rev=346099&view=rev
Log:
Update framework-header-fix to force system sed
Summary:
There are 2 changes here:
1. Use system sed instead of the sed found in the user's path. This
fi
teemperor added a comment.
Yeah it uses the color settings of the diagnostic engine which are probably set
to false in LLDB. I think activating colors there should fix the issue.
https://reviews.llvm.org/D54072
___
lldb-commits mailing list
lldb-co
zturner added a comment.
I tried that one and it didn’t show color, bit maybe I need to add an
overload of dumpColor that allows to pass a raw_ostream
https://reviews.llvm.org/D54072
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://l
I tried that one and it didn’t show color, bit maybe I need to add an
overload of dumpColor that allows to pass a raw_ostream
On Sun, Nov 4, 2018 at 6:25 AM Raphael Isemann via Phabricator <
revi...@reviews.llvm.org> wrote:
> teemperor added a comment.
>
> I think Pavel's point is to call the `dum
teemperor added a comment.
I think Pavel's point is to call the `dump` overload which allows specifying
our own custom raw_ostream:
https://clang.llvm.org/doxygen/classclang_1_1Decl.html#a278b3b87b6f9d3b20ed566a8684341a6
And our raw_ostream is configured by LLDB to correctly choose if we want c
zturner added a comment.
The issue is that clang writes directly to stderr
https://reviews.llvm.org/D54072
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
The issue is that clang writes directly to stderr
On Sun, Nov 4, 2018 at 5:38 AM Pavel Labath via Phabricator <
revi...@reviews.llvm.org> wrote:
> labath added a comment.
>
> In https://reviews.llvm.org/D54072#1286748, @zturner wrote:
>
> > Unfortunately then color output is impossible. Where else
labath added a comment.
In https://reviews.llvm.org/D54072#1286748, @zturner wrote:
> Unfortunately then color output is impossible. Where else would the output
> be expected to go?
If you execute the command over the SB API
(SBCommandInterpreter::HandleCommand) then it will go into the provi
zturner added a subscriber: davide.
zturner added a comment.
Ok so probably this commands output will not go to a log file when logging
is enabled? I can’t think of any other side effects.
Given that the immediate use case for this is interactive investigation and
testing, the first of which is h
Ok so probably this commands output will not go to a log file when logging
is enabled? I can’t think of any other side effects.
Given that the immediate use case for this is interactive investigation and
testing, the first of which is helped by color output and the second of
which doesn’t need log
zturner added a subscriber: vsk.
zturner added a comment.
Unfortunately then color output is impossible. Where else would the output
be expected to go?
https://reviews.llvm.org/D54072
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://
Unfortunately then color output is impossible. Where else would the output
be expected to go?
On Sun, Nov 4, 2018 at 2:23 AM Pavel Labath via Phabricator <
revi...@reviews.llvm.org> wrote:
> labath added inline comments.
>
>
>
> Comment at: lldb/source/Commands/CommandObjectTarget
Author: labath
Date: Sun Nov 4 04:54:29 2018
New Revision: 346094
URL: http://llvm.org/viewvc/llvm-project?rev=346094&view=rev
Log:
Fix log statement in r346093
Thanks to Dávid Bolvanský for pointing that out.
Modified:
lldb/trunk/source/Host/common/NativeProcessProtocol.cpp
Modified: lldb
This revision was automatically updated to reflect the committed changes.
Closed by commit rL346093: NativeProcessProtocol: Simplify breakpoint setting
code (authored by labath, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D52941
Files:
labath added a comment.
thanks.
https://reviews.llvm.org/D52941
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: labath
Date: Sun Nov 4 02:58:08 2018
New Revision: 346093
URL: http://llvm.org/viewvc/llvm-project?rev=346093&view=rev
Log:
NativeProcessProtocol: Simplify breakpoint setting code
Summary:
A fairly simple operation as setting a breakpoint (writing a breakpoint
opcode) at a given address
labath added inline comments.
Comment at: lldb/source/Commands/CommandObjectTarget.cpp:2275
+SymbolFile *sf = m->GetSymbolVendor()->GetSymbolFile();
+sf->DumpClangAST();
+ }
The dump function should take the output stream from the `result` ob
32 matches
Mail list logo
