[Lldb-commits] [PATCH] D54731: [lit] Enable the use of custom user-defined lit commands

2018-11-20 Thread Vedant Kumar via Phabricator via lldb-commits
vsk added a subscriber: filcab. vsk added a comment. For compiling/linking, I think we can get by using lit substitutions to fill in platform-specific options? iOS testing for Swift is done this way (both on-device and simulator), as is testing for the profiling runtime. Dan and @filcab are mor

[Lldb-commits] [PATCH] D54731: [lit] Enable the use of custom user-defined lit commands

2018-11-20 Thread Zachary Turner via Phabricator via lldb-commits
zturner added a reviewer: vsk. zturner added a comment. +vsk. One thing I need input from LLDB people on is whether this seems like a good "general direction" for writing lit tests. Does wrapping compilation and linker commands behind a python function seem like it would address these use cas

[Lldb-commits] [PATCH] D54731: [lit] Enable the use of custom user-defined lit commands

2018-11-20 Thread Reid Kleckner via Phabricator via lldb-commits
rnk added a comment. I think the code to implement this is fine, but before we add this complexity to lit, I just wanted to know if other folks who work on the LLDB test suite are on board and want to use this approach to abstract over building apps for different targets. I see @stella.stamenov

[Lldb-commits] [lldb] r347365 - Update call to EvaluateAsInt() to the new syntax.

2018-11-20 Thread Bill Wendling via lldb-commits
Author: void Date: Tue Nov 20 15:24:18 2018 New Revision: 347365 URL: http://llvm.org/viewvc/llvm-project?rev=347365&view=rev Log: Update call to EvaluateAsInt() to the new syntax. Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp U

[Lldb-commits] [lldb] r347323 - [lit] Build and link TestIRMemoryMapWindows explicitly

2018-11-20 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Tue Nov 20 08:44:06 2018 New Revision: 347323 URL: http://llvm.org/viewvc/llvm-project?rev=347323&view=rev Log: [lit] Build and link TestIRMemoryMapWindows explicitly If we just invoke clang-cl without specifying the linker, the tests fail on Windows because they c

[Lldb-commits] [lldb] r347321 - [lit] Disable the stop hook tests on Windows

2018-11-20 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Tue Nov 20 08:24:03 2018 New Revision: 347321 URL: http://llvm.org/viewvc/llvm-project?rev=347321&view=rev Log: [lit] Disable the stop hook tests on Windows These tests are not able to pass on Windows as written as they don't even build Modified: lldb/trunk/lit/

[Lldb-commits] [lldb] r347305 - [CMake] Streamline code signing for debugserver and pass entitlements to extended llvm_codesign

2018-11-20 Thread Stefan Granitz via lldb-commits
Author: stefan.graenitz Date: Tue Nov 20 06:10:33 2018 New Revision: 347305 URL: http://llvm.org/viewvc/llvm-project?rev=347305&view=rev Log: [CMake] Streamline code signing for debugserver and pass entitlements to extended llvm_codesign Summary: Use llvm_codesign to sign debugserver with entitl

[Lldb-commits] [PATCH] D54476: [CMake] Streamline code signing for debugserver

2018-11-20 Thread Phabricator via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL347305: [CMake] Streamline code signing for debugserver and pass entitlements to… (authored by stefan.graenitz, committed by ). Changed prior to commit: https://reviews.llvm.org/D54476?vs=174405&id=1747

[Lldb-commits] [PATCH] D54751: [LLDB] - Fix setting the breakpoints when -gsplit-dwarf and DWARF 5 owere used for executable.

2018-11-20 Thread George Rimar via Phabricator via lldb-commits
grimar updated this revision to Diff 174755. grimar added a comment. - Added the test case forgotten. https://reviews.llvm.org/D54751 Files: lit/Breakpoint/Inputs/split-dwarf-5-addrbase.dwo.yaml lit/Breakpoint/Inputs/split-dwarf-5-addrbase.yaml lit/Breakpoint/split-dwarf-5-addrbase.test

[Lldb-commits] [PATCH] D54751: [LLDB] - Fix setting the breakpoints when -gsplit-dwarf and DWARF 5 owere used for executable.

2018-11-20 Thread George Rimar via Phabricator via lldb-commits
grimar created this revision. grimar added reviewers: LLDB, clayborg. Herald added subscribers: JDevlieghere, aprantl. Imagine the following code: void baz() { } int main() { baz(); return 0; } When compiling with with `-gdwarf-4 -gsplit-dwarf` LLDB is able to set the breakpo

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

2018-11-20 Thread Robert O'Callahan via Phabricator via lldb-commits
rocallahan created this revision. rocallahan added a reviewer: ruiu. rocallahan added a project: lld. Herald added subscribers: llvm-commits, MaskRay, JDevlieghere, arichardson, emaste. Herald added a reviewer: espindola. Rust projects tend to link in all object files from all dependent libraries