[Lldb-commits] [PATCH] D54886: Add support for the Dylan language to ClangASTContext

This revision was automatically updated to reflect the committed changes. Closed by commit rL347637: Add support for the Dylan language to ClangASTContext (authored by brucem, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] r347637 - Add support for the Dylan language to ClangASTContext

Author: brucem Date: Mon Nov 26 21:37:27 2018 New Revision: 347637 URL: http://llvm.org/viewvc/llvm-project?rev=347637=rev Log: Add support for the Dylan language to ClangASTContext Summary: This change adds eLanguageTypeDylan to the set of languages supported by ClangASTContext. Debug info

[Lldb-commits] [PATCH] D54886: Add support for the Dylan language to ClangASTContext

housel updated this revision to Diff 175391. housel added a comment. Updated against r347619 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54886/new/ https://reviews.llvm.org/D54886 Files: source/Symbol/ClangASTContext.cpp Index: source/Symbol/ClangASTContext.cpp

[Lldb-commits] [PATCH] D54886: Add support for the Dylan language to ClangASTContext

brucem added a comment. I can land this today. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54886/new/ https://reviews.llvm.org/D54886 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D54886: Add support for the Dylan language to ClangASTContext

housel added a comment. I don't have commit access; could someone land this please? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54886/new/ https://reviews.llvm.org/D54886 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D54886: Add support for the Dylan language to ClangASTContext

housel updated this revision to Diff 175385. housel added a comment. Adds an inline comment about Open Dylan debug info CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54886/new/ https://reviews.llvm.org/D54886 Files: source/Symbol/ClangASTContext.cpp Index:

Re: [Lldb-commits] [PATCH] D54692: [Driver] Use libOption with tablegen.

One potentially nice way to test this would be to have all the -O, -o, -S, -s, -Q, and -q just run "script print(N)" where N is some number that changes at each line, then FileCheck the output On Mon, Nov 26, 2018 at 6:38 PM Jim Ingham via Phabricator < revi...@reviews.llvm.org> wrote: > jingham

[Lldb-commits] [PATCH] D54692: [Driver] Use libOption with tablegen.

jingham added a comment. You have to gather all the -O's and -S's and -Q's and add them to the list of code that gets sourced before the file is loaded in the order in which you find them. There can be more than one of each of these and they can be interspersed anywhere among the other

[Lldb-commits] [PATCH] D54692: [Driver] Use libOption with tablegen.

JDevlieghere updated this revision to Diff 175377. JDevlieghere added a comment. Will land this tomorrow once we've figured out how to integrate tablegen with the Xcode project. In the meantime I found some issues due to ordering of command options. Their relative order matters and we had

[Lldb-commits] [PATCH] D54914: Add a generic build script for building test inferiors

zturner updated this revision to Diff 175366. zturner added a comment. I went ahead and fixed up the rest of the native pdb tests. This exposed a couple of minor issues with the build script which I also fixed in the process. @stella.stamenova would you mind giving this a try? I think it will

Re: [Lldb-commits] [lldb] r347305 - [CMake] Streamline code signing for debugserver and pass entitlements to extended llvm_codesign

Reverted in r347619. -- Davide On Mon, Nov 26, 2018 at 3:34 PM Davide Italiano wrote: > > On Tue, Nov 20, 2018 at 6:13 AM Stefan Granitz via lldb-commits > wrote: > > > > Author: stefan.graenitz > > Date: Tue Nov 20 06:10:33 2018 > > New Revision: 347305 > > > > URL:

[Lldb-commits] [lldb] r347619 - Revert "[CMake] Streamline code signing for debugserver and pass entitlements to extended llvm_codesign"

Author: davide Date: Mon Nov 26 16:25:49 2018 New Revision: 347619 URL: http://llvm.org/viewvc/llvm-project?rev=347619=rev Log: Revert "[CMake] Streamline code signing for debugserver and pass entitlements to extended llvm_codesign" It breaks the lldb cmake bots. Modified:

[Lldb-commits] [lldb] r347615 - [FileSystem] Ignore nanoseconds when comparing oso_mod_time

Author: jdevlieghere Date: Mon Nov 26 15:40:52 2018 New Revision: 347615 URL: http://llvm.org/viewvc/llvm-project?rev=347615=rev Log: [FileSystem] Ignore nanoseconds when comparing oso_mod_time After a recent change in LLVM the TimePoint encoding become more precise, exceeding the precision of

Re: [Lldb-commits] [lldb] r347305 - [CMake] Streamline code signing for debugserver and pass entitlements to extended llvm_codesign

On Tue, Nov 20, 2018 at 6:13 AM Stefan Granitz via lldb-commits wrote: > > Author: stefan.graenitz > Date: Tue Nov 20 06:10:33 2018 > New Revision: 347305 > > URL: http://llvm.org/viewvc/llvm-project?rev=347305=rev > Log: > [CMake] Streamline code signing for debugserver and pass entitlements to

[Lldb-commits] [PATCH] D54914: Add a generic build script for building test inferiors

zturner updated this revision to Diff 175344. zturner added a comment. Herald added a subscriber: delcypher. It turned out to not be super complicated, so I went ahead and made it support toolchain auto-detection. This allows the substitution to bake in a command line parameter of

[Lldb-commits] [PATCH] D54914: Add a generic build script for building test inferiors

JDevlieghere added a comment. I personally prefer this approach, if only for the fact that the substitutions are more familiar and that this change would be local to lldb. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54914/new/ https://reviews.llvm.org/D54914

[Lldb-commits] [PATCH] D54914: Add a generic build script for building test inferiors

zturner created this revision. zturner added reviewers: rnk, davide, stella.stamenova, labath, vsk, aprantl. This is an alternative approach to D54731 . Instead of allow the user to invoke arbitrary python code directly from inside of a test, this patch adds a

[Lldb-commits] [PATCH] D54692: [Driver] Use libOption with tablegen.

JDevlieghere added a comment. In D54692#1308640 , @clayborg wrote: > I would wait to get another OK from anyone else just to be sure. Sounds good. Thanks Greg! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54692/new/

[Lldb-commits] [PATCH] D54692: [Driver] Use libOption with tablegen.

clayborg added a comment. I would wait to get another OK from anyone else just to be sure. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54692/new/ https://reviews.llvm.org/D54692 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D54692: [Driver] Use libOption with tablegen.

JDevlieghere added a comment. In D54692#1308604 , @clayborg wrote: > Can you attach new output with the grouping and extra usage? I updated the original snippet, see https://reviews.llvm.org/P8118 CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D54692: [Driver] Use libOption with tablegen.

clayborg added a comment. Can you attach new output with the grouping and extra usage? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54692/new/ https://reviews.llvm.org/D54692 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D54692: [Driver] Use libOption with tablegen.

JDevlieghere updated this revision to Diff 175319. JDevlieghere added a comment. - Add grouping - Use basename for help CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54692/new/ https://reviews.llvm.org/D54692 Files: tools/driver/CMakeLists.txt tools/driver/Driver.cpp

[Lldb-commits] [PATCH] D54692: [Driver] Use libOption with tablegen.

jingham added a comment. I didn't read the patch in detail yet, these are just meta-comments: It looks like the libOption approach (or this implementation of it) is missing the notion of option groups. That's what you see in the first section of the lldb --help printout in the current

[Lldb-commits] [PATCH] D54692: [Driver] Use libOption with tablegen.

clayborg added a comment. I know cl::opt had ways to group options and the table gen is more powerful so it must have this feature? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54692/new/ https://reviews.llvm.org/D54692 ___ lldb-commits

[Lldb-commits] [PATCH] D54692: [Driver] Use libOption with tablegen.

clayborg added a comment. Can we still group the options as mentioned in my previous comment? Comment at: tools/driver/Driver.cpp:943 +usage << '\n'; +usage << argv[0] << " -h" << '\n'; +usage << argv[0] << " -v [[--] [ ...]]\n"; Get file base

[Lldb-commits] [PATCH] D54692: [Driver] Use libOption with tablegen.

JDevlieghere updated this revision to Diff 175300. JDevlieghere added a comment. Add old usage. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54692/new/ https://reviews.llvm.org/D54692 Files: tools/driver/CMakeLists.txt tools/driver/Driver.cpp tools/driver/Driver.h

[Lldb-commits] [PATCH] D54616: [Reproducers] Improve reproducer API and add unit tests.

JDevlieghere updated this revision to Diff 175293. JDevlieghere marked 6 inline comments as done. JDevlieghere added a comment. Thanks Pavel, really useful feedback, I learned a few new things :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54616/new/ https://reviews.llvm.org/D54616

[Lldb-commits] [PATCH] D54692: [Driver] Use libOption with tablegen.

clayborg added a comment. the old usage: Usage: lldb -h lldb -v [[--] [ ...]] lldb -a -f [-c ] [-s ] [-o ] [-S ] [-O ] [-k ] [-K ] [-Q] [-b] [-e] [-x] [-X] [-l ] [-d] [-z ] [[--] [ ...]] lldb -n -w [-s ] [-o ] [-S ] [-O ] [-k ] [-K ] [-Q] [-b] [-e] [-x] [-X] [-l ]

[Lldb-commits] [lldb] r347579 - [lit] Fully qualify lit_config to avoid runtime crashes.

Author: davide Date: Mon Nov 26 09:39:20 2018 New Revision: 347579 URL: http://llvm.org/viewvc/llvm-project?rev=347579=rev Log: [lit] Fully qualify lit_config to avoid runtime crashes. Modified: lldb/trunk/lit/helper/toolchain.py Modified: lldb/trunk/lit/helper/toolchain.py URL:

[Lldb-commits] [lldb] r347578 - [Cmake] Add missing dependency to `count`.

Author: davide Date: Mon Nov 26 09:30:28 2018 New Revision: 347578 URL: http://llvm.org/viewvc/llvm-project?rev=347578=rev Log: [Cmake] Add missing dependency to `count`. Modified: lldb/trunk/lit/CMakeLists.txt Modified: lldb/trunk/lit/CMakeLists.txt URL:

[Lldb-commits] [PATCH] D54692: [Driver] Use libOption with tablegen.

labath added a comment. In D54692#1308207 , @zturner wrote: > In D54692#1308190 , @labath wrote: > > > Another reason for using libOption is that it is also usable as a parser > > for the lldb command line,

[Lldb-commits] [PATCH] D54863: [ASTImporter] Set MustBuildLookupTable on PrimaryContext

martong added a comment. > Is this failing only on linux? Do you happen to have a buildbot link that > shows the failure? This LLDB patch is to prevent the buildbot failure when we commit this Clang/ASTImporter patch : https://reviews.llvm.org/D53655 Repository: rL LLVM CHANGES SINCE

[Lldb-commits] [PATCH] D54886: Add support for the Dylan language to ClangASTContext

aprantl added inline comments. Comment at: source/Symbol/ClangASTContext.cpp:123 + language == eLanguageTypeD || + language == eLanguageTypeDylan; } Please add a comment explaining that "The Debug info generated by the Open Dylan compiler's

[Lldb-commits] [PATCH] D54863: [ASTImporter] Set MustBuildLookupTable on PrimaryContext

martong added a comment. Thank you all for the review! :) Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54863/new/ https://reviews.llvm.org/D54863 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D54863: [ASTImporter] Set MustBuildLookupTable on PrimaryContext

This revision was automatically updated to reflect the committed changes. Closed by commit rL347575: [ASTImporter] Set MustBuildLookupTable on PrimaryContext (authored by martong, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D54692: [Driver] Use libOption with tablegen.

zturner added a comment. In D54692#1308190 , @labath wrote: > > There’s actually been a slow push away from cl::opt. It’s less flexible > > and doesn’t support some things that the TableGen approach does. > > Recently there’s been a few efforts to port

[Lldb-commits] [PATCH] D54682: [Driver] Extract option parsing and option processing.

JDevlieghere abandoned this revision. JDevlieghere added a comment. Thanks everyone! Looks like the general consensus is in favor of using libOption, so I'm abandoning this in favor of D54692 . Please continue the discussion there. Repository: rLLDB LLDB

[Lldb-commits] [PATCH] D54692: [Driver] Use libOption with tablegen.

labath added a comment. > There’s actually been a slow push away from cl::opt. It’s less flexible > and doesn’t support some things that the TableGen approach does. > Recently there’s been a few efforts to port existing tools onto TableGen > options from cl::opt. > > I don’t think cl::opt is

[Lldb-commits] [PATCH] D54863: [ASTImporter] Set MustBuildLookupTable on PrimaryContext

davide added a comment. In D54863#1308176 , @martong wrote: > > Can you write an lldb test for this? > > There is already an existing test for that: > > 2: test_expr_dwarf (TestSharedLib.SharedLibTestCase) > Test that types work when defined in a

[Lldb-commits] [PATCH] D54692: [Driver] Use libOption with tablegen.

davide added a comment. In D54692#1308071 , @clayborg wrote: > Would be great to see old and new output like Zach suggested. Is there a > reason we need to use TableGen? Other command line tools just use llvm::opt > stuff. Seems a bit obtuse to use

[Lldb-commits] [PATCH] D54863: [ASTImporter] Set MustBuildLookupTable on PrimaryContext

martong added a comment. > Can you write an lldb test for this? There is already an existing test for that: 2: test_expr_dwarf (TestSharedLib.SharedLibTestCase) Test that types work when defined in a shared library and forward-declared in the main executable ... python:

[Lldb-commits] [PATCH] D54692: [Driver] Use libOption with tablegen.

zturner added a comment. I actually don't find this too bad, and like Pavel mentioned earlier, it's something that we can fix in LLVM and improve everyone's output. Which is one of the nice things about sharing code like this. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D54692: [Driver] Use libOption with tablegen.

JDevlieghere added a comment. Current output: https://reviews.llvm.org/P8117 Tablegen output: https://reviews.llvm.org/P8118 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54692/new/ https://reviews.llvm.org/D54692

Re: [Lldb-commits] [PATCH] D54692: [Driver] Use libOption with tablegen.

There’s actually been a slow push away from cl::opt. It’s less flexible and doesn’t support some things that the TableGen approach does. Recently there’s been a few efforts to port existing tools onto TableGen options from cl::opt. I don’t think cl::opt is going away anytime soon so if it works I

[Lldb-commits] [PATCH] D54692: [Driver] Use libOption with tablegen.

clayborg added a comment. Would be great to see old and new output like Zach suggested. Is there a reason we need to use TableGen? Other command line tools just use llvm::opt stuff. Seems a bit obtuse to use TableGen? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D28305: [Host] Handle short reads and writes, take 3

labath added a comment. This is a stale patch which I am abandoning. I am just cleaning up my queue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28305/new/ https://reviews.llvm.org/D28305 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D28305: [Host] Handle short reads and writes, take 3

clayborg added a comment. Any reason we are removing File::SeekFromCurrent and File::SeekFromEnd? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28305/new/ https://reviews.llvm.org/D28305 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D54751: [LLDB] - Fix setting the breakpoints when -gsplit-dwarf and DWARF 5 were used for building the executable.

clayborg added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:354-355 + if (!addr_base) +addr_base = cu_die.GetAttributeValueAsUnsigned(m_dwarf, this, + DW_AT_GNU_addr_base, 0);

[Lldb-commits] [PATCH] D54751: [LLDB] - Fix setting the breakpoints when -gsplit-dwarf and DWARF 5 were used for building the executable.

clayborg added a comment. Missed an inline comment on last comment Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:311 + dw_addr_t addr_base = + cu_die.GetAttributeValueAsUnsigned(m_dwarf, this, DW_AT_addr_base, 0); + SetAddrBase(addr_base);

[Lldb-commits] [PATCH] D54751: [LLDB] - Fix setting the breakpoints when -gsplit-dwarf and DWARF 5 were used for building the executable.

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. See inlined comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:353 + // unit in contrast. + if (!addr_base) +addr_base =

[Lldb-commits] [PATCH] D54843: [Expr] Check the language before ignoring Objective C keywords

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:404 -// non-Apple platforms, but for now it is needed. -

[Lldb-commits] [PATCH] D54863: [ASTImporter] Set MustBuildLookupTable on PrimaryContext

clayborg accepted this revision. clayborg added a comment. Looks good to me as long as test suite is happy. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54863/new/ https://reviews.llvm.org/D54863 ___ lldb-commits

[Lldb-commits] [PATCH] D54863: [ASTImporter] Set MustBuildLookupTable on PrimaryContext

davide added a comment. In D54863#1306947 , @martong wrote: > We have a change in Clang/ASTImporter which causes an LLDB assertion, unless > this patch is applied. > The related change is https://reviews.llvm.org/D53655 > > In that patch we change the

[Lldb-commits] [PATCH] D54843: [Expr] Check the language before ignoring Objective C keywords

aleksandr.urakov added a reviewer: labath. aleksandr.urakov marked an inline comment as done. aleksandr.urakov added inline comments. Comment at: source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:401-404 -// FIXME: the following language option is a temporary

[Lldb-commits] [PATCH] D54751: [LLDB] - Fix setting the breakpoints when -gsplit-dwarf and DWARF 5 were used for building the executable.

grimar added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:351 + if (!addr_base) +addr_base = + cu_die.GetAttributeValueAsUnsigned(m_dwarf, this, DW_AT_GNU_addr_base, 0); jankratochvil wrote: > Here I would find good also

[Lldb-commits] [PATCH] D54751: [LLDB] - Fix setting the breakpoints when -gsplit-dwarf and DWARF 5 were used for building the executable.

grimar updated this revision to Diff 175222. grimar marked an inline comment as done. grimar added a comment. Thanks for looking at this, Jan! - Rewrote the comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54751/new/ https://reviews.llvm.org/D54751 Files:

[Lldb-commits] [PATCH] D54751: [LLDB] - Fix setting the breakpoints when -gsplit-dwarf and DWARF 5 were used for building the executable.

jankratochvil added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:351 + if (!addr_base) +addr_base = + cu_die.GetAttributeValueAsUnsigned(m_dwarf, this, DW_AT_GNU_addr_base, 0); Here I would find good also a comment: ```

[Lldb-commits] [PATCH] D54751: [LLDB] - Fix setting the breakpoints when -gsplit-dwarf and DWARF 5 were used for building the executable.

jankratochvil accepted this revision. jankratochvil added a comment. This revision is now accepted and ready to land. I do not think my approval is sufficient but I agree with the patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54751/new/ https://reviews.llvm.org/D54751

[Lldb-commits] [PATCH] D54863: [ASTImporter] Set MustBuildLookupTable on PrimaryContext

labath accepted this revision. labath added a reviewer: clayborg. labath added a comment. The change looks pretty safe to me. Adding Greg in case he has any concerns. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54863/new/ https://reviews.llvm.org/D54863

[Lldb-commits] [PATCH] D54843: [Expr] Check the language before ignoring Objective C keywords

labath added inline comments. Comment at: source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:401-404 -// FIXME: the following language option is a temporary workaround, -// to "ask for C++, get ObjC++". Apple hopes to remove this requirement on -//