[Lldb-commits] [lldb] r348440 - Add a unit test for ArchSpec matching to document how it behaves (and test it).

Author: adrian Date: Wed Dec 5 16:43:55 2018 New Revision: 348440 URL: http://llvm.org/viewvc/llvm-project?rev=348440&view=rev Log: Add a unit test for ArchSpec matching to document how it behaves (and test it). Modified: lldb/trunk/source/Utility/ArchSpec.cpp lldb/trunk/unittests/Utilit

[Lldb-commits] [lldb] r348435 - [lldbsuite] Disable TestStopPCs when there's no XML support

Author: stella.stamenova Date: Wed Dec 5 16:11:17 2018 New Revision: 348435 URL: http://llvm.org/viewvc/llvm-project?rev=348435&view=rev Log: [lldbsuite] Disable TestStopPCs when there's no XML support The test relies on xml support to setup the correct registers. If there's no XML support, the

[Lldb-commits] [PATCH] D44072: [lldb] Retrieve currently handled Obj-C exception via __cxa_current_exception_type and add GetCurrentExceptionBacktrace SB ABI

jingham added a comment. This looks good. Can you add two more tests: 1. Can you add a step to your tests that shows fetching the current exception object from a thread that doesn't have an exception does the right thing (i.e. nothing). 2. Since C++ and ObjC exceptions use the same mechanism c

Re: [Lldb-commits] [PATCH] D54942: [PDB] Make PDB lit tests use the new builder

I was thinking that we could just automatically compute the output file names as: os.path.join(out_dir, basename(output_file) + '.' + basename(input_file) + '.obj') Currently it's just os.path.join(out_dir, basename(input_file) + '.obj') which is why I think the problem occurs. On Wed, Dec 5,

Re: [Lldb-commits] [PATCH] D54942: [PDB] Make PDB lit tests use the new builder

I think with all the tests running in parallel we should err on the side of having unique names for everything automatically generated. From: Aleksandr Urakov Sent: Wednesday, December 5, 2018 12:48 PM To: Zachary Turner Cc: reviews+d54942+public+2603ca548f36d...@reviews.llvm.org; Stella Stamen

Re: [Lldb-commits] [PATCH] D54942: [PDB] Make PDB lit tests use the new builder

With such solution there would be even no need to change the current commit. But I'm not sure that it's trivial to do - the output file name may contain path with directories. May be we can replace slashes with underscores in the output file path and concatenate it with the object file name? Or eve

[Lldb-commits] [PATCH] D55318: [Expressions] Add support of expressions evaluation in some object's context

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. This is a little bit odd, but it does make it easy to call methods on a value you got from FindVariable without having to cons up an expression. That seems worthwhile. It would b

Re: [Lldb-commits] [PATCH] D54942: [PDB] Make PDB lit tests use the new builder

It is not possible to specify object file name in compile and link mode. But perhaps we can just change the default object file name to include something from the output file as well On Wed, Dec 5, 2018 at 12:26 PM Aleksandr Urakov via Phabricator < revi...@reviews.llvm.org> wrote: > aleksandr.ura

[Lldb-commits] [PATCH] D54942: [PDB] Make PDB lit tests use the new builder

aleksandr.urakov added a subscriber: zturner. aleksandr.urakov added a comment. The similar problem with `typedefs.test` is here: http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/1940/steps/test/logs/stdio I have an assumption about the cause of the problem. Are the tests running

[Lldb-commits] [PATCH] D55142: Minidump debugging using the native PDB reader

markmentovai added a comment. This seems like a step in the right direction. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55142/new/ https://reviews.llvm.org/D55142 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llv

[Lldb-commits] [PATCH] D54942: [PDB] Make PDB lit tests use the new builder

aleksandr.urakov added a comment. It looks strange. The compiler can't open the object file. And in the next build it is ok - may be it was some server failure (e.g. full disk)? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54942/new/ https://reviews.llvm.org/D54

[Lldb-commits] [PATCH] D54942: [PDB] Make PDB lit tests use the new builder

stella.stamenova added a comment. enums-layout.test is now failing on Windows: http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/1938/steps/test/logs/stdio Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54942/new/ https://reviews.llvm.org/D54942 _

[Lldb-commits] [PATCH] D55230: [lit] Multiple build outputs and default target bitness

stella.stamenova added a comment. LLDB :: BuildScript/toolchain-clang-cl.test is failing on Linux. 2018-12-05T17:59:42.1570845Z Command Output (stderr): 2018-12-05T17:59:42.1582271Z -- 2018-12-05T17:59:42.1593369Z Traceback (most recent call last): 2018-12-05T17:59:42.1604689Z File "/h

[Lldb-commits] [PATCH] D55142: Minidump debugging using the native PDB reader

lemo updated this revision to Diff 176853. lemo marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55142/new/ https://reviews.llvm.org/D55142 Files: source/Plugins/Process/minidump/MinidumpParser.cpp source/Plugins/Process/minidump/MinidumpParser.h sour

[Lldb-commits] [PATCH] D55142: Minidump debugging using the native PDB reader

lemo marked 9 inline comments as done. lemo added a comment. In D55142#1316153 , @labath wrote: > I don't see any tests :(. > Also, the three bullet points in the description sound like rather > independent pieces of functionality. Would it be possible t

[Lldb-commits] [PATCH] D55318: [Expressions] Add support of expressions evaluation in some object's context

aleksandr.urakov added a comment. Btw, it can be useful if there ever would be a declarative format for pretty printers in LLDB. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55318/new/ https://reviews.llvm.org/D55318 ___

Re: [Lldb-commits] [PATCH] D54942: [PDB] Make PDB lit tests use the new builder

Ok, thanks! On Wed, Dec 5, 2018 at 6:06 PM Zachary Turner wrote: > Yes, if the tests pass for you with current builder, please commit > On Wed, Dec 5, 2018 at 6:06 AM Aleksandr Urakov via Phabricator < > revi...@reviews.llvm.org> wrote: > >> aleksandr.urakov added a comment. >> >> It seems that

[Lldb-commits] [PATCH] D54942: [PDB] Make PDB lit tests use the new builder

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL348386: [PDB] Make PDB lit tests use the new builder (authored by aleksandr.urakov, committed by ). Herald added a subscri

[Lldb-commits] [lldb] r348386 - [PDB] Make PDB lit tests use the new builder

Author: aleksandr.urakov Date: Wed Dec 5 09:35:30 2018 New Revision: 348386 URL: http://llvm.org/viewvc/llvm-project?rev=348386&view=rev Log: [PDB] Make PDB lit tests use the new builder Reviewers: zturner, stella.stamenova Reviewed By: zturner Tags: #lldb Differential Revision: https://revie

[Lldb-commits] [PATCH] D55316: [CMake] Add support for NO_INSTALL_RPATH argument in llvm_add_library()

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: cmake/modules/AddLLVM.cmake:458 + if(NOT ARG_NO_INSTALL_RPATH) +if(ARG_MODULE OR ARG_SHARED) Any kind of comment that we could add h

[Lldb-commits] [PATCH] D55317: [CMake] Aggregate options for LLDB in LLDBConfig.cmake

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Looks more organized. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55317/new/ https://reviews.llvm.org/D55317 ___ lldb-commits mailin

[Lldb-commits] [PATCH] D55320: [CMake] Move debugserver options to separate debugserverConfig.cmake

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: cmake/modules/debugserverConfig.cmake:2 +# Duplicate options from LLDBConfig that are relevant for debugserver Standalone builds. + +option(LLDB_USE_ENTITL

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

friss added a comment. In D55328#1320267 , @clayborg wrote: > I like seeing all of the cmake modifications for the LLDB.framework. Are we > planning on trying to get rid of the Xcode project at some point soon and use > the auto generated one made by cma

[Lldb-commits] [PATCH] D55332: [CMake] Python bindings generation polishing

sgraenitz marked an inline comment as done. sgraenitz added inline comments. Comment at: CMakeLists.txt:143 -DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/scripts/finishSwigWrapperClasses.py -DEPENDS ${LLDB_PYTHON_TARGET_DIR}/lldb.py COMMENT "Python script sym-link

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

sgraenitz marked an inline comment as done. sgraenitz added a comment. I am still running some remaining tests, but please let me know what you think about it in the meantime. In case you want to try this patch yourself, please checkout together with the related revisions (see Stack). ===

[Lldb-commits] [PATCH] D55332: [CMake] Python bindings generation polishing

sgraenitz created this revision. sgraenitz added reviewers: JDevlieghere, aprantl, stella.stamenova, beanz, zturner. Herald added a subscriber: mgorny. Simplify SWIG invocation and handling of generated files. The `swig_wrapper` target can generate `LLDBWrapPython.cpp` and `lldb.py` in its own

[Lldb-commits] [PATCH] D55319: [CMake] Proposal: Prefer LLDB_VERSION over plist value in EmbedAppleVersion.cmake

sgraenitz added a comment. In order to reduce the risk of breaking the Xcode build, I use a separate `resources/LLDB-Info.plist.in` (https://reviews.llvm.org/D55328#change-SBZDFQxftWtU) for the framework. I did not yet change which plist is used here, but yes writing the correct version would

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

clayborg added a comment. I like seeing all of the cmake modifications for the LLDB.framework. Are we planning on trying to get rid of the Xcode project at some point soon and use the auto generated one made by cmake? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55328/new/ https://re

[Lldb-commits] [PATCH] D55330: [CMake] Revised RPATH handling

sgraenitz created this revision. sgraenitz added reviewers: xiaobai, JDevlieghere, aprantl, clayborg. Herald added subscribers: mgorny, ki.stfu. If we build LLDB.framework, dependant tools need appropriate RPATHs in both locations, the build-tree (for testing) and the install-tree (for deployment

[Lldb-commits] [PATCH] D44072: [lldb] Retrieve currently handled Obj-C exception via __cxa_current_exception_type and add GetCurrentExceptionBacktrace SB ABI

kubamracek added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44072/new/ https://reviews.llvm.org/D44072 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D55319: [CMake] Proposal: Prefer LLDB_VERSION over plist value in EmbedAppleVersion.cmake

friss added a comment. Wouldn't it make even more sense to to inject LLDB_VERSION into the Info.plist? We will use the Info.plist afterwards, right? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55319/new/ https://reviews.llvm.org/D55319 _

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

sgraenitz created this revision. sgraenitz added reviewers: xiaobai, JDevlieghere, aprantl, davide, beanz. Herald added a subscriber: mgorny. Add features to LLDB CMake builds that have so far only been available in Xcode. Clean up a few inconveniences and prepare further improvements. Options:

Re: [Lldb-commits] [lldb] r348319 - [build.py] Disable tests on non-Windows.

It should be, but I haven’t tested any of the non Windows paths at all yet, so while that seems like a logical fix, there’s probably something else that would break, like not having a clang-cl environment. So the thinking was to just disable them until i can implement and test support for other pla

Re: [Lldb-commits] [lldb] r348319 - [build.py] Disable tests on non-Windows.

On 05/12/2018 16:03, Zachary Turner wrote: If you can commit the same fix I did for the other two that would be great, otherwise I’ll get to it when i get into the office in ~2 hours The thing is, I'm not sure if that's the right fix here. I mean, this script should be able to compile with cl

[Lldb-commits] [PATCH] D55214: Introduce ObjectFileBreakpad

labath marked 3 inline comments as done. labath added inline comments. Comment at: source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.h:74 + + bool IsStripped() override { return false; } + markmentovai wrote: > labath wrote: > > zturner wrote: > > > Is this

[Lldb-commits] [PATCH] D55214: Introduce ObjectFileBreakpad

markmentovai added inline comments. Comment at: source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.h:74 + + bool IsStripped() override { return false; } + labath wrote: > zturner wrote: > > Is this always true for breakpad files? > Well.. the whole point of t

Re: [Lldb-commits] [PATCH] D54942: [PDB] Make PDB lit tests use the new builder

Yes, if the tests pass for you with current builder, please commit On Wed, Dec 5, 2018 at 6:06 AM Aleksandr Urakov via Phabricator < revi...@reviews.llvm.org> wrote: > aleksandr.urakov added a comment. > > It seems that all the reviews this one depends on are already in. Can we > proceed with it?

Re: [Lldb-commits] [lldb] r348319 - [build.py] Disable tests on non-Windows.

If you can commit the same fix I did for the other two that would be great, otherwise I’ll get to it when i get into the office in ~2 hours On Wed, Dec 5, 2018 at 3:03 AM Pavel Labath wrote: > On 05/12/2018 00:56, Zachary Turner via lldb-commits wrote: > > Author: zturner > > Date: Tue Dec 4 15:

[Lldb-commits] [PATCH] D54942: [PDB] Make PDB lit tests use the new builder

aleksandr.urakov added a comment. It seems that all the reviews this one depends on are already in. Can we proceed with it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54942/new/ https://reviews.llvm.org/D54942 ___ lldb-commits mailing l

[Lldb-commits] [PATCH] D55320: [CMake] Move debugserver options to separate debugserverConfig.cmake

sgraenitz created this revision. sgraenitz added reviewers: JDevlieghere, aprantl, xiaobai. Herald added a subscriber: mgorny. One place for debugserver options, analog to LLDBConfig for LLDB options (see D55317 ). It was discussed in earlier reviews already, e.g

[Lldb-commits] [PATCH] D55319: [CMake] Proposal: Prefer LLDB_VERSION over plist value in EmbedAppleVersion.cmake

sgraenitz created this revision. sgraenitz added reviewers: aprantl, friss. Herald added a subscriber: mgorny. LLDB_VERSION works analogous to CLANG_VERSION, with the exception that it includes the optional LLDB_VERSION_SUFFIX. Thus it should be equal to LLDB_VERSION_STRING and we could use it i

[Lldb-commits] [PATCH] D55318: [Expressions] Add support of expressions evaluation in some object's context

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: teemperor, clayborg, jingham, zturner, labath, davide, spyffe. aleksandr.urakov added a project: LLDB. Herald added subscribers: lldb-commits, abidh. This patch adds support of expression evaluation in a context of some obj

[Lldb-commits] [PATCH] D55317: [CMake] Aggregate options for LLDB in LLDBConfig.cmake

sgraenitz created this revision. sgraenitz added reviewers: JDevlieghere, aprantl, xiaobai. Herald added subscribers: mgorny, srhines. In preparation for LLDB.framework changes, collect options for LLDB in LLDBConfig.cmake (used for both, standalone and in-tree builds). https://reviews.llvm.org

[Lldb-commits] [PATCH] D55084: [CMake] Add RPATHS parameter to llvm_add_executable/library

sgraenitz abandoned this revision. sgraenitz added a comment. More requirements for RPATH handling in LLDB came up. We will do it manually over there instead of adding support in LLVM. Added D55316 to avoid the need for reverting default settings. Repository:

[Lldb-commits] [PATCH] D55316: [CMake] Add support for NO_INSTALL_RPATH argument in llvm_add_library()

sgraenitz created this revision. sgraenitz added reviewers: aprantl, JDevlieghere, davide, friss. Herald added a subscriber: mgorny. Allow clients to suppress setup of default RPATHs in designated library targets. This is used in LLDB when emitting liblldb as a framework bundle, which itself doe

[Lldb-commits] [lldb] r348360 - [CMake] Fix side-effect from LLDB_VERSION change in r346668 for framework-enabled builds

Author: stefan.graenitz Date: Wed Dec 5 04:18:44 2018 New Revision: 348360 URL: http://llvm.org/viewvc/llvm-project?rev=348360&view=rev Log: [CMake] Fix side-effect from LLDB_VERSION change in r346668 for framework-enabled builds Modified: lldb/trunk/CMakeLists.txt lldb/trunk/cmake/modu

[Lldb-commits] [PATCH] D55214: Introduce ObjectFileBreakpad

labath added inline comments. Comment at: lit/Modules/Breakpad/lit.local.cfg:1 +config.suffixes = ['.test'] zturner wrote: > This shouldn't be necessary, the top-level `lit.cfg.py` already recognizes > `.test` extension. You only need a lit.local.cfg if you're

[Lldb-commits] [PATCH] D55214: Introduce ObjectFileBreakpad

labath updated this revision to Diff 176781. labath marked 17 inline comments as done. labath added a comment. Updated according to review comments. Also added a couple of tests for invalid inputs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55214/new/ https://reviews.llvm.org/D55214

Re: [Lldb-commits] [lldb] r348319 - [build.py] Disable tests on non-Windows.

On 05/12/2018 00:56, Zachary Turner via lldb-commits wrote: Author: zturner Date: Tue Dec 4 15:56:25 2018 New Revision: 348319 URL: http://llvm.org/viewvc/llvm-project?rev=348319&view=rev Log: [build.py] Disable tests on non-Windows. This won't work until we get the GCC / clang builder impleme