[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

rocallahan added a comment. Sorry for the delayed reply. I just discovered that Phabricator nofications were being buried by my mail filters. In D54747#1312161 , @ruiu wrote: > What you are doing in this patch is not too complicated and makes sense to >

[Lldb-commits] [lldb] r350149 - [RegisterValue] Rewrite operator!= in terms of operator==. NFCI.

Author: davide Date: Fri Dec 28 21:05:23 2018 New Revision: 350149 URL: http://llvm.org/viewvc/llvm-project?rev=350149&view=rev Log: [RegisterValue] Rewrite operator!= in terms of operator==. NFCI. Modified: lldb/trunk/source/Utility/RegisterValue.cpp Modified: lldb/trunk/source/Utility/Regi

[Lldb-commits] [lldb] r350148 - [CompilerType] Simplify operator!=. NFCI.

Author: davide Date: Fri Dec 28 21:00:33 2018 New Revision: 350148 URL: http://llvm.org/viewvc/llvm-project?rev=350148&view=rev Log: [CompilerType] Simplify operator!=. NFCI. Modified: lldb/trunk/source/Symbol/CompilerType.cpp Modified: lldb/trunk/source/Symbol/CompilerType.cpp URL: http://

[Lldb-commits] [lldb] r350147 - [CompilerType] Remove dead code. NFCI.

Author: davide Date: Fri Dec 28 20:59:07 2018 New Revision: 350147 URL: http://llvm.org/viewvc/llvm-project?rev=350147&view=rev Log: [CompilerType] Remove dead code. NFCI. Modified: lldb/trunk/source/Symbol/CompilerType.cpp Modified: lldb/trunk/source/Symbol/CompilerType.cpp URL: http://llv

[Lldb-commits] [lldb] r350146 - [SymbolContext] Rewrite operator== to be more concise.

Author: davide Date: Fri Dec 28 20:57:00 2018 New Revision: 350146 URL: http://llvm.org/viewvc/llvm-project?rev=350146&view=rev Log: [SymbolContext] Rewrite operator== to be more concise. And probably, less error prone. NFCI. Modified: lldb/trunk/source/Symbol/SymbolContext.cpp Modified: ll

[Lldb-commits] [PATCH] D56126: [NativePDB] Add basic support of methods recostruction in AST

zturner added a comment. > This info is contained in the Symbols stream, not in the TPI stream. As far > as I understand, we can't find in a simple way the link between a > LF_ONEMETHOD record and a corresponding S_GPROC32 record. I think it's the > place, where we need to use the approach simi

[Lldb-commits] [PATCH] D56124: PECOFF: Fix section name computation

labath updated this revision to Diff 179644. labath added a comment. An excellent idea. Updating to use StringRef. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56124/new/ https://reviews.llvm.org/D56124 Files: lit/Modules/PECOFF/sections-names.yaml source

[Lldb-commits] [PATCH] D56124: PECOFF: Fix section name computation

zturner added a comment. What about just making this function return a StringRef? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56124/new/ https://reviews.llvm.org/D56124 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [PATCH] D56132: Symtab: Remove one copy of symbol size computation code

labath created this revision. labath added reviewers: clayborg, jasonmolenda, tberghammer. The implementation in CalculateSymbolSizes has been made redundant in D19004 , as this patch added another copy of size computation code into InitAddressIndexes (which is ca

[Lldb-commits] [lldb] r350122 - Fix signed-unsigned comparisons in MinidumpParserTest

Author: labath Date: Fri Dec 28 05:34:50 2018 New Revision: 350122 URL: http://llvm.org/viewvc/llvm-project?rev=350122&view=rev Log: Fix signed-unsigned comparisons in MinidumpParserTest Modified: lldb/trunk/unittests/Process/minidump/MinidumpParserTest.cpp Modified: lldb/trunk/unittests/Pro

[Lldb-commits] [lldb] r350121 - Remove unused variable from ClangASTContext

Author: labath Date: Fri Dec 28 05:34:44 2018 New Revision: 350121 URL: http://llvm.org/viewvc/llvm-project?rev=350121&view=rev Log: Remove unused variable from ClangASTContext Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp URL:

[Lldb-commits] [PATCH] D56129: Simplify ObjectFile::GetArchitecture

labath created this revision. labath added reviewers: clayborg, zturner. Herald added subscribers: JDevlieghere, arichardson, emaste. Herald added a reviewer: espindola. instead of returning the architecture through by-ref argument and a boolean value indicating success, we can just return the Arc

[Lldb-commits] [PATCH] D56126: [NativePDB] Add basic support of methods recostruction in AST

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: zturner, labath, lemo, stella.stamenova. aleksandr.urakov added a project: LLDB. Herald added subscribers: lldb-commits, teemperor, abidh. This patch adds the basic support of methods reconstruction by native PDB plugin. It

[Lldb-commits] [PATCH] D56124: PECOFF: Fix section name computation

labath created this revision. labath added reviewers: zturner, stella.stamenova. Herald added a subscriber: abidh. If a section name is exactly 8 bytes long (or has been truncated to 8 bytes), it will not contain the terminating nul character. This means reading the name as a c string will p