[Lldb-commits] [PATCH] D56234: [lldb-server] Add unnamed pipe support to PipeWindows

labath added a comment. Looks very nice. Thanks. Comment at: include/lldb/Host/windows/PipeWindows.h:52 + lldb::pipe_t GetReadPipe() const { return lldb::pipe_t(m_read); } + lldb::pipe_t GetWritePipe() const { return lldb::pipe_t(m_write); } missing `overr

[Lldb-commits] [PATCH] D56234: [lldb-server] Add unnamed pipe support to PipeWindows

labath added inline comments. Comment at: include/lldb/Host/windows/PipeWindows.h:71-74 // PipeWindows specific methods. These allow access to the underlying OS // handle. HANDLE GetReadNativeHandle(); HANDLE GetWriteNativeHandle(); Are these still n

[Lldb-commits] [PATCH] D56531: [CMake] Replace use of llvm-config with LLVM and Clang CMake packages

labath added a comment. Seems like I nice cleanup. I just have a question about the search paths. (Also, I agree with @mgorny about not doing this so close to the branch point.) Comment at: cmake/modules/LLDBStandalone.cmake:9 + find_package(LLVM REQUIRED CONFIG +HINTS "$

[Lldb-commits] [lldb] r350802 - Add a verbose mode to "image dump line-table" and use it to write a .debug_line test

Author: labath Date: Thu Jan 10 01:16:00 2019 New Revision: 350802 URL: http://llvm.org/viewvc/llvm-project?rev=350802&view=rev Log: Add a verbose mode to "image dump line-table" and use it to write a .debug_line test Summary: The motivation for this is being able to write tests for the upcoming

[Lldb-commits] [PATCH] D56315: Add a verbose mode to "image dump line-table" and use it to write a .debug_line test

This revision was automatically updated to reflect the committed changes. Closed by commit rL350802: Add a verbose mode to "image dump line-table" and use it to write a .debug_line… (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE

[Lldb-commits] [lldb] r350804 - Implement ObjectFileELF::GetBaseAddress

Author: labath Date: Thu Jan 10 01:32:31 2019 New Revision: 350804 URL: http://llvm.org/viewvc/llvm-project?rev=350804&view=rev Log: Implement ObjectFileELF::GetBaseAddress Summary: The concept of a base address was already present in the implementation (it's needed for computing section load add

[Lldb-commits] [PATCH] D55995: [lldb] - Fix compilation with MSVS 2015 update 3

grimar added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55995/new/ https://reviews.llvm.org/D55995 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r350810 - Revert "Add a verbose mode to "image dump line-table" and use it to write a .debug_line test"

Author: labath Date: Thu Jan 10 02:23:27 2019 New Revision: 350810 URL: http://llvm.org/viewvc/llvm-project?rev=350810&view=rev Log: Revert "Add a verbose mode to "image dump line-table" and use it to write a .debug_line test" This reverts commit r350802 because the test fails on windows. This h

[Lldb-commits] [lldb] r350809 - PECOFF: Fix section name computation

Author: labath Date: Thu Jan 10 02:23:19 2019 New Revision: 350809 URL: http://llvm.org/viewvc/llvm-project?rev=350809&view=rev Log: PECOFF: Fix section name computation If a section name is exactly 8 bytes long (or has been truncated to 8 bytes), it will not contain the terminating nul character

[Lldb-commits] [PATCH] D56124: PECOFF: Fix section name computation

This revision was automatically updated to reflect the committed changes. Closed by commit rL350809: PECOFF: Fix section name computation (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56124?vs=179644&id=181013#to

[Lldb-commits] [PATCH] D56537: ObjectFilePECOFF: Create a "container" section spanning the entire module image

labath created this revision. labath added reviewers: zturner, amccarth, stella.stamenova, clayborg. Herald added subscribers: abidh, JDevlieghere. This is coming from the discussion in D55356 (the most interesting part happened on the mailing list, so it isn't r

[Lldb-commits] [PATCH] D56543: DWARF: Add some support for non-native directory separators

labath created this revision. labath added reviewers: clayborg, zturner, JDevlieghere. Herald added a subscriber: aprantl. If we opened a file which was produced on system with different path syntax, we would parse the paths from the debug info incorrectly. The reason for that is that we would pa

[Lldb-commits] [PATCH] D55995: [lldb] - Fix compilation with MSVS 2015 update 3

labath added a reviewer: zturner. labath added a comment. BTW, I've been compiling lldb with VS2017 and haven't run into this issue. Also, with the imminent release of VS2019, I expect someone will soon start a thread proposing to drop VS2015, so you might be better of switching to a newer comp

[Lldb-commits] [PATCH] D55995: [lldb] - Fix compilation with MSVS 2015 update 3

grimar added a comment. In D55995#1352772 , @labath wrote: > BTW, I've been compiling lldb with VS2017 and haven't run into this issue. > Also, with the imminent release of VS2019, I expect someone will soon start a > thread proposing to drop VS2015, so

[Lldb-commits] [PATCH] D55995: [lldb] - Fix compilation with MSVS 2015 update 3

grimar planned changes to this revision. grimar added a comment. I'll try to switch to MSVS 2017 and recheck this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55995/new/ https://reviews.llvm.org/D55995 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [PATCH] D55434: ObjectFileBreakpad: Implement sections

sylvestre.ledru added a comment. @labath This broke lldb on Debian stable: In file included from /build/llvm-toolchain-snapshot-8~svn350764/tools/lldb/source/Utility/DataExtractor.cpp:10: /build/llvm-toolchain-snapshot-8~svn350764/tools/lldb/include/lldb/Utility/DataExtractor.h:1099:29: er

[Lldb-commits] [lldb] r350834 - Fix compilation error on 32-bit architectures introduced in r350511

Author: labath Date: Thu Jan 10 07:53:20 2019 New Revision: 350834 URL: http://llvm.org/viewvc/llvm-project?rev=350834&view=rev Log: Fix compilation error on 32-bit architectures introduced in r350511 The issue was a narrowing conversion when converting from uint64_t to a size_t. Modified: l

[Lldb-commits] [PATCH] D55434: ObjectFileBreakpad: Implement sections

sylvestre.ledru added a comment. On i386 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55434/new/ https://reviews.llvm.org/D55434 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[Lldb-commits] [PATCH] D55434: ObjectFileBreakpad: Implement sections

labath added a comment. Thanks for the heads-up. This should be fixed in r350834. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55434/new/ https://reviews.llvm.org/D55434 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [lldb] r350835 - [opaque pointer types] Remove some calls to generic Type subtype accessors.

Author: jyknight Date: Thu Jan 10 08:07:20 2019 New Revision: 350835 URL: http://llvm.org/viewvc/llvm-project?rev=350835&view=rev Log: [opaque pointer types] Remove some calls to generic Type subtype accessors. That is, remove many of the calls to Type::getNumContainedTypes(), Type::subtypes(), a

[Lldb-commits] [PATCH] D56531: [CMake] Replace use of llvm-config with LLVM and Clang CMake packages

compnerd requested changes to this revision. compnerd added inline comments. This revision now requires changes to proceed. Comment at: cmake/modules/LLDBStandalone.cmake:7 option(LLVM_INSTALL_TOOLCHAIN_ONLY "Only include toolchain files in the 'install' target." OFF) + fi

[Lldb-commits] [PATCH] D56440: [CMake] Phase out LLDB_TEST_C/CXX_COMPILER in favor of single LLDB_TEST_COMPILER

sgraenitz marked 6 inline comments as done. sgraenitz added a comment. In D56440#1351033 , @sgraenitz wrote: > In D56440#1349892 , @JDevlieghere > wrote: > > > It looks like `LLDB_TEST_COMPILER_IS_DEFAULT` is set b

[Lldb-commits] [PATCH] D56543: DWARF: Add some support for non-native directory separators

aprantl added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.h:255 + void ComputePathStyle(); + I would probably call this DetectPathStyle() since it's more a heuristic? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56543/new/

[Lldb-commits] [PATCH] D56400: [CMake] Some cleanup around test preparations

stella.stamenova requested changes to this revision. stella.stamenova added inline comments. This revision now requires changes to proceed. Comment at: CMakeLists.txt:49 set(LLDB_DEFAULT_TEST_FILECHECK "${LLVM_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin/FileCheck${CMAKE_EXECUTABLE_SU

[Lldb-commits] [PATCH] D56543: DWARF: Add some support for non-native directory separators

zturner added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.h:255 + void ComputePathStyle(); + aprantl wrote: > I would probably call this DetectPathStyle() since it's more a heuristic? Maybe even `Guess` since `Compute` implies absolu

[Lldb-commits] [PATCH] D56543: DWARF: Add some support for non-native directory separators

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. DW_AT_comp_dir isn't enough. See inline suggestions. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:775-787 +void DWARFUnit::ComputePathStyle() { +

[Lldb-commits] [PATCH] D56531: [CMake] Replace use of llvm-config with LLVM and Clang CMake packages

xiaobai marked 2 inline comments as done. xiaobai added inline comments. Comment at: cmake/modules/LLDBStandalone.cmake:7 option(LLVM_INSTALL_TOOLCHAIN_ONLY "Only include toolchain files in the 'install' target." OFF) + find_package(LLVM REQUIRED CONFIG co

[Lldb-commits] [lldb] r350876 - lldbtest.py: try to fix a runtime exception

Author: adrian Date: Thu Jan 10 11:06:46 2019 New Revision: 350876 URL: http://llvm.org/viewvc/llvm-project?rev=350876&view=rev Log: lldbtest.py: try to fix a runtime exception found on http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-matrix/32/consoleFull#15046896708254eaf0-7326-4999-85b

[Lldb-commits] [PATCH] D56234: [lldb-server] Add unnamed pipe support to PipeWindows

Hui added a comment. In D56234#1352371 , @labath wrote: > Looks very nice. Thanks. There is a similar type file_t widely used in llvm. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56234/new/ https://reviews.llvm.org/D56234

[Lldb-commits] [PATCH] D56531: [CMake] Replace use of llvm-config with LLVM and Clang CMake packages

xiaobai updated this revision to Diff 181135. xiaobai added a comment. compnerd's comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56531/new/ https://reviews.llvm.org/D56531 Files: cmake/modules/LLDBStandalone.cmake Index: cmake/modules/LLDBStandalone.cmake

[Lldb-commits] [lldb] r350888 - [NativePDB] Add support for parsing typedef records.

Author: zturner Date: Thu Jan 10 12:57:32 2019 New Revision: 350888 URL: http://llvm.org/viewvc/llvm-project?rev=350888&view=rev Log: [NativePDB] Add support for parsing typedef records. Typedefs are represented as S_UDT records in the globals stream. This creates a strange situation where "types

[Lldb-commits] [lldb] r350889 - Change SymbolFile::ParseTypes to ParseTypesForCompileUnit.

Author: zturner Date: Thu Jan 10 12:57:50 2019 New Revision: 350889 URL: http://llvm.org/viewvc/llvm-project?rev=350889&view=rev Log: Change SymbolFile::ParseTypes to ParseTypesForCompileUnit. The function SymbolFile::ParseTypes previously accepted a SymbolContext. This makes it extremely difficu

[Lldb-commits] [PATCH] D56462: Change SymbolFile::ParseTypes to ParseTypesForCompileUnit

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL350889: Change SymbolFile::ParseTypes to ParseTypesForCompileUnit. (authored by zturner, committed by ). Herald added a su

[Lldb-commits] [PATCH] D56461: [NativePDB] Add support for parsing typedefs and make lldb-test work with the native reader.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL350888: [NativePDB] Add support for parsing typedef records. (authored by zturner, committed by ). Herald added a subscrib

[Lldb-commits] [PATCH] D56564: [SymbolFile]

zturner created this revision. zturner added reviewers: labath, clayborg, davide. Previously all of these functions accepted a SymbolContext&. While a CompileUnit is one member of a SymbolContext, there are also many others, and by passing such a monolithic parameter in this way it makes t

lldb-commits@lists.llvm.org

clayborg added a comment. All the change to the symbol vendor make sense, but it seems like all of the call sites should be: cu->GetLanguage(); cu->ParseFunctions(); cu->GetLineTable(); cu->ParseDebugMacros(); cu->GetSupportFiles(); cu->ParseTypes(); Some of these calls might alread

lldb-commits@lists.llvm.org

zturner added a comment. In D56564#1353514 , @clayborg wrote: > All the change to the symbol vendor make sense, but it seems like all of the > call sites should be: > > cu->GetLanguage(); > cu->ParseFunctions(); > cu->GetLineTable(); > cu->ParseDe

lldb-commits@lists.llvm.org

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. This is fine to start. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56564/new/ https://reviews.llvm.org/D56564 ___ lldb-commits mai

[Lldb-commits] [PATCH] D56461: [NativePDB] Add support for parsing typedefs and make lldb-test work with the native reader.

amccarth added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp:1289 +if (type) + (void)type->GetFullCompilerType(); + } The body of this loop is a little odd because it's disposing of all the results and i