[Lldb-commits] [lldb] r351524 - [Reproducers] Fix reproducers unittest.

Author: jdevlieghere Date: Thu Jan 17 23:17:05 2019 New Revision: 351524 URL: http://llvm.org/viewvc/llvm-project?rev=351524&view=rev Log: [Reproducers] Fix reproducers unittest. Fix fallout from r351501 in the reproducer unittest. Modified: lldb/trunk/unittests/Utility/ReproducerTest.cpp M

[Lldb-commits] [PATCH] D56814: [Reproducers] Refactor reproducer info

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. JDevlieghere marked 2 inline comments as done. Closed by commit rL351501: [Reproducers] Refactor reproducer info (authored by JDevlieghere, c

[Lldb-commits] [lldb] r351501 - [Reproducers] Refactor reproducer info

Author: jdevlieghere Date: Thu Jan 17 17:04:59 2019 New Revision: 351501 URL: http://llvm.org/viewvc/llvm-project?rev=351501&view=rev Log: [Reproducers] Refactor reproducer info In the original reproducer design, I expected providers to be more dynamic than they turned out. For example, we don't

[Lldb-commits] [lldb] r351498 - [CMake] Only test debugserver if platform can use debugserver

Author: xiaobai Date: Thu Jan 17 16:05:25 2019 New Revision: 351498 URL: http://llvm.org/viewvc/llvm-project?rev=351498&view=rev Log: [CMake] Only test debugserver if platform can use debugserver In commit svn r351496 I changed this condition from `if(LLDB_CAN_USE_DEBUGSERVER)` to `if(NOT SKIP_TE

[Lldb-commits] [lldb] r351497 - [lit] Fix lldbtest format

Author: jdevlieghere Date: Thu Jan 17 15:30:06 2019 New Revision: 351497 URL: http://llvm.org/viewvc/llvm-project?rev=351497&view=rev Log: [lit] Fix lldbtest format The lldbtest format was incorrectly detecting XFAIL as FAIL because it was looking for the `FAIL:` substring in the dotest output.

[Lldb-commits] [PATCH] D56763: [CMake] Prevent lldbDebugserverCommon from building if you disable debugserver builds

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB351496: [CMake] Prevent lldbDebugserverCommon from building if you disable debugserver… (authored by xiaobai, committed

[Lldb-commits] [lldb] r351496 - [CMake] Prevent lldbDebugserverCommon from building if you disable debugserver builds

Author: xiaobai Date: Thu Jan 17 15:14:04 2019 New Revision: 351496 URL: http://llvm.org/viewvc/llvm-project?rev=351496&view=rev Log: [CMake] Prevent lldbDebugserverCommon from building if you disable debugserver builds Summary: The flags `LLDB_USE_SYSTEM_DEBUGSERVER` and `LLDB_NO_DEBUGSERVER` w

[Lldb-commits] [lldb] r351490 - Don't run TestBreakpointThumbCodesection.py on darwin systems;

Author: jmolenda Date: Thu Jan 17 14:26:25 2019 New Revision: 351490 URL: http://llvm.org/viewvc/llvm-project?rev=351490&view=rev Log: Don't run TestBreakpointThumbCodesection.py on darwin systems; we don't use a thumb code section. Don't run Test128BitsInteger.py on armv7k; it's not a supported

[Lldb-commits] [lldb] r351489 - [CMake] Fix lldb-test-depends target

Author: jdevlieghere Date: Thu Jan 17 14:25:20 2019 New Revision: 351489 URL: http://llvm.org/viewvc/llvm-project?rev=351489&view=rev Log: [CMake] Fix lldb-test-depends target The lldb-test-depends target was using the old CMake variable name LLDB_TEST_DEPENDS instead of LLDB_TEST_DEPS. This patc

[Lldb-commits] [lldb] r351486 - [lit] Make sure tests are actually skipped on darwin and windows.

Author: davide Date: Thu Jan 17 13:57:33 2019 New Revision: 351486 URL: http://llvm.org/viewvc/llvm-project?rev=351486&view=rev Log: [lit] Make sure tests are actually skipped on darwin and windows. Modified: lldb/trunk/lit/Expr/TestIRMemoryMap.test lldb/trunk/lit/Quit/TestQuitExitCode-30

[Lldb-commits] [PATCH] D55724: [ARC] Add SystemV ABI

tatyana-krasnukha updated this revision to Diff 182352. tatyana-krasnukha added a comment. Addressed the comment Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55724/new/ https://reviews.llvm.org/D55724 Files: source/API/SystemInitializerFull.cpp source/Plu

[Lldb-commits] [PATCH] D56590: breakpad: Add FUNC records to the symtab

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Much cleaner! Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56590/new/ https://reviews.llvm.org/D56590 ___ lldb-commits maili

[Lldb-commits] [PATCH] D56844: Breakpad: Extract parsing code into a separate file

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Never mind, just read the update to your other patch. Would be nice to identify line records in toToken, but that will probably cost more CPU cycles that it is worth, so I think this is a

[Lldb-commits] [PATCH] D56844: Breakpad: Extract parsing code into a separate file

clayborg added a comment. Are we missing parsing of FUNC and line entry lines in this patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56844/new/ https://reviews.llvm.org/D56844 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

clayborg added inline comments. Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4707 if (comm.GetQXferLibrariesSVR4ReadSupported()) { list.clear(); My two cents: I fully support a stub being able to provide the register info for DWAR

[Lldb-commits] [PATCH] D55724: [ARC] Add SystemV ABI

clayborg added inline comments. Comment at: source/Plugins/ABI/SysV-arc/ABISysV_arc.cpp:43 + +namespace dwarf { +enum regnums { add "namespace {" around all of this Comment at: source/Plugins/ABI/SysV-arc/ABISysV_arc.cpp:52 +}; +} // namespace

[Lldb-commits] [PATCH] D54617: [Reproducers] Add file provider

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: include/lldb/Utility/Reproducer.h:91-92 + +const char *FileInfo::name = "files"; +const char *FileInfo::file = "files.yaml"; + labath wrote: > Are you sure this can be

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha updated this revision to Diff 182325. tatyana-krasnukha added a comment. Removed registers adjustment, dwarf numbers are corrected by AugmentRegisterInfoViaABI now. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55718/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D55724: [ARC] Add SystemV ABI

tatyana-krasnukha updated this revision to Diff 182323. tatyana-krasnukha added a comment. Added a list of registers with correct dwarf numbers Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55724/new/ https://reviews.llvm.org/D55724 Files: source/API/SystemI

[Lldb-commits] [PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

Hui added a comment. It could be the llvm::sys::flattenWindowsCommandLine issue to flatten the command “dir c:\" for Windows Command Terminal. However it is not an issue for PS or MingGW. It is observed the flattened one is "\"C:\\WINDOWS\\system32\\cmd.exe\" /C \" dir c:\" " which will

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha marked an inline comment as not done. tatyana-krasnukha added inline comments. Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4707 +else + // The register info is incorrect, just clear it. + m_register_info.Clear();

[Lldb-commits] [PATCH] D56618: [SymbolFile] Remove the SymbolContext parameter from FindTypes

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This makes sense to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56618/new/ https://reviews.llvm.org/D56618 ___ lldb-commits mailin

[Lldb-commits] [PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

labath added a comment. In D56230#1361650 , @Hui wrote: > +#if defined(_WIN32) > +TEST(ArgsTest, GetFlattenWindowsCommandString) { > + Args args; > + args.AppendArgument("D:\\launcher.exe"); > + args.AppendArgument("--log=abc def"); > + > + std::

[Lldb-commits] [PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

Hui added a comment. In D56230#1361634 , @labath wrote: > In D56230#1358356 , @zturner wrote: > > > I've always disliked this argument and hoped that someday someone would > > remove it entirely. My recollection (

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

labath added inline comments. Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4707 +else + // The register info is incorrect, just clear it. + m_register_info.Clear(); tatyana-krasnukha wrote: > clayborg wrote: > > Is

[Lldb-commits] [PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

labath added a comment. In D56230#1358356 , @zturner wrote: > I've always disliked this argument and hoped that someday someone would > remove it entirely. My recollection (which may be wrong) is that the only > actual use of it is so that if someone ty

[Lldb-commits] [lldb] r351447 - Recommit "Teach the default symbol vendor to respect module.GetSymbolFileFileSpec()"

Author: labath Date: Thu Jan 17 07:07:35 2019 New Revision: 351447 URL: http://llvm.org/viewvc/llvm-project?rev=351447&view=rev Log: Recommit "Teach the default symbol vendor to respect module.GetSymbolFileFileSpec()" This reapplies commit r351330, which was reverted due to a failing test on mac

[Lldb-commits] [lldb] r351435 - Recommit "Add a verbose mode to "image dump line-table" and use it to write a .debug_line test"

Author: labath Date: Thu Jan 17 05:11:04 2019 New Revision: 351435 URL: http://llvm.org/viewvc/llvm-project?rev=351435&view=rev Log: Recommit "Add a verbose mode to "image dump line-table" and use it to write a .debug_line test" This reapplies r350802, which was reverted because of issues with p

[Lldb-commits] [PATCH] D56595: SymbolFileBreakpad: Add line table support

labath planned changes to this revision. labath added a comment. I think I understand what you mean. I'll try to refactor this to create a compile unit for each function. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56595/new/ https://reviews.llvm.org/D56595 ___

[Lldb-commits] [PATCH] D56590: breakpad: Add FUNC records to the symtab

labath added inline comments. Comment at: source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:26 namespace { class LineIterator { public: clayborg wrote: > Move this functionality into llvm::breakpad::Line? I haven't moved this part to the new file becau

[Lldb-commits] [PATCH] D56590: breakpad: Add FUNC records to the symtab

labath updated this revision to Diff 182254. labath marked 7 inline comments as done. labath added a comment. Thanks for the review. I've refactored the code to separate (and centralize) the breakpad parsing from the part which does presents the information to lldb. I've done this slightly differ

[Lldb-commits] [PATCH] D56844: Breakpad: Extract parsing code into a separate file

labath created this revision. labath added reviewers: clayborg, lemo, zturner. Herald added subscribers: fedor.sergeev, mgorny. This centralizes parsing of breakpad records, which was previously spread out over ObjectFileBreakpad and SymbolFileBreakpad. For each record type X there is a separate

[Lldb-commits] [PATCH] D54617: [Reproducers] Add file provider

labath added inline comments. Comment at: include/lldb/Utility/Reproducer.h:91-92 + +const char *FileInfo::name = "files"; +const char *FileInfo::file = "files.yaml"; + Are you sure this can be in a header? I would expect this to give you multiply-defined symbol

[Lldb-commits] [PATCH] D56814: [Reproducers] Refactor reproducer info

labath added a comment. This looks much better. LGTM, just make sure to do something with the lower_bound search, as I don't think that's right. Comment at: include/lldb/Utility/Reproducer.h:58-59 + virtual const char *GetName() const = 0; + virtual const char *GetFile() c