Author: jdevlieghere
Date: Tue Jan 22 16:13:47 2019
New Revision: 351902
URL: http://llvm.org/viewvc/llvm-project?rev=351902&view=rev
Log:
Revert "[dotest] Add logging to investigate CI issue."
We figured out the issue so the logging is no longer necessary. It turns
out we were using a session fo
xiaobai added a comment.
@sgraenitz: I don't mind at all, I view those changes as improvements. Thanks
for that!
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56531/new/
https://reviews.llvm.org/D56531
___
lldb-commi
sgraenitz added a comment.
FYI Fixed two small details with https://reviews.llvm.org/rL351879, hope that's
ok:
- `LLDB_PATH_TO_CLANG_BUILD` defaults to `LLDB_PATH_TO_LLVM_BUILD`
- switch args for `file(TO_CMAKE_PATH "" )`
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.
Author: stefan.graenitz
Date: Tue Jan 22 13:14:51 2019
New Revision: 351879
URL: http://llvm.org/viewvc/llvm-project?rev=351879&view=rev
Log:
[CMake] Fix two details from r351863
Modified:
lldb/trunk/cmake/modules/LLDBStandalone.cmake
Modified: lldb/trunk/cmake/modules/LLDBStandalone.cmake
U
jasonmolenda added a comment.
I'll test this later today. The cleanup looks good; the goal of the most
recent changes was to make HAVE_LIBCOMPESSION always enabled on Darwin systems
- the setting would occasionally get lost in the Xcode project settings and
we'd have slow channels using uncomp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL351863: [CMake] Replace use of llvm-config with LLVM and
Clang CMake packages (authored by xiaobai, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
CHANGES SINCE LAST ACTIO
Author: xiaobai
Date: Tue Jan 22 11:26:42 2019
New Revision: 351863
URL: http://llvm.org/viewvc/llvm-project?rev=351863&view=rev
Log:
[CMake] Replace use of llvm-config with LLVM and Clang CMake packages
Summary:
I did this for two reasons:
- Using the CMake packages simplifies building LLDB Stan
labath marked an inline comment as done.
labath added inline comments.
Comment at: source/Plugins/ObjectFile/Breakpad/BreakpadRecords.cpp:87-97
// The textual module id encoding should be between 33 and 40 bytes long,
// depending on the size of the age field, which is of v
clayborg added inline comments.
Comment at: source/Plugins/ObjectFile/Breakpad/BreakpadRecords.cpp:87-97
// The textual module id encoding should be between 33 and 40 bytes long,
// depending on the size of the age field, which is of variable length.
// The first three c
labath marked 2 inline comments as done.
labath added inline comments.
Comment at: source/Plugins/ObjectFile/Breakpad/BreakpadRecords.cpp:67
+/// to the endian-specific integer N. Return true on success.
+template static bool consume_integer(llvm::StringRef &str, T &N) {
+ llvm
Author: stefan.graenitz
Date: Tue Jan 22 07:59:47 2019
New Revision: 351830
URL: http://llvm.org/viewvc/llvm-project?rev=351830&view=rev
Log:
[CMake] Turn LLDB_FRAMEWORK_TOOLS into STRING to allow overrides from cache
files
Modified:
lldb/trunk/cmake/modules/LLDBConfig.cmake
Modified: lldb/
clayborg added a comment.
Let me know what you think of the UUID code and if you want to include that in
this patch
Comment at: source/Plugins/ObjectFile/Breakpad/BreakpadRecords.cpp:67
+/// to the endian-specific integer N. Return true on success.
+template static bool consu
clayborg requested changes to this revision.
clayborg added inline comments.
This revision now requires changes to proceed.
Comment at: include/lldb/Core/Architecture.h:119-123
+ virtual std::vector
+ ConfigurationRegisterNames() const { return {}; }
+
+ using ConfigurationReg
13 matches
Mail list logo
