[Lldb-commits] [lldb] r353487 - Removing some unimplemented methods from the SB headers

Author: jingham Date: Thu Feb 7 16:34:04 2019 New Revision: 353487 URL: http://llvm.org/viewvc/llvm-project?rev=353487&view=rev Log: Removing some unimplemented methods from the SB headers NFC Modified: lldb/trunk/include/lldb/API/SBCommandInterpreter.h lldb/trunk/include/lldb/API/SBExec

[Lldb-commits] [PATCH] D57895: Breakpad: auto-detect path style of file entries

amccarth added inline comments. Comment at: include/lldb/Utility/FileSpec.h:250 + /// unreliable (e.g. "c:\foo.txt" is a valid relative posix path). + static llvm::Optional

[Lldb-commits] [PATCH] D57928: Fix x86 return pattern detection

mortimer created this revision. mortimer added a reviewer: jasonmolenda. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Replace 0xc9 (LEAVE) with 0xcb (RETF) in ret_pattern_p(). Also put 0xc3 first, since it is the most common form and will match first. Repository: rLL

[Lldb-commits] [lldb] r353472 - [CommandInterpreter] Early return on error (NFC)

Author: jdevlieghere Date: Thu Feb 7 13:51:20 2019 New Revision: 353472 URL: http://llvm.org/viewvc/llvm-project?rev=353472&view=rev Log: [CommandInterpreter] Early return on error (NFC) We save two levels of indentation by returning early if the given file doesn't exists or cannot be opened. M

[Lldb-commits] [lldb] r353468 - Silence fallthrough warnings in debugserver.

Author: adrian Date: Thu Feb 7 13:22:38 2019 New Revision: 353468 URL: http://llvm.org/viewvc/llvm-project?rev=353468&view=rev Log: Silence fallthrough warnings in debugserver. Modified: lldb/trunk/include/lldb/module.modulemap lldb/trunk/tools/debugserver/source/debugserver.cpp Modifie

[Lldb-commits] [lldb] r353447 - Add missing overrides

Author: asmith Date: Thu Feb 7 10:52:22 2019 New Revision: 353447 URL: http://llvm.org/viewvc/llvm-project?rev=353447&view=rev Log: Add missing overrides Modified: lldb/trunk/include/lldb/Host/windows/PipeWindows.h Modified: lldb/trunk/include/lldb/Host/windows/PipeWindows.h URL: http://ll

[Lldb-commits] [lldb] r353446 - [lldb-server] Improve support on Windows

Author: asmith Date: Thu Feb 7 10:46:25 2019 New Revision: 353446 URL: http://llvm.org/viewvc/llvm-project?rev=353446&view=rev Log: [lldb-server] Improve support on Windows Summary: This commit contains the following changes: - Rewrite vfile close/read/write packet handlers with portable rout

[Lldb-commits] [PATCH] D56231: [lldb-server] Improve support on Windows

asmith updated this revision to Diff 185817. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56231/new/ https://reviews.llvm.org/D56231 Files: include/lldb/Host/File.h include/lldb/Host/FileSystem.h source/Host/common/File.cpp source/Host/common/FileSystem.cpp source/Plugins/Proc

[Lldb-commits] [lldb] r353444 - [lldb-instr] Make lldb-instr a test dependency

Author: jdevlieghere Date: Thu Feb 7 10:41:59 2019 New Revision: 353444 URL: http://llvm.org/viewvc/llvm-project?rev=353444&view=rev Log: [lldb-instr] Make lldb-instr a test dependency Modified: lldb/trunk/CMakeLists.txt Modified: lldb/trunk/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-

[Lldb-commits] [PATCH] D57912: [lldb] [unittests] Disable MainLoopTest::DetectsEOF on NetBSD

mgorny created this revision. mgorny added reviewers: labath, krytarowski. Herald added a project: LLDB. mgorny updated this revision to Diff 185815. The NetBSD kernel currently does not support detecting closed slave pty via kevent on master pty. This causes the test to hang forever. To avoid t

[Lldb-commits] [PATCH] D57912: [lldb] [unittests] Disable MainLoopTest::DetectsEOF on NetBSD

mgorny updated this revision to Diff 185815. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57912/new/ https://reviews.llvm.org/D57912 Files: lldb/unittests/Host/MainLoopTest.cpp Index: lldb/unittests/Host/MainLoopTest.cpp ==

[Lldb-commits] [PATCH] D56231: [lldb-server] Improve support on Windows

asmith added a comment. Any other comments on this one? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56231/new/ https://reviews.llvm.org/D56231 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[Lldb-commits] [lldb] r353440 - [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

Author: asmith Date: Thu Feb 7 10:22:00 2019 New Revision: 353440 URL: http://llvm.org/viewvc/llvm-project?rev=353440&view=rev Log: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv Reviewers: zturner, llvm-commits, labath, serge-sans-paille Reviewed By: labath Subscrib

[Lldb-commits] [PATCH] D57689: Adds property to force enabling of GDB JIT loader for MacOS

yurydelendik added a comment. In D57689#1384148 , @jingham wrote: > Could you add a test for this setting to the > ./functionalities/jitloader_gdb/TestJITLoaderGDB.py test? Added tests In D57689#1384894 , @labat

[Lldb-commits] [PATCH] D57689: Adds property to force enabling of GDB JIT loader for MacOS

yurydelendik updated this revision to Diff 185809. yurydelendik added a comment. - Remove enable-jit-breakpoint option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57689/new/ https://reviews.llvm.org/D57689 Files: lldb/packages/Python/lldbsuite

[Lldb-commits] [PATCH] D57689: Adds property to force enabling of GDB JIT loader for MacOS

yurydelendik updated this revision to Diff 185807. yurydelendik added a comment. Herald added a reviewer: serge-sans-paille. - Add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57689/new/ https://reviews.llvm.org/D57689 Files: lldb/package

[Lldb-commits] [PATCH] D57907: lldb: Fix compilation on OpenBSD

mortimer created this revision. mortimer added a reviewer: krytarowski. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Update the OpenBSD Host.cpp for the new SetFile() function signature. Fixes compiling lldb on OpenBSD. Repository: rLLDB LLDB https://reviews.llvm.or

[Lldb-commits] [PATCH] D57895: Breakpad: auto-detect path style of file entries

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57895/new/ https://reviews.llvm.org/D57895 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.or

[Lldb-commits] [PATCH] D56322: [Reproducers] SBReproducer framework

lebedev.ri added a comment. In D56322#1389013 , @labath wrote: > Btw, I've just noticed that the files you've added here still have the old > license header. Would be good to get at least an automatic Herald rule for this I suspect there might be more o

[Lldb-commits] [lldb] r353429 - Fix headers for files added in r353047

Author: labath Date: Thu Feb 7 09:16:25 2019 New Revision: 353429 URL: http://llvm.org/viewvc/llvm-project?rev=353429&view=rev Log: Fix headers for files added in r353047 I started working on that patch before the headers were updated. Since they were new files, I didn't get any conflicts during

[Lldb-commits] [PATCH] D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME

labath added a comment. Herald added a subscriber: llvm-commits. It looks like the files you've added here still have the old headers. Could you please update that? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55122/new/ https://reviews.llvm.org/D55122 __

[Lldb-commits] [PATCH] D56322: [Reproducers] SBReproducer framework

labath added a comment. Btw, I've just noticed that the files you've added here still have the old license header. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56322/new/ https://reviews.llvm.org/D56322 ___ lldb-com

[Lldb-commits] [PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

asmith updated this revision to Diff 185784. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56230/new/ https://reviews.llvm.org/D56230 Files: packages/Python/lldbsuite/test/functionalities/platform/TestPlatformCommand.py packages/Python/lldbsuite/test/settings/quoting/TestQuoting.py

[Lldb-commits] [PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

asmith updated this revision to Diff 185783. Herald added a reviewer: serge-sans-paille. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56230/new/ https://reviews.llvm.org/D56230 Files: packages/Python/lldbsuite/test/functionalities/platform/TestPlatformCommand.py packages/Python/lldb

[Lldb-commits] [lldb] r353420 - Fix signed/unsigned mismatches in ProcessInfoTest.cpp

Author: labath Date: Thu Feb 7 07:56:40 2019 New Revision: 353420 URL: http://llvm.org/viewvc/llvm-project?rev=353420&view=rev Log: Fix signed/unsigned mismatches in ProcessInfoTest.cpp Modified: lldb/trunk/unittests/Host/ProcessInfoTest.cpp Modified: lldb/trunk/unittests/Host/ProcessInfoTe

[Lldb-commits] [lldb] r353419 - Fix incorrect log messages in NativeProcessLinux (pr40588)

Author: labath Date: Thu Feb 7 07:56:35 2019 New Revision: 353419 URL: http://llvm.org/viewvc/llvm-project?rev=353419&view=rev Log: Fix incorrect log messages in NativeProcessLinux (pr40588) The "signal" argument was removed from the MonitorCallback function, but not from the log statements with

[Lldb-commits] [PATCH] D57895: Breakpad: auto-detect path style of file entries

labath created this revision. labath added reviewers: clayborg, lemo, JDevlieghere. Herald added a subscriber: aprantl. This adds support for auto-detection of path style to SymbolFileBreakpad (similar to how r351328 did the same for DWARF). We guess each file entry separately, as we have no idea

[Lldb-commits] [lldb] r353410 - Breakpad: temporarily XFAIL line-table tests

Author: labath Date: Thu Feb 7 06:47:12 2019 New Revision: 353410 URL: http://llvm.org/viewvc/llvm-project?rev=353410&view=rev Log: Breakpad: temporarily XFAIL line-table tests The tests are failing on windows because the paths in the symbol file are parsed using the host path style. I'm working

[Lldb-commits] [lldb] r353406 - use_lldb_suite.py: Fix potential infinite loop

Author: labath Date: Thu Feb 7 06:03:43 2019 New Revision: 353406 URL: http://llvm.org/viewvc/llvm-project?rev=353406&view=rev Log: use_lldb_suite.py: Fix potential infinite loop The loop searching for use_lldb_suite_root had a bug where if the marker file happened to be missing, it would enter

[Lldb-commits] [lldb] r353405 - Fix some warnings introduced in r353324 (ReproducerInstrumentation patch)

Author: labath Date: Thu Feb 7 05:51:38 2019 New Revision: 353405 URL: http://llvm.org/viewvc/llvm-project?rev=353405&view=rev Log: Fix some warnings introduced in r353324 (ReproducerInstrumentation patch) GetIndexForObjectImpl generated a bunch of "conversion casts away constness warnings". Cha

[Lldb-commits] [lldb] r353404 - SymbolFileBreakpad: Add line table support

Author: labath Date: Thu Feb 7 05:42:32 2019 New Revision: 353404 URL: http://llvm.org/viewvc/llvm-project?rev=353404&view=rev Log: SymbolFileBreakpad: Add line table support Summary: This patch teaches SymbolFileBreakpad to parse the line information in breakpad files and present it to lldb. T

[Lldb-commits] [PATCH] D56595: SymbolFileBreakpad: Add line table support

This revision was automatically updated to reflect the committed changes. Closed by commit rL353404: SymbolFileBreakpad: Add line table support (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

[Lldb-commits] [PATCH] D57402: build: remove custom variables

sgraenitz added a comment. > it is pretty reasonable to ask that the user tell us where LLVM and Clang are > built Yes, and `Clang_DIR` should default to the build-/install-tree specified via `LLVM_DIR`. In the vast majority of cases we build against one tree that has both, Clang and LLVM. If

[Lldb-commits] [PATCH] D57880: Add assert for 'bad' code path in GetUniqueNamespaceDeclaration

teemperor created this revision. teemperor added a reviewer: shafik. Herald added subscribers: lldb-commits, abidh. Herald added a project: LLDB. If we call this function with a non-namespace as a second argument (and a nullptr name), we currently only get a nullptr as a return when we hit the "B

[Lldb-commits] [lldb] r353381 - Fix documentation formatting for ShellExpandArguments

Author: teemperor Date: Thu Feb 7 01:47:57 2019 New Revision: 353381 URL: http://llvm.org/viewvc/llvm-project?rev=353381&view=rev Log: Fix documentation formatting for ShellExpandArguments Modified: lldb/trunk/include/lldb/Host/Host.h lldb/trunk/include/lldb/Target/Platform.h Modified: