Re: [Lldb-commits] [lldb] r354424 - [Instrumentation] Make API logging unconditional

On 20/02/2019 02:49, Jonas Devlieghere via lldb-commits wrote: Author: jdevlieghere Date: Tue Feb 19 17:49:13 2019 New Revision: 354424 URL: http://llvm.org/viewvc/llvm-project?rev=354424&view=rev Log: [Instrumentation] Make API logging unconditional We should always log API calls in addition t

[Lldb-commits] [PATCH] D58405: Merge target triple into module triple when constructing module from memory

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Augmenting the architecture with the target information sounds right to me. If we're reading a module from memory, then we already have a running target, and I consider that information more r

[Lldb-commits] [PATCH] D58410: [Reproducers] Initialize reproducers before initializing the debugger.

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/source/API/SBReproducer.cpp:49 +SBError SBReproducer::InitializeCapture(const char *path) { + SBError error; + if (auto e = Reproducer::Initialize(ReproducerMode::Capture, FileSp

[Lldb-commits] [PATCH] D58339: Changes for running LLDB test suite for Swift on PowerPC64LE

sarveshtamba added a comment. Any updates on this one? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58339/new/ https://reviews.llvm.org/D58339 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://list

[Lldb-commits] [lldb] r354425 - [TestModuleCXX] Use UNSUPPORTED instead of REQUIRES

Author: jdevlieghere Date: Tue Feb 19 17:49:16 2019 New Revision: 354425 URL: http://llvm.org/viewvc/llvm-project?rev=354425&view=rev Log: [TestModuleCXX] Use UNSUPPORTED instead of REQUIRES The requires value turns out to be bogus and the test gets skipped on macOS. Modified: lldb/trunk/lit

[Lldb-commits] [lldb] r354424 - [Instrumentation] Make API logging unconditional

Author: jdevlieghere Date: Tue Feb 19 17:49:13 2019 New Revision: 354424 URL: http://llvm.org/viewvc/llvm-project?rev=354424&view=rev Log: [Instrumentation] Make API logging unconditional We should always log API calls in addition to logging whether the call was recorded as part of the reproducer

[Lldb-commits] [lldb] r354423 - [lldb-instr] Group RECORD macros

Author: jdevlieghere Date: Tue Feb 19 17:49:10 2019 New Revision: 354423 URL: http://llvm.org/viewvc/llvm-project?rev=354423&view=rev Log: [lldb-instr] Group RECORD macros Group LLDB_RECORD macros per input file. Modified: lldb/trunk/lit/tools/lldb-instr/TestInstrumentationRegister.test

[Lldb-commits] [lldb] r354418 - Move -fcxx-modules to MANDATORY_MODULE_BUILD_CFLAGS (NFC)

Author: adrian Date: Tue Feb 19 17:14:05 2019 New Revision: 354418 URL: http://llvm.org/viewvc/llvm-project?rev=354418&view=rev Log: Move -fcxx-modules to MANDATORY_MODULE_BUILD_CFLAGS (NFC) Modified: lldb/trunk/packages/Python/lldbsuite/test/make/Makefile.rules Modified: lldb/trunk/packages

[Lldb-commits] [lldb] r354415 - [lldbtest] Remove some accidentally commented out code.

Author: davide Date: Tue Feb 19 16:54:10 2019 New Revision: 354415 URL: http://llvm.org/viewvc/llvm-project?rev=354415&view=rev Log: [lldbtest] Remove some accidentally commented out code. Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py Modified: lldb/trunk/packages/Python/ll

[Lldb-commits] [lldb] r354414 - [testsuite] Fix TestUnicodeString to work with Py2 and Py3.

Author: davide Date: Tue Feb 19 16:54:07 2019 New Revision: 354414 URL: http://llvm.org/viewvc/llvm-project?rev=354414&view=rev Log: [testsuite] Fix TestUnicodeString to work with Py2 and Py3. Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbinline.py Modified: lldb/trunk/packages/Pyt

[Lldb-commits] [PATCH] D58405: Merge target triple into module triple when constructing module from memory

aprantl added a comment. Perhaps a unit test? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58405/new/ https://reviews.llvm.org/D58405 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[Lldb-commits] [PATCH] D58405: Merge target triple into module triple when constructing module from memory

compnerd added a comment. Probably just a replay of GDB protocol packets connected to a testing server would work. But, I don't know if there is infrastructure for that yet. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58405/new/ https://reviews.llvm.org/D58405 ___

[Lldb-commits] [PATCH] D58405: Merge target triple into module triple when constructing module from memory

aprantl added a comment. Can you think of a way to test this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58405/new/ https://reviews.llvm.org/D58405 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[Lldb-commits] [PATCH] D58394: Add --auto-continue to stop-hooks, fix up a few tests

jingham updated this revision to Diff 187465. jingham added a comment. I wasn't using the right %lldb when running the tests. That provides the 'echo-comment-commands false'. Run correctly you don't need the command in the test files. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION htt

[Lldb-commits] [PATCH] D58405: Merge target triple into module triple when constructing module from memory

xiaobai updated this revision to Diff 187460. xiaobai added a comment. Minor change CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58405/new/ https://reviews.llvm.org/D58405 Files: source/Core/Module.cpp Index: source/Core/Module.cpp =

[Lldb-commits] [PATCH] D58405: Merge target triple into module triple when constructing module from memory

xiaobai updated this revision to Diff 187458. xiaobai added a comment. Updating based on feedback from clayborg CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58405/new/ https://reviews.llvm.org/D58405 Files: source/Core/Module.cpp Index: source/Core/Module.cpp =

[Lldb-commits] [lldb] r354400 - [lldb-instr] Don't print REGISTER macro when RECORD is already present

Author: jdevlieghere Date: Tue Feb 19 15:13:29 2019 New Revision: 354400 URL: http://llvm.org/viewvc/llvm-project?rev=354400&view=rev Log: [lldb-instr] Don't print REGISTER macro when RECORD is already present Currently we'd always print the LLDB_REGISTER macro, even if the LLDB_RECORD macro was

[Lldb-commits] [PATCH] D58410: [Reproducers] Initialize reproducers before initializing the debugger.

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/include/lldb/API/SBDebugger.h:48 + + static lldb::SBError InitializeWithErrorHandling(); This should be safe, I don't know anyone relying on this and apparently

[Lldb-commits] [PATCH] D58410: [Reproducers] Initialize reproducers before initializing the debugger.

JDevlieghere created this revision. JDevlieghere added a reviewer: labath. Herald added subscribers: abidh, mgorny. Herald added a project: LLDB. As per the discussion on the mailing list (http://lists.llvm.org/pipermail/lldb-commits/Week-of-Mon-20190218/048007.html) and IRC. Repository: rLL

[Lldb-commits] [PATCH] D58330: 01/03: new SectionPart for Section subranges (for effective .debug_types concatenation)

clayborg added a comment. So I question the need for the SectionPart class. Seems like it would be easier to just add extra args to the ReadSectionData calls? Comments? Comment at: lldb/include/lldb/Symbol/ObjectFile.h:739 // be larger than what Section::GetFileSize reports

[Lldb-commits] [PATCH] D58405: Make educated guess when constructing module from memory

xiaobai marked an inline comment as done. xiaobai added inline comments. Comment at: source/Target/Process.cpp:2639 + ModuleSP module_sp(new Module( + file_spec, GetTarget().GetExecutableModule()->GetArchitecture())); if (module_sp) { clayborg wrote: > S

[Lldb-commits] [PATCH] D58330: 01/03: new SectionPart for Section subranges (for effective .debug_types concatenation)

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Symbol/ObjectFile.h:58 +private: + Section *const m_section; + // It should match: llvm::DWARFUnitIndex::Entry::SectionContribution Should this be a SectionSP? If not, can we use a reference?

[Lldb-commits] [PATCH] D58405: Make educated guess when constructing module from memory

clayborg added inline comments. Comment at: source/Target/Process.cpp:2639 + ModuleSP module_sp(new Module( + file_spec, GetTarget().GetExecutableModule()->GetArchitecture())); if (module_sp) { So if you have a target that is set to "aarch64-linux-androi

[Lldb-commits] [PATCH] D51578: 02/03: Contiguous sections (.debug_info+.debug_types) for D54670==D32167 (.debug_types)

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. Few comments inline. Comment at: lldb/include/lldb/Symbol/ObjectFile.h:781 +friend std::unique_ptr ObjectFile::SectionReaderFactory( + const S

[Lldb-commits] [PATCH] D54670: 03/03: .debug_types: Update of D32167 (.debug_types) on top of D51578 (section concatenation)

JDevlieghere added a comment. Few style nits Comment at: lldb/source/Plugins/SymbolFile/DWARF/DIERef.cpp:44 const DWARFUnit *dwarf_cu = form_value.GetCompileUnit(); if (dwarf_cu) { + // Replace the compile unit with the type signature compile unit ---

[Lldb-commits] [PATCH] D58405: Make educated guess when constructing module from memory

xiaobai marked an inline comment as done. xiaobai added inline comments. Comment at: source/Target/Process.cpp:2638-2639 } - ModuleSP module_sp(new Module(file_spec, ArchSpec())); + ModuleSP module_sp(new Module( + file_spec, GetTarget().GetExecutableModule()->GetArchit

[Lldb-commits] [PATCH] D58405: Make educated guess when constructing module from memory

clayborg added inline comments. Comment at: source/Target/Process.cpp:2638-2639 } - ModuleSP module_sp(new Module(file_spec, ArchSpec())); + ModuleSP module_sp(new Module( + file_spec, GetTarget().GetExecutableModule()->GetArchitecture())); if (module_sp) { -

[Lldb-commits] [PATCH] D58405: Make educated guess when constructing module from memory

xiaobai added a comment. In D58405#1402908 , @aprantl wrote: > > a good guess is the triple that the target executable was compiled for. > > What does this do when the executable has multiple slices, such as a Mach-O > universal binary? Hmm, I hadn't

[Lldb-commits] [PATCH] D58405: Make educated guess when constructing module from memory

aprantl added a comment. > a good guess is the triple that the target executable was compiled for. What does this do when the executable has multiple slices, such as a Mach-O universal binary? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58405/new/ https://reviews.llvm.org/D58405

[Lldb-commits] [PATCH] D58398: Add Facebook Minidump directory streams and options to dump them.

clayborg added a comment. BTW: I did add a - character after the CHECK before I checked it in Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58398/new/ https://reviews.llvm.org/D58398 ___ lldb-commits mailing list lldb

[Lldb-commits] [PATCH] D58398: Add Facebook Minidump directory streams and options to dump them.

This revision was automatically updated to reflect the committed changes. Closed by commit rL354385: Add Facebook Minidump directory streams and options to dump them. (authored by gclayton, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

[Lldb-commits] [lldb] r354385 - Add Facebook Minidump directory streams and options to dump them.

Author: gclayton Date: Tue Feb 19 13:48:34 2019 New Revision: 354385 URL: http://llvm.org/viewvc/llvm-project?rev=354385&view=rev Log: Add Facebook Minidump directory streams and options to dump them. Facebook creates minidump files that contain specific information about why things crash. Addin

[Lldb-commits] [PATCH] D58405: Make educated guess when constructing module from memory

xiaobai created this revision. xiaobai added reviewers: clayborg, zturner, JDevlieghere, compnerd, aprantl, labath. Herald added a subscriber: jdoerfert. While debugging an android process remotely from a windows machine, I noticed that the modules constructed from an object file in memory only h

[Lldb-commits] [PATCH] D54670: 03/03: .debug_types: Update of D32167 (.debug_types) on top of D51578 (section concatenation)

clayborg added a comment. I am definitely ready for this to go in ASAP if we are good on this! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54670/new/ https://reviews.llvm.org/D54670 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D58347: Reinitialize UnwindTable when the SymbolFile changes

jasonmolenda marked an inline comment as done. jasonmolenda added inline comments. Comment at: source/Core/Module.cpp:1451-1454 +// Clear the unwind table too, as that may also be affected by the +// symbol file information. +m_unwind_table.reset(); +

Re: [Lldb-commits] [PATCH] D55038: [Reproducers] Change how reproducers are initialized.

I think we'll need to reconsider this in light of the SBReproducers. The Initialize method causes a bootstrapping problem, where we try to record the Initialize call before the reproducer is initialized. Not recording the initialization call isn't sufficient to solve this and in addition would caus

[Lldb-commits] [PATCH] D58398: Add Facebook Minidump directory streams and options to dump them.

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Would be nice to change the filecheck prefixes to `CHECK-...` to separate the CHECK and the item being checked. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58398/new/ https://r

[Lldb-commits] [PATCH] D58398: Add Facebook Minidump directory streams and options to dump them.

clayborg created this revision. clayborg added reviewers: labath, abdulras, zturner. Facebook creates minidump files that contain specific information about why things crash. Adding ways to dump these allows tools to be made that can auto download symbols based on the information that is contain

[Lldb-commits] [PATCH] D58394: Add --auto-continue to stop-hooks, fix up a few tests

jingham created this revision. jingham added reviewers: labath, jgorbe. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Auto-continuing a stop hook by adding a "continue" command to the hook didn't work very well for multi-threaded programs. The first hook in kept all the

[Lldb-commits] [PATCH] D55653: [lldb-mi] Check raw pointers before passing them to std::string ctor/assignment

sgraenitz added a comment. Good initiative to fix potential nullptr assignments to `std::string`. In D55653#1400513 , @tatyana-krasnukha wrote: > a caller still should examine pointers he passes to CMIUtilString::Format as > the ellipsis parameter. So

[Lldb-commits] [PATCH] D58347: Reinitialize UnwindTable when the SymbolFile changes

clayborg added inline comments. Comment at: source/Core/Module.cpp:1451-1454 +// Clear the unwind table too, as that may also be affected by the +// symbol file information. +m_unwind_table.reset(); + Are we sure no one is holding onto inf

[Lldb-commits] [PATCH] D42870: [lldb] [ObjectFile/ELF] Correct recognition of NetBSD images

labath added a comment. Looks good to me. Thank you for writing the tests. @davide, do you have anything to add here? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D42870/new/ https://reviews.llvm.org/D42870 ___ lldb-commits mailing list ll

[Lldb-commits] [PATCH] D42870: [lldb] [ObjectFile/ELF] Correct recognition of NetBSD images

mgorny updated this revision to Diff 187358. mgorny added a comment. Switched to use shorter identifiers. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D42870/new/ https://reviews.llvm.org/D42870 Files: lldb/lit/Modules/ELF/Inputs/netbsd-amd64.core lldb/lit/Modules/ELF/netbsd-core-a

[Lldb-commits] [lldb] r354324 - Revert "minidump: Add ability to attach (breakpad) symbol files to placeholder modules"

Author: labath Date: Tue Feb 19 05:52:31 2019 New Revision: 354324 URL: http://llvm.org/viewvc/llvm-project?rev=354324&view=rev Log: Revert "minidump: Add ability to attach (breakpad) symbol files to placeholder modules" This reverts r354263, because it uncovered a problem in handling of the min

[Lldb-commits] [PATCH] D42870: [lldb] [ObjectFile/ELF] Correct recognition of NetBSD images

mgorny updated this revision to Diff 187351. mgorny added a comment. Updated to include a non-stripped core. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D42870/new/ https://reviews.llvm.org/D42870 Files: lldb/lit/Modules/ELF/Inputs/netbsd-amd64.core lldb/lit/Modules/ELF/netbsd-cor

[Lldb-commits] [PATCH] D42870: [lldb] [ObjectFile/ELF] Correct recognition of NetBSD images

mgorny updated this revision to Diff 187350. mgorny added a comment. Reduced the test .yaml to the absolute minimum. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D42870/new/ https://reviews.llvm.org/D42870 Files: lldb/lit/Modules/ELF/Inputs/netbsd-amd64.core lldb/lit/Modules/ELF/ne

[Lldb-commits] [lldb] r354308 - Fix vscode tests for python3

Author: labath Date: Tue Feb 19 00:25:25 2019 New Revision: 354308 URL: http://llvm.org/viewvc/llvm-project?rev=354308&view=rev Log: Fix vscode tests for python3 encode/decode the data before sending it over the socket. Since (AFAICT) the vscode protocol (unlike the gdb-remote one) is fully textu

[Lldb-commits] [lldb] r354307 - [gui] Simplify SourceFileWindowDelegate::WindowDelegateDraw

Author: labath Date: Tue Feb 19 00:12:41 2019 New Revision: 354307 URL: http://llvm.org/viewvc/llvm-project?rev=354307&view=rev Log: [gui] Simplify SourceFileWindowDelegate::WindowDelegateDraw instead of printf-ing into a buffer, and them using that buffer as a format string, simply use the appro