[Lldb-commits] [PATCH] D58394: Add --auto-continue to stop-hooks, fix up a few tests

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Ok, LGTM in that case. In terms of the linux decorators, I guess this means that the "unsupported" decorator can be removed on the threaded version of the test, and an "XFAIL" needs to be adde

[Lldb-commits] [PATCH] D58410: [Reproducers] Initialize reproducers before initializing the debugger.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. LGTM. I'd maybe rename InitializeReplay into Replay (i.e., do the merging the other way around), since the `Initialize` part makes me think the replay will not actually commence there. I forg

[Lldb-commits] [PATCH] D58193: Do not explicitly depend on llvm tools during standalone build

serge-sans-paille added a comment. @sgraenitz : it's possible that r352382 fixes my issue. I'll double check that first! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58193/new/ https://reviews.llvm.org/D58193 ___

[Lldb-commits] [lldb] r354540 - Revert "[lldb-mi] Move TestMIPrompt away from pexpect()."

Author: davide Date: Wed Feb 20 17:55:31 2019 New Revision: 354540 URL: http://llvm.org/viewvc/llvm-project?rev=354540&view=rev Log: Revert "[lldb-mi] Move TestMIPrompt away from pexpect()." I see a test failing on the macOS bots. I can't reproduce locally, so try to get the bots green before I c

[Lldb-commits] [lldb] r354526 - Merge target triple into module triple when constructing module from memory

Author: xiaobai Date: Wed Feb 20 15:12:56 2019 New Revision: 354526 URL: http://llvm.org/viewvc/llvm-project?rev=354526&view=rev Log: Merge target triple into module triple when constructing module from memory Summary: While debugging an android process remotely from a windows machine, I noticed

[Lldb-commits] [PATCH] D58405: Merge target triple into module triple when constructing module from memory

This revision was automatically updated to reflect the committed changes. Closed by commit rL354526: Merge target triple into module triple when constructing module from memory (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository:

[Lldb-commits] [PATCH] D58405: Merge target triple into module triple when constructing module from memory

clayborg accepted this revision. clayborg added a comment. Looks good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58405/new/ https://reviews.llvm.org/D58405 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org

[Lldb-commits] [PATCH] D58465: testsuite: Fix TestCompDirSymLink and TestSourceManager on Linux with symlinked build dir

jankratochvil updated this revision to Diff 187666. jankratochvil retitled this revision from "testsuite: Fix TestCompDirSymLink on Linux with symlinked build dir" to "testsuite: Fix TestCompDirSymLink and TestSourceManager on Linux with symlinked build dir". jankratochvil edited the summary of t

[Lldb-commits] [lldb] r354506 - [lldb-mi] Move TestMIPrompt away from pexpect().

Author: davide Date: Wed Feb 20 11:25:12 2019 New Revision: 354506 URL: http://llvm.org/viewvc/llvm-project?rev=354506&view=rev Log: [lldb-mi] Move TestMIPrompt away from pexpect(). Added: lldb/trunk/lit/tools/lldb-mi/breakpoint/break-main.test Removed: lldb/trunk/packages/Python/lldbsuit

[Lldb-commits] [PATCH] D58465: testsuite: Fix TestCompDirSymLink on Linux with symlinked build dir

jankratochvil created this revision. jankratochvil added a project: LLDB. Herald added subscribers: jdoerfert, aprantl. Herald added a reviewer: serge-sans-paille. Getting failure when building in a directory which is symlinked elsewhere: Failing Tests (1): lldb-Suite :: functionalities/

[Lldb-commits] [PATCH] D58394: Add --auto-continue to stop-hooks, fix up a few tests

jingham marked 2 inline comments as done. jingham added a comment. Pavel, I think the new behavior w.r.t. launching is better. When the process plugins are managing events to handle a launch or attach, they really don't want random stop hooks getting in their way. On MacOS, if you set a stop h

[Lldb-commits] [PATCH] D58394: Add --auto-continue to stop-hooks, fix up a few tests

jingham updated this revision to Diff 187616. jingham added a comment. Trying to guess how thread list output is going to look is indeed a losing game. I changed the stop hook to set a global variable in the target, then just print the value at the end. If we ran the stop hook the right number

[Lldb-commits] [PATCH] D58193: Do not explicitly depend on llvm tools during standalone build

sgraenitz accepted this revision. sgraenitz added a subscriber: hans. sgraenitz added a comment. This revision is now accepted and ready to land. @serge-sans-paille After all, it appears to me that your issue is caused by something else, but if this change fixes it, I am not against taking it for

[Lldb-commits] [PATCH] D58459: [lldb-mi] Remove a test that uses pexpect().

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB354494: [lldb-mi] Remove a test that uses pexpect(). (authored by davide, committed by ). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D58459?vs=187604&id=187615#to

[Lldb-commits] [PATCH] D58459: [lldb-mi] Remove a test that uses pexpect().

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58459/new/ https://reviews.llvm.org/D58459 ___ lld

[Lldb-commits] [lldb] r354494 - [lldb-mi] Remove a test that uses pexpect().

Author: davide Date: Wed Feb 20 10:27:29 2019 New Revision: 354494 URL: http://llvm.org/viewvc/llvm-project?rev=354494&view=rev Log: [lldb-mi] Remove a test that uses pexpect(). Summary: Its functionality is entirely covered by exec-run.test (which doesn't use pexpect) Reviewers: serge-sans-pail

[Lldb-commits] [PATCH] D55653: [lldb-mi] Check raw pointers before passing them to std::string ctor/assignment

tatyana-krasnukha updated this revision to Diff 187613. tatyana-krasnukha added a comment. LLDB_PROJECT_ROOT -> LLDB_SOURCE_DIR CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55653/new/ https://reviews.llvm.org/D55653 Files: tools/lldb-mi/MICmdCmdMiscellanous.cpp tools/lldb-mi/MICmn

[Lldb-commits] [PATCH] D55653: [lldb-mi] Check raw pointers before passing them to std::string ctor/assignment

tatyana-krasnukha updated this revision to Diff 187597. tatyana-krasnukha added a comment. Thanks for the review! > So Format() and Printf() don't handle nullptr arguments already? They just forward arguments to `vsprintf`/`vsnprintf`. Otherwise, the would have to do twice the work parsing form

Re: [Lldb-commits] [lldb] r354425 - [TestModuleCXX] Use UNSUPPORTED instead of REQUIRES

Done in r354487. Thanks for the heads up! On Wed, Feb 20, 2019 at 9:41 AM Jonas Devlieghere wrote: > Based on the decorators of the other modules test it looks like this > should be Darwin only. I'll update the test. > > On Wed, Feb 20, 2019 at 9:31 AM Jan Kratochvil > wrote: > >> On Wed, 20 Fe

Re: [Lldb-commits] [lldb] r354466 - [lldb] [ObjectFile/ELF] Fix recognizing NetBSD images

The bot is now green, thanks for your fix! On Wed, Feb 20, 2019 at 9:10 AM Michał Górny wrote: > > On Wed, 2019-02-20 at 08:39 -0800, Davide Italiano wrote: > > This broke the bots, link: > > > > http://green.lab.llvm.org/green/job/lldb-cmake/20047/ > > > > Can you please take a look and see what

[Lldb-commits] [lldb] r354487 - [TestModuleCXX] Make this test Darwin-only.

Author: jdevlieghere Date: Wed Feb 20 09:43:34 2019 New Revision: 354487 URL: http://llvm.org/viewvc/llvm-project?rev=354487&view=rev Log: [TestModuleCXX] Make this test Darwin-only. Apparently this functionality is not expected to work on non-Darwin systems. I should've checked the decorator on

Re: [Lldb-commits] [lldb] r354425 - [TestModuleCXX] Use UNSUPPORTED instead of REQUIRES

Based on the decorators of the other modules test it looks like this should be Darwin only. I'll update the test. On Wed, Feb 20, 2019 at 9:31 AM Jan Kratochvil wrote: > On Wed, 20 Feb 2019 02:49:16 +0100, Jonas Devlieghere via lldb-commits > wrote: > > Author: jdevlieghere > > Date: Tue Feb 19

[Lldb-commits] [PATCH] D58410: [Reproducers] Initialize reproducers before initializing the debugger.

JDevlieghere updated this revision to Diff 187601. JDevlieghere added a comment. - Add comment to SBReproducer.h explaining we cannot use any SB objects in the interface or implementation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58410/new/ https://reviews.llvm.org/D58410 Files:

[Lldb-commits] [PATCH] D58410: [Reproducers] Initialize reproducers before initializing the debugger.

JDevlieghere added a comment. In D58410#1403630 , @labath wrote: > I think this looks mostly fine. See my comment about not using SB classes in > the reproducer api. I still kind of like the idea of naming the reproducer > class in some special way, to m

[Lldb-commits] [PATCH] D58410: [Reproducers] Initialize reproducers before initializing the debugger.

JDevlieghere updated this revision to Diff 187598. JDevlieghere added a comment. - Return a string instead of an SBError - Make InitializeReplay perform the actual replay. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58410/new/ https://reviews.llvm.org/D58410 Files: lldb/include/lld

Re: [Lldb-commits] [lldb] r354425 - [TestModuleCXX] Use UNSUPPORTED instead of REQUIRES

On Wed, 20 Feb 2019 02:49:16 +0100, Jonas Devlieghere via lldb-commits wrote: > Author: jdevlieghere > Date: Tue Feb 19 17:49:16 2019 > New Revision: 354425 ... > --- lldb/trunk/lit/Reproducer/Modules/TestModuleCXX.test (original) > +++ lldb/trunk/lit/Reproducer/Modules/TestModuleCXX.test Tue Feb 1

[Lldb-commits] [PATCH] D42870: [lldb] [ObjectFile/ELF] Correct recognition of NetBSD images

stella.stamenova added a comment. This broke the windows bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/1894 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D42870/new/ https://reviews.llvm.org/D42870 _

Re: [Lldb-commits] [lldb] r354466 - [lldb] [ObjectFile/ELF] Fix recognizing NetBSD images

On Wed, 2019-02-20 at 08:39 -0800, Davide Italiano wrote: > This broke the bots, link: > > http://green.lab.llvm.org/green/job/lldb-cmake/20047/ > > Can you please take a look and see what's needed to fix (and revert > otherwise)? > Thanks for the ping. I've just committed the update for this

[Lldb-commits] [lldb] r354483 - [lldb] [test] Fix expected netbsd output for TestImageListMultiArchitecture

Author: mgorny Date: Wed Feb 20 09:10:34 2019 New Revision: 354483 URL: http://llvm.org/viewvc/llvm-project?rev=354483&view=rev Log: [lldb] [test] Fix expected netbsd output for TestImageListMultiArchitecture Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/object-file/Tes

Re: [Lldb-commits] [lldb] r354466 - [lldb] [ObjectFile/ELF] Fix recognizing NetBSD images

This broke the bots, link: http://green.lab.llvm.org/green/job/lldb-cmake/20047/ Can you please take a look and see what's needed to fix (and revert otherwise)? Thanks On Wed, Feb 20, 2019 at 6:30 AM Michal Gorny via lldb-commits wrote: > > Author: mgorny > Date: Wed Feb 20 06:31:06 2019 > New

[Lldb-commits] [PATCH] D42870: [lldb] [ObjectFile/ELF] Correct recognition of NetBSD images

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB354466: [lldb] [ObjectFile/ELF] Fix recognizing NetBSD images (authored by mgorny, committed by ). Herald added a proje

[Lldb-commits] [lldb] r354466 - [lldb] [ObjectFile/ELF] Fix recognizing NetBSD images

Author: mgorny Date: Wed Feb 20 06:31:06 2019 New Revision: 354466 URL: http://llvm.org/viewvc/llvm-project?rev=354466&view=rev Log: [lldb] [ObjectFile/ELF] Fix recognizing NetBSD images Split the recognition into NetBSD executables & shared libraries and core(5) files. Introduce new owner type:

[Lldb-commits] [PATCH] D54670: 03/03: .debug_types: Update of D32167 (.debug_types) on top of D51578 (section concatenation)

labath added a comment. In D54670#1403670 , @jankratochvil wrote: > In D54670#1403642 , @labath wrote: > > > I am still worried about the divergence from llvm's dwarf reader here. > > > I am still going to investig

[Lldb-commits] [PATCH] D54670: 03/03: .debug_types: Update of D32167 (.debug_types) on top of D51578 (section concatenation)

jankratochvil added a comment. In D54670#1403642 , @labath wrote: > I am still worried about the divergence from llvm's dwarf reader here. I am still going to investigate your `DW_FORM_*` dispatching suggestion .

[Lldb-commits] [PATCH] D58347: Reinitialize UnwindTable when the SymbolFile changes

labath marked 2 inline comments as done. labath added inline comments. Comment at: source/Core/Module.cpp:1451-1454 +// Clear the unwind table too, as that may also be affected by the +// symbol file information. +m_unwind_table.reset(); +

[Lldb-commits] [PATCH] D58398: Add Facebook Minidump directory streams and options to dump them.

labath added a comment. lgtm Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58398/new/ https://reviews.llvm.org/D58398 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[Lldb-commits] [PATCH] D58394: Add --auto-continue to stop-hooks, fix up a few tests

labath added a comment. Thank you for jumping onto this. I've tried the patch out on linux, and the stop-hook-threads.test now passes. However, the basic test now fails for me because the stop hook isn't fired in the "run" command. it is caused by the "is hijacked" check in `ProcessEventData::D

[Lldb-commits] [PATCH] D54670: 03/03: .debug_types: Update of D32167 (.debug_types) on top of D51578 (section concatenation)

labath added a comment. I am still worried about the divergence from llvm's dwarf reader here. We now have a relatively nice Object API, which presents a view of the object file that everybody is used to (i.e., as a bunch of sections). This includes the llvm object and dwarf readers, and the DW

[Lldb-commits] [PATCH] D58410: [Reproducers] Initialize reproducers before initializing the debugger.

labath added a comment. I think this looks mostly fine. See my comment about not using SB classes in the reproducer api. I still kind of like the idea of naming the reproducer class in some special way, to make it more obvious that it is not "just another" SB class, but I'm not sure if that wou