[Lldb-commits] [PATCH] D58394: Add --auto-continue to stop-hooks, fix up a few tests

2019-02-21 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. It seems both `linux` and `system-linux` work. I am not sure what's the difference between the two, but it looks like for other OSs we use the `system-` form, so I'd go with that. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58394/new/

[Lldb-commits] [PATCH] D58394: Add --auto-continue to stop-hooks, fix up a few tests

2019-02-21 Thread Jim Ingham via Phabricator via lldb-commits
jingham updated this revision to Diff 187893. jingham marked an inline comment as done. jingham added a comment. Is this the right way to do it? I don't know why the other was UNSUPPORTED: linux. The only other XFAIL for linux I could see spelled it -linux-? Repository: rLLDB LLDB CHANGES

[Lldb-commits] [lldb] r354639 - Revert "[xcodeproj] Add SBReproducer to LLDB.framework"

2019-02-21 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Thu Feb 21 16:03:59 2019 New Revision: 354639 URL: http://llvm.org/viewvc/llvm-project?rev=354639&view=rev Log: Revert "[xcodeproj] Add SBReproducer to LLDB.framework" This was bogus. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xc

[Lldb-commits] [lldb] r354637 - [xcodeproj] Add SBReproducer to LLDB.framework

2019-02-21 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Thu Feb 21 15:58:36 2019 New Revision: 354637 URL: http://llvm.org/viewvc/llvm-project?rev=354637&view=rev Log: [xcodeproj] Add SBReproducer to LLDB.framework Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj UR

[Lldb-commits] [PATCH] D58410: [Reproducers] Initialize reproducers before initializing the debugger.

2019-02-21 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL354631: [Reproducers] Initialize reproducers before initializing the debugger. (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pri

[Lldb-commits] [lldb] r354631 - [Reproducers] Initialize reproducers before initializing the debugger.

2019-02-21 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Thu Feb 21 14:26:16 2019 New Revision: 354631 URL: http://llvm.org/viewvc/llvm-project?rev=354631&view=rev Log: [Reproducers] Initialize reproducers before initializing the debugger. As per the discussion on the mailing list: http://lists.llvm.org/pipermail/lldb-commits

[Lldb-commits] [PATCH] D58517: [lldb] [test] Do not link -ldl on NetBSD

2019-02-21 Thread Michał Górny via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL354617: [lldb] [test] Do not link -ldl on NetBSD (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

[Lldb-commits] [lldb] r354617 - [lldb] [test] Do not link -ldl on NetBSD

2019-02-21 Thread Michal Gorny via lldb-commits
Author: mgorny Date: Thu Feb 21 12:28:21 2019 New Revision: 354617 URL: http://llvm.org/viewvc/llvm-project?rev=354617&view=rev Log: [lldb] [test] Do not link -ldl on NetBSD Fix the load_* using test Makefiles not to link -ldl on NetBSD. There is no such a library on NetBSD, and dlopen() is avail

[Lldb-commits] [PATCH] D58517: [lldb] [test] Do not link -ldl on NetBSD

2019-02-21 Thread Michał Górny via Phabricator via lldb-commits
mgorny updated this revision to Diff 187826. mgorny edited the summary of this revision. mgorny added a comment. Switched to appending `-ldl` via Makefile.rules, using USE_LIBDL option. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58517/new/ https://reviews.llvm.org/D58517 Files: ll

[Lldb-commits] [PATCH] D58517: [lldb] [test] Do not link -ldl on NetBSD

2019-02-21 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Could you define some variable like DL_LIBS in the main Makefile.rules? Then you could just do `LD_EXTRAS := $(DL_LIBS)` in the tests. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58517/new/ https://reviews.llvm.org/D58517 _

[Lldb-commits] [PATCH] D58517: [lldb] [test] Do not link -ldl on NetBSD

2019-02-21 Thread Michał Górny via Phabricator via lldb-commits
mgorny created this revision. mgorny added reviewers: krytarowski, labath, jasonmolenda, jingham. mgorny added a project: LLDB. Herald added a subscriber: abidh. Fix the load_* using test Makefiles not to link -ldl on NetBSD. There is no such a library on NetBSD, and dlopen() is available without

[Lldb-commits] [lldb] r354602 - [unittest] Fix missing user-provided default constructor

2019-02-21 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Thu Feb 21 09:18:06 2019 New Revision: 354602 URL: http://llvm.org/viewvc/llvm-project?rev=354602&view=rev Log: [unittest] Fix missing user-provided default constructor error: default initialization of an object of const type 'const Pod' without a user-provided default

[Lldb-commits] [PATCH] D58465: testsuite: Fix TestCompDirSymLink and TestSourceManager on Linux with symlinked build dir

2019-02-21 Thread Jan Kratochvil via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB354556: testsuite: Fix TestCompDirSymLink and TestSourceManager on Linux with symlinked… (authored by jankratochvil, committed by ). Changed prior to commit: https://reviews.llvm.org/D58465?vs=18766

[Lldb-commits] [lldb] r354556 - testsuite: Fix TestCompDirSymLink and TestSourceManager on Linux with symlinked build dir

2019-02-21 Thread Jan Kratochvil via lldb-commits
Author: jankratochvil Date: Thu Feb 21 01:05:27 2019 New Revision: 354556 URL: http://llvm.org/viewvc/llvm-project?rev=354556&view=rev Log: testsuite: Fix TestCompDirSymLink and TestSourceManager on Linux with symlinked build dir Getting failure when building in a directory which is symlinked el