[Lldb-commits] [PATCH] D58748: [ExpressionParser] Test GetClangResourceDir

teemperor added inline comments. Comment at: packages/Python/lldbsuite/test/functionalities/paths/TestPaths.py:20 +# GetClangResourceDir doesn't work on windows yet +@expectedFailureAll(oslist=["windows"]) @no_debug_info_test Doesn't that mean that

[Lldb-commits] [PATCH] D47625: [cmake] Detect presence of wide-char libedit at build time

davide added a comment. Herald added a subscriber: jdoerfert. Herald added a project: LLVM. Pavel, this broke unicode handling for lldb on MacOS. If you type something in the lldb cmdline, it won't print the right character but a series of unicode sequences. The main concern is that this also

[Lldb-commits] [lldb] r355063 - Move Symbols.cpp files.

Author: jmolenda Date: Wed Feb 27 17:26:01 2019 New Revision: 355063 URL: http://llvm.org/viewvc/llvm-project?rev=355063=rev Log: Move Symbols.cpp files. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

[Lldb-commits] [lldb] r355055 - [Reprodicuers] Check initialization

Author: jdevlieghere Date: Wed Feb 27 16:49:57 2019 New Revision: 355055 URL: http://llvm.org/viewvc/llvm-project?rev=355055=rev Log: [Reprodicuers] Check initialization If the reproducer is not initialzied, the call to ::Instance() will result in an assertion. Modified:

[Lldb-commits] [PATCH] D58748: [ExpressionParser] Test GetClangResourceDir

xiaobai created this revision. xiaobai added reviewers: zturner, clayborg. Herald added subscribers: jdoerfert, kadircet, ioeric, ilya-biryukov. Herald added a reviewer: serge-sans-paille. I'm doing this because I plan on implementing `ComputeClangDirectory` on windows so that

[Lldb-commits] [lldb] r355042 - Remove unnecessary demangling operation (NFC)

Author: adrian Date: Wed Feb 27 14:54:47 2019 New Revision: 355042 URL: http://llvm.org/viewvc/llvm-project?rev=355042=rev Log: Remove unnecessary demangling operation (NFC) This extra call to the demangler doesn't affect the performance of C++ because the result is being cached anyway; but I'm

[Lldb-commits] [PATCH] D58720: Remove unnecessary demangling operation (hopefully NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rL355042: Remove unnecessary demangling operation (NFC) (authored by adrian, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D58564: [Reproducers] Add command provider

JDevlieghere updated this revision to Diff 188617. JDevlieghere added a comment. Pavel made a good point that with the previous implementation, the first call to RunCommandInterpreter would replay every recorded commands. This is indeed incorrect, because it's possible and likely that the state

[Lldb-commits] [lldb] r355037 - Remove dependency from Host -> Core.

Author: zturner Date: Wed Feb 27 13:53:08 2019 New Revision: 355037 URL: http://llvm.org/viewvc/llvm-project?rev=355037=rev Log: Remove dependency from Host -> Core. I wasn't actually trying to eliminate this one, but looks like it happened as a side effect of moving Symbols out of Host.

[Lldb-commits] [PATCH] D58730: Rename Symbols.cpp from Host to Symbols/LocateSymbolFile.{h, cpp}

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB355032: Move Host/Symbols.cpp to Symbols/LocateSymbolFile.cpp (authored by zturner, committed by ). Herald added subscribers: abidh, krytarowski. Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D58678: Improve step over performance by not stopping at branches that are function calls and stepping into and them out of each one

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Alright, thanks for the explanation. Assuming Jim has no objections this LGTM. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58678/new/

[Lldb-commits] [PATCH] D58730: Rename Symbols.cpp from Host to Symbols/LocateSymbolFile.{h, cpp}

JDevlieghere accepted this revision. JDevlieghere added a comment. Thanks Zachary! This LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58730/new/ https://reviews.llvm.org/D58730 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D58699: Adapt the ObjC checker instrumentation to handle objc_msgSend with struct returns

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB355026: Pass arguments correctly to the objc object checker on arm64 (authored by jingham, committed by ). Changed prior to commit: https://reviews.llvm.org/D58699?vs=188464=188600#toc Repository:

[Lldb-commits] [lldb] r355026 - Pass arguments correctly to the objc object checker on arm64

Author: jingham Date: Wed Feb 27 12:27:25 2019 New Revision: 355026 URL: http://llvm.org/viewvc/llvm-project?rev=355026=rev Log: Pass arguments correctly to the objc object checker on arm64 Traditionally objc had two entry points, objc_msgSend for scalar return methods, and objc_msgSend_stret

[Lldb-commits] [PATCH] D58730: Rename Symbols.cpp from Host to Symbols/LocateSymbolFile.{h, cpp}

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. This seems reasonable to me. Any Host implementation can live off source/Host/common/Symbols.cpp, and only needs to do anything if it wants to augment that behavior. Seen that way, it is

[Lldb-commits] [PATCH] D58699: Adapt the ObjC checker instrumentation to handle objc_msgSend with struct returns

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Sounds good. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58699/new/ https://reviews.llvm.org/D58699 ___

[Lldb-commits] [PATCH] D58730: Rename Symbols.cpp from Host to Symbols/LocateSymbolFile.{h, cpp}

zturner created this revision. zturner added reviewers: labath, JDevlieghere, jingham. Herald added subscribers: jdoerfert, MaskRay, arichardson, mgorny, emaste. Herald added a reviewer: espindola. After this change, there is only 1 remaining dependency in Host to Target. While this change might

[Lldb-commits] [PATCH] D48752: Quiet command regex instructions during batch execution

kastiglione added a comment. @clayborg this has been updated the approach you suggested, adding an `interactive` parameter. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48752/new/ https://reviews.llvm.org/D48752 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D58654: Move Config.h from Host to Utility

zturner added a comment. In D58654#1411084 , @labath wrote: > BTW, what's the reason that you have to have this split now? I understand its > attractiveness from a Zen perspective, but it seems to me that at the end of > the day, it doesn't have that

[Lldb-commits] [PATCH] D58727: https://reviews.llvm.org/D58394 done right

jingham created this revision. jingham added a reviewer: labath. Herald added subscribers: lldb-commits, abidh. Herald added a project: LLDB. I was running the lit tests by hand (since you can't actually run them with the Xcode build) and missed one crucial fact. The lit tests are all run in

[Lldb-commits] [lldb] r355009 - [Reproducer] Make 'reproducer generate' a NOOP during replay.

Author: jdevlieghere Date: Wed Feb 27 09:47:06 2019 New Revision: 355009 URL: http://llvm.org/viewvc/llvm-project?rev=355009=rev Log: [Reproducer] Make 'reproducer generate' a NOOP during replay. Instead of filtering out the 'reproducer generate' command during replay, just make the operation a

[Lldb-commits] [PATCH] D58566: [Reproducers] Add more logging capabilities to reproducer instrumentation

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB355002: [Reproducers] Add more logging to reproducer instrumentation (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D58566?vs=188492=188557#toc

[Lldb-commits] [lldb] r355002 - [Reproducers] Add more logging to reproducer instrumentation

Author: jdevlieghere Date: Wed Feb 27 08:40:08 2019 New Revision: 355002 URL: http://llvm.org/viewvc/llvm-project?rev=355002=rev Log: [Reproducers] Add more logging to reproducer instrumentation Debugging issues with instrumentation capture and replay can be particularly tricky, especially

[Lldb-commits] [PATCH] D58720: Remove unnecessary demangling operation (hopefully NFC)

aprantl created this revision. aprantl added reviewers: sgraenitz, jingham. Herald added a subscriber: erik.pilkington. Herald added a project: LLDB. This extra call to the demangler doesn't affect the performance of C++ because the result is being cached anyway; but I'm working on a patch to

[Lldb-commits] [lldb] r354976 - Remove XFAIL-Linux from two asan tests

Author: labath Date: Wed Feb 27 06:26:48 2019 New Revision: 354976 URL: http://llvm.org/viewvc/llvm-project?rev=354976=rev Log: Remove XFAIL-Linux from two asan tests It turns out these tests actually succeed, if one has a clang with address sanitizer support enabled (i.e., has enabled the

[Lldb-commits] [PATCH] D58350: Insert random blocks of python code with swig instead of modify-python-lldb.py

This revision was automatically updated to reflect the committed changes. Closed by commit rL354975: Insert blocks of python code with swig instead of modify-python-lldb.py (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository:

[Lldb-commits] [lldb] r354975 - Insert blocks of python code with swig instead of modify-python-lldb.py

Author: labath Date: Wed Feb 27 06:16:48 2019 New Revision: 354975 URL: http://llvm.org/viewvc/llvm-project?rev=354975=rev Log: Insert blocks of python code with swig instead of modify-python-lldb.py Summary: Swig is perfectly capable of inserting blocks of python code into its output (and we

[Lldb-commits] [PATCH] D58350: Insert random blocks of python code with swig instead of modify-python-lldb.py

labath marked an inline comment as done. labath added inline comments. Comment at: scripts/lldb.swig:95 + +# == +# The modify-python-lldb.py script is responsible for post-processing this SWIG-

Re: [Lldb-commits] [PATCH] D58653: [Utility] Remove Triple{Environment, OS, Vendor}IsUnspecifiedUnknown from ArchSpec

On 26/02/2019 23:27, Greg Clayton via Phabricator wrote: clayborg added a comment. In D58653#1411285 , @aprantl wrote: @clayborg I recently ran into a similar issue and I think that perhaps adding explicit `llvm::Triple::Any{Vendor|OS|...}`