[Lldb-commits] [lldb] r355661 - Add ASAN llvm build directory variants to

Author: jmolenda Date: Thu Mar 7 20:18:21 2019 New Revision: 355661 URL: http://llvm.org/viewvc/llvm-project?rev=355661=rev Log: Add ASAN llvm build directory variants to get_llvm_bin_dirs(). Modified: lldb/trunk/packages/Python/lldbsuite/test/dotest.py Modified:

[Lldb-commits] [lldb] r355658 - [Reproducers] TestImagineList.test -> TestImageList.test

Author: jdevlieghere Date: Thu Mar 7 16:53:57 2019 New Revision: 355658 URL: http://llvm.org/viewvc/llvm-project?rev=355658=rev Log: [Reproducers] TestImagineList.test -> TestImageList.test And run the actual binary so we load the shared libraries. Added:

[Lldb-commits] [lldb] r355657 - [Reproducers] Mark partial specialization as inline

Author: jdevlieghere Date: Thu Mar 7 16:24:06 2019 New Revision: 355657 URL: http://llvm.org/viewvc/llvm-project?rev=355657=rev Log: [Reproducers] Mark partial specialization as inline The overload and/or template specialization are regular functions and should be marked inline when implemented

[Lldb-commits] [PATCH] D59114: [lldb-vscode] Don't hang indefinitely on invalid program

This revision was automatically updated to reflect the committed changes. Closed by commit rL355656: [lldb-vscode] Report an error if an invalid program is specified. (authored by zturner, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [lldb] r355656 - [lldb-vscode] Report an error if an invalid program is specified.

Author: zturner Date: Thu Mar 7 16:11:27 2019 New Revision: 355656 URL: http://llvm.org/viewvc/llvm-project?rev=355656=rev Log: [lldb-vscode] Report an error if an invalid program is specified. Previously if an invalid program was specified, there was a bug which, when we attempted to launch

[Lldb-commits] [lldb] r355654 - [Reproducers] Use partial template specialization instead of overload

Author: jdevlieghere Date: Thu Mar 7 15:37:46 2019 New Revision: 355654 URL: http://llvm.org/viewvc/llvm-project?rev=355654=rev Log: [Reproducers] Use partial template specialization instead of overload Not sure if this is what's causing MSVC to claim the function to be already defined

[Lldb-commits] [lldb] r355651 - Make bytes_read an unsigned

Author: jdevlieghere Date: Thu Mar 7 14:59:55 2019 New Revision: 355651 URL: http://llvm.org/viewvc/llvm-project?rev=355651=rev Log: Make bytes_read an unsigned Modified: lldb/trunk/tools/lldb-vscode/IOStream.cpp Modified: lldb/trunk/tools/lldb-vscode/IOStream.cpp URL:

[Lldb-commits] [PATCH] D59114: [lldb-vscode] Don't hang indefinitely on invalid program

zturner created this revision. zturner added a reviewer: clayborg. When you configure your launch settings, if you pass a path to an invalid program, we would previously hand indefinitely. This is because a combination of two bugs working together. The first is that we did not attempt to

[Lldb-commits] [lldb] r355650 - Remove unused function

Author: jdevlieghere Date: Thu Mar 7 14:58:39 2019 New Revision: 355650 URL: http://llvm.org/viewvc/llvm-project?rev=355650=rev Log: Remove unused function Modified: lldb/trunk/tools/lldb-vscode/VSCode.cpp Modified: lldb/trunk/tools/lldb-vscode/VSCode.cpp URL:

[Lldb-commits] [PATCH] D59072: [ExpressionParser] Implement ComputeClangResourceDir for Windows

xiaobai added a comment. In D59072#1422059 , @stella.stamenova wrote: > This broke the Windows bot because now one of the TestPaths tests passes on > Windows: > > http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/2394 > > There's also this

[Lldb-commits] [lldb] r355648 - Fix TestPaths.py on windows

Author: xiaobai Date: Thu Mar 7 14:37:23 2019 New Revision: 355648 URL: http://llvm.org/viewvc/llvm-project?rev=355648=rev Log: Fix TestPaths.py on windows I committed an implementation of GetClangResourceDir on windows but forgot to update this test. I merged the tests like I intended to, but

Re: [Lldb-commits] [lldb] r355647 - Add logging to TestQueues.py

 On Thu, Mar 7, 2019 at 2:26 PM Frederic Riss via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: friss > Date: Thu Mar 7 14:28:01 2019 > New Revision: 355647 > > URL: http://llvm.org/viewvc/llvm-project?rev=355647=rev > Log: > Add logging to TestQueues.py > > In an attempt to

[Lldb-commits] [lldb] r355647 - Add logging to TestQueues.py

Author: friss Date: Thu Mar 7 14:28:01 2019 New Revision: 355647 URL: http://llvm.org/viewvc/llvm-project?rev=355647=rev Log: Add logging to TestQueues.py In an attempt to understand why the test is still failing after r35, add some logging. Modified:

[Lldb-commits] [PATCH] D59101: [SBAPI] Log from record macro

JDevlieghere added a comment. In D59101#1422129 , @clayborg wrote: > As long as we are still seeing all argument values, I check the first 10 or > so calls and it looked like this was the case, then I am good with this. Correct, the macros forward the

[Lldb-commits] [PATCH] D59101: [SBAPI] Log from record macro

clayborg added a comment. As long as we are still seeing all argument values, I check the first 10 or so calls and it looked like this was the case, then I am good with this. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59101/new/

[Lldb-commits] [lldb] r355644 - Fix TestAppleSimulatorOSType.py with Xcode 10.2

Author: friss Date: Thu Mar 7 14:12:03 2019 New Revision: 355644 URL: http://llvm.org/viewvc/llvm-project?rev=355644=rev Log: Fix TestAppleSimulatorOSType.py with Xcode 10.2 It looks like the simctl tool shipped in Xcode10.2 changed the format of its json output. Modified:

[Lldb-commits] [lldb] r355640 - [testsuite] Recommit the TestTerminal directory.

Author: davide Date: Thu Mar 7 13:33:43 2019 New Revision: 355640 URL: http://llvm.org/viewvc/llvm-project?rev=355640=rev Log: [testsuite] Recommit the TestTerminal directory. Turns out this is actually testing that editline doesn't screw up the terminal. Added:

[Lldb-commits] [PATCH] D59072: [ExpressionParser] Implement ComputeClangResourceDir for Windows

stella.stamenova added a comment. This broke the Windows bot because now one of the TestPaths tests passes on Windows: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/2394 There's also this comment in the test file: 1. TODO: Merge into test_path when GetClangResourceDir is

[Lldb-commits] [PATCH] D59104: [lldb-vscode] Make server mode work on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL355637: [lldb-vscode] Support running in server mode on Windows. (authored by zturner, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r355637 - [lldb-vscode] Support running in server mode on Windows.

Author: zturner Date: Thu Mar 7 13:23:21 2019 New Revision: 355637 URL: http://llvm.org/viewvc/llvm-project?rev=355637=rev Log: [lldb-vscode] Support running in server mode on Windows. Windows can't use standard i/o system calls such as read and write to work with sockets, it instead needs to

[Lldb-commits] [PATCH] D47062: Suggest lldb-dotest to reproduce a failure.

JDevlieghere abandoned this revision. JDevlieghere added a comment. Herald added a reviewer: serge-sans-paille. Herald added a subscriber: jdoerfert. Abandoning this until we can replace the dotest driver with lit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47062/new/

[Lldb-commits] [PATCH] D59102: Add an LLVM-style dump method to CompilerType for extra convenience during debugging

This revision was automatically updated to reflect the committed changes. Closed by commit rL355632: Add an LLVM-style dump method to CompilerType for extra convenience during… (authored by adrian, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[Lldb-commits] [lldb] r355632 - Add an LLVM-style dump method to CompilerType for extra convenience during debugging

Author: adrian Date: Thu Mar 7 12:20:02 2019 New Revision: 355632 URL: http://llvm.org/viewvc/llvm-project?rev=355632=rev Log: Add an LLVM-style dump method to CompilerType for extra convenience during debugging This change has no effect on Release (NoAsserts) builds. Differential Revision:

[Lldb-commits] [PATCH] D59072: [ExpressionParser] Implement ComputeClangResourceDir for Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL355631: [ExpressionParser] Implement ComputeClangResourceDir for Windows (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [lldb] r355631 - [ExpressionParser] Implement ComputeClangResourceDir for Windows

Author: xiaobai Date: Thu Mar 7 12:09:15 2019 New Revision: 355631 URL: http://llvm.org/viewvc/llvm-project?rev=355631=rev Log: [ExpressionParser] Implement ComputeClangResourceDir for Windows Summary: This function is useful for expression evaluation, especially when doing swift debugging on

[Lldb-commits] [PATCH] D59004: [lldb] Fix DW_OP_addrx uses.

This revision was automatically updated to reflect the committed changes. Closed by commit rL355629: [lldb] Fix DW_OP_addrx uses. (authored by tamur, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D59104: [lldb-vscode] Make server mode work on Windows

zturner created this revision. zturner added a reviewer: clayborg. Herald added a subscriber: mgorny. For historical reasons, Windows unfortunately doesn't support using sockets in standard system calls like read/write, which means that they also can't be buffered with a `FILE*`. This violates

[Lldb-commits] [PATCH] D59102: Add an LLVM-style dump method to CompilerType for extra convenience during debugging

davide added a comment. We should also add it to `SwiftASTContext` downstream. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59102/new/ https://reviews.llvm.org/D59102 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D59102: Add an LLVM-style dump method to CompilerType for extra convenience during debugging

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. This will save me characters typing, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59102/new/ https://reviews.llvm.org/D59102

[Lldb-commits] [PATCH] D59102: Add an LLVM-style dump method to CompilerType for extra convenience during debugging

aprantl created this revision. aprantl added a reviewer: davide. Herald added a subscriber: jdoerfert. Herald added a project: LLDB. I find myself extracting m_type and and casting it to call dump() on the raw AST type several times per day, so why not make this a little more convenient!

[Lldb-commits] [lldb] r355615 - [testsuite] Spring cleaning: this tests `stty`, not `lldb`.

Author: davide Date: Thu Mar 7 10:05:18 2019 New Revision: 355615 URL: http://llvm.org/viewvc/llvm-project?rev=355615=rev Log: [testsuite] Spring cleaning: this tests `stty`, not `lldb`. Removed: lldb/trunk/packages/Python/lldbsuite/test/terminal/

[Lldb-commits] [lldb] r355612 - [testsuite] Drop characters that can't be decoded, restoring parity with Py2.

Author: davide Date: Thu Mar 7 09:45:53 2019 New Revision: 355612 URL: http://llvm.org/viewvc/llvm-project?rev=355612=rev Log: [testsuite] Drop characters that can't be decoded, restoring parity with Py2. Tests that check the output of `memory find` may trip over unreadable characters, and in

[Lldb-commits] [PATCH] D59088: Fix TestDataFormatter.test uninitialized variable

This revision was automatically updated to reflect the committed changes. Closed by commit rL355611: Fix TestDataFormatter.test uninitialized variable (authored by jankratochvil, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r355611 - Fix TestDataFormatter.test uninitialized variable

Author: jankratochvil Date: Thu Mar 7 09:35:47 2019 New Revision: 355611 URL: http://llvm.org/viewvc/llvm-project?rev=355611=rev Log: Fix TestDataFormatter.test uninitialized variable After D55626 I see a failure in my Fedora buildbot. There is uninitialized variable as the Foo constructor has

[Lldb-commits] [PATCH] D59088: Fix TestDataFormatter.test uninitialized variable

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thank you! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59088/new/ https://reviews.llvm.org/D59088

[Lldb-commits] [lldb] r355610 - [Reproducers] Disable registering lldb::thread_t everywhere

Author: jdevlieghere Date: Thu Mar 7 09:27:33 2019 New Revision: 355610 URL: http://llvm.org/viewvc/llvm-project?rev=355610=rev Log: [Reproducers] Disable registering lldb::thread_t everywhere As discussed on the mailing list, default serialization for thread ids is not correct, even if they're

Re: [Lldb-commits] [PATCH] D57475: [Reproducers] Add SBReproducer macros

Yes, I think that makes sense. I'll remove the register macro for now, which initializes the types. The record macro I'll leave in place to ensure the toggling between boundaries doesn't get affected by this. The "nice" side effect is that it will trigger an assertion during replay, which

[Lldb-commits] [PATCH] D58930: Add XCOFF triple object format type for AIX

jasonliu updated this revision to Diff 189713. jasonliu added a comment. Share the same "unsupported error" message with WASM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58930/new/ https://reviews.llvm.org/D58930 Files:

[Lldb-commits] [PATCH] D55626: [Reproducers] Add tests for functionality

jankratochvil added a comment. There is also failing `TestImagineList` on my Fedora buildbot : ++ : 'RUN: at line 19' ++ cat

[Lldb-commits] [PATCH] D59088: Fix TestDataFormatter.test uninitialized variable

jankratochvil created this revision. jankratochvil added a reviewer: JDevlieghere. jankratochvil added a project: LLDB. Herald added subscribers: teemperor, jfb. After D55626 I see a failure in my Fedora buildbot

[Lldb-commits] [PATCH] D32149: [lldb] [Process] Add proper support for NetBSD core files with threads

krytarowski added a comment. Looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32149/new/ https://reviews.llvm.org/D32149 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D57475: [Reproducers] Add SBReproducer macros

labath added a comment. Jonas, would it be possible to just not intercept the functions which work with thread IDs and similar stuff (an all OSs)? Using the naive serialization approach will not be correct for these, even if the types happen to be implemented as primitive types (most likely we

[Lldb-commits] [PATCH] D59004: [lldb] Fix DW_OP_addrx uses.

labath added a comment. Thank you. The test looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59004/new/ https://reviews.llvm.org/D59004 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D58962: Sanity check --max-gdbserver-port

labath added a comment. In D58962#1420529 , @jankratochvil wrote: > In D58962#1420137 , @JDevlieghere > wrote: > > > There's a tools folder (`lit/tools`) where this would fit. It's lowercase, > > possibly to

[Lldb-commits] [PATCH] D59072: [ExpressionParser] Implement ComputeClangResourceDir for Windows

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59072/new/ https://reviews.llvm.org/D59072 ___

[Lldb-commits] [PATCH] D32149: [lldb] [Process] Add proper support for NetBSD core files with threads

mgorny updated this revision to Diff 189658. mgorny edited the summary of this revision. mgorny added a comment. I've added one more test case, and added stop reason/signal checking for both threads. I think it's ready for review now. CHANGES SINCE LAST ACTION