[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

2019-03-24 Thread Robert O'Callahan via Phabricator via lldb-commits
rocallahan added a comment. Another clarification: > DWARF type information currently shared between functions in the same CU > would have to be duplicated. I guess that's not necessary. The compiler could put all debuginfo that's shared between functions into a non-COMDAT section for the comp

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

2019-03-24 Thread Robert O'Callahan via Phabricator via lldb-commits
rocallahan added a comment. To be clear, I think the best long-term solution is for LLD to rewrite the DWARF, but from my (admittedly limited) perspective that seems to be at best a distant prospect. Repository: rLLD LLVM Linker CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54747/ne

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

2019-03-24 Thread Robert O'Callahan via Phabricator via lldb-commits
rocallahan added a comment. > Do you have numbers with ld.bfd and gold? I don't have numbers for that exact test with those linkers but they basically behave the same way as LLD. Repository: rLLD LLVM Linker CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54747/new/ https://reviews.l

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

2019-03-24 Thread Robert O'Callahan via Phabricator via lldb-commits
rocallahan marked 3 inline comments as done. rocallahan added a comment. > @rocallahan I find that people are discussing a generic approach in D59553 > Thanks for the reference. It seems to me that there is no consensus there yet for any approach that would obs

[Lldb-commits] [PATCH] D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior.

2019-03-24 Thread Aleksei Sidorin via Phabricator via lldb-commits
a_sidorin added a comment. Hello Raphael, Thank you for the explanation. I have +1 to Gabor's question to understand if this functionality can actually be added to the common ASTImporter. Comment at: clang/include/clang/AST/ASTImporter.h:149 +/// decl on its own. +vir