[Lldb-commits] [lldb] r356971 - [Python] Define empty SWIG wrapper for unit testin"

Author: jdevlieghere Date: Mon Mar 25 18:11:15 2019 New Revision: 356971 URL: http://llvm.org/viewvc/llvm-project?rev=356971=rev Log: [Python] Define empty SWIG wrapper for unit testin" The python plugin uses wrappers generated by swig. For the symbols to be available, we'd need to link against

[Lldb-commits] [PATCH] D59719: [ScriptInterpreter] Make sure that PYTHONHOME is right.

davide added a comment. In D59719#1441254 , @labath wrote: > It sounds to me like you could achieve the same thing by generalizing the > LLDB_PYTHON_HOME logic in LLDBConfig.cmake. This would have the advantage of > centralizing the way we manage

[Lldb-commits] [PATCH] D59719: [ScriptInterpreter] Make sure that PYTHONHOME is right.

davide added a comment. In D59719#1441254 , @labath wrote: > It sounds to me like you could achieve the same thing by generalizing the > LLDB_PYTHON_HOME logic in LLDBConfig.cmake. This would have the advantage of > centralizing the way we manage

[Lldb-commits] [PATCH] D59719: [ScriptInterpreter] Make sure that PYTHONHOME is right.

davide added a comment. In D59719#1442181 , @ted wrote: > This doesn't look correct to me - it looks like there are 1 too many #endifs. > I think the one at line 179 should be removed - it should have been replaced > by the #else that is at line 180.

[Lldb-commits] [PATCH] D59708: [ExpressionParser] Add swift-lldb case for finding clang resource dir

jingham accepted this revision. jingham added a comment. Except for a typo and a little quibble about a comment, this looks okay to me. Comment at: source/Plugins/ExpressionParser/Clang/ClangHost.cpp:42 /// This will compute the clang resource directory assuming that clang

[Lldb-commits] [lldb] r356967 - [Python] Move SWIG wrapper dependency into the plugin

Author: jdevlieghere Date: Mon Mar 25 16:36:12 2019 New Revision: 356967 URL: http://llvm.org/viewvc/llvm-project?rev=356967=rev Log: [Python] Move SWIG wrapper dependency into the plugin This should fix the Windows bot (fingers crossed). Modified: lldb/trunk/source/API/CMakeLists.txt

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

ruiu added a comment. I committed https://reviews.llvm.org/D59800 which I believe makes your change easier to follow once rebased. Could you rebase it and upload a patch? Thanks! Repository: rLLD LLVM Linker CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54747/new/

[Lldb-commits] [lldb] r356960 - [lldb] [Process/NetBSD] Use nullptr to fix template arg deduction

Author: mgorny Date: Mon Mar 25 15:29:29 2019 New Revision: 356960 URL: http://llvm.org/viewvc/llvm-project?rev=356960=rev Log: [lldb] [Process/NetBSD] Use nullptr to fix template arg deduction Modified: lldb/trunk/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp Modified:

[Lldb-commits] [PATCH] D59708: [ExpressionParser] Add swift-lldb case for finding clang resource dir

xiaobai updated this revision to Diff 192204. xiaobai added a comment. Added comment about verify CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59708/new/ https://reviews.llvm.org/D59708 Files: source/Plugins/ExpressionParser/Clang/ClangHost.cpp

[Lldb-commits] [lldb] r356950 - [PythonTestSuite] Fix usage of InitializePrivate in PythonTestSuite

Author: jdevlieghere Date: Mon Mar 25 14:07:53 2019 New Revision: 356950 URL: http://llvm.org/viewvc/llvm-project?rev=356950=rev Log: [PythonTestSuite] Fix usage of InitializePrivate in PythonTestSuite Modified: lldb/trunk/unittests/ScriptInterpreter/Python/PythonTestSuite.cpp Modified:

[Lldb-commits] [lldb] r356944 - [ScriptInterpreterPython] Make SWIG callback private (NFC)

Author: jdevlieghere Date: Mon Mar 25 13:39:08 2019 New Revision: 356944 URL: http://llvm.org/viewvc/llvm-project?rev=356944=rev Log: [ScriptInterpreterPython] Make SWIG callback private (NFC) With the initialization taking place inside the Python script interpreter, these function no longer

[Lldb-commits] [PATCH] D59708: [ExpressionParser] Add swift-lldb case for finding clang resource dir

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Please add a comment about `verify` being only for tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59708/new/ https://reviews.llvm.org/D59708

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

ruiu added inline comments. Comment at: lld/ELF/MarkLive.cpp:192 + Sec->Live = true; + if (Sec->kind() != SectionBase::Kind::Regular && + Sec->kind() != SectionBase::Kind::Merge) rocallahan wrote: > ruiu wrote: > > rocallahan wrote: > > > MaskRay wrote: >

[Lldb-commits] [PATCH] D59719: [ScriptInterpreter] Make sure that PYTHONHOME is right.

ted added a comment. This doesn't look correct to me - it looks like there are 1 too many #endifs. I think the one at line 179 should be removed - it should have been replaced by the #else that is at line 180. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] r356942 - [ScriptInterpreterPython] Move SWIG initialization into the Python plugin (NFC)

Author: jdevlieghere Date: Mon Mar 25 13:14:31 2019 New Revision: 356942 URL: http://llvm.org/viewvc/llvm-project?rev=356942=rev Log: [ScriptInterpreterPython] Move SWIG initialization into the Python plugin (NFC) Abstract initialization of the Python SWIG support in the Python plugin.

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

rocallahan marked 2 inline comments as done. rocallahan added inline comments. Comment at: lld/ELF/MarkLive.cpp:190 +template static void setSectionLive(InputSectionBase *Sec) { + Sec->Live = true; ruiu wrote: > Since this file is MarkLive, markSection is

[Lldb-commits] [PATCH] D59708: [ExpressionParser] Add swift-lldb case for finding clang resource dir

xiaobai added a comment. I changed the default behavior here setting file_spec to some known default unverified value to not setting it at all. It previously relied on there being a relative path to the clang resource dir, of which there are now two to pick from. Additionally, we pass in the

[Lldb-commits] [PATCH] D59708: [ExpressionParser] Add swift-lldb case for finding clang resource dir

xiaobai updated this revision to Diff 192185. xiaobai added a comment. Herald added a subscriber: jdoerfert. - Respect LIBDIR for swift-lldb case - Loop over a list of known directory suffixes - Change default behavior to not set file_spec and return false upon failure. CHANGES SINCE LAST

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

ruiu added inline comments. Comment at: lld/ELF/MarkLive.cpp:190 +template static void setSectionLive(InputSectionBase *Sec) { + Sec->Live = true; Since this file is MarkLive, markSection is perhaps a better name. Comment at:

[Lldb-commits] [PATCH] D59708: [ExpressionParser] Add swift-lldb case for finding clang resource dir

xiaobai added a comment. In D59708#1439872 , @jingham wrote: > The behavior when verify is false seems a little weird to me. In that case > you will just always get the $install_dir/lib/clang/$clang_version path. > That's fairly different from the

[Lldb-commits] [PATCH] D59779: [Args] Handle backticks

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB356927: [Args] Handle backticks to prevent crash. (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D59779?vs=192131=192139#toc Repository: rLLDB LLDB

[Lldb-commits] [lldb] r356927 - [Args] Handle backticks to prevent crash.

Author: jdevlieghere Date: Mon Mar 25 10:27:14 2019 New Revision: 356927 URL: http://llvm.org/viewvc/llvm-project?rev=356927=rev Log: [Args] Handle backticks to prevent crash. Currently LLDB crashes when autocompleting a command that ends with a backtick because the quote character wasn't

[Lldb-commits] [PATCH] D59779: [Args] Handle backticks

JDevlieghere added a comment. In D59779#1441705 , @labath wrote: > Given the current way lldb command interpreter parser does things (which > tries to model a posix shell), (one of) the correct ways to do `'`-quoting > would be to replace each `'` char

[Lldb-commits] [PATCH] D59779: [Args] Handle backticks

labath added a comment. Given the current way lldb command interpreter parser does things (which tries to model a posix shell), (one of) the correct ways to do `'`-quoting would be to replace each `'` char by `'\''`. However, this isn't the only problem with how we do tab-completion of quoted

[Lldb-commits] [PATCH] D59779: [Args] Handle backticks

JDevlieghere created this revision. JDevlieghere added reviewers: labath, zturner, davide. Herald added a subscriber: jdoerfert. Herald added a project: LLDB. Currently LLDB crashes when autocompleting a command that ends with a backtick. ./bin/lldb test.tmp.out (lldb) target create

[Lldb-commits] [PATCH] D59775: Minidump: Add support for reading/writing strings

labath created this revision. labath added reviewers: jhenderson, zturner, clayborg. Herald added a project: LLVM. labath added a parent revision: D59634: Add minidump support to obj2yaml. Strings in minidump files are stored as a 32-bit length field, giving the length of the string in *bytes*,

[Lldb-commits] [PATCH] D59681: Update the lldb driver to support the -O and -S options when passing --repl

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB356911: Update the lldb driver to support the -O and -S options when passing --repl (authored by adrian, committed by ). Changed prior to commit: https://reviews.llvm.org/D59681?vs=191904=192116#toc

[Lldb-commits] [lldb] r356911 - Update the lldb driver to support the -O and -S options when passing --repl

Author: adrian Date: Mon Mar 25 08:38:18 2019 New Revision: 356911 URL: http://llvm.org/viewvc/llvm-project?rev=356911=rev Log: Update the lldb driver to support the -O and -S options when passing --repl At the moment when --repl is passed to lldb it silently ignores any commands passed via the

[Lldb-commits] [PATCH] D59582: Python 2/3 compat: StringIO

This revision was automatically updated to reflect the committed changes. Closed by commit rL356910: Python 2/3 compat: StringIO (authored by serge_sans_paille, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D59586: Python 2/3 compat: tkinter

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB356909: Python 2/3 compat: tkinter (authored by serge_sans_paille, committed by ). Changed prior to commit: https://reviews.llvm.org/D59586?vs=191448=192113#toc Repository: rLLDB LLDB CHANGES

[Lldb-commits] [PATCH] D59589: Python 2/3 compat: str vs basestring

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB356908: Python 2/3 compat: str vs basestring (authored by serge_sans_paille, committed by ). Changed prior to commit: https://reviews.llvm.org/D59589?vs=191453=192112#toc Repository: rLLDB LLDB

[Lldb-commits] [PATCH] D59591: Python 2/3 compat: unichr vs chr

serge-sans-paille closed this revision. serge-sans-paille added a comment. Closed by https://reviews.llvm.org/rL356904 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59591/new/ https://reviews.llvm.org/D59591 ___

[Lldb-commits] [PATCH] D59590: Python 2/3 compat: queue vs Queue

This revision was automatically updated to reflect the committed changes. Closed by commit rL356905: Python 2/3 compat: queue vs Queue (authored by serge_sans_paille, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D59589: Python 2/3 compat: str vs basestring

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59589/new/ https://reviews.llvm.org/D59589 ___

[Lldb-commits] [lldb] r356898 - Minidump: Use minidump constants defined in llvm

Author: labath Date: Mon Mar 25 07:09:27 2019 New Revision: 356898 URL: http://llvm.org/viewvc/llvm-project?rev=356898=rev Log: Minidump: Use minidump constants defined in llvm This patch begins the process of migrating the "minidump" plugin to the minidump parser in llvm. The llvm parser is not

[Lldb-commits] [lldb] r356896 - Reapply minidump changes reverted in r356806

Author: labath Date: Mon Mar 25 07:02:16 2019 New Revision: 356896 URL: http://llvm.org/viewvc/llvm-project?rev=356896=rev Log: Reapply minidump changes reverted in r356806 The changes were reverted due to ubsan errors (unaligned accesses). Here I fix those errors by first copying the data into

[Lldb-commits] [PATCH] D59537: Instantiate 'std' templates explicitly in the expression evaluator

martong added inline comments. Comment at: lldb/source/Symbol/StdModuleHandler.cpp:242 +// Instantiate the template. +found_decl = ClassTemplateSpecializationDecl::Create( +m_sema->getASTContext(), martong wrote: > Is there any guarantee that the

[Lldb-commits] [PATCH] D59537: Instantiate 'std' templates explicitly in the expression evaluator

martong added inline comments. Comment at: lldb/source/Symbol/StdModuleHandler.cpp:242 +// Instantiate the template. +found_decl = ClassTemplateSpecializationDecl::Create( +m_sema->getASTContext(), Is there any guarantee that the before any

[Lldb-commits] [PATCH] D59582: Python 2/3 compat: StringIO

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I have a feeling most of these files should be just deleted, but since you went through the trouble of creating this patch, I see no reason why to not accept it. Repository: rLLDB LLDB

[Lldb-commits] [PATCH] D59586: Python 2/3 compat: tkinter

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. LGTM, although this is looks like another piece of unmaintained code. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59586/new/

[Lldb-commits] [PATCH] D59590: Python 2/3 compat: queue vs Queue

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. It looks like this code hasn't been touched since 2013, so who knows if it even works. But fixing this should be fine anyway. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D59719: [ScriptInterpreter] Make sure that PYTHONHOME is right.

labath added a comment. It sounds to me like you could achieve the same thing by generalizing the LLDB_PYTHON_HOME logic in LLDBConfig.cmake. This would have the advantage of centralizing the way we manage python-finding logic (instead of each OS doing it's own thing) and also enable those

[Lldb-commits] [PATCH] D59015: [lldb-mi] Include full path in the -data-disassemble response

abidh accepted this revision. abidh added a comment. This revision is now accepted and ready to land. Looks ok but I would like a testcase to go with the change. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59015/new/ https://reviews.llvm.org/D59015

[Lldb-commits] [lldb] r356876 - Fix a broken comment line. NFC.

Author: abidh Date: Mon Mar 25 02:41:49 2019 New Revision: 356876 URL: http://llvm.org/viewvc/llvm-project?rev=356876=rev Log: Fix a broken comment line. NFC. Just checking that commit access is working after licensing changes. Modified: lldb/trunk/tools/lldb-mi/MICmdCmdMiscellanous.cpp