[Lldb-commits] [PATCH] D60022: [Process] Fix WriteMemory return value

JDevlieghere added a comment. Thanks Ismail, the patch LGTM, assuming I understand the code correctly. FWIW I think this function is a good example of how early returns might prevent something like this from happening in the future. If you agree and have the bandwidth, feel free to refactor it,

[Lldb-commits] [PATCH] D60022: [Process] Fix WriteMemory return value

mib updated this revision to Diff 192954. mib added a comment. Remove TraceOn and XMLSupport Check CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60022/new/ https://reviews.llvm.org/D60022 Files: packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestWriteMemory.py so

[Lldb-commits] [PATCH] D60022: [Process] Fix WriteMemory return value

JDevlieghere added inline comments. Comment at: packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestWriteMemory.py:10 + +@skipIfXmlSupportMissing +def test(self): Why does this test depend on XML support? Repository: rLLDB LLDB CHAN

[Lldb-commits] [PATCH] D60022: [Process] Fix WriteMemory return value

davide added inline comments. Comment at: packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestWriteMemory.py:19-20 +target = self.dbg.CreateTarget('') +if self.TraceOn(): +self.runCmd("log enable gdb-remote packets") +process

[Lldb-commits] [PATCH] D60001: Allow partial UUID matching in Minidump core file plug-in

clayborg marked 2 inline comments as done. clayborg added inline comments. Comment at: source/Plugins/Process/minidump/ProcessMinidump.cpp:394 +if (error.Fail()) { + GetTarget().GetImages().Remove(module_sp); + module_sp.reset(); labath wrote: > Und

[Lldb-commits] [lldb] r357313 - [ScriptInterpreterPython] Fix the unit test after refactor

Author: jdevlieghere Date: Fri Mar 29 13:56:52 2019 New Revision: 357313 URL: http://llvm.org/viewvc/llvm-project?rev=357313&view=rev Log: [ScriptInterpreterPython] Fix the unit test after refactor Modified: lldb/trunk/unittests/ScriptInterpreter/Python/PythonTestSuite.cpp Modified: lldb/tru

[Lldb-commits] [PATCH] D59976: [Python] Remove Python include from ScriptInterpreterPython.h

This revision was automatically updated to reflect the committed changes. Closed by commit rL357307: [Python] Remove Python include from ScriptInterpreterPython.h (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

[Lldb-commits] [lldb] r357307 - [Python] Remove Python include from ScriptInterpreterPython.h

Author: jdevlieghere Date: Fri Mar 29 13:17:20 2019 New Revision: 357307 URL: http://llvm.org/viewvc/llvm-project?rev=357307&view=rev Log: [Python] Remove Python include from ScriptInterpreterPython.h This patch limits the scope of the python header to the implementation of the python script inte

[Lldb-commits] [PATCH] D59976: [Python] Remove Python include from ScriptInterpreterPython.h

JDevlieghere marked an inline comment as done. JDevlieghere added a comment. Thanks for the review, Pavel! Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:1229-1230 + Locker locker(this, +ScriptInterpreterPythonImpl::Locker

[Lldb-commits] [PATCH] D59976: [Python] Remove Python include from ScriptInterpreterPython.h

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:1229-1230 + Locker locker(this, +ScriptInterpreterPythonImpl::Locke

[Lldb-commits] [PATCH] D60001: Allow partial UUID matching in Minidump core file plug-in

labath added a reviewer: markmentovai. labath added a comment. +mark, in case he has any thoughts about this. It's unfortunate that we need to add workarounds like this, but it seems that's what the situation is. Comment at: packages/Python/lldbsuite/test/functionalities/post

[Lldb-commits] [PATCH] D59976: [Python] Remove Python include from ScriptInterpreterPython.h

JDevlieghere updated this revision to Diff 192892. JDevlieghere added a comment. Herald added a subscriber: jdoerfert. Make ScriptInterpreterPython abstract. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59976/new/ https://reviews.llvm.org/D59976 Files: lldb/source/API/SBHostOS.cpp

[Lldb-commits] [PATCH] D60001: Allow partial UUID matching in Minidump core file plug-in

clayborg created this revision. clayborg added reviewers: labath, zturner. Herald added a subscriber: javed.absar. Breakpad had bugs in earlier versions where it would take a 20 byte ELF build ID and put it into the minidump file as a 16 byte PDB70 UUID with an age of zero. This would make it im

[Lldb-commits] [lldb] r357292 - [ScriptInterpreterPython] Remove unused field (NFC)

Author: jdevlieghere Date: Fri Mar 29 10:58:07 2019 New Revision: 357292 URL: http://llvm.org/viewvc/llvm-project?rev=357292&view=rev Log: [ScriptInterpreterPython] Remove unused field (NFC) The m_lldb_module was initialized but not used. Modified: lldb/trunk/source/Plugins/ScriptInterprete

[Lldb-commits] [lldb] r357287 - [CMake] Move link dependencies where they are used.

Author: jdevlieghere Date: Fri Mar 29 10:47:26 2019 New Revision: 357287 URL: http://llvm.org/viewvc/llvm-project?rev=357287&view=rev Log: [CMake] Move link dependencies where they are used. The utility library shouldn't depend on curses, libedit or python. Move curses to core, libedit to host an

[Lldb-commits] [PATCH] D59970: [CMake] Untangle linking of dependencies

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB357287: [CMake] Move link dependencies where they are used. (authored by JDevlieghere, committed by ). Changed prior t

[Lldb-commits] [PATCH] D59968: [Cmake] Unify python variables

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB357282: [Cmake] Unify python variables (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D59968?vs=192735&id=192858#toc Repository: rLLDB LLDB CHANGES S

[Lldb-commits] [lldb] r357282 - [Cmake] Unify python variables

Author: jdevlieghere Date: Fri Mar 29 10:35:42 2019 New Revision: 357282 URL: http://llvm.org/viewvc/llvm-project?rev=357282&view=rev Log: [Cmake] Unify python variables FindPythonInterp and FindPythonLibs do two things, they set some variables (PYTHON_LIBRARIES, PYTHON_INCLUDE_DIRS) and update t

[Lldb-commits] [PATCH] D59972: [Python] Remove readline module

This revision was automatically updated to reflect the committed changes. Closed by commit rL357277: [Python] Remove readline module (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.or

[Lldb-commits] [lldb] r357277 - [Python] Remove readline module

Author: jdevlieghere Date: Fri Mar 29 10:12:08 2019 New Revision: 357277 URL: http://llvm.org/viewvc/llvm-project?rev=357277&view=rev Log: [Python] Remove readline module Todd added this empty readline module to workaround an issue with an old version of Python on Ubuntu in 2014 (18841). In the m

[Lldb-commits] [lldb] r357276 - Use the multi-lockable form of std::lock for operator=

Author: jingham Date: Fri Mar 29 10:07:30 2019 New Revision: 357276 URL: http://llvm.org/viewvc/llvm-project?rev=357276&view=rev Log: Use the multi-lockable form of std::lock for operator= For = operators for lists that have mutexes, we were either just taking the locks sequentially or hand-rolli

[Lldb-commits] [PATCH] D59957: Convert = operators that take object mutexes to the multi-lock version of std::lock

This revision was automatically updated to reflect the committed changes. Closed by commit rL357276: Use the multi-lockable form of std::lock for operator= (authored by jingham, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https

[Lldb-commits] [PATCH] D59991: [Linux/x86] Fix writing of non-gpr registers on newer processors

davezarzycki accepted this revision. davezarzycki added a comment. I've verified that this fixes my Skylake-SP (Xeon 8168) workstation. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59991/new/ https://reviews.llvm.org/D59991 ___ lld

[Lldb-commits] [PATCH] D59911: Don't abort() in lldb_assert and document why.

This revision was automatically updated to reflect the committed changes. Closed by commit rL357268: Don't abort() in lldb_assert and document why. (authored by adrian, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://review

[Lldb-commits] [lldb] r357268 - Don't abort() in lldb_assert and document why.

Author: adrian Date: Fri Mar 29 09:12:27 2019 New Revision: 357268 URL: http://llvm.org/viewvc/llvm-project?rev=357268&view=rev Log: Don't abort() in lldb_assert and document why. rdar://problem/49356014 Differential Revision: https://reviews.llvm.org/D59911 Added: lldb/trunk/docs/resources

[Lldb-commits] [PATCH] D59911: Don't abort() in lldb_assert and document why.

aprantl added a comment. Another problem with `lldb_assert()` is that in its current form it prints to stderr, which AFAIK is not even visible when LLDB is invoked from an IDE like Xcode. I like Pavel's suggestion of having a report_once function. It looks like everybody seems to agree that ll

[Lldb-commits] [PATCH] D59991: [Linux/x86] Fix writing of non-gpr registers on newer processors

jankratochvil accepted this revision. jankratochvil added a comment. This revision is now accepted and ready to land. LGTM and it has fixed for me on Kaby Lake Refresh (i7-8650U): lldb-Suite :: functionalities/register/register_command/TestRegisters.py lldb-Suite :: tools/lldb-server/TestGdbR

[Lldb-commits] [PATCH] D59991: [Linux/x86] Fix writing of non-gpr registers on newer processors

labath created this revision. labath added reviewers: jankratochvil, davezarzycki. We're using ptrace(PTRACE_SETREGSET, NT_X86_XSTATE) to write all non-gpt registers on x86 linux. Unfortunately, this method has a quirk, where the kernel rejects all attempts to write to this area if one supplies a

[Lldb-commits] [PATCH] D59972: [Python] Remove readline module

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Wohoo, it's great to be able to get rid of that. Judging by the bug reports, it looks like what actually happened is that libedit fixed some readline incompatibilities, instead of python fixin

[Lldb-commits] [PATCH] D59976: [Python] Remove Python include from ScriptInterpreterPython.h

labath added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.h:394-410 + std::unique_ptr m_saved_stdin; + std::unique_ptr m_saved_stdout; + std::unique_ptr m_saved_stderr; + std::unique_ptr m_main_module; + std::unique_ptr m

[Lldb-commits] [PATCH] D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior.

martong accepted this revision. martong added a comment. In D59485#1446950 , @a_sidorin wrote: > Hello Raphael, > I think we should accept this change. I don't see an easy way to merge the > LLDB stuff into ASTImporter; also, this patch provides a good e

[Lldb-commits] [PATCH] D59976: [Python] Remove Python include from ScriptInterpreterPython.h

labath added a comment. Btw, I really like this cleanup. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59976/new/ https://reviews.llvm.org/D59976 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://li

[Lldb-commits] [PATCH] D59976: [Python] Remove Python include from ScriptInterpreterPython.h

labath added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.h:327 - class Locker : public ScriptInterpreterLocker { - public: You could still keep this class inside ScriptInterpreterPython, and just forward

[Lldb-commits] [PATCH] D59970: [CMake] Untangle linking of dependencies

labath added a comment. I agree Utility is not the right place for this, but I am not sure about Core either. For curses, that's probably fine as an interim solution, because the usage is in IOHandler. However, for libedit, I'd expect this stuff to be in Host, since that's where we have the `

[Lldb-commits] [PATCH] D59911: Don't abort() in lldb_assert and document why.

labath accepted this revision. labath added a comment. In D59911#1446942 , @jingham wrote: > In this case it might be better to print an error at the problem site. You > could certainly do this with an assert and a printf. lldbassert just > provides a

[Lldb-commits] [PATCH] D59972: [Python] Remove readline module

mgorny added a comment. WFM. We've been stripping it in Gentoo since the inception. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59972/new/ https://reviews.llvm.org/D59972 ___ lldb-commits mailing list lldb-commit