[Lldb-commits] [PATCH] D59960: Fix for ambiguous lookup in expressions between local variable and namespace

friss added a comment. You didn't address my comment that "this" needs to treated specially in Obj-C++ too. Other than that this LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59960/new/ https://reviews.llvm.org/D59960 ___

[Lldb-commits] [PATCH] D59960: Fix for ambiguous lookup in expressions between local variable and namespace

shafik added a comment. @friss I had to rework the tests a little but they now cover Objective-C static and non-static methods as well as C and C++. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59960/new/ https://reviews.llvm.org/D59960

[Lldb-commits] [PATCH] D59960: Fix for ambiguous lookup in expressions between local variable and namespace

shafik updated this revision to Diff 194600. shafik added a comment. -Adjusting tests to ensure coverage of Objecive-C static and non-static methods and C and C++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59960/new/ https://reviews.llvm.org/D59960 Files:

[Lldb-commits] [lldb] r358137 - Fix undefined behavior in DWARFASTParser::ParseChildArrayInfo()

Author: adrian Date: Wed Apr 10 14:18:44 2019 New Revision: 358137 URL: http://llvm.org/viewvc/llvm-project?rev=358137=rev Log: Fix undefined behavior in DWARFASTParser::ParseChildArrayInfo() PR40827: https://bugs.llvm.org/show_bug.cgi?id=40827 Modified:

[Lldb-commits] [PATCH] D60508: [NFC] Remove ASCII lines from comments

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB358135: [NFC] Remove ASCII lines from comments (authored by JDevlieghere, committed by ). Changed prior to commit:

[Lldb-commits] [PATCH] D60519: [Windows] Dump more information about access violation exception

amccarth added a comment. Does this affect any existing tests? Is there a good way to test it? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60519/new/ https://reviews.llvm.org/D60519 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D60519: [Windows] Dump more information about access violation exception

leonid.mashinskiy added a comment. Thanks for review! Please, commit this for me, because I have no commit access. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60519/new/ https://reviews.llvm.org/D60519 ___

[Lldb-commits] [PATCH] D60498: Clean up docstrings in swig interface files

labath added a comment. This is purely a guess on my part, but I think this is an artefact of the process which was used to produce the swig interface files initially, though I don't know what that process actually was. I don't think doxygen ever reads these files, as it can parse the real c++

[Lldb-commits] [PATCH] D60498: Clean up docstrings in swig interface files

amccarth added a comment. LGTM, though I'm not clear why this extra visual noise was there in the first place. Does doxygen depend on this style when reading the swigged API? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60498/new/ https://reviews.llvm.org/D60498

[Lldb-commits] [PATCH] D60508: [NFC] Remove ASCII lines from comments

labath added a comment. Let's ship it. :) Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60508/new/ https://reviews.llvm.org/D60508 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D60508: [NFC] Remove ASCII lines from comments

sgraenitz added a comment. +1 Following the local coding style was a pain when adding functions in these files. Good step forward. This covers the majority of occurrences. Leaving `unittests` unchanged is probably intentional. There's a few more left in `tools` and other corners for a

[Lldb-commits] [PATCH] D60508: [NFC] Remove ASCII lines from comments

teemperor added a comment. Herald added a subscriber: dexonsmith. LGTM. Thanks for doing this! These lines are really frustrating to maintain when writing documentation. Also this should bring us yet again a bit closer to the LLVM style, so +1 for that. Repository: rLLDB LLDB CHANGES SINCE

[Lldb-commits] [PATCH] D60508: [NFC] Remove ASCII lines from comments

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added subscribers: jsji, abidh, arphaman, atanasyan, MaskRay, kbarton, arichardson, javed.absar, ki.stfu, nemanjai, emaste. Herald added a reviewer: espindola. Herald added a reviewer: jfb. Herald added a project:

[Lldb-commits] [lldb] r358070 - Minidump: Use llvm parser for reading the ModuleList stream

Author: labath Date: Wed Apr 10 04:07:28 2019 New Revision: 358070 URL: http://llvm.org/viewvc/llvm-project?rev=358070=rev Log: Minidump: Use llvm parser for reading the ModuleList stream In this patch, I just remove the structure definitions for the ModuleList stream and the associated parsing

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

This revision was automatically updated to reflect the committed changes. Closed by commit rL358069: Discard debuginfo for object files empty after GC (authored by ruiu, committed by ). Changed prior to commit: https://reviews.llvm.org/D54747?vs=194255=194469#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

ruiu added a comment. I will do that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54747/new/ https://reviews.llvm.org/D54747 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D60501: Minidump: extend UUID byte-swapping to windows platform

labath created this revision. labath added reviewers: clayborg, amccarth, markmentovai, asmith. D59433 added code to swap bytes UUIDs coming from minidump files, but only enabled it for apple platforms. Based on my research, I believe this is the correct thing

[Lldb-commits] [PATCH] D60325: [lldb] [Process/NetBSD] Fix wrongly mapping mm* registers

mgorny updated this revision to Diff 194457. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60325/new/ https://reviews.llvm.org/D60325 Files: lldb/lit/Register/Inputs/x86-mm-xmm-read.cpp lldb/lit/Register/x86-mm-xmm-read.test

[Lldb-commits] [lldb] r358055 - Docstringify some comments in the swig interface files

Author: labath Date: Wed Apr 10 00:55:04 2019 New Revision: 358055 URL: http://llvm.org/viewvc/llvm-project?rev=358055=rev Log: Docstringify some comments in the swig interface files Without these, the comments don't end up in the generated python code. Modified:

[Lldb-commits] [PATCH] D60458: [zorg] Add lldb-x86_64-debian builder

This revision was automatically updated to reflect the committed changes. Closed by commit rL358054: [zorg] Add lldb-x86_64-debian builder (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID()

labath added a comment. Herald added a project: LLDB. In D56229#1346941 , @zturner wrote: > Well, I guess I would ask what you want to do with the GUID? If you want to > match it to a debug information file, then the Debug Directory is the correct >

[Lldb-commits] [PATCH] D56233: [lldb-server] Add initial support for lldb-server on Windows

labath marked an inline comment as done. labath added inline comments. Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h:294 + + lldb_private::UUID m_uuid; }; asmith wrote: > labath wrote: > > Move UUID handling into a separate patch. > The UUID

[Lldb-commits] [PATCH] D60468: Lock accesses to OptionValueFileSpecList objects

labath added a comment. In D60468#1460212 , @friss wrote: > In D60468#1460065 , @labath wrote: > > > No opinion on the patch, but what is the reason for having settings that > > are shared between multiple

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

ruiu accepted this revision. ruiu added a comment. This revision is now accepted and ready to land. LGTM I'd write a comment explaining why we are handling debug sections in a special way, but that can be done later. Please submit. Thank you for doing this! CHANGES SINCE LAST ACTION