[Lldb-commits] [PATCH] D60654: Fix UNPREDICTABLE check in EmulateInstructionARM::EmulateADDRegShift

teemperor added a comment. I don't think I can provide a test for this because I don't really know the code so well (and generating an UNPREDICTABLE seems tricky too). I'll leave this up for a bit to see if someone comes up with a test (or I'll have time to dig into the code) and then commit.

[Lldb-commits] [PATCH] D60667: Allow direct comparison of ConstString against StringRef

clayborg added a comment. LGTM. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60667/new/ https://reviews.llvm.org/D60667 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[Lldb-commits] [PATCH] D60667: Allow direct comparison of ConstString against StringRef

amccarth added a comment. I, too, have some concern that this could have unintended side effects. To make the temporary `StringRef`s from the zero-terminated strings requires a `strlen` call each time. So we're making two passes over a string each time (once to measure and once to compare).

[Lldb-commits] [PATCH] D60655: Fix typo in ArmUnwindInfo::GetUnwindPlan

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Agreed, this change is correct. I double checked this in the http://infocenter.arm.com/help/topic/com.arm.doc.ihi0038b/IHI0038B_ehabi.pdf doc (mod 24 Nov 2015) and the only differ

[Lldb-commits] [PATCH] D59667: Regression test to ensure that we handling importing of anonymous enums correctly

shafik updated this revision to Diff 195254. shafik marked 3 inline comments as done. shafik added a comment. Small updated to test, remove use of `printf` and associated include. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59667/new/ https://reviews.llvm.org/D59667 Files: package

[Lldb-commits] [PATCH] D59667: Regression test to ensure that we handling importing of anonymous enums correctly

shafik added inline comments. Comment at: packages/Python/lldbsuite/test/expression_command/cast_int_to_anonymous_enum/main.cpp:8 +int main() { + flow_e f; + aprantl wrote: > It looks like this variable is not actually used by the test? I need the type in the

[Lldb-commits] [PATCH] D59667: Regression test to ensure that we handling importing of anonymous enums correctly

This revision was automatically updated to reflect the committed changes. Closed by commit rL358462: [ASTImporter] Regression test to ensure that we handling importing of anonymous… (authored by shafik, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[Lldb-commits] [lldb] r358462 - [ASTImporter] Regression test to ensure that we handling importing of anonymous enums correctly

Author: shafik Date: Mon Apr 15 16:05:45 2019 New Revision: 358462 URL: http://llvm.org/viewvc/llvm-project?rev=358462&view=rev Log: [ASTImporter] Regression test to ensure that we handling importing of anonymous enums correctly Summary: https://reviews.llvm.org/D51633 added error handling in th

[Lldb-commits] [PATCH] D60737: [lldb] Don't filter variable list when doing a lookup by mangled name in SymbolFileDWARF::FindGlobalVariables

kubamracek created this revision. kubamracek added a reviewer: jingham. kubamracek added a project: LLDB. Repository: rLLDB LLDB https://reviews.llvm.org/D60737 Files: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp Index: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp ===

[Lldb-commits] [PATCH] D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID()

asmith updated this revision to Diff 195282. asmith edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56229/new/ https://reviews.llvm.org/D56229 Files: lit/Modules/PECOFF/export-dllfunc.yaml source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp sour

[Lldb-commits] [PATCH] D60737: [lldb] Don't filter variable list when doing a lookup by mangled name in SymbolFileDWARF::FindGlobalVariables

labath added a comment. A test case? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60737/new/ https://reviews.llvm.org/D60737 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin