[Lldb-commits] [PATCH] D60962: [NativePDB] Extend .pdb files search folders

zloyrobot added inline comments. Comment at: lldb/lit/SymbolFile/NativePDB/pdb-file-lookup.cpp:4 + +// Test that we can find .pdb file in folder containing .exe file. +// RUN: %build --compiler=clang-cl --nodefaultlib -o %t.exe -- %s stella.stamenova wrote: > Is

[Lldb-commits] [lldb] r358939 - One small tweak to LocateExecutableScriptingResources - I

Author: jmolenda Date: Mon Apr 22 18:13:27 2019 New Revision: 358939 URL: http://llvm.org/viewvc/llvm-project?rev=358939&view=rev Log: One small tweak to LocateExecutableScriptingResources - I was still stat'ing the possibly-dSYM FileSpec before I (more cheaply) checked the filepath for telltale d

[Lldb-commits] [lldb] r358938 - Add a small check to PlatformDarwin::LoadScriptingResourceForModule

Author: jmolenda Date: Mon Apr 22 18:02:51 2019 New Revision: 358938 URL: http://llvm.org/viewvc/llvm-project?rev=358938&view=rev Log: Add a small check to PlatformDarwin::LoadScriptingResourceForModule which reads the python files in a dSYM bundle, to check that the SymbolFile is actually a dSYM

[Lldb-commits] [lldb] r358929 - Fix a bug in my change to ModulesDidLoad in r357955.

Author: jmolenda Date: Mon Apr 22 15:42:29 2019 New Revision: 358929 URL: http://llvm.org/viewvc/llvm-project?rev=358929&view=rev Log: Fix a bug in my change to ModulesDidLoad in r357955. In the process of hoisting the LoadScriptingResourceForModule out of Target::ModuleAdded and into Target::Modu

[Lldb-commits] [PATCH] D60963: Fix dereferencing null pointer

thakis added a comment. test? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60963/new/ https://reviews.llvm.org/D60963 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[Lldb-commits] [lldb] r358928 - [Docs] Move API docs to the front page

Author: jdevlieghere Date: Mon Apr 22 15:41:55 2019 New Revision: 358928 URL: http://llvm.org/viewvc/llvm-project?rev=358928&view=rev Log: [Docs] Move API docs to the front page This moves the links to the C++ and Python API docs up to the main page. As of now the links are still broken [1], but

[Lldb-commits] [PATCH] D60984: [Reproducers] Limit logging to calls that cross the API boundary.

JDevlieghere created this revision. JDevlieghere added reviewers: jasonmolenda, jingham, labath. Herald added a project: LLDB. We recently moved API logging into the instrumentation macros. This made that logging is now consistent and abstracted behind a macro for every API functions, independen

[Lldb-commits] [lldb] r358924 - Rename C++ TestGlobalVariables.py to have a distinct name from C version.

Author: adrian Date: Mon Apr 22 15:16:33 2019 New Revision: 358924 URL: http://llvm.org/viewvc/llvm-project?rev=358924&view=rev Log: Rename C++ TestGlobalVariables.py to have a distinct name from C version. Added: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/global_variables/TestCPPGlo

[Lldb-commits] [PATCH] D60829: FuncUnwinders: remove "current_offset" from function arguments

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Sorry for the delay in looking at this. It looks like a good change, an improvement on the original for sure. I've never seen multiple eh_frame FDEs for a single function, so tha

[Lldb-commits] [PATCH] D60962: [NativePDB] Extend .pdb files search folders

stella.stamenova added inline comments. Comment at: lldb/lit/SymbolFile/NativePDB/pdb-file-lookup.cpp:4 + +// Test that we can find .pdb file in folder containing .exe file. +// RUN: %build --compiler=clang-cl --nodefaultlib -o %t.exe -- %s Is this not testing f

[Lldb-commits] [lldb] r358918 - [EditLineTest] Not always TERM is available, e.g. on some bots.

Author: davide Date: Mon Apr 22 13:27:10 2019 New Revision: 358918 URL: http://llvm.org/viewvc/llvm-project?rev=358918&view=rev Log: [EditLineTest] Not always TERM is available, e.g. on some bots. Modified: lldb/trunk/unittests/Editline/EditlineTest.cpp Modified: lldb/trunk/unittests/Editlin

[Lldb-commits] [lldb] r358916 - [Reproducers] Fix lifetime issue

Author: jdevlieghere Date: Mon Apr 22 13:05:02 2019 New Revision: 358916 URL: http://llvm.org/viewvc/llvm-project?rev=358916&view=rev Log: [Reproducers] Fix lifetime issue Deallocating the data recorder in during the ::Keep() operation causes problems down the line when exiting the debugger. The

[Lldb-commits] [PATCH] D60968: WIP, RFC: Add an example of how LLDB python plug-in could look like

apolyakov marked an inline comment as done. apolyakov added a comment. In D60968#1474470 , @clayborg wrote: > Not sure what functionality this really adds? It seems to just wrap the OS > plug-in python class in a different way? You are right, for now th

[Lldb-commits] [PATCH] D60608: Make TestVSCode_step pass reliably

jgorbe added a comment. Thanks for the fix! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60608/new/ https://reviews.llvm.org/D60608 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi

[Lldb-commits] [PATCH] D60968: WIP, RFC: Add an example of how LLDB python plug-in could look like

clayborg added a comment. Not sure what functionality this really adds? It seems to just wrap the OS plug-in python class in a different way? Comment at: lldb/examples/python/lldb-os-plugin/arch/arc.py:15 +# Find the location of registers description file. +_interp = lldb.debu

[Lldb-commits] [PATCH] D60968: WIP, RFC: Add an example of how LLDB python plug-in could look like

apolyakov created this revision. apolyakov added reviewers: jingham, aprantl, labath. Herald added a project: LLDB. This commit shows how LLDB python plug-in could look like. Such an approach allows users to use LLDB for OS kernel debugging, for doing that they only need to implement two interfa

[Lldb-commits] [PATCH] D60948: yamlify TestMiniDumpUUID binaries

clayborg accepted this revision. clayborg added inline comments. This revision is now accepted and ready to land. Comment at: packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/linux-arm-zero-uuids.yaml:5 +Processor Arch: AMD64 +Platform ID: MacO

[Lldb-commits] [PATCH] D59015: [lldb-mi] Include full path in the -data-disassemble response

clayborg added inline comments. Comment at: lldb/tools/lldb-mi/MICmdCmdData.cpp:419 + // Get a full path to the file. + std::unique_ptr pPathBuffer(new char[PATH_MAX]); + lineEntry.GetFileSpec().GetPath(pPathBuffer.get(), PATH_MAX); anton.kolesov w

[Lldb-commits] [PATCH] D60963: Fix dereferencing null pointer

zloyrobot created this revision. zloyrobot added reviewers: amccarth, thakis. zloyrobot added a project: LLDB. Herald added subscribers: llvm-commits, lldb-commits, erik.pilkington, hiraditya. Herald added a project: LLVM. All callers of Demangler::parseTagUniqueName check 'Demangler.Error' and a

[Lldb-commits] [PATCH] D60962: [NativePDB] Extend .pdb files search folders

zloyrobot created this revision. zloyrobot added reviewers: amccarth, asmith, stella.stamenova. zloyrobot added a project: LLDB. Herald added subscribers: lldb-commits, teemperor. This patch adds ability to find .pdb files in NT_SYMBOL_PATH folders and in .exe file folder Repository: rLLDB LL

[Lldb-commits] [PATCH] D59015: [lldb-mi] Include full path in the -data-disassemble response

anton.kolesov added inline comments. Comment at: lldb/tools/lldb-mi/MICmdCmdData.cpp:419 + // Get a full path to the file. + std::unique_ptr pPathBuffer(new char[PATH_MAX]); + lineEntry.GetFileSpec().GetPath(pPathBuffer.get(), PATH_MAX); clayborg w

[Lldb-commits] [lldb] r358873 - [NativePDB] Add anonymous namespaces support

Author: aleksandr.urakov Date: Mon Apr 22 00:14:40 2019 New Revision: 358873 URL: http://llvm.org/viewvc/llvm-project?rev=358873&view=rev Log: [NativePDB] Add anonymous namespaces support Summary: This patch adds anonymous namespaces support to the native PDB plugin. I had to reference from the

[Lldb-commits] [PATCH] D60817: [NativePDB] Add anonymous namespaces support

This revision was automatically updated to reflect the committed changes. Closed by commit rL358873: [NativePDB] Add anonymous namespaces support (authored by aleksandr.urakov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https: