[Lldb-commits] [lldb] r359063 - [Docs] Add more redirects

Author: jdevlieghere Date: Tue Apr 23 18:58:17 2019 New Revision: 359063 URL: http://llvm.org/viewvc/llvm-project?rev=359063&view=rev Log: [Docs] Add more redirects Found two more broken links. Modified: lldb/trunk/docs/.htaccess Modified: lldb/trunk/docs/.htaccess URL: http://llvm.org/vie

[Lldb-commits] [lldb] r359061 - [Docs] Move external links up

Author: jdevlieghere Date: Tue Apr 23 18:48:40 2019 New Revision: 359061 URL: http://llvm.org/viewvc/llvm-project?rev=359061&view=rev Log: [Docs] Move external links up With a duplicate link removed and the API reference moved up, the page didn't make much sense anymore. Removed: lldb/trunk/

[Lldb-commits] [lldb] r359062 - [Docs] Update the CI page

Author: jdevlieghere Date: Tue Apr 23 18:48:43 2019 New Revision: 359062 URL: http://llvm.org/viewvc/llvm-project?rev=359062&view=rev Log: [Docs] Update the CI page - Add the Sphinx bot - Add a little more info Modified: lldb/trunk/docs/resources/bots.rst Modified: lldb/trunk/docs/resourc

[Lldb-commits] [lldb] r359052 - [Docs] Fix link to C++ docs

Author: jdevlieghere Date: Tue Apr 23 17:10:23 2019 New Revision: 359052 URL: http://llvm.org/viewvc/llvm-project?rev=359052&view=rev Log: [Docs] Fix link to C++ docs ... and add a redirect for the old URL. Modified: lldb/trunk/docs/.htaccess lldb/trunk/docs/index.rst Modified: lldb/tru

Re: [Lldb-commits] [PATCH] D61044: Fix infinite recursion when calling C++ template functions

> On Apr 23, 2019, at 3:51 PM, Frédéric Riss wrote: > > > > I don’t know what Phabricator did to my commit message. Here it is > (hopefully) un-mangled: I fixed it by ```-quoting the verbatim blocks. -- adrian ___ lldb-commits mailing list lldb-

Re: [Lldb-commits] [PATCH] D61044: Fix infinite recursion when calling C++ template functions

> On Apr 23, 2019, at 3:48 PM, Frederic Riss via Phabricator > wrote: > > friss created this revision. > friss added reviewers: shafik, clayborg, jingham. > Herald added subscribers: kristof.beyls, javed.absar, aprantl. > > When we encounter a templated function in the debug information, we >

[Lldb-commits] [PATCH] D61003: PostfixExpression: move parser out of NativePDB internals

amccarth accepted this revision. amccarth added a comment. Nice. Thanks for adding the test, too! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61003/new/ https://reviews.llvm.org/D61003 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [PATCH] D61044: Fix infinite recursion when calling C++ template functions

friss created this revision. friss added reviewers: shafik, clayborg, jingham. Herald added subscribers: kristof.beyls, javed.absar, aprantl. When we encounter a templated function in the debug information, we were creating an AST that looked like this: FunctionTemplateDecl 0x12980ab90 <> foo |

[Lldb-commits] [PATCH] D60962: [NativePDB] Extend .pdb files search folders

amccarth added a comment. cc: Pavel Labath because I know he's been involved in conversations about how to find symbol files in general (PDB, split DWARF, Breakpad, etc.), especially when doing post-mortem debugging. I believe there are complications when the debugger host is different than the

[Lldb-commits] [PATCH] D61036: [lldb] Use local definition of get_cpuid_count

JosephTremoulet added a comment. @labath, as discussed in D59991 , I went with a local copy of the function since I didn't see an obvious opportunity to tweak the calling code, but maybe I overlooked something. My copy of cpuid.h matches https://github.com/gcc-

[Lldb-commits] [PATCH] D61036: [lldb] Use local definition of get_cpuid_count

JosephTremoulet created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This is needed for gcc/cstdlib++ 5.4.0, where __get_cpuid_count is not defined in cpuid.h. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D61036 Files: lldb/source/Pl

[Lldb-commits] [PATCH] D60468: Lock accesses to OptionValueFileSpecList objects

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB359028: Lock accesses to OptionValueFileSpecList objects (authored by friss, committed by ). Herald added a subscriber: teemperor. Herald added a project: LLDB. Changed prior to commit: https://revie

[Lldb-commits] [lldb] r359028 - Lock accesses to OptionValueFileSpecList objects

Author: friss Date: Tue Apr 23 13:17:04 2019 New Revision: 359028 URL: http://llvm.org/viewvc/llvm-project?rev=359028&view=rev Log: Lock accesses to OptionValueFileSpecList objects Before a Debugger gets a Target, target settings are routed to a global set of settings. Even without this, some par

[Lldb-commits] [PATCH] D60468: Lock accesses to OptionValueFileSpecList objects

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Fine to fix the current issue. We should think about building this into the base class eventually. We can always have multi-threaded access, so we will always need to protect modifying ope

[Lldb-commits] [PATCH] D60468: Lock accesses to OptionValueFileSpecList objects

friss added a comment. There were no objections to the patch, and it fixes a real crash seen in the field so I'm going to check it in. There seems to be consensus that properties should be per-debugger, so I'll work on this when I get some spare cycles. Note that making that change won't preve

[Lldb-commits] [PATCH] D61000: Kill modify-python-lldb.py

clayborg accepted this revision. clayborg added a comment. Thanks for the diff! LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61000/new/ https://reviews.llvm.org/D61000 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://

[Lldb-commits] [PATCH] D61000: Kill modify-python-lldb.py

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Since this just changes how we fix up comments for the generated functions in lldb.py, I can't see any harm in removing it. It is clearly showing you a C-view of the function, so char -> st

[Lldb-commits] [PATCH] D60984: [Reproducers] Limit logging to calls that cross the API boundary.

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB359016: [Reproducers] Limit logging to calls that cross the API boundary. (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D60984?vs=196139&id=196281#toc

[Lldb-commits] [lldb] r359016 - [Reproducers] Limit logging to calls that cross the API boundary.

Author: jdevlieghere Date: Tue Apr 23 10:44:40 2019 New Revision: 359016 URL: http://llvm.org/viewvc/llvm-project?rev=359016&view=rev Log: [Reproducers] Limit logging to calls that cross the API boundary. We recently moved API logging into the instrumentation macros. This made that logging is now

[Lldb-commits] [lldb] r359011 - Revert "[EditLineTest] Not always TERM is available, e.g. on some bots."

Author: davide Date: Tue Apr 23 09:51:20 2019 New Revision: 359011 URL: http://llvm.org/viewvc/llvm-project?rev=359011&view=rev Log: Revert "[EditLineTest] Not always TERM is available, e.g. on some bots." This was a speculative fix trying to placate some bots, but it's ultimately just a bot conf

Re: [Lldb-commits] [lldb] r358918 - [EditLineTest] Not always TERM is available, e.g. on some bots.

You're right, I thought this was fixing a problem, but it's not. I'm going to revert this immediately. On Tue, Apr 23, 2019 at 2:12 AM Pavel Labath via lldb-commits wrote: > > On 22/04/2019 22:27, Davide Italiano via lldb-commits wrote: > > Author: davide > > Date: Mon Apr 22 13:27:10 2019 > > Ne

[Lldb-commits] [PATCH] D61003: PostfixExpression: move parser out of NativePDB internals

aleksandr.urakov accepted this revision. aleksandr.urakov added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61003/new/ https://reviews.llvm.org/D61003 ___ lldb-comm

[Lldb-commits] [PATCH] D59991: [Linux/x86] Fix writing of non-gpr registers on newer processors

labath added a comment. In D59991#1475709 , @JosephTremoulet wrote: > In D59991#1475694 , @labath wrote: > > > gcc-5.4 technically supported, so we can try to make things work for you. > > I'd be best if you can c

[Lldb-commits] [PATCH] D59991: [Linux/x86] Fix writing of non-gpr registers on newer processors

JosephTremoulet added a comment. In D59991#1475694 , @labath wrote: > gcc-5.4 technically supported, so we can try to make things work for you. I'd > be best if you can create a patch that will make things work for you (since > it's kinda hard for me to

[Lldb-commits] [lldb] r359005 - [Docs] Add missing leading slash

Author: jdevlieghere Date: Tue Apr 23 09:00:43 2019 New Revision: 359005 URL: http://llvm.org/viewvc/llvm-project?rev=359005&view=rev Log: [Docs] Add missing leading slash Modified: lldb/trunk/docs/.htaccess Modified: lldb/trunk/docs/.htaccess URL: http://llvm.org/viewvc/llvm-project/lldb/t

[Lldb-commits] [lldb] r359004 - [Docs] Add 301 redirects for old URLs

Author: jdevlieghere Date: Tue Apr 23 08:57:47 2019 New Revision: 359004 URL: http://llvm.org/viewvc/llvm-project?rev=359004&view=rev Log: [Docs] Add 301 redirects for old URLs Added: lldb/trunk/docs/.htaccess Modified: lldb/trunk/docs/conf.py Added: lldb/trunk/docs/.htaccess URL: http:

[Lldb-commits] [PATCH] D59991: [Linux/x86] Fix writing of non-gpr registers on newer processors

labath added a comment. gcc-5.4 technically supported, so we can try to make things work for you. I'd be best if you can create a patch that will make things work for you (since it's kinda hard for me to test that). Or at least, can you paste the contents of your cpuid.h somewhere? Repository

[Lldb-commits] [PATCH] D59991: [Linux/x86] Fix writing of non-gpr registers on newer processors

JosephTremoulet added inline comments. Comment at: lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp:282 + // Then fetch the maximum size of the area. + if (!__get_cpuid_count(0x0d, 0, &eax, &ebx, &ecx, &edx)) +return sizeof(FPR); --

[Lldb-commits] [PATCH] D60963: Fix dereferencing null pointer

zloyrobot added a comment. In D60963#1474783 , @thakis wrote: > test? Would you please advise me on what kind of test I should add for such fix? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60963/new/ https://reviews

[Lldb-commits] [PATCH] D61018: RegisterContextLLDB: Push CFA value on DWARF stack when evaluating register expressions

labath added a comment. Indeed the test passes on a mac with just a single linker warning saying it could not create compact unwind info because the %rip save address is weird, but that is not surprising. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61018/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D61018: RegisterContextLLDB: Push CFA value on DWARF stack when evaluating register expressions

labath updated this revision to Diff 196253. labath added a comment. This is the version that should at least compile on a mac (it turns out asm is more portable than I expected). I am still building lldb to see if the test will pass. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61018

[Lldb-commits] [PATCH] D61000: Kill modify-python-lldb.py

labath added a comment. Sure. This is the diff: F8747706: modify.diff . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61000/new/ https://reviews.llvm.org/D61000 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [PATCH] D61000: Kill modify-python-lldb.py

clayborg added a comment. Can you post a diff of things before and after? Hard to tell what we are opting out of just by seeing this patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61000/new/ https://reviews.llvm.org/D61000 ___ lldb-co

[Lldb-commits] [PATCH] D61018: RegisterContextLLDB: Push CFA value on DWARF stack when evaluating register expressions

labath added a comment. Actually, it seems it may be possible to tweak this asm so that it can run on a mac too (windows support unlikely). I'll try to post an updated version soon. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61018/new/ https://reviews.llvm.org/D61018

[Lldb-commits] [PATCH] D61018: RegisterContextLLDB: Push CFA value on DWARF stack when evaluating register expressions

labath added a comment. In D61018#1475553 , @clayborg wrote: > Got errors trying to compile this .s file on mac: > > $ ~/Documents/src/lldb/svn/lldb/llvm-build/Release+Asserts/x86_64/bin/clang > foo.s -o foo.o > foo.s:3:9: error: unknown directive >

[Lldb-commits] [PATCH] D61018: RegisterContextLLDB: Push CFA value on DWARF stack when evaluating register expressions

clayborg added a comment. Got errors trying to compile this .s file on mac: $ ~/Documents/src/lldb/svn/lldb/llvm-build/Release+Asserts/x86_64/bin/clang foo.s -o foo.o foo.s:3:9: error: unknown directive .type bar, @function ^ foo.s:11:9: error: unknown directive

[Lldb-commits] [PATCH] D61018: RegisterContextLLDB: Push CFA value on DWARF stack when evaluating register expressions

labath created this revision. labath added reviewers: jasonmolenda, clayborg. Herald added a subscriber: aprantl. This behavior is specified in the Section 6.4.2.3 (Register Rule instructions) of the DWARF4 spec. We were not doing that, which meant that any register rule which was relying on the c

[Lldb-commits] [PATCH] D60962: [NativePDB] Extend .pdb files search folders

zloyrobot updated this revision to Diff 196232. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60962/new/ https://reviews.llvm.org/D60962 Files: lldb/lit/SymbolFile/NativePDB/Inputs/pdb-file-lookup.lldbinit lldb/lit/SymbolFile/NativePDB/pdb-file-lookup.cpp

[Lldb-commits] [PATCH] D60962: [NativePDB] Extend .pdb files search folders

zloyrobot updated this revision to Diff 196226. zloyrobot added a comment. Add test case for searching .pdb file in the same folder as .exe file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60962/new/ https://reviews.llvm.org/D60962 Files: lldb/lit/SymbolFile/NativePDB/pdb-file-look

[Lldb-commits] [PATCH] D61004: FuncUnwinders: Factor out address validity check

labath created this revision. labath added reviewers: jasonmolenda, aprantl. Some (but not all) of the unwind plan creation functions were checking the validity of their address range before they attempted to create the unwind plan. Since a FuncUnwinders object cannot do anything reasonable with

[Lldb-commits] [PATCH] D61003: PostfixExpression: move parser out of NativePDB internals

labath created this revision. labath added reviewers: amccarth, clayborg, JDevlieghere, aleksandr.urakov. Herald added a subscriber: mgorny. The postfix expressions in PDB and breakpad symbol files are similar enough that they can be parsed by the same parser. This patch generalizes the parser in

[Lldb-commits] [PATCH] D59831: [CMake] macOS: Find DebugSymbols.framework inside the SDK

sgraenitz accepted this revision. sgraenitz added a comment. LGTM too. Did this land? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59831/new/ https://reviews.llvm.org/D59831 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D60599: Move postfix expression code out of the NativePDB plugin

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB358976: Move postfix expression code out of the NativePDB plugin (authored by labath, committed by ). Herald added a subscriber: abidh. Herald added a project: LLDB. Changed prior to commit: https://

[Lldb-commits] [lldb] r358976 - Move postfix expression code out of the NativePDB plugin

Author: labath Date: Tue Apr 23 04:50:07 2019 New Revision: 358976 URL: http://llvm.org/viewvc/llvm-project?rev=358976&view=rev Log: Move postfix expression code out of the NativePDB plugin Summary: The NativePDB plugin contains code to convert "programs" describing the layout of function frames

[Lldb-commits] [PATCH] D61000: Kill modify-python-lldb.py

labath created this revision. labath added reviewers: amccarth, jingham, clayborg. Herald added a subscriber: mgorny. After the last round of cleanups, this script was almost a no-op. The only piece of functionality that remained was the one which tried to make the swig-generated function signatur

[Lldb-commits] [lldb] r358967 - modify-python-lldb: Remove \a-removing code

Author: labath Date: Tue Apr 23 03:04:22 2019 New Revision: 358967 URL: http://llvm.org/viewvc/llvm-project?rev=358967&view=rev Log: modify-python-lldb: Remove \a-removing code instead, remove \a directly from the interface files. Modified: lldb/trunk/scripts/Python/modify-python-lldb.py

[Lldb-commits] [PATCH] D60829: FuncUnwinders: remove "current_offset" from function arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rL358964: FuncUnwinders: remove "current_offset" from function arguments (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CH

[Lldb-commits] [lldb] r358964 - FuncUnwinders: remove "current_offset" from function arguments

Author: labath Date: Tue Apr 23 02:57:14 2019 New Revision: 358964 URL: http://llvm.org/viewvc/llvm-project?rev=358964&view=rev Log: FuncUnwinders: remove "current_offset" from function arguments Summary: This argument was added back in 2010 (r118882) to support the ability to unwind from functio

[Lldb-commits] [lldb] r358959 - UnwindPlan: pretty-print dwarf expressions

Author: labath Date: Tue Apr 23 02:16:51 2019 New Revision: 358959 URL: http://llvm.org/viewvc/llvm-project?rev=358959&view=rev Log: UnwindPlan: pretty-print dwarf expressions Summary: Previously we were printing the dwarf expressions in unwind rules simply as "dwarf-expr". This patch uses the ex

[Lldb-commits] [PATCH] D60949: UnwindPlan: pretty-print dwarf expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB358959: UnwindPlan: pretty-print dwarf expressions (authored by labath, committed by ). Herald added a subscriber: teemperor. Herald added a project: LLDB. Changed prior to commit: https://reviews.ll

Re: [Lldb-commits] [lldb] r358918 - [EditLineTest] Not always TERM is available, e.g. on some bots.

On 22/04/2019 22:27, Davide Italiano via lldb-commits wrote: Author: davide Date: Mon Apr 22 13:27:10 2019 New Revision: 358918 URL: http://llvm.org/viewvc/llvm-project?rev=358918&view=rev Log: [EditLineTest] Not always TERM is available, e.g. on some bots. Modified: lldb/trunk/unittests/E

[Lldb-commits] [PATCH] D60829: FuncUnwinders: remove "current_offset" from function arguments

labath added a comment. Thanks for the review. Don't worry about the delay -- it has actually coincided with the public holidays on this side of the globe, so I was not working anyway. (but the delay wasn't long even if I had worked) :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D608

[Lldb-commits] [PATCH] D60984: [Reproducers] Limit logging to calls that cross the API boundary.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Logging only external calls makes sense to me. The one thing I was not sure about is the name of the `Recorder` class, since it's responsibility was now extended to include logging (and that h

[Lldb-commits] [PATCH] D60948: yamlify TestMiniDumpUUID binaries

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB358957: yamlify TestMiniDumpUUID binaries (authored by labath, committed by ). Herald added a subscriber: abidh. Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D60948

[Lldb-commits] [lldb] r358957 - yamlify TestMiniDumpUUID binaries

Author: labath Date: Tue Apr 23 01:49:39 2019 New Revision: 358957 URL: http://llvm.org/viewvc/llvm-project?rev=358957&view=rev Log: yamlify TestMiniDumpUUID binaries Summary: Instead of checking in raw minidump binaries, check in their yaml form, and call yaml2obj in the test. Reviewers: claybo

[Lldb-commits] [PATCH] D60968: WIP, RFC: Add an example of how LLDB python plug-in could look like

labath resigned from this revision. labath added a comment. I don't have any opinions on os plugins. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60968/new/ https://reviews.llvm.org/D60968 ___ lldb-co