[Lldb-commits] [lldb] r359752 - Mention the thread-format & frame-format settings in help.

Author: jingham Date: Wed May 1 19:14:08 2019 New Revision: 359752 URL: http://llvm.org/viewvc/llvm-project?rev=359752&view=rev Log: Mention the thread-format & frame-format settings in help. You can only find out about this useful customization by browsing the settings list output or the llvm.o

[Lldb-commits] [PATCH] D61414: [test] Convert TestWatchpointSetErrorCases.py to lit

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB359751: [test] Convert TestWatchpointSetErrorCases.py to lit (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D61414?vs=197674&id=197691#toc Repository:

[Lldb-commits] [PATCH] D61406: [CommandObjectCommands] Honor stop-command-source-on-error

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB359750: [CommandObjectCommands] Honor stop-command-source-on-error (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D61406?vs=197662&id=197689#toc Reposit

[Lldb-commits] [lldb] r359751 - [test] Convert TestWatchpointSetErrorCases.py to lit

Author: jdevlieghere Date: Wed May 1 18:54:05 2019 New Revision: 359751 URL: http://llvm.org/viewvc/llvm-project?rev=359751&view=rev Log: [test] Convert TestWatchpointSetErrorCases.py to lit This test is flaky on GreenDragon. Since it was a pexpect test and straightforward enough to convert, I w

[Lldb-commits] [lldb] r359750 - [CommandObjectCommands] Honor stop-command-source-on-error

Author: jdevlieghere Date: Wed May 1 18:54:02 2019 New Revision: 359750 URL: http://llvm.org/viewvc/llvm-project?rev=359750&view=rev Log: [CommandObjectCommands] Honor stop-command-source-on-error This patch ensures that we honor the stop-command-source-on-error setting from `command source`. Th

[Lldb-commits] [lldb] r359748 - [CMake] Remove EmulateInstructionMIPS dependency on Interpreter

Author: xiaobai Date: Wed May 1 18:10:38 2019 New Revision: 359748 URL: http://llvm.org/viewvc/llvm-project?rev=359748&view=rev Log: [CMake] Remove EmulateInstructionMIPS dependency on Interpreter Modified: lldb/trunk/source/Plugins/Instruction/MIPS/CMakeLists.txt lldb/trunk/source/Plugi

[Lldb-commits] [PATCH] D61414: [test] Convert TestWatchpointSetErrorCases.py to lit

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61414/new/ https://reviews.llvm.org/D61414 ___ lldb-commits

[Lldb-commits] [PATCH] D61414: [test] Convert TestWatchpointSetErrorCases.py to lit

JDevlieghere created this revision. JDevlieghere added reviewers: davide, labath. Herald added a subscriber: teemperor. Herald added a project: LLDB. This test is flaky on GreenDragon. Since it was a pexpect test and straightforward enough to convert, I went ahead and converted it to a lit test.

[Lldb-commits] [PATCH] D61406: [CommandObjectCommands] Honor stop-command-source-on-error

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61406/new/ https://reviews.llvm.org/D61406 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D61362: lldb-server: remove link against lldbInterpreter

compnerd closed this revision. compnerd added a comment. SVN r359738 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61362/new/ https://reviews.llvm.org/D61362 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [lldb] r359738 - lldb-server: remove link against lldbInterpreter

Author: compnerd Date: Wed May 1 16:06:45 2019 New Revision: 359738 URL: http://llvm.org/viewvc/llvm-project?rev=359738&view=rev Log: lldb-server: remove link against lldbInterpreter This dependency is unused. Remove the extraneous link. Modified: lldb/trunk/tools/lldb-server/CMakeLists.txt

[Lldb-commits] [PATCH] D61406: [CommandObjectCommands] Honor stop-command-source-on-error

JDevlieghere updated this revision to Diff 197662. JDevlieghere retitled this revision from "Watchpoint test + stop-command-source-on-error fix combo" to "[CommandObjectCommands] Honor stop-command-source-on-error ". JDevlieghere edited the summary of this revision. JDevlieghere added a comment.

[Lldb-commits] [PATCH] D61146: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference when loading from DWARF

This revision was automatically updated to reflect the committed changes. Closed by commit rL359732: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference… (authored by shafik, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pr

[Lldb-commits] [lldb] r359732 - Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference when loading from DWARF

Author: shafik Date: Wed May 1 15:23:06 2019 New Revision: 359732 URL: http://llvm.org/viewvc/llvm-project?rev=359732&view=rev Log: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference when loading from DWARF Summary: This will fix a bug where during expression parsing w

[Lldb-commits] [PATCH] D61406: Watchpoint test + stop-command-source-on-error fix combo

JDevlieghere updated this revision to Diff 197652. JDevlieghere added a comment. Reduce test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61406/new/ https://reviews.llvm.org/D61406 Files: lldb/lit/Watchpoint/Inputs/main.cpp lldb/lit/Watchpoint/SetErrorCases.test lldb/packages/P

[Lldb-commits] [PATCH] D61406: Watchpoint test + stop-command-source-on-error fix combo

JDevlieghere created this revision. JDevlieghere added reviewers: davide, sgraenitz, friss. Herald added subscribers: teemperor, jfb. Herald added a project: LLDB. The original intention was to change the watchpoint Python test to a lit test. While doing so, I found a situation where stop-command

[Lldb-commits] [PATCH] D61362: lldb-server: remove link against lldbInterpreter

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. Seems like the right thing to do. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61362/new/ https://reviews.llvm.org/D61362 _

[Lldb-commits] [lldb] r359730 - [lldb-server] Remove lldb-server's dependency on Core

Author: xiaobai Date: Wed May 1 14:41:40 2019 New Revision: 359730 URL: http://llvm.org/viewvc/llvm-project?rev=359730&view=rev Log: [lldb-server] Remove lldb-server's dependency on Core No need to directly link against Core, as lldb-server doesn't directly use it. Modified: lldb/trunk/tool

[Lldb-commits] [PATCH] D61146: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference when loading from DWARF

friss accepted this revision. friss added a comment. This revision is now accepted and ready to land. Thanks, indeed this looks better. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61146/new/ https://reviews.llvm.org/D61146 ___ lldb-commit

[Lldb-commits] [PATCH] D61146: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference when loading from DWARF

shafik updated this revision to Diff 197636. shafik marked an inline comment as done. shafik added a comment. Modifying copy contructor to be act more intuitively. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61146/new/ https://reviews.llvm.org/D61146 Files: packages/Python/lldbsui

[Lldb-commits] [PATCH] D61146: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference when loading from DWARF

shafik added inline comments. Comment at: packages/Python/lldbsuite/test/expression_command/argument_passing_restrictions/TestArgumentPassingRestrictions.py:32 +self.expect("expr takePassByRef(p)", +substrs=['(int)', '= 11223344']) friss wrote: >

[Lldb-commits] [PATCH] D61146: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference when loading from DWARF

friss added inline comments. Comment at: packages/Python/lldbsuite/test/expression_command/argument_passing_restrictions/TestArgumentPassingRestrictions.py:32 +self.expect("expr takePassByRef(p)", +substrs=['(int)', '= 11223344']) If this test pa

[Lldb-commits] [lldb] r359724 - Disable queues_with_libBacktraceRecording

Author: jdevlieghere Date: Wed May 1 13:37:05 2019 New Revision: 359724 URL: http://llvm.org/viewvc/llvm-project?rev=359724&view=rev Log: Disable queues_with_libBacktraceRecording After multiple attempts from both Fred and Adrian, this variant of the test is still flaky on GreenDragon. This comm

[Lldb-commits] [PATCH] D61146: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference when loading from DWARF

shafik added a comment. @friss added second test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61146/new/ https://reviews.llvm.org/D61146 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[Lldb-commits] [PATCH] D61146: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference when loading from DWARF

shafik updated this revision to Diff 197628. shafik added a comment. Testing both passing as and argument and returning CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61146/new/ https://reviews.llvm.org/D61146 Files: packages/Python/lldbsuite/test/expression_command/argument_passing_

[Lldb-commits] [PATCH] D61360: Initialization: remove ObjectContainer from Common

xiaobai added inline comments. Comment at: source/API/SystemInitializerFull.cpp:132-133 + ObjectContainerBSDArchive::Initialize(); + ObjectContainerUniversalMachO::Initialize(); + You need to include the headers for these classes Repository: rLLDB LLDB C

[Lldb-commits] [PATCH] D61368: Fix build URL in new LLDB website

kwk added a comment. In D61368#1485840 , @teemperor wrote: > I just realized that you probably don't have commit access yet, so I'll > commit this for you. Thanks for the patch! Thank you @teemperor ! Repository: rL LLVM CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D61146: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference when loading from DWARF

friss added inline comments. Comment at: packages/Python/lldbsuite/test/expression_command/argument_passing_restrictions/TestArgumentPassingRestrictions.py:28-29 + +self.expect("expr f.bar(&f).x", +substrs=['(int)', '= 11223344']) This still test

[Lldb-commits] [PATCH] D61146: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference when loading from DWARF

shafik updated this revision to Diff 197618. shafik added a comment. - Simplifying test - Fixing unintended deleted test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61146/new/ https://reviews.llvm.org/D61146 Files: packages/Python/lldbsuite/test/expression_command/argument_passing

[Lldb-commits] [PATCH] D61146: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference when loading from DWARF

shafik added a comment. @teemperor good call, that is indeed simpler and yes I did not intend that delete. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61146/new/ https://reviews.llvm.org/D61146 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [PATCH] D61394: Remove unnecessary check in SymbolFileDWARF::ParseImportedModules

teemperor created this revision. teemperor added a reviewer: aprantl. Herald added subscribers: lldb-commits, jdoerfert. Herald added a project: LLDB. This check seems unnecessary as we already assert the same condition above and also access `sc.comp_unit` before this check. Repository: rLLDB

[Lldb-commits] [PATCH] D61146: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference when loading from DWARF

teemperor added a comment. As we're anyway throwing in reduced test cases, here is another version: struct PassByRef { // PassByRef should be pass by reference since the destructor is // user-defined which means it can not be passed in registers. ~PassByRef() {} int x = 0; };

[Lldb-commits] [PATCH] D61146: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference when loading from DWARF

friss added a comment. Correct me if I'm wrong, but the test seems overly complicated still. We are testing that we can get the return value of a type that needs to be passed by reference. Calling simple free function `Bounds bounds()` should trigger this code path, shouldn't it? I would be int

[Lldb-commits] [lldb] r359699 - Disabling test in TestClassTemplateParameterPack.py until we do template lookup correctly

Author: shafik Date: Wed May 1 09:39:31 2019 New Revision: 359699 URL: http://llvm.org/viewvc/llvm-project?rev=359699&view=rev Log: Disabling test in TestClassTemplateParameterPack.py until we do template lookup correctly Summary: Some tests currently only work because we are pulling all the lo

[Lldb-commits] [PATCH] D61146: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference when loading from DWARF

shafik added a comment. @aprantl @teemperor I believe I addressed your comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61146/new/ https://reviews.llvm.org/D61146 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://list

[Lldb-commits] [PATCH] D61376: [lldb] [lit] Split 'register read' tests between zmm*, xmm16+, ymm16+

mgorny created this revision. mgorny added reviewers: labath, JDevlieghere, krytarowski. Herald added subscribers: kristof.beyls, javed.absar. Since Darwin target implements support for zmm* registers without matching support for the respectively added xmm* and ymm* registers, split the tests for

[Lldb-commits] [PATCH] D61303: [lldb] [lit] Add write tests for MM/XMM/r8-r15 registers

This revision was automatically updated to reflect the committed changes. Closed by commit rL359681: [lldb] [lit] Add write tests for MM/XMM registers (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[Lldb-commits] [lldb] r359682 - [lldb] [lit] Add write tests for r8-r15 & xmm8-xmm15 registers

Author: mgorny Date: Wed May 1 06:55:23 2019 New Revision: 359682 URL: http://llvm.org/viewvc/llvm-project?rev=359682&view=rev Log: [lldb] [lit] Add write tests for r8-r15 & xmm8-xmm15 registers Differential Revision: https://reviews.llvm.org/D61303 Added: lldb/trunk/lit/Register/Inputs/x86

[Lldb-commits] [lldb] r359681 - [lldb] [lit] Add write tests for MM/XMM registers

Author: mgorny Date: Wed May 1 06:55:13 2019 New Revision: 359681 URL: http://llvm.org/viewvc/llvm-project?rev=359681&view=rev Log: [lldb] [lit] Add write tests for MM/XMM registers Differential Revision: https://reviews.llvm.org/D61303 Added: lldb/trunk/lit/Register/Inputs/x86-mm-xmm-write

[Lldb-commits] [PATCH] D61368: Fix build URL in new LLDB website

This revision was automatically updated to reflect the committed changes. Closed by commit rL359665: Fix build URL in new LLDB website (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org

[Lldb-commits] [lldb] r359665 - Fix build URL in new LLDB website

Author: teemperor Date: Wed May 1 02:55:00 2019 New Revision: 359665 URL: http://llvm.org/viewvc/llvm-project?rev=359665&view=rev Log: Fix build URL in new LLDB website Summary: After the LLDB website was migrated to be generated by Sphinx the build.html file lives in another location. See htt

[Lldb-commits] [PATCH] D61368: Fix build URL in new LLDB website

teemperor added a comment. I just realized that you probably don't have commit access yet, so I'll commit this for you. Thanks for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61368/new/ https://reviews.llvm.org/D61368 _

[Lldb-commits] [lldb] r359664 - Removed unnecessary conversion to StringRef

Author: teemperor Date: Wed May 1 02:49:07 2019 New Revision: 359664 URL: http://llvm.org/viewvc/llvm-project?rev=359664&view=rev Log: Removed unnecessary conversion to StringRef Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp Modified: lldb/trunk/source/Plugins/Sym

[Lldb-commits] [PATCH] D61064: Object/Minidump: Add support for the ThreadList stream

jhenderson accepted this revision. jhenderson added a comment. This revision is now accepted and ready to land. Aside from a couple of nits, LGTM. Comment at: lib/Object/Minidump.cpp:69 size_t ListOffset = 4; - // Some producers insert additional padding bytes to align the

[Lldb-commits] [PATCH] D61368: Fix build URL in new LLDB website

kkleine created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. After the LLDB website was migrated to be generated by Sphinx the build.html file lives in another location. See http://lists.llvm.org/pipermail/lldb-dev/2019-April/014992.html. Repository: