[Lldb-commits] [PATCH] D61292: Include inlined functions when figuring out a contiguous address range

labath added a comment. I'm impressed by the test. I've tried to think of an alternative strategy for testing this (perhaps by adding a suitable mode to lldb-test), but I couldn't come up with one that a reasonable one, so this might be the best we can do right now. Thank you for taking the tr

[Lldb-commits] [PATCH] D61478: Move decl completion out of the ASTImporterDelegate and document it [NFC]

teemperor created this revision. teemperor added reviewers: shafik, aprantl. Herald added a reviewer: martong. Herald added a reviewer: a.sidorin. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. teemperor edited the summary of this revision. Herald added a subscriber: rnkovac

[Lldb-commits] [PATCH] D61292: Include inlined functions when figuring out a contiguous address range

aadsm marked 4 inline comments as done and an inline comment as not done. aadsm added inline comments. Comment at: lldb/unittests/Symbol/TestLineEntry.cpp:60-87 +#define EXPECTED_NO_ERROR(x) \ + if (std::error_code ASSERT_NO_ERR

[Lldb-commits] [PATCH] D61473: ExpressionParser: only force link MCJIT when needed

compnerd added a comment. gold-2.27, clang 6.0.0, `-ffunction-sections`, `-fdata-sections`, `-DLLVM_ENABLE_UNWIND_TABLES=NO`, MinSizeRel: **BEFORE** bin/lldb-server : section size addr .interp 284194928 .note.ABI-tag

[Lldb-commits] [lldb] r359848 - [Reproducers] Improve reproducer help

Author: jdevlieghere Date: Thu May 2 17:10:31 2019 New Revision: 359848 URL: http://llvm.org/viewvc/llvm-project?rev=359848&view=rev Log: [Reproducers] Improve reproducer help Extend the documentation for the reproducer command. Modified: lldb/trunk/source/Commands/CommandObjectReproducer.c

[Lldb-commits] [PATCH] D61473: ExpressionParser: only force link MCJIT when needed

compnerd created this revision. compnerd added reviewers: labath, clayborg, emaste, davide, xiaobai. Herald added subscribers: teemperor, abidh, krytarowski, mgorny. Herald added a project: LLDB. This was added to support FreeBSD. The inclusion of this header increases the size of `lldb-server` d

[Lldb-commits] [lldb] r359847 - RegisterContextLLDB::GetFullUnwindPlanForFrame has four verbose

Author: jmolenda Date: Thu May 2 16:49:56 2019 New Revision: 359847 URL: http://llvm.org/viewvc/llvm-project?rev=359847&view=rev Log: RegisterContextLLDB::GetFullUnwindPlanForFrame has four verbose logging messages that are written the same, making it difficult to know for certain which code path

[Lldb-commits] [lldb] r359846 - Fix tests on non-Darwin platforms.

Author: adrian Date: Thu May 2 16:49:55 2019 New Revision: 359846 URL: http://llvm.org/viewvc/llvm-project?rev=359846&view=rev Log: Fix tests on non-Darwin platforms. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/c/vla/TestVLA.py lldb/trunk/packages/Python/lldbsuite/test/lang

[Lldb-commits] [lldb] r359843 - Upstreaming an apple local patch by Frederic Riss.

Author: jmolenda Date: Thu May 2 16:14:26 2019 New Revision: 359843 URL: http://llvm.org/viewvc/llvm-project?rev=359843&view=rev Log: Upstreaming an apple local patch by Frederic Riss. lldb has an expression that runs in the inferior process to collect the isa values and hash of the class names

[Lldb-commits] [PATCH] D61451: Hide runtime support values such as clang's __vla_expr from frame variable

This revision was automatically updated to reflect the committed changes. Closed by commit rL359841: Hide runtime support values such as clang's __vla_expr from frame variable (authored by adrian, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[Lldb-commits] [lldb] r359841 - Hide runtime support values such as clang's __vla_expr from frame variable

Author: adrian Date: Thu May 2 16:07:23 2019 New Revision: 359841 URL: http://llvm.org/viewvc/llvm-project?rev=359841&view=rev Log: Hide runtime support values such as clang's __vla_expr from frame variable by respecting the "artificial" attribute on variables. Function arguments that are artifi

[Lldb-commits] [PATCH] D60957: Read ObjC class names in one large read, instead of reading them individually

jasonmolenda abandoned this revision. jasonmolenda added a comment. I had some more revisions on this patch, but I finally understood that I was solving the wrong problem with this patchset. lldb should not fetch class names up front when scanning the objective c class tables, they should only

[Lldb-commits] [PATCH] D59960: Fix for ambiguous lookup in expressions between local variable and namespace

shafik added a comment. @teemperor @jingham @clayborg I believe now that https://reviews.llvm.org/D46551 is landed the performance concerns should be addressed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59960/new/ https://reviews.llvm.org/D59960

[Lldb-commits] [PATCH] D61451: Hide runtime support values such as clang's __vla_expr from frame variable

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61451/new/ https://reviews.llvm.org/D61451 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [lldb] r359832 - Initialization: move InstructionEmulation to full initialization

Author: compnerd Date: Thu May 2 14:49:29 2019 New Revision: 359832 URL: http://llvm.org/viewvc/llvm-project?rev=359832&view=rev Log: Initialization: move InstructionEmulation to full initialization The debug server does not need to use the instruction emulation. This helps reduce the size of t

[Lldb-commits] [PATCH] D61469: [Alias] Add 're' alias for register

JDevlieghere created this revision. JDevlieghere added a reviewer: jingham. Herald added a project: LLDB. This patch makes `re` an alias for `register`. Currently `re` gives you the choice between `register` and `reproducer`. Given that you use `register` a lot more often, `register` should win

[Lldb-commits] [PATCH] D61451: Hide runtime support values such as clang's __vla_expr from frame variable

aprantl updated this revision to Diff 197871. aprantl added a comment. Thanks you! There was indeed a bug that prevented us from recognizing the correct runtime for the C++ `this` pointer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61451/new/ https://reviews.llvm.org/D61451 Files:

[Lldb-commits] [PATCH] D61292: Include inlined functions when figuring out a contiguous address range

aadsm marked an inline comment as done. aadsm added inline comments. Comment at: lldb/include/lldb/Symbol/Declaration.h:112-113 + /// + /// Compares the specification from \a rhs. If the file specifications are + /// equal, then continue to compare the line. + /// ---

[Lldb-commits] [PATCH] D61440: C.128 override, virtual keyword handling

teemperor added a comment. You don't have to use arc, you can also just update the code via the "Update diff" button and upload a patch file. So it doesn't really matter how you organize your local git branch as long as you can produce a patch file from the changes. Phabricator takes care of ma

[Lldb-commits] [PATCH] D61292: Include inlined functions when figuring out a contiguous address range

jingham added inline comments. Comment at: lldb/include/lldb/Symbol/Declaration.h:113 + /// Compares the specification from \a rhs. If the file specifications are + /// equal, then continue to compare the line. + /// clayborg wrote: > How about just returning

[Lldb-commits] [PATCH] D61292: Include inlined functions when figuring out a contiguous address range

clayborg added inline comments. Comment at: lldb/include/lldb/Symbol/Declaration.h:113 + /// Compares the specification from \a rhs. If the file specifications are + /// equal, then continue to compare the line. + /// How about just returning a bool: ``` bool

[Lldb-commits] [PATCH] D61440: C.128 override, virtual keyword handling

kwk added a comment. In D61440#1488470 , @teemperor wrote: > Not sure how you invoke git clang-format, but I assume you specified the > wrong commit range... That is correct in this case I've used clang format directly on the whole file. Sorry if that

Re: [Lldb-commits] [PATCH] D61451: Hide runtime support values such as clang's __vla_expr from frame variable

If we did this wrong, then either stopping in a C++ method in a .mm file would suppress "this" (if we mistakenly used the ObjC Runtime's "RuntimeSupportValue") or stopping in an ObjC method in a .mm file would suppress "self and _cmd" (if we used the C++ Runtime's RuntimeSupportValue). So we n

[Lldb-commits] [PATCH] D61292: Include inlined functions when figuring out a contiguous address range

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. This makes sense to me. Pinning the extension to the call site prevented all the cases I could think of where this might go wrong. I had a bunch of small comments inline. =

[Lldb-commits] [PATCH] D61440: C.128 override, virtual keyword handling

teemperor added a comment. Not sure how you invoke git clang-format, but I assume you specified the wrong commit range... I personally use some custom command that executes this `git rebase -i --autosquash -x 'git clang-format master && git commit -a --amend --no-edit' master` which essentiall

[Lldb-commits] [PATCH] D61440: C.128 override, virtual keyword handling

kkleine updated this revision to Diff 197848. kkleine added a comment. - Address formatting issues brought up in https://reviews.llvm.org/D61440#1488450 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61440/new/ https://reviews.llvm.org/D61440 File

[Lldb-commits] [PATCH] D61440: C.128 override, virtual keyword handling

kwk added a comment. In D61440#1488450 , @teemperor wrote: > FYI, I still think there are some style issues there (e.g. the > AppleObjCRuntimeV2.cpp change makes it longer than 80 chars) but I can just > clang-format this before committing. > > Otherwise

[Lldb-commits] [PATCH] D61440: C.128 override, virtual keyword handling

teemperor accepted this revision. teemperor added a comment. FYI, I still think there are some style issues there (e.g. the AppleObjCRuntimeV2.cpp change makes it longer than 80 chars) but I can just clang-format this before committing. Otherwise, unless someone objects to this change I'll merg

[Lldb-commits] [PATCH] D61440: C.128 override, virtual keyword handling

teemperor added a comment. In D61440#1488424 , @kwk wrote: > In D61440#1488174 , @teemperor wrote: > > > LGTM module some minor code style issues (You removed some `virtual`s but > > didn't fix the indentation of t

[Lldb-commits] [PATCH] D61440: C.128 override, virtual keyword handling

kkleine updated this revision to Diff 197846. kkleine added a comment. - Fix https://reviews.llvm.org/D61440#inline-545102 - Fix https://reviews.llvm.org/D61440#inline-545098 - Fix https://reviews.llvm.org/D61440#inline-545099 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[Lldb-commits] [PATCH] D61440: C.128 override, virtual keyword handling

kwk added a comment. @teemperor I would have loved to use clang-format for this but apparently the LLDB code is still manually formatted. It would be a bliss to just use the LLVM clang-format style and never ever talk about "style" again. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[Lldb-commits] [PATCH] D61440: C.128 override, virtual keyword handling

kwk added a comment. In D61440#1488174 , @teemperor wrote: > LGTM module some minor code style issues (You removed some `virtual`s but > didn't fix the indentation of the parameters on the next line, see the inline > comments for examples). @teemperor

[Lldb-commits] [PATCH] D61451: Hide runtime support values such as clang's __vla_expr from frame variable

aprantl updated this revision to Diff 197843. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61451/new/ https://reviews.llvm.org/D61451 Files: lldb/include/lldb/Target/CPPLanguageRuntime.h lldb/include/lldb/Target/LanguageRuntime.h lldb/include/lldb/Target/ObjCLanguageRuntime.h ll

[Lldb-commits] [lldb] r359817 - Initialization: correct macro usage

Author: compnerd Date: Thu May 2 12:25:18 2019 New Revision: 359817 URL: http://llvm.org/viewvc/llvm-project?rev=359817&view=rev Log: Initialization: correct macro usage `_MSC_VER` indiciates that you are building with MSVC, not that you are building for Windows. Use `_WIN32` (which identifies

[Lldb-commits] [PATCH] D61451: Hide runtime support values such as clang's __vla_expr from frame variable

aprantl added a comment. In D61451#1488186 , @jingham wrote: > Could you add a comment (probably best in LanguageRuntime.h) saying what a > RuntimeSupportValue is? Done. > Also, so far as I can tell, this patch works because we use the CPP language >

[Lldb-commits] [lldb] r359816 - gdb-remote: fix the build on Windows

Author: compnerd Date: Thu May 2 12:09:58 2019 New Revision: 359816 URL: http://llvm.org/viewvc/llvm-project?rev=359816&view=rev Log: gdb-remote: fix the build on Windows Windows does not have a definition for `mode_t`. Include the appropriate header. Modified: lldb/trunk/source/Plugins/Pr

[Lldb-commits] [PATCH] D61394: Remove unnecessary check in SymbolFileDWARF::ParseImportedModules

This revision was automatically updated to reflect the committed changes. Closed by commit rL359813: Remove unnecessary check in SymbolFileDWARF::ParseImportedModules (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to co

[Lldb-commits] [lldb] r359812 - Disable TestArgumentPassingRestrictions for clang < 7

Author: jdevlieghere Date: Thu May 2 11:26:46 2019 New Revision: 359812 URL: http://llvm.org/viewvc/llvm-project?rev=359812&view=rev Log: Disable TestArgumentPassingRestrictions for clang < 7 http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-matrix/ Modified: lldb/trunk/packages/Pyt

[Lldb-commits] [lldb] r359813 - Remove unnecessary check in SymbolFileDWARF::ParseImportedModules

Author: teemperor Date: Thu May 2 11:26:58 2019 New Revision: 359813 URL: http://llvm.org/viewvc/llvm-project?rev=359813&view=rev Log: Remove unnecessary check in SymbolFileDWARF::ParseImportedModules Summary: This check seems unnecessary as we already assert the same condition above and also a

[Lldb-commits] [PATCH] D61394: Remove unnecessary check in SymbolFileDWARF::ParseImportedModules

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. True. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61394/new/ https://reviews.llvm.org/D61394 ___ lldb-comm

[Lldb-commits] [lldb] r359811 - gdb-remote: reduce some inclusion of Target/Process.h

Author: compnerd Date: Thu May 2 11:15:03 2019 New Revision: 359811 URL: http://llvm.org/viewvc/llvm-project?rev=359811&view=rev Log: gdb-remote: reduce some inclusion of Target/Process.h Reduce the inclusion of Target/Process.h to help isolate why Process is being preserved during the build of

[Lldb-commits] [PATCH] D61360: Initialization: remove ObjectContainer from Common

compnerd closed this revision. compnerd added a comment. SVN r359810 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61360/new/ https://reviews.llvm.org/D61360 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [lldb] r359810 - Initialization: remove ObjectContainer from Common

Author: compnerd Date: Thu May 2 11:11:44 2019 New Revision: 359810 URL: http://llvm.org/viewvc/llvm-project?rev=359810&view=rev Log: Initialization: remove ObjectContainer from Common This restructures the initialization path to move the ObjectContainer initialization into the *full* initializa

[Lldb-commits] [PATCH] D61360: Initialization: remove ObjectContainer from Common

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: source/API/SystemInitializerFull.cpp:132-133 + ObjectContainerBSDArchive::Initialize(); + ObjectContainerUniversalMachO::Initialize(); +

[Lldb-commits] [PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

teemperor added a comment. I think the best way to handle these errors in LLDB is to just log and then return some default value. That should make the current command print an error, which is better than terminating LLDB. Otherwise the LLDB part of this patch LGTM. Repository: rG LLVM Githu

[Lldb-commits] [lldb] r359807 - [test] TestSharedPtr -> TestSharedPtrDbgInfoContent

Author: jdevlieghere Date: Thu May 2 10:35:18 2019 New Revision: 359807 URL: http://llvm.org/viewvc/llvm-project?rev=359807&view=rev Log: [test] TestSharedPtr -> TestSharedPtrDbgInfoContent Two tests cannot share the same name, because they will generate an identical trace file. When that happen

[Lldb-commits] [PATCH] D61451: Hide runtime support values such as clang's __vla_expr from frame variable

jingham added a comment. Could you add a comment (probably best in LanguageRuntime.h) saying what a RuntimeSupportValue is? Also, so far as I can tell, this patch works because we use the CPP language runtime for C++ methods is an ObjC++ file, and the ObjCLanguageRuntime for ObjC methods in di

[Lldb-commits] [PATCH] D61440: C.128 override, virtual keyword handling

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM module some minor code style issues (You removed some `virtual`s but didn't fix the indentation of the parameters on the next line, see the inline comments for examples). ===

[Lldb-commits] [PATCH] D61440: C.128 override, virtual keyword handling

shafik added a comment. Thank you! LGTM, in general we avoid "large" refactoring changes to avoid polluting the blame list but the changes are relatively local and they are good changes that can catch real bugs in the future. I would like a second set of eyes though. Repository: rG LLVM Gi

[Lldb-commits] [PATCH] D61451: Hide runtime support values such as clang's __vla_expr from frame variable

aprantl created this revision. aprantl added a reviewer: jingham. Herald added a project: LLDB. by respecting the "artificial" attribute on variables. Function arguments that are artificial and useful to end-users are being whitelisted by the language runtime. Repository: rG LLVM Github Mono

[Lldb-commits] [PATCH] D61361: PluginInstructionARM: avoid unnecessary link

compnerd added a comment. @labath - but that is the reality of this: there *are* two classes of dependencies. I think that if we try to split up all the modules into linked libraries and header-only libraries, we are going to make an even bigger mess than what we have. Repository: rLLDB LL

[Lldb-commits] [PATCH] D61439: [lldb] [lit] Add write tests for AVX-512 registers (zmm, xmm15+, ymm15+)

mgorny added a comment. Thanks. Now you'll have proper motivation to add AVX-512 support to Linux ;-). Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61439/new/ https://reviews.llvm.org/D61439 ___ lldb-commits maili

[Lldb-commits] [PATCH] D61439: [lldb] [lit] Add write tests for AVX-512 registers (zmm, xmm15+, ymm15+)

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB359797: [lldb] [lit] Add write tests for AVX-512 registers (zmm, xmm15+, ymm15+) (authored by mgorny, committed by ). Herald added a subscriber: teemperor. Herald added a project: LLDB. Changed prior t

[Lldb-commits] [lldb] r359797 - [lldb] [lit] Add write tests for AVX-512 registers (zmm, xmm15+, ymm15+)

Author: mgorny Date: Thu May 2 09:10:35 2019 New Revision: 359797 URL: http://llvm.org/viewvc/llvm-project?rev=359797&view=rev Log: [lldb] [lit] Add write tests for AVX-512 registers (zmm, xmm15+, ymm15+) Differential Revision: https://reviews.llvm.org/D61439 Added: lldb/trunk/lit/Register/

[Lldb-commits] [PATCH] D61360: Initialization: remove ObjectContainer from Common

compnerd added inline comments. Comment at: source/API/SystemInitializerFull.cpp:132-133 + ObjectContainerBSDArchive::Initialize(); + ObjectContainerUniversalMachO::Initialize(); + labath wrote: > xiaobai wrote: > > You need to include the headers for these c

[Lldb-commits] [PATCH] D61360: Initialization: remove ObjectContainer from Common

compnerd updated this revision to Diff 197797. compnerd marked 6 inline comments as done. compnerd added a comment. address feedback Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61360/new/ https://reviews.llvm.org/D61360 Files: source/API/SystemInitializerF

[Lldb-commits] [PATCH] D61439: [lldb] [lit] Add write tests for AVX-512 registers (zmm, xmm15+, ymm15+)

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. The tests look fine to me, but given that mac doesn't support writing to ymm registers, I'd be surprised if these were to pass too (so I'd add system-darwin to the list of XFAILs too). At tha

[Lldb-commits] [lldb] r359795 - Reinstate xfail-darwin in x86-64-ymm-write.test

Author: labath Date: Thu May 2 08:38:09 2019 New Revision: 359795 URL: http://llvm.org/viewvc/llvm-project?rev=359795&view=rev Log: Reinstate xfail-darwin in x86-64-ymm-write.test It turns out writing into ymm registers really does not work there. Modified: lldb/trunk/lit/Register/x86-64-ym

[Lldb-commits] [PATCH] D61361: PluginInstructionARM: avoid unnecessary link

labath added a comment. Or another thing: if one sees a header from module X being included in file Y, then it's reasonable to assume it's fair game to include another file from the same module X is fair game. But this creates a two classes of header files: files in X, which don't have a link d

[Lldb-commits] [PATCH] D61361: PluginInstructionARM: avoid unnecessary link

compnerd added a comment. @labath - I don't have a problem with the dependency - we can do a `add_dependency` for the plugin. My issue is that this should not be linked against. This mess of dependencies makes it difficult to track down the bloat in `lldb-server`. Currently, `lldb-server` we

[Lldb-commits] [PATCH] D61361: PluginInstructionARM: avoid unnecessary link

compnerd updated this revision to Diff 197793. compnerd added a comment. convert link to a proper dependency Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61361/new/ https://reviews.llvm.org/D61361 Files: source/Plugins/Instruction/ARM/CMakeLists.txt Index

[Lldb-commits] [PATCH] D61361: PluginInstructionARM: avoid unnecessary link

labath added a comment. My point is that we shouldn't need to differentiate between "link" dependencies and "other" dependencies, as it's not a well-defined boundary. It's easy to turn one into the other by moving things in or out of line. Hence my suggestion - move the required things into a d

[Lldb-commits] [lldb] r359794 - Fix the compile RUN line in x86-64-ymm-write.test

Author: labath Date: Thu May 2 08:16:01 2019 New Revision: 359794 URL: http://llvm.org/viewvc/llvm-project?rev=359794&view=rev Log: Fix the compile RUN line in x86-64-ymm-write.test Optimistically assuming this was the result of the darwin failure too, so removing the XFAIL there. Modified:

[Lldb-commits] [PATCH] D61292: Include inlined functions when figuring out a contiguous address range

clayborg added a comment. Jim: this is a modified version of the patch we had talked about a while ago with needed fixes for making sure the inline function call site is the same as the starting file and line. We have iterated on this locally already, so I am good with this patch. Let us know w

[Lldb-commits] [PATCH] D61423: MinidumpYAML: add support for the ThreadList stream

clayborg added a comment. lgtm Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61423/new/ https://reviews.llvm.org/D61423 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[Lldb-commits] [lldb] r359787 - [lldb] [lit] Mark x86-64-ymm-write XFAIL on Darwin

Author: mgorny Date: Thu May 2 07:03:42 2019 New Revision: 359787 URL: http://llvm.org/viewvc/llvm-project?rev=359787&view=rev Log: [lldb] [lit] Mark x86-64-ymm-write XFAIL on Darwin Modified: lldb/trunk/lit/Register/x86-64-ymm-write.test Modified: lldb/trunk/lit/Register/x86-64-ymm-write.t

[Lldb-commits] [PATCH] D61439: [lldb] [lit] Add write tests for AVX-512 registers (zmm, xmm15+, ymm15+)

mgorny updated this revision to Diff 197772. mgorny retitled this revision from "[lldb] [lit] Add write tests for ZMM registers" to "[lldb] [lit] Add write tests for AVX-512 registers (zmm, xmm15+, ymm15+)". mgorny added a comment. Added xmm15+ and ymm15+ tests. CHANGES SINCE LAST ACTION ht

[Lldb-commits] [PATCH] D61440: C.128 override, virtual keyword handling

kkleine created this revision. Herald added subscribers: lldb-commits, kadircet, arphaman. Herald added a project: LLDB. According to [C128] "Virtual functions should specify exactly one of `virtual`, `override`, or `final`", I've added override where a virtual function is overriden but the explic

[Lldb-commits] [PATCH] D61439: [lldb] [lit] Add write tests for ZMM registers

mgorny created this revision. mgorny added reviewers: labath, JDevlieghere, krytarowski. As before, it's only build-tested as I don't have access to any AVX512-capable hardware. https://reviews.llvm.org/D61439 Files: lldb/lit/Register/Inputs/x86-zmm-write.cpp lldb/lit/Register/x86-64-zmm-w

[Lldb-commits] [PATCH] D61431: [lldb] [lit] Introduce tests for writing YMM registers

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB359783: [lldb] [lit] Introduce tests for writing YMM registers (authored by mgorny, committed by ). Herald added a subscriber: teemperor. Herald added a project: LLDB. Changed prior to commit: https:

[Lldb-commits] [lldb] r359784 - [lldb] [lit] Use LLDB-like output for XMM registers in write tests

Author: mgorny Date: Thu May 2 05:55:54 2019 New Revision: 359784 URL: http://llvm.org/viewvc/llvm-project?rev=359784&view=rev Log: [lldb] [lit] Use LLDB-like output for XMM registers in write tests Modified: lldb/trunk/lit/Register/Inputs/x86-64-write.cpp lldb/trunk/lit/Register/Inputs/

[Lldb-commits] [lldb] r359783 - [lldb] [lit] Introduce tests for writing YMM registers

Author: mgorny Date: Thu May 2 05:55:44 2019 New Revision: 359783 URL: http://llvm.org/viewvc/llvm-project?rev=359783&view=rev Log: [lldb] [lit] Introduce tests for writing YMM registers Differential Revision: https://reviews.llvm.org/D61431 Added: lldb/trunk/lit/Register/Inputs/x86-ymm-wri

[Lldb-commits] [PATCH] D61431: [lldb] [lit] Introduce tests for writing YMM registers

mgorny updated this revision to Diff 197760. mgorny added a comment. Switch test output to resemble LLDB output more. However, I've added extra space around `{` and `}` to make output routine simpler. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61431/new/ https://reviews.llvm.org/D61

[Lldb-commits] [PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

martong created this revision. martong added reviewers: shafik, teemperor, aprantl, a_sidorin, balazske. Herald added subscribers: lldb-commits, cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added projects: clang, LLDB. This is the final phase of

[Lldb-commits] [PATCH] D61376: [lldb] [lit] Split 'register read' tests between zmm*, xmm16+, ymm16+

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB359780: [lldb] [lit] Split 'register read' tests between zmm*, xmm16+, ymm16+ (authored by mgorny, committed by ). Herald added a subscriber: teemperor. Herald added a project: LLDB. Changed prior to c

[Lldb-commits] [lldb] r359780 - [lldb] [lit] Split 'register read' tests between zmm*, xmm16+, ymm16+

Author: mgorny Date: Thu May 2 04:26:30 2019 New Revision: 359780 URL: http://llvm.org/viewvc/llvm-project?rev=359780&view=rev Log: [lldb] [lit] Split 'register read' tests between zmm*, xmm16+, ymm16+ Since Darwin target implements support for zmm* registers without matching support for the res

[Lldb-commits] [PATCH] D61305: Add std::stack and std::queue support to CxxModuleHandler

This revision was automatically updated to reflect the committed changes. Closed by commit rL359779: Add std::stack and std::queue support to CxxModuleHandler (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r359779 - Add std::stack and std::queue support to CxxModuleHandler

Author: teemperor Date: Thu May 2 04:25:50 2019 New Revision: 359779 URL: http://llvm.org/viewvc/llvm-project?rev=359779&view=rev Log: Add std::stack and std::queue support to CxxModuleHandler Reviewers: aprantl, shafik Reviewed By: aprantl, shafik Subscribers: lldb-commits Tags: #c_modules_i

[Lldb-commits] [PATCH] D61431: [lldb] [lit] Introduce tests for writing YMM registers

mgorny created this revision. mgorny added reviewers: labath, JDevlieghere, krytarowski. https://reviews.llvm.org/D61431 Files: lldb/lit/Register/Inputs/x86-ymm-write.cpp lldb/lit/Register/x86-64-ymm-write.test lldb/lit/Register/x86-ymm-write.test Index: lldb/lit/Register/x86-ymm-write.tes

[Lldb-commits] [PATCH] D61299: Rename Minion to ASTImporterDelegate

This revision was automatically updated to reflect the committed changes. Closed by commit rL359777: Rename Minion to ASTImporterDelegate (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

[Lldb-commits] [lldb] r359777 - Rename Minion to ASTImporterDelegate

Author: teemperor Date: Thu May 2 03:58:33 2019 New Revision: 359777 URL: http://llvm.org/viewvc/llvm-project?rev=359777&view=rev Log: Rename Minion to ASTImporterDelegate Summary: I think there universal agreement that Minion isn't the best name for this class. This patch renames the class to

[Lldb-commits] [PATCH] D61266: Skip TestClassTemplateParameterPack.py on all platforms

teemperor closed this revision. teemperor added a comment. This has been merged as rLLDB359699 but somehow Phabriactor hasn't figured out yet that this needs to be closed. Closing this manually. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61266/

[Lldb-commits] [PATCH] D46551: Inject only relevant local variables in the expression evaluation context

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB359773: Inject only relevant local variables in the expression evaluation context (authored by teemperor, committed by ). Changed prior to commit: https://reviews.llvm.org/D46551?vs=196965&id=197729#

[Lldb-commits] [lldb] r359773 - Inject only relevant local variables in the expression evaluation context

Author: teemperor Date: Thu May 2 03:12:56 2019 New Revision: 359773 URL: http://llvm.org/viewvc/llvm-project?rev=359773&view=rev Log: Inject only relevant local variables in the expression evaluation context Summary: In r259902, LLDB started injecting all the locals in every expression evaluati

[Lldb-commits] [PATCH] D61299: Rename Minion to ASTImporterDelegate

teemperor updated this revision to Diff 197728. teemperor added a comment. - Added documentation. - Fixed more references to 'minion' pointed out in the review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61299/new/ https://reviews.llvm.org/D61299 Files: lldb/include/lldb/Symbol/Cl

[Lldb-commits] [PATCH] D61311: PostfixExpression: Use signed integers in IntegerNode

labath marked an inline comment as done. labath added inline comments. Comment at: include/lldb/Symbol/PostfixExpression.h:97 private: - uint32_t m_value; + int64_t m_value; }; clayborg wrote: > Do we want to try and use lldb_private::Scalar here? Then this c

[Lldb-commits] [lldb] r359765 - Fix MSVC build

Author: labath Date: Thu May 2 01:52:06 2019 New Revision: 359765 URL: http://llvm.org/viewvc/llvm-project?rev=359765&view=rev Log: Fix MSVC build Address an ambiguity between lldb_private::Thread and llvm::minidump::Thread. Follow-up to llvm r359762 (which introduced the second type). Modified

[Lldb-commits] [PATCH] D61423: MinidumpYAML: add support for the ThreadList stream

labath created this revision. labath added reviewers: amccarth, jhenderson, clayborg. Herald added a project: LLVM. The implementation is a pretty straightforward extension of the pattern used for (de)serializing the ModuleList stream. Since there are other streams which use the same format (Memor

[Lldb-commits] [PATCH] D61361: PluginInstructionARM: avoid unnecessary link

labath added a comment. I don't think this is a good way to solve this problem. The llvm's definition of dependencies http://llvm.org/docs/CodingStandards.html#library-layering explicitly that it is not the same as "the thing that's needed to make linkers happy" (emphasis mine): One library

[Lldb-commits] [PATCH] D61064: Object/Minidump: Add support for the ThreadList stream

labath marked 2 inline comments as done. labath added a comment. Thanks for the review. Comment at: unittests/Object/MinidumpTest.cpp:446 + + for (const std::vector &Data : {OneThread, PaddedThread}) { +auto ExpectedFile = create(Data); jhenderson wrote: >

[Lldb-commits] [PATCH] D61064: Object/Minidump: Add support for the ThreadList stream

This revision was automatically updated to reflect the committed changes. Closed by commit rL359762: Object/Minidump: Add support for the ThreadList stream (authored by labath, committed by ). Changed prior to commit: https://reviews.llvm.org/D61064?vs=196435&id=197710#toc Repository: rL LLV

[Lldb-commits] [PATCH] D61376: [lldb] [lit] Split 'register read' tests between zmm*, xmm16+, ymm16+

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thanks for splitting these. Since we deleted the zmm dotest tests, I think it's important to do this so we don't regress test coverage on darwin. (But somebody on the darwin side should take a

Re: [Lldb-commits] [lldb] r359730 - [lldb-server] Remove lldb-server's dependency on Core

On 01/05/2019 23:41, Alex Langford via lldb-commits wrote: Author: xiaobai Date: Wed May 1 14:41:40 2019 New Revision: 359730 URL: http://llvm.org/viewvc/llvm-project?rev=359730&view=rev Log: [lldb-server] Remove lldb-server's dependency on Core No need to directly link against Core, as lldb-s

[Lldb-commits] [PATCH] D61360: Initialization: remove ObjectContainer from Common

labath added inline comments. Comment at: source/API/CMakeLists.txt:99-100 lldbUtility +lldbPluginObjectContainerBSDArchive +lldbPluginObjectContainerMachOArchive ${LLDB_ALL_PLUGINS} xiaobai wrote: > These should get sucked into LLDB_ALL_PLUGINS