[Lldb-commits] [lldb] r360646 - ARMDefines.h: fix -Wimplicit-fallthrough in -DLLVM_ENABLE_ASSERTIONS=OFF builds

Author: maskray Date: Mon May 13 21:09:52 2019 New Revision: 360646 URL: http://llvm.org/viewvc/llvm-project?rev=360646=rev Log: ARMDefines.h: fix -Wimplicit-fallthrough in -DLLVM_ENABLE_ASSERTIONS=OFF builds Reviewed By: JDevlieghere Differential Revision: https://reviews.llvm.org/D61844

[Lldb-commits] [PATCH] D61776: [Target] Generalize some behavior in Thread

xiaobai updated this revision to Diff 199364. xiaobai added a comment. - Fix minor bug in ItaniumABILanguageRuntime - Modify test to accomodate new behavior CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61776/new/ https://reviews.llvm.org/D61776 Files:

[Lldb-commits] [PATCH] D61687: Update Python tests for lldb-server on Windows

Hui added inline comments. Comment at: packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemoteModuleInfo.py:24-27 +# Replace path separators in the json string either with "" or "/" on Windows. +triple = self.dbg.GetSelectedPlatform().GetTriple() +

[Lldb-commits] [lldb] r360641 - LLDB website: Change the title back to "The LLDB Debugger"

Author: adrian Date: Mon May 13 19:31:56 2019 New Revision: 360641 URL: http://llvm.org/viewvc/llvm-project?rev=360641=rev Log: LLDB website: Change the title back to "The LLDB Debugger" This is what the old homepage also used. Modified: lldb/trunk/docs/conf.py lldb/trunk/docs/index.rst

[Lldb-commits] [PATCH] D61776: [Target] Generalize some behavior in Thread

xiaobai added a comment. Unfortunately I can't land this patch as-is. With this patch applied, TestObjCExceptions fails. It looks like c++ exceptions are supported at the bare minimum as a part of the objc exception handling logic. It was failing 2 subtests: `test_objc_exceptions_at_throw` and

[Lldb-commits] [lldb] r360638 - [Docs] Differentiate between public and private API

Author: jdevlieghere Date: Mon May 13 17:36:05 2019 New Revision: 360638 URL: http://llvm.org/viewvc/llvm-project?rev=360638=rev Log: [Docs] Differentiate between public and private API On the homepage we should have a clear distinction between the public and private C++ APIs. Modified:

[Lldb-commits] [PATCH] D61877: [CMake] Add error to clarify that lldb requires libcxx

JDevlieghere added inline comments. Comment at: lldb/CMakeLists.txt:127 else() +if(NOT libcxx IN_LIST LLVM_ENABLE_PROJECTS) + message(FATAL_ERROR Should we check that LLVM_ENABLE_PROJECTS is not empty, for people that are still using the

[Lldb-commits] [PATCH] D61877: [CMake] Add error to clarify that lldb requires libcxx

jryans created this revision. jryans added reviewers: sgraenitz, JDevlieghere. Herald added a subscriber: mgorny. Herald added a reviewer: EricWF. Herald added a project: LLDB. This adds a specific error message to clarify that lldb requires libcxx when built together with clang on macOS. In

[Lldb-commits] [lldb] r360632 - [Docs] Fix code formattign in variable.rst

Author: jdevlieghere Date: Mon May 13 16:05:51 2019 New Revision: 360632 URL: http://llvm.org/viewvc/llvm-project?rev=360632=rev Log: [Docs] Fix code formattign in variable.rst Fixes missing newline between :: and the actual code. Modified: lldb/trunk/docs/use/variable.rst Modified:

[Lldb-commits] [lldb] r360631 - [CMake] Reinstate LLDB_CAN_USE_LLDB_SERVER

Author: jdevlieghere Date: Mon May 13 15:55:11 2019 New Revision: 360631 URL: http://llvm.org/viewvc/llvm-project?rev=360631=rev Log: [CMake] Reinstate LLDB_CAN_USE_LLDB_SERVER We cannot manipulate the LLDB_TOOL_LLDB_SERVER_BUILD directly from LLDBConfig.cmake because this would set the variable

[Lldb-commits] [lldb] r360624 - Disable TestEnvironment on Windows

Author: jdevlieghere Date: Mon May 13 15:02:09 2019 New Revision: 360624 URL: http://llvm.org/viewvc/llvm-project?rev=360624=rev Log: Disable TestEnvironment on Windows The input source file seems to be triggering an error in the Visual Studio headers. > xstddef:338:2: error: ''auto' return

[Lldb-commits] [PATCH] D61833: Fix IPv6 support on lldb-server platform

aadsm updated this revision to Diff 199331. aadsm added a comment. Use functions instead of subclassing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61833/new/ https://reviews.llvm.org/D61833 Files:

[Lldb-commits] [PATCH] D61872: [CMake] Simplify lldb-server handling

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61872/new/ https://reviews.llvm.org/D61872 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D61872: [CMake] Simplify lldb-server handling

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB360621: [CMake] Simplify lldb-server handling (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D61872?vs=199327=199328#toc Repository: rLLDB LLDB

[Lldb-commits] [PATCH] D61872: [CMake] Simplify lldb-server handling

davide added inline comments. Comment at: lldb/tools/CMakeLists.txt:12 add_lldb_tool_subdirectory(lldb-mi) +add_lldb_tool_subdirectory(lldb-server) add_lldb_tool_subdirectory(lldb-vscode) This probably predates the use of `add_lldb_tool_subdirectory` in lldb.

[Lldb-commits] [lldb] r360621 - [CMake] Simplify lldb-server handling

Author: jdevlieghere Date: Mon May 13 14:25:02 2019 New Revision: 360621 URL: http://llvm.org/viewvc/llvm-project?rev=360621=rev Log: [CMake] Simplify lldb-server handling We can piggyback off the existing add_lldb_tool_subdirectory to decide whether or not lldb-server should be built.

[Lldb-commits] [PATCH] D61872: [CMake] Simplify lldb-server handling

JDevlieghere updated this revision to Diff 199327. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61872/new/ https://reviews.llvm.org/D61872 Files: lldb/cmake/modules/LLDBConfig.cmake lldb/tools/CMakeLists.txt lldb/unittests/tools/CMakeLists.txt Index:

[Lldb-commits] [PATCH] D61864: Merge target and launch info environments

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB360612: Merge target and launch info environments (authored by JDevlieghere, committed by ). Herald added a subscriber: teemperor. Changed prior to commit:

[Lldb-commits] [lldb] r360612 - Merge target and launch info environments

Author: jdevlieghere Date: Mon May 13 12:17:48 2019 New Revision: 360612 URL: http://llvm.org/viewvc/llvm-project?rev=360612=rev Log: Merge target and launch info environments Before this change we were overriding the launch info environment with the target environment. This meant that the

[Lldb-commits] [lldb] r360611 - Remove commented-out code

Author: jdevlieghere Date: Mon May 13 12:17:44 2019 New Revision: 360611 URL: http://llvm.org/viewvc/llvm-project?rev=360611=rev Log: Remove commented-out code Modified: lldb/trunk/source/Commands/CommandObjectProcess.cpp Modified: lldb/trunk/source/Commands/CommandObjectProcess.cpp URL:

[Lldb-commits] [PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

aprantl added inline comments. Comment at: clang/include/clang/AST/ASTImporter.h:203 /// context, or the import error. -llvm::Expected Import_New(TypeSourceInfo *FromTSI); -// FIXME: Remove this version. -TypeSourceInfo *Import(TypeSourceInfo *FromTSI); +

[Lldb-commits] [PATCH] D61864: Merge target and launch info environments

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. The fix looks good, but it seems like it wouldn't be hard to make the test windows-compatible, so I think we should do that. All it would take is to compile a very dumb version of "env" which

[Lldb-commits] [PATCH] D61602: Handle function parameters of RunCommandInterpreter (script bridge)

lubgr added a comment. No, I don't have the permissions. Thanks in advance for comitting this. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61602/new/ https://reviews.llvm.org/D61602 ___ lldb-commits mailing list

Re: [Lldb-commits] [lldb] r360564 - @skipIfLinux flaky lldb-mi tests

Hi, Unfortunately, the next few months I'll be busy with my bachelor's thesis, so I can't dive into that problem right now. I've just tested lldb-mi on Ubuntu Linux 18.04 and it seems that there is some race condition somewhere in lldb-mi or lldb's core, I ran lldb-mi's LIT test suite for five

[Lldb-commits] [PATCH] D61864: Merge target and launch info environments

JDevlieghere created this revision. JDevlieghere added reviewers: labath, aprantl, davide. Herald added a project: LLDB. Before this change we were overriding the launch info environment with the target environment. This meant that the environment variables passed to `process launch

[Lldb-commits] [PATCH] D61805: Add nullptr check in FindLibCppStdFunctionCallableInfo()

aprantl added inline comments. Comment at: source/Target/CPPLanguageRuntime.cpp:217 if (symbol != NULL && symbol->GetName().GetStringRef().contains("__invoke")) { davide wrote: > This should probably be `nullptr`, anyway, my general comment is

[Lldb-commits] [PATCH] D61602: Handle function parameters of RunCommandInterpreter (script bridge)

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Excellent, thanks! Can you check this in or do you need me to? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61602/new/ https://reviews.llvm.org/D61602

[Lldb-commits] [PATCH] D61759: Switch to FindSymbolsMatchingRegExAndType() from FindFunctions() in FindLibCppStdFunctionCallableInfo()

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB360599: [DataFormatters] FindLibCppStdFunctionCallableInfo() currently uses… (authored by shafik, committed by ). Herald added a project: LLDB. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] r360599 - [DataFormatters] FindLibCppStdFunctionCallableInfo() currently uses FindFunctions() in order to find a lambdas operator()() but using FindSymbolsMatchingRegExAndType()

Author: shafik Date: Mon May 13 09:48:06 2019 New Revision: 360599 URL: http://llvm.org/viewvc/llvm-project?rev=360599=rev Log: [DataFormatters] FindLibCppStdFunctionCallableInfo() currently uses FindFunctions() in order to find a lambdas operator()() but using FindSymbolsMatchingRegExAndType()

[Lldb-commits] [PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

martong added a comment. @aprantl Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61438/new/ https://reviews.llvm.org/D61438 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r360587 - [NativePDB] Fix tests after r360569

Author: aleksandr.urakov Date: Mon May 13 08:06:13 2019 New Revision: 360587 URL: http://llvm.org/viewvc/llvm-project?rev=360587=rev Log: [NativePDB] Fix tests after r360569 Modified: lldb/trunk/lit/SymbolFile/NativePDB/stack_unwinding01.cpp Modified:

[Lldb-commits] [PATCH] D60963: Fix dereferencing null pointer

thakis added a comment. Add a test that fails without the code change and that passes with it. I don't know under which conditions this change is needed, so I apologize that I can't make a more concrete suggestion. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] r360583 - DWARF/DIERef: remove non-const operator

Author: labath Date: Mon May 13 06:52:40 2019 New Revision: 360583 URL: http://llvm.org/viewvc/llvm-project?rev=360583=rev Log: DWARF/DIERef: remove non-const operator< It serves no purpose as one can always invoke the const version instead. Modified:

[Lldb-commits] [PATCH] D61128: Support member function types in PdbAstBuilder

labath added a comment. Looks like this is failing on the windows bot. Looking at the test, it seems that you are asserting that you will unwind into a particular offset in ntdll.dll. That sounds like an incredibly fragile assertion, which will only be true for people running the exact same

[Lldb-commits] [PATCH] D61853: [FuncUnwinders] Use "symbol file" unwind plans for unwinding

labath created this revision. labath added reviewers: jasonmolenda, clayborg. Previous patch (r360409) introduced the "symbol file unwind plan" concept, but that plan wasn't used for unwinding yet. With this patch, we start to consider the new plan as a possible strategy for both synchronous and

[Lldb-commits] [lldb] r360576 - Add REQUIRES: windows to NativePDB/stack_unwinding01.cpp

Author: labath Date: Mon May 13 04:32:52 2019 New Revision: 360576 URL: http://llvm.org/viewvc/llvm-project?rev=360576=rev Log: Add REQUIRES: windows to NativePDB/stack_unwinding01.cpp The test runs the compiled executable. As such, it can only work on windows hosts. Modified:

[Lldb-commits] [PATCH] D61733: Breakpad: Generate unwind plans from STACK CFI records

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB360574: Breakpad: Generate unwind plans from STACK CFI records (authored by labath, committed by ). Herald added a subscriber: abidh. Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] r360574 - Breakpad: Generate unwind plans from STACK CFI records

Author: labath Date: Mon May 13 04:25:35 2019 New Revision: 360574 URL: http://llvm.org/viewvc/llvm-project?rev=360574=rev Log: Breakpad: Generate unwind plans from STACK CFI records Summary: This patch implements the GetUnwindPlan interface (added in the previous patch) for SymbolFileBreakpad,

[Lldb-commits] [PATCH] D61611: [JITLoaderGDB] Set eTypeJIT for objects read from JIT descriptors

sgraenitz added a comment. > It looks like this test is flaky [...] what would you say to just deleting > the "# CHECK: 1 location added to breakpoint 1" line from the test? Thanks for reporting and explaining. Sounds like a reasonable change. Pushed with rL360571

[Lldb-commits] [lldb] r360569 - [NativePDB] Support member function types in PdbAstBuilder

Author: aleksandr.urakov Date: Mon May 13 02:41:57 2019 New Revision: 360569 URL: http://llvm.org/viewvc/llvm-project?rev=360569=rev Log: [NativePDB] Support member function types in PdbAstBuilder Summary: This patch implements missing case in PdbAstBuilder::CreateType for

[Lldb-commits] [lldb] r360568 - minidump: Use yaml instead of checked-in binaries for ThreadList tests

Author: labath Date: Mon May 13 02:35:00 2019 New Revision: 360568 URL: http://llvm.org/viewvc/llvm-project?rev=360568=rev Log: minidump: Use yaml instead of checked-in binaries for ThreadList tests yaml2obj now supports the ThreadList stream. Removed:

[Lldb-commits] [PATCH] D61611: [JITLoaderGDB] Set eTypeJIT for objects read from JIT descriptors

labath added a comment. It looks like this test is flaky: http://lab.llvm.org:8014/builders/lldb-x86_64-debian/builds/1339/steps/test/logs/stdio http://lab.llvm.org:8014/builders/lldb-x86_64-debian/builds/1294/steps/test/logs/stdio The failure messages I've seen are all the same and seem to

Re: [Lldb-commits] [lldb] r360564 - @skipIfLinux flaky lldb-mi tests

On 13/05/2019 11:00, Raphael Isemann wrote: These tests are now SkipIf Windows, FreeBSD, Darwin AND Linux :( So unless someone sets up a Minix or GNU Hurd bot these tests are never run. Yeah, the state of lldb-mi is... sad :/ CC'ing Alexander who was IIRC able to fix these tests in the

[Lldb-commits] [PATCH] D60962: [NativePDB] Extend .pdb files search folders

zloyrobot added a comment. In D60962#1477160 , @amccarth wrote: > Thanks Pavel! > > Please address Pavel's inline comments, and I'll accept this. Kind reminder Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60962/new/

[Lldb-commits] [PATCH] D60963: Fix dereferencing null pointer

zloyrobot added a comment. kind reminder Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60963/new/ https://reviews.llvm.org/D60963 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D61128: Support member function types in PdbAstBuilder

zloyrobot added a comment. In D61128#1483663 , @zloyrobot wrote: > In D61128#1482765 , @amccarth wrote: > > > Thanks for the improved commit message. Again, sorry about the delay. > > > No problem, thanks for

Re: [Lldb-commits] [lldb] r360564 - @skipIfLinux flaky lldb-mi tests

These tests are now SkipIf Windows, FreeBSD, Darwin AND Linux :( So unless someone sets up a Minix or GNU Hurd bot these tests are never run. CC'ing Alexander who was IIRC able to fix these tests in the past, so maybe he has an idea what's going on. - Raphael Am Mo., 13. Mai 2019 um 10:45 Uhr

[Lldb-commits] [PATCH] D61783: [DWARF] Use sequential integers for the IDs of the SymbolFileDWOs

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB360565: [DWARF] Use sequential integers for the IDs of the SymbolFileDWOs (authored by labath, committed by ). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] r360565 - [DWARF] Use sequential integers for the IDs of the SymbolFileDWOs

Author: labath Date: Mon May 13 01:58:34 2019 New Revision: 360565 URL: http://llvm.org/viewvc/llvm-project?rev=360565=rev Log: [DWARF] Use sequential integers for the IDs of the SymbolFileDWOs Summary: Instead of using the offset of the contained compile unit, we use it's ID. The goal of this

[Lldb-commits] [lldb] r360564 - @skipIfLinux flaky lldb-mi tests

Author: labath Date: Mon May 13 01:48:03 2019 New Revision: 360564 URL: http://llvm.org/viewvc/llvm-project?rev=360564=rev Log: @skipIfLinux flaky lldb-mi tests Modified: lldb/trunk/lit/tools/lldb-mi/breakpoint/break-insert.test lldb/trunk/lit/tools/lldb-mi/exec/exec-next.test

[Lldb-commits] [PATCH] D61833: Fix IPv6 support on lldb-server platform

labath added a comment. The actual change looks obviously correct. Below are my comments on the test situation. > I wanted to reuse the CreateConnectedSockets part of the SocketTests. > Initially I thought about creating a few functions in a test socket utility > file, but then I realized the

[Lldb-commits] [lldb] r360562 - Remove declaratons of deleted structs/classes

Author: maskray Date: Mon May 13 01:25:53 2019 New Revision: 360562 URL: http://llvm.org/viewvc/llvm-project?rev=360562=rev Log: Remove declaratons of deleted structs/classes Modified: lldb/trunk/include/lldb/lldb-forward.h Modified: lldb/trunk/include/lldb/lldb-forward.h URL: