[Lldb-commits] [PATCH] D61686: Enable lldb-server on Windows

JDevlieghere added inline comments. Comment at: cmake/modules/LLDBConfig.cmake:421 # ensure we build lldb-server when an lldb target is being built. -if (CMAKE_SYSTEM_NAME MATCHES "Android|Darwin|FreeBSD|Linux|NetBSD") +if (CMAKE_SYSTEM_NAME MATCHES "Android|Darwin|FreeBSD|Linux

[Lldb-commits] [lldb] r360753 - Replace assert with static_assert here applicable.

Author: jdevlieghere Date: Tue May 14 22:39:41 2019 New Revision: 360753 URL: http://llvm.org/viewvc/llvm-project?rev=360753&view=rev Log: Replace assert with static_assert here applicable. Replaces assert() with static_assert() if the condition is can be evaluated at compile time. Modified:

[Lldb-commits] [lldb] r360751 - Mark private unimplemented functions as deleted

Author: jdevlieghere Date: Tue May 14 22:31:14 2019 New Revision: 360751 URL: http://llvm.org/viewvc/llvm-project?rev=360751&view=rev Log: Mark private unimplemented functions as deleted Applies modernize-use-equals-delete to the LLDB code base and removes the now redundant comments. Modified:

[Lldb-commits] [PATCH] D61686: Enable lldb-server on Windows

asmith updated this revision to Diff 199555. asmith edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61686/new/ https://reviews.llvm.org/D61686 Files: cmake/modules/LLDBConfig.cmake source/Host/windows/Host.cpp source/Plugins/Process/gdb-remote/GDB

[Lldb-commits] [PATCH] D61687: Update Python tests for lldb-server on Windows

asmith updated this revision to Diff 199554. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61687/new/ https://reviews.llvm.org/D61687 Files: packages/Python/lldbsuite/test/dotest.py packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemoteAuxvSupport.py packages/Python/lldbsui

[Lldb-commits] [lldb] r360748 - [Docs] Document lldb-dotest

Author: jdevlieghere Date: Tue May 14 21:42:30 2019 New Revision: 360748 URL: http://llvm.org/viewvc/llvm-project?rev=360748&view=rev Log: [Docs] Document lldb-dotest Document the lldb-dotest binary. Modified: lldb/trunk/docs/resources/test.rst Modified: lldb/trunk/docs/resources/test.rst U

[Lldb-commits] [lldb] r360745 - Revert "build: use the correct variable"

Author: compnerd Date: Tue May 14 20:57:07 2019 New Revision: 360745 URL: http://llvm.org/viewvc/llvm-project?rev=360745&view=rev Log: Revert "build: use the correct variable" This reverts commit b5a8abd57f23e2f621d5ceb0f64f1bb8f9579c3f. This should not be needed as the lldb-server tool will add

[Lldb-commits] [lldb] r360744 - [lldb] [lit] Fix whitespace in matches for remaining AVX512 tests

Author: mgorny Date: Tue May 14 20:32:47 2019 New Revision: 360744 URL: http://llvm.org/viewvc/llvm-project?rev=360744&view=rev Log: [lldb] [lit] Fix whitespace in matches for remaining AVX512 tests Modified: lldb/trunk/lit/Register/x86-64-xmm16-read.test lldb/trunk/lit/Register/x86-64-ym

[Lldb-commits] [PATCH] D61776: [Target] Generalize some behavior in Thread

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB360741: [Target] Generalize some behavior in Thread (authored by xiaobai, committed by ). Herald added a subscriber: teemperor. Herald added a project: LLDB. Changed prior to commit: https://reviews.

[Lldb-commits] [lldb] r360741 - [Target] Generalize some behavior in Thread

Author: xiaobai Date: Tue May 14 18:46:45 2019 New Revision: 360741 URL: http://llvm.org/viewvc/llvm-project?rev=360741&view=rev Log: [Target] Generalize some behavior in Thread Summary: I don't think there's a good reason for this behavior to be considered ObjC-specific. We can generalize this.

[Lldb-commits] [PATCH] D61921: [Target] Generalize language-specific behavior in ThreadPlanStepThrough

xiaobai added a comment. In D61921#1502338 , @jingham wrote: > Getting it from the Process's m_language_runtimes is probably fine. On > reflection, I can't think of a reason why you would want to iterate over all > the available LanguageRuntimes, includ

[Lldb-commits] [PATCH] D61921: [Target] Generalize language-specific behavior in ThreadPlanStepThrough

jingham added a comment. Getting it from the Process's m_language_runtimes is probably fine. On reflection, I can't think of a reason why you would want to iterate over all the available LanguageRuntimes, including the ones that hadn't been recognized in this Process yet. It's fine to do that

[Lldb-commits] [PATCH] D61921: [Target] Generalize language-specific behavior in ThreadPlanStepThrough

xiaobai added a comment. In D61921#1502254 , @jingham wrote: > There is a TypeSystemEnumerateSupportedLanguages that we use so that we don't > have to enumerate over all the language in the languages enums. After all > the plugin manager knows which lan

[Lldb-commits] [PATCH] D61602: Handle function parameters of RunCommandInterpreter (script bridge)

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB360730: Make SBDebugger.RunCommandInterpreter callable from Python. (authored by jingham, committed by ). Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61602/new/ htt

[Lldb-commits] [lldb] r360730 - Make SBDebugger.RunCommandInterpreter callable from Python.

Author: jingham Date: Tue May 14 17:08:55 2019 New Revision: 360730 URL: http://llvm.org/viewvc/llvm-project?rev=360730&view=rev Log: Make SBDebugger.RunCommandInterpreter callable from Python. Authored by: Lukas Boger Differential Revision: https://reviews.llvm.org/D61602 Added: lldb/trun

[Lldb-commits] [PATCH] D61921: [Target] Generalize language-specific behavior in ThreadPlanStepThrough

jingham added a comment. There is a TypeSystemEnumerateSupportedLanguages that we use so that we don't have to enumerate over all the language in the languages enums. After all the plugin manager knows which languages we have type systems for. If you're going to be doing a lot of this general

[Lldb-commits] [lldb] r360725 - [lit/Register] Fix matching of the output.

Author: davide Date: Tue May 14 16:17:12 2019 New Revision: 360725 URL: http://llvm.org/viewvc/llvm-project?rev=360725&view=rev Log: [lit/Register] Fix matching of the output. Modified: lldb/trunk/lit/Register/x86-64-zmm-read.test Modified: lldb/trunk/lit/Register/x86-64-zmm-read.test URL:

[Lldb-commits] [PATCH] D61921: [Target] Generalize language-specific behavior in ThreadPlanStepThrough

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM! Comment at: source/Target/ThreadPlanStepThrough.cpp:91 + if (!m_sub_plan_sp) { +for (unsigned lang = eLanguageTypeUnknown; + !m_sub_plan_sp &&

[Lldb-commits] [PATCH] D61921: [Target] Generalize language-specific behavior in ThreadPlanStepThrough

xiaobai marked 2 inline comments as done. xiaobai added inline comments. Comment at: source/Target/ThreadPlanStepThrough.cpp:91 + if (!m_sub_plan_sp) { +for (unsigned lang = eLanguageTypeUnknown; + !m_sub_plan_sp && lang < eNumLanguageTypes; lang++) { ---

[Lldb-commits] [PATCH] D61921: [Target] Generalize language-specific behavior in ThreadPlanStepThrough

JDevlieghere added inline comments. Comment at: source/Target/ThreadPlanStepThrough.cpp:91 + if (!m_sub_plan_sp) { +for (unsigned lang = eLanguageTypeUnknown; + !m_sub_plan_sp && lang < eNumLanguageTypes; lang++) { Given that we seem to have this pa

[Lldb-commits] [PATCH] D61921: [Target] Generalize language-specific behavior in ThreadPlanStepThrough

xiaobai created this revision. xiaobai added reviewers: jingham, JDevlieghere. When creating a ThreadPlan to step through a trampoline, we ask the ObjC language runtime and the CPP language runtime to come up with such a thread plan if the dynamic loader fails to give us one. I don't see why this

[Lldb-commits] [PATCH] D61913: Get back the navigation sidebar on the LLDB website

aprantl added a comment. Do you think the fact that sphinx doesn't update the css will be a problem on lldb.llvm.org with the way the script is run? (ninja clean does not delete the html directory either). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61913/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D61913: [WIP] Get back the navigation sidebar on the LLDB website

aprantl updated this revision to Diff 199510. aprantl added a comment. Make Doxygen links in sidebar work. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61913/new/ https://reviews.llvm.org/D61913 Files: lldb/docs/_static/lldb.css lldb/docs/conf.py lldb/docs/index.rst Index: lldb

[Lldb-commits] [PATCH] D61913: [WIP] Get back the navigation sidebar on the LLDB website

aprantl marked an inline comment as done. aprantl added inline comments. Comment at: lldb/docs/index.rst:73 + * `Public Python API Reference `_ * `Public C++ API Reference

[Lldb-commits] [PATCH] D61913: [WIP] Get back the navigation sidebar on the LLDB website

aprantl created this revision. aprantl added a reviewer: JDevlieghere. Herald added subscribers: lldb-commits, arphaman. Herald added a project: LLDB. This is a little experiment to get back the navigation sidebar on the LLDB website like it used to be: https://web.archive.org/web/20170204135403

[Lldb-commits] [PATCH] D61913: [WIP] Get back the navigation sidebar on the LLDB website

aprantl marked an inline comment as done. aprantl added inline comments. Comment at: lldb/docs/_static/lldb.css:27 +div.sphinxsidebar h3, div.sphinxsidebar h4, +div.sphinxsidebar p, div.sphinxsidebar p a { This is copied & pasted from the old static website.

[Lldb-commits] [PATCH] D61502: Permit cross-CU references

jankratochvil updated this revision to Diff 199490. jankratochvil retitled this revision from "03/06: New CUDIERef" to "Permit cross-CU references". jankratochvil edited the summary of this revision. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61502/new/ https

[Lldb-commits] [PATCH] D61504: 05/06: Track CUs and TUs separately

jankratochvil abandoned this revision. jankratochvil added a comment. Obsoleted by: D61908 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61504/new/ https://reviews.llvm.org/D61504

[Lldb-commits] [PATCH] D61503: 04/06: Track .debug_types vs. .debug_info difference

jankratochvil abandoned this revision. jankratochvil added a comment. Obsoleted by: D61908 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61503/new/ https://reviews.llvm.org/D61503

[Lldb-commits] [PATCH] D61908: DWARF: Add ability to reference debug info coming from multiple sections

clayborg added a comment. See inline comments. Nice patch overall though, real close. Comment at: source/Plugins/SymbolFile/DWARF/DIERef.cpp:18 if (form_value.IsValid()) { const DWARFUnit *dwarf_cu = form_value.GetCompileUnit(); if (dwarf_cu) { We

Re: [Lldb-commits] [lldb] r360695 - build: use the correct variable

Hey Saleem, Why is this necessary after Pavel's change in r360652? Now that the LLDB_CAN_USE_LLDB_SERVER is defined correctly, the LLDB_TOOL_LLDB_SERVER_BUILD option should never be set. Thanks, Jonas On Tue, May 14, 2019 at 10:22 AM Saleem Abdulrasool via lldb-commits < lldb-commits@lists.llvm

Re: [Lldb-commits] [lldb] r360652 - [CMake] Correctly reinstate LLDB_CAN_USE_LLDB_SERVER

Thanks Pavel! On Tue, May 14, 2019 at 1:15 AM Pavel Labath via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: labath > Date: Tue May 14 01:18:06 2019 > New Revision: 360652 > > URL: http://llvm.org/viewvc/llvm-project?rev=360652&view=rev > Log: > [CMake] Correctly reinstate LLDB_CAN

[Lldb-commits] [lldb] r360695 - build: use the correct variable

Author: compnerd Date: Tue May 14 10:24:45 2019 New Revision: 360695 URL: http://llvm.org/viewvc/llvm-project?rev=360695&view=rev Log: build: use the correct variable Adjust the variable that controls whether the unit tests use `lldb-server`. This should repair the default build on Windows. Modi

[Lldb-commits] [lldb] r360693 - lldb-server: rename `llgs::terminate` (NFC)

Author: compnerd Date: Tue May 14 10:07:36 2019 New Revision: 360693 URL: http://llvm.org/viewvc/llvm-project?rev=360693&view=rev Log: lldb-server: rename `llgs::terminate` (NFC) `terminate` overlaps with a C function on Windows: ``` D:\a\1\s\lldb\tools\lldb-server\lldb-server.cpp(45,13): warni

[Lldb-commits] [PATCH] D61877: [CMake] Add error to clarify that lldb requires libcxx

sgraenitz accepted this revision. sgraenitz added a comment. This revision is now accepted and ready to land. Sure, will commit this on your behalf tomorrow. (If nothing else comes up.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61877/new/ https

[Lldb-commits] [lldb] r360691 - Rename MacOS X -> macOS where applicable.

Author: adrian Date: Tue May 14 09:37:43 2019 New Revision: 360691 URL: http://llvm.org/viewvc/llvm-project?rev=360691&view=rev Log: Rename MacOS X -> macOS where applicable. Modified: lldb/trunk/docs/lldb-gdb-remote.txt lldb/trunk/docs/resources/build.rst lldb/trunk/docs/status/about

[Lldb-commits] [PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

martong added a comment. Thank you guys for the review! In D61438#1501457 , @aprantl wrote: > Alright, thanks for taking the time to walk me through the thought process! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[Lldb-commits] [PATCH] D61877: [CMake] Add error to clarify that lldb requires libcxx

jryans added a comment. Thanks for the review! 😄 I don't have commit access yet, so could you please commit this for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61877/new/ https://reviews.llvm.org/D61877 __

[Lldb-commits] [PATCH] D61908: DWARF: Add ability to reference debug info coming from multiple sections

labath created this revision. labath added reviewers: JDevlieghere, clayborg, aprantl. Herald added a subscriber: arphaman. This patch adds the ability to precisely address debug info in situations when a single file can have more than one debug-info-bearing sections (as is the case with type unit

[Lldb-commits] [PATCH] D61877: [CMake] Add error to clarify that lldb requires libcxx

sgraenitz added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61877/new/ https://reviews.llvm.org/D61877 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org

[Lldb-commits] [PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

aprantl accepted this revision. aprantl added a comment. Alright, thanks for taking the time to walk me through the thought process! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61438/new/ https://reviews.llvm.org/D61438 ___

[Lldb-commits] [PATCH] D61885: Minidump: Add support for the MemoryList stream

jhenderson added inline comments. Comment at: include/llvm/Object/Minidump.h:85-86 + /// error is returned if the file does not contain this stream, or if the + /// stream is not large enough to contain the number of threads declared in + /// the stream header. The consistency

[Lldb-commits] [lldb] r360669 - DWARF/NFC: Centralize DIERef conversions

Author: labath Date: Tue May 14 05:44:40 2019 New Revision: 360669 URL: http://llvm.org/viewvc/llvm-project?rev=360669&view=rev Log: DWARF/NFC: Centralize DIERef conversions apple and manual indexing code were creating a DIERef in a bunch of places. Though the code itself is not much, it is also

[Lldb-commits] [PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

martong marked an inline comment as done. martong added inline comments. Comment at: clang/include/clang/AST/ASTImporter.h:203 /// context, or the import error. -llvm::Expected Import_New(TypeSourceInfo *FromTSI); -// FIXME: Remove this version. -TypeSourceInfo *

[Lldb-commits] [PATCH] D61877: [CMake] Add error to clarify that lldb requires libcxx

jryans marked 3 inline comments as done. jryans added a comment. Thanks all for the review! 😄 In D61877#1500981 , @sgraenitz wrote: > Thanks for adding this. Would it make sense to use > `LLVM_ENABLE_PROJECTS_USED`? > https://github.com/llvm/llvm-projec

[Lldb-commits] [PATCH] D61877: [CMake] Add error to clarify that lldb requires libcxx

jryans updated this revision to Diff 199394. jryans added a comment. Updated to support old project layout as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61877/new/ https://reviews.llvm.org/D61877 Files: lldb/CMakeLists.txt lldb/docs/re

[Lldb-commits] [PATCH] D61886: Support member functions construction and lookup in PdbAstBuilder

zloyrobot created this revision. zloyrobot added reviewers: amccarth, aleksandr.urakov, stella.stamenova. zloyrobot added a project: LLDB. Herald added subscribers: lldb-commits, teemperor. This path implements member function support in PdbAstBuilder::GetOrCreateFunctionDecl. It allows to lookup

[Lldb-commits] [PATCH] D61877: [CMake] Add error to clarify that lldb requires libcxx

sgraenitz added a comment. Thanks for adding this. Would it make sense to use `LLVM_ENABLE_PROJECTS_USED`? https://github.com/llvm/llvm-project/blob/a568222d/llvm/CMakeLists.txt#L128 BTW `LLVM_ENABLE_PROJECTS` can be "all" but LLVM should already have handled it at this point. ==

[Lldb-commits] [PATCH] D61885: Minidump: Add support for the MemoryList stream

labath created this revision. labath added reviewers: amccarth, jhenderson, clayborg. Herald added a project: LLVM. the stream format is exactly the same as for ThreadList and ModuleList streams, only the entry types are slightly different, so the changes in this patch are just straight-forward ap

[Lldb-commits] [lldb] r360655 - TestMinidumpNew.py: Use yaml2obj where possible

Author: labath Date: Tue May 14 01:59:08 2019 New Revision: 360655 URL: http://llvm.org/viewvc/llvm-project?rev=360655&view=rev Log: TestMinidumpNew.py: Use yaml2obj where possible Replace checked-in minidumps with their yaml forms now that yaml2obj supports the ThreadList stream. I delete the te

[Lldb-commits] [lldb] r360654 - typedef enum -> enum

Author: maskray Date: Tue May 14 01:55:50 2019 New Revision: 360654 URL: http://llvm.org/viewvc/llvm-project?rev=360654&view=rev Log: typedef enum -> enum Reviewed By: labath Differential Revision: https://reviews.llvm.org/D61883 Modified: lldb/trunk/include/lldb/Breakpoint/Breakpoint.h

[Lldb-commits] [lldb] r360652 - [CMake] Correctly reinstate LLDB_CAN_USE_LLDB_SERVER

Author: labath Date: Tue May 14 01:18:06 2019 New Revision: 360652 URL: http://llvm.org/viewvc/llvm-project?rev=360652&view=rev Log: [CMake] Correctly reinstate LLDB_CAN_USE_LLDB_SERVER r360631 introduced a "syntax error" which meant that cmake was still not honoring the value of LLDB_CAN_USE_LLD

[Lldb-commits] [PATCH] D61687: Update Python tests for lldb-server on Windows

labath added inline comments. Comment at: packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemoteModuleInfo.py:24-27 +# Replace path separators in the json string either with "" or "/" on Windows. +triple = self.dbg.GetSelectedPlatform().GetTriple() +