[Lldb-commits] [PATCH] D62021: Fix LLDB warnings when compiling with Clang 8.0

labath added inline comments. Comment at: source/Host/windows/ProcessLauncherWindows.cpp:35-37 + reinterpret_cast(const_cast(warg.c_str())), + reinterpret_cast( + const_cast(warg.c_str() + warg.size() + 1))); I don't believe the con

[Lldb-commits] [PATCH] D61994: [CommandInterpreter] Refactor SourceInitFile

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I think this looks better than the original. Given that the only callers of `SourceInitFile` pass a constant value for the `InitFileLocation` argument, what I'd consider also doing is getting

[Lldb-commits] [PATCH] D61952: [CMake] Stabilize install process for LLDB.framework

labath added a comment. Yeah, neither of the options look really appealing... Still, I can't escape the feeling that we are doing something wrong, as the installation process should not be that complicated. Or is the framework support in cmake just not good enough? Given that Alex (I believe)

[Lldb-commits] [lldb] r361000 - Make DWARFContext dwo-aware and port debug_info sections over

Author: labath Date: Fri May 17 01:26:58 2019 New Revision: 361000 URL: http://llvm.org/viewvc/llvm-project?rev=361000&view=rev Log: Make DWARFContext dwo-aware and port debug_info sections over Summary: The previous attempt and moving section handling over to DWARFContext (D59611) failed because

[Lldb-commits] [PATCH] D62012: Make DWARFContext dwo-aware and port debug_info sections over

This revision was automatically updated to reflect the committed changes. labath marked an inline comment as done. Closed by commit rL361000: Make DWARFContext dwo-aware and port debug_info sections over (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber:

[Lldb-commits] [PATCH] D62012: Make DWARFContext dwo-aware and port debug_info sections over

labath marked 2 inline comments as done. labath added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFContext.cpp:47 +m_data_debug_info); + else +return LoadOrGetSection(m_main_section_list, eSectionTypeDWARFDebugInfo, --

[Lldb-commits] [PATCH] D62041: [Docs] Remove SVN checkout from LLDB build steps

jryans updated this revision to Diff 13. jryans added a comment. Updated to remove the whole section Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62041/new/ https://reviews.llvm.org/D62041 Files: lldb/docs/resources/build.rst Index: lldb/

[Lldb-commits] [PATCH] D62041: [Docs] Remove SVN checkout from LLDB build steps

jryans marked 2 inline comments as done. jryans added a comment. Thanks for the review @JDevlieghere! 😄 This should be ready for another look. I don't have commit access yet, so assuming it's approved, please commit when you have time. Comment at: lldb/docs/resources/build.rs

[Lldb-commits] [PATCH] D61952: [CMake] Stabilize install process for LLDB.framework

sgraenitz added a comment. Sure, ideally CMake defined a global install order and this order would handle overlap. I think that's unlikely to happen. It took quite some time to find and fix an overlap case downstream and I think it's worth avoiding it in general in the future. OTOH I see that t

[Lldb-commits] [lldb] r361010 - minidump: Use MemoryList parsing code from llvm

Author: labath Date: Fri May 17 02:47:34 2019 New Revision: 361010 URL: http://llvm.org/viewvc/llvm-project?rev=361010&view=rev Log: minidump: Use MemoryList parsing code from llvm Modified: lldb/trunk/source/Plugins/Process/minidump/MinidumpParser.cpp lldb/trunk/source/Plugins/Process/mi

[Lldb-commits] [PATCH] D61956: [CMake] Add first CMake cache files

sgraenitz updated this revision to Diff 27. sgraenitz marked 11 inline comments as done. sgraenitz added a comment. Fix default install locations and add comments on how to use DESTDIR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61956/new/ ht

[Lldb-commits] [PATCH] D61956: [CMake] Add first CMake cache files

sgraenitz added a comment. In D61956#1505144 , @xiaobai wrote: > I noticed you have lots of comments that say "Release has different values > for these variables". Yes, I was arguing: //In a previous sketch I had extra variants for development and rele

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

ruiu added a comment. Bob, thank you for reverting this. So, Robert, looks like this idea didn't work well. We need a different solution. And perhaps a better approach is to use --start-lib and --end-lib. You found that these options didn't work well for your input, but I don't fully understan

[Lldb-commits] [PATCH] D62061: Add AST logging

martong created this revision. martong added a reviewer: shafik. Herald added subscribers: lldb-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a project: LLDB. Log the AST of the TU associated with LLDB's `expr` command, once a declaration is completed Repository: rG LLVM Github

[Lldb-commits] [PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

martong updated this revision to Diff 200031. martong added a comment. - Rebase to master - Rebase to D62061 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61333/new/ https://reviews.llvm.org/D61333 Files: clang/

[Lldb-commits] [PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

martong marked an inline comment as done. martong added inline comments. Comment at: lldb/source/Symbol/ClangASTImporter.cpp:922 + + Log *log_ast(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_AST)); + if (log_ast) { shafik wrote: > I am going to sa

[Lldb-commits] [PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

martong updated this revision to Diff 200033. martong added a comment. - se -> so Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61333/new/ https://reviews.llvm.org/D61333 Files: clang/lib/AST/ASTImporter.cpp clang/unittests/AST/ASTImporterTest

[Lldb-commits] [PATCH] D61952: [CMake] Stabilize install process for LLDB.framework

sgraenitz added a comment. >> In D61952#1503551 , @JDevlieghere >> wrote: >> >>> How does this cleanup affect dependency tracking? Does the build dir become >>> unusable after running ninja install? >> >> >> In D61952#1504942

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

thakis added a comment. For posterity, https://bugs.chromium.org/p/chromium/issues/detail?id=960881#c31 has the explanation for what exactly was happening in the Chromium/Android build. It's a bit different from rnk's example since no cross-TU imports are happening. It likely explains why rnk c

[Lldb-commits] [PATCH] D61994: [CommandInterpreter] Refactor SourceInitFile

JDevlieghere updated this revision to Diff 200056. JDevlieghere added a comment. Remove unneeded use of FileSpec. I wanted to do this yesterday but didn't get around to it... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61994/new/ https://reviews.llvm.org/D61994 Files: lldb/include

[Lldb-commits] [lldb] r361046 - [Docs] Remove SVN checkout from LLDB build steps

Author: jdevlieghere Date: Fri May 17 09:22:26 2019 New Revision: 361046 URL: http://llvm.org/viewvc/llvm-project?rev=361046&view=rev Log: [Docs] Remove SVN checkout from LLDB build steps This removes several older paragraphs in the LLDB build steps for Unix systems which suggested checking out v

[Lldb-commits] [PATCH] D62041: [Docs] Remove SVN checkout from LLDB build steps

JDevlieghere added a comment. LGTM. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62041/new/ https://reviews.llvm.org/D62041 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:/

[Lldb-commits] [PATCH] D62041: [Docs] Remove SVN checkout from LLDB build steps

This revision was automatically updated to reflect the committed changes. Closed by commit rL361046: [Docs] Remove SVN checkout from LLDB build steps (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:

[Lldb-commits] [PATCH] D62021: Fix LLDB warnings when compiling with Clang 8.0

aganea marked 2 inline comments as done. aganea added inline comments. Comment at: source/Host/windows/ProcessLauncherWindows.cpp:35-37 + reinterpret_cast(const_cast(warg.c_str())), + reinterpret_cast( + const_cast(warg.c_str() + warg.size() + 1)));

[Lldb-commits] [lldb] r361049 - Update list of supported architectures.

Author: adrian Date: Fri May 17 10:05:23 2019 New Revision: 361049 URL: http://llvm.org/viewvc/llvm-project?rev=361049&view=rev Log: Update list of supported architectures. Modified: lldb/trunk/docs/index.rst Modified: lldb/trunk/docs/index.rst URL: http://llvm.org/viewvc/llvm-project/lldb/

[Lldb-commits] [PATCH] D61952: [CMake] Stabilize install process for LLDB.framework

xiaobai added a comment. In D61952#1506608 , @sgraenitz wrote: > @xiaobai Out of interest: have you faced overwrite issues when running > `install` and would this patch help? It's been a while since I've looked at in detail but I don't remember having

[Lldb-commits] [lldb] r361064 - [CommandInterpreter] Fix trailing blanks after `all` or [0-9]+ for bt

Author: stella.stamenova Date: Fri May 17 11:52:42 2019 New Revision: 361064 URL: http://llvm.org/viewvc/llvm-project?rev=361064&view=rev Log: [CommandInterpreter] Fix trailing blanks after `all` or [0-9]+ for bt The change that was committed for this used \\s to match spaces which does not work

[Lldb-commits] [PATCH] D62073: Introduce DWARFUnitHeader and use it to parse type units out of .debug_info

labath created this revision. labath added reviewers: aprantl, clayborg, JDevlieghere. This patch introduces the DWARFUnitHeader class. Its purpose (and its structure, to the extent it was possible to make it) is the same as its LLVM counterpart -- to extract the unit header information before we

[Lldb-commits] [PATCH] D62073: Introduce DWARFUnitHeader and use it to parse type units out of .debug_info

labath added a comment. The TypeUnit and CompileUnit classes are pretty much identical now, but that'll change once we start parsing type signatures and cross-referencing them. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62073/new/ https://reviews.llvm.org/D62073 _

[Lldb-commits] [PATCH] D61952: [CMake] Stabilize install process for LLDB.framework

sgraenitz added a comment. Ok thanks. I will be OOO next week, so no hurries. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61952/new/ https://reviews.llvm.org/D61952 ___ lldb-commits mailing list lldb

[Lldb-commits] [lldb] r361069 - [CMake] Add first CMake cache files

Author: stefan.graenitz Date: Fri May 17 12:19:41 2019 New Revision: 361069 URL: http://llvm.org/viewvc/llvm-project?rev=361069&view=rev Log: [CMake] Add first CMake cache files Summary: CMake cache scripts pre-populate the CMakeCache in a build directory with commonly used settings. The CMake i

[Lldb-commits] [lldb] r361068 - [CMake] Inline info plist in lldb driver

Author: stefan.graenitz Date: Fri May 17 12:19:34 2019 New Revision: 361068 URL: http://llvm.org/viewvc/llvm-project?rev=361068&view=rev Log: [CMake] Inline info plist in lldb driver Modified: lldb/trunk/tools/driver/CMakeLists.txt Modified: lldb/trunk/tools/driver/CMakeLists.txt URL: http:

[Lldb-commits] [PATCH] D61956: [CMake] Add first CMake cache files

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL361069: [CMake] Add first CMake cache files (authored by stefan.graenitz, committed by ). Herald added a project: LLVM. He

[Lldb-commits] [PATCH] D62073: Introduce DWARFUnitHeader and use it to parse type units out of .debug_info

aprantl added a comment. Nice! FYI, we have a bot that runs the LLDB dotests against DWARF5 (the last stage http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-matrix/) to track the progress. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62073/new/ https://reviews.llvm.org/D62073

[Lldb-commits] [PATCH] D62073: Introduce DWARFUnitHeader and use it to parse type units out of .debug_info

aprantl added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:882 + case llvm::dwarf::DW_UT_partial: +return GetVersion() < 5 ? 11 :12; + case llvm::dwarf::DW_UT_skeleton: clang-format? CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [PATCH] D62073: Introduce DWARFUnitHeader and use it to parse type units out of .debug_info

clayborg added a comment. Are type units still disabled with the kill switch we had in? Or is this on top of the .debug_types patch? We have an internal .debug_types patch we have been using on an older LLVM/Clang/LLDB and we had some major performance issues regarding line tables so I am not s

[Lldb-commits] [lldb] r361078 - [EditLine] Check string pointers before dereferencing them.

Author: davide Date: Fri May 17 14:49:17 2019 New Revision: 361078 URL: http://llvm.org/viewvc/llvm-project?rev=361078&view=rev Log: [EditLine] Check string pointers before dereferencing them. Get*AtIndex() can return nullptr. This only happens in the swift REPL support, so it's hard to test upst

[Lldb-commits] [PATCH] D61956: [CMake] Add first CMake cache files

hintonda added a comment. Btw, options on the command line always override what's in the cache. Has nothing to do with FORCE. All FORCE does is make sure the set command actually changes an existing cache value. So it's an ordering issue. If the `-D` comes before the `-C` then using FORCE w

[Lldb-commits] [lldb] r361079 - Fix IPv6 support on lldb-server platform

Author: xiaobai Date: Fri May 17 15:30:53 2019 New Revision: 361079 URL: http://llvm.org/viewvc/llvm-project?rev=361079&view=rev Log: Fix IPv6 support on lldb-server platform This is a general fix for the ConnectionFileDescriptor class but my main motivation was to make lldb-server working with I

[Lldb-commits] [PATCH] D61833: Fix IPv6 support on lldb-server platform

xiaobai added a comment. Landed -- r361079 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61833/new/ https://reviews.llvm.org/D61833 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lis

[Lldb-commits] [PATCH] D61833: Fix IPv6 support on lldb-server platform

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB361079: Fix IPv6 support on lldb-server platform (authored by xiaobai, committed by ). Changed prior to commit: https://reviews.llvm.org/D61833?vs=199619&id=200108#toc Repository: rLLDB LLDB CHAN

[Lldb-commits] [lldb] r361080 - [CommandInterpreter] Refactor SourceInitFile

Author: jdevlieghere Date: Fri May 17 15:53:04 2019 New Revision: 361080 URL: http://llvm.org/viewvc/llvm-project?rev=361080&view=rev Log: [CommandInterpreter] Refactor SourceInitFile I was looking at the current implementation of SourceInitFile and there were a few things that made this function

[Lldb-commits] [PATCH] D61994: [CommandInterpreter] Refactor SourceInitFile

This revision was automatically updated to reflect the committed changes. Closed by commit rL361080: [CommandInterpreter] Refactor SourceInitFile (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

[Lldb-commits] [PATCH] D62089: Make ConnectionFileDescription work with all sockets

aadsm created this revision. aadsm added reviewers: labath, clayborg, xiaobai. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. My main goal here is to make lldb-server work with Android Studio. This is currently not the case because lldb-server is started in platform mode

[Lldb-commits] [PATCH] D62089: Make ConnectionFileDescription work with all sockets

aadsm added a comment. I'm not really sure which source version lldb-server is being shipped with Android Studio today (since their version works just fine obviously)... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62089/new/ https://reviews.llvm

[Lldb-commits] [lldb] r361083 - Unbreak windows build bot

Author: xiaobai Date: Fri May 17 17:09:43 2019 New Revision: 361083 URL: http://llvm.org/viewvc/llvm-project?rev=361083&view=rev Log: Unbreak windows build bot Commit c28f81797084b8416ff5be4f9e79000a9741ca6a (svn r361079) broke the windows buildbot. This should fix it. Modified: lldb/trunk/u

[Lldb-commits] [lldb] r361086 - Revert "Fix IPv6 support on lldb-server platform"

Author: xiaobai Date: Fri May 17 18:09:44 2019 New Revision: 361086 URL: http://llvm.org/viewvc/llvm-project?rev=361086&view=rev Log: Revert "Fix IPv6 support on lldb-server platform" This reverts commit c28f81797084b8416ff5be4f9e79000a9741ca6a. This reverts commit 7e79b64642486f510f7872174eb831d

[Lldb-commits] [lldb] r361087 - [crashlog] Use loads() instead of readPlistFromString() for python 3.

Author: davide Date: Fri May 17 18:57:12 2019 New Revision: 361087 URL: http://llvm.org/viewvc/llvm-project?rev=361087&view=rev Log: [crashlog] Use loads() instead of readPlistFromString() for python 3. Modified: lldb/trunk/examples/python/crashlog.py Modified: lldb/trunk/examples/python/c

[Lldb-commits] [PATCH] D62089: Make ConnectionFileDescription work with all sockets

aadsm updated this revision to Diff 200126. aadsm added a comment. Avoid parsing the URL when starting the GDB server if it's not a TCP connection. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62089/new/ https://reviews.llvm.org/D62089 Files: l

[Lldb-commits] [PATCH] D61833: Fix IPv6 support on lldb-server platform

xiaobai added a comment. This broke windows buildbots. I tried to fix with svn r361083 but there were other things that got broken. @aadsm: We should revisit this patch next week and see what we need to fix up before it goes in. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://rev

Re: [Lldb-commits] [lldb] r361079 - Fix IPv6 support on lldb-server platform

Alex, not sure if it's helpful for you as you already reverted this, but I was able to find this failing on our lldb-sanitize bot (on Green dragon). Here's the stack trace. TEST 'lldb-Unit :: Host/./HostTests/ConnectionFileDescriptorTest.TCPGetURIv6' FAILED ***