[Lldb-commits] [PATCH] D62221: [lldb-server][LLGS] Support 'g' packets

labath added a comment. BTW, do you have commit access, or you need someone to commit this for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62221/new/ https://reviews.llvm.org/D62221 ___ lldb-com

[Lldb-commits] [PATCH] D62499: Create a generic handler for Xfer packets

labath added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:2738 + if (!memory_buffer_sp) { +if (xfer_object == "auxv") { +// *BSD impls should be able to do this too. aadsm wrote: > xiaobai wrote: >

[Lldb-commits] [PATCH] D62503: Add ReadCStringFromMemory for faster string reads

labath added a comment. In D62503#1520435 , @aadsm wrote: > > However, now that I think about it, that is nonsense, because there is no > > way for us to say to the user that "we failed to read some initial bytes, > > but this is the memory contents afte

[Lldb-commits] [PATCH] D62499: Create a generic handler for Xfer packets

krytarowski added a comment. > One time just before it's loaded (so lldb can check which modules are loaded) > and another right after it's loaded (so lldb can check again which ones are > loaded and calculate the difference). There is on NetBSD and on a selection of other OSs: `_rtld_debug_sta

[Lldb-commits] [PATCH] D62570: [WIP] Use LLVM's debug line parser in LLDB

labath added a comment. Interesting stuff. I was wondering why you even needed to construct the `DWARFContext` and `DWARFUnit`, so I looked around a bit. It looks like they are only used for calling `DWARFFormValue::extract` to fetch the strings from the string table in the V5 case. So, it soun

[Lldb-commits] [PATCH] D62562: [Target] Introduce Process::GetLanguageRuntimes

labath added inline comments. Comment at: source/Target/Process.cpp:1565 + for (const lldb::LanguageType lang_type : Language::GetSupportedLanguages()) { +if (auto runtime = GetLanguageRuntime(lang_type, retry_if_null)) + language_runtimes.emplace_back(std::move(runtim

[Lldb-commits] [PATCH] D62499: Create a generic handler for Xfer packets

labath added a comment. In D62499#1520610 , @krytarowski wrote: > > One time just before it's loaded (so lldb can check which modules are > > loaded) and another right after it's loaded (so lldb can check again which > > ones are loaded and calculate the

[Lldb-commits] [PATCH] D62500: Add support to read aux vector values

labath added a comment. In D62500#1519658 , @JDevlieghere wrote: > > A third option would be to create a completely new library for this. In the > > past we've talked about a new library for "classes describing various > > properties of a process", wher

[Lldb-commits] [PATCH] D62302: DWARF: Fix address range support in mixed 4+5 scenario

labath marked 2 inline comments as done. labath added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:372 +return std::move(*expected_ranges); + unit.GetSymbolFileDWARF()->GetObjectFile()->GetModule()->ReportError( + "{0x%8.8x}: DIE

[Lldb-commits] [lldb] r361938 - DWARF: Fix address range support in mixed 4+5 scenario

Author: labath Date: Wed May 29 02:22:36 2019 New Revision: 361938 URL: http://llvm.org/viewvc/llvm-project?rev=361938&view=rev Log: DWARF: Fix address range support in mixed 4+5 scenario Summary: debug_ranges got renamed to debug_rnglists in DWARF 5. Prior to this patch lldb was just picking the

[Lldb-commits] [PATCH] D62302: DWARF: Fix address range support in mixed 4+5 scenario

This revision was automatically updated to reflect the committed changes. labath marked an inline comment as done. Closed by commit rL361938: DWARF: Fix address range support in mixed 4+5 scenario (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-co

[Lldb-commits] [lldb] r361939 - DWARFASTParserClang: Unify compilation unit language handling

Author: labath Date: Wed May 29 02:32:59 2019 New Revision: 361939 URL: http://llvm.org/viewvc/llvm-project?rev=361939&view=rev Log: DWARFASTParserClang: Unify compilation unit language handling Summary: The function was not being consistent in how it retrieved the language of the current compile

[Lldb-commits] [PATCH] D62481: DWARFASTParserClang: Unify compilation unit language handling

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB361939: DWARFASTParserClang: Unify compilation unit language handling (authored by labath, committed by ). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D62481?vs=20

[Lldb-commits] [PATCH] D62477: DWARFASTParserClang: Move attribute parsing into a single function

labath marked an inline comment as done. labath added a comment. In D62477#1519318 , @clayborg wrote: > Would be good to verify performance doesn't regress from this somehow. Maybe > having a large DWARF file with many types and accessing each type and ma

[Lldb-commits] [PATCH] D62472: [CMake] LLDB.framework tools handling

sgraenitz updated this revision to Diff 201859. sgraenitz marked an inline comment as done. sgraenitz added a comment. Fixed debugserver; excluded changes in add_lldb_library() for now; result of this test looks as good as before: $ cmake -GNinja -C../llvm-project/lldb/cmake/caches/Apple-lldb-ma

[Lldb-commits] [lldb] r361946 - [CMake] LLDB.framework tools handling

Author: stefan.graenitz Date: Wed May 29 04:26:06 2019 New Revision: 361946 URL: http://llvm.org/viewvc/llvm-project?rev=361946&view=rev Log: [CMake] LLDB.framework tools handling Summary: Modify the way LLDB.framework tools are collected. This allows for better fine-tuning of the install behavi

[Lldb-commits] [lldb] r361947 - [CMake] Remove lldb-server from LLDB.framework

Author: stefan.graenitz Date: Wed May 29 04:28:11 2019 New Revision: 361947 URL: http://llvm.org/viewvc/llvm-project?rev=361947&view=rev Log: [CMake] Remove lldb-server from LLDB.framework Summary: The LLDB test suite doesn't need lldb-server in the framework bundle anymore. Reviewers: JDevlieg

[Lldb-commits] [lldb] r361948 - Revert "D11003: Tolerate DWARF compile unit without filename."

Author: labath Date: Wed May 29 04:28:35 2019 New Revision: 361948 URL: http://llvm.org/viewvc/llvm-project?rev=361948&view=rev Log: Revert "D11003: Tolerate DWARF compile unit without filename." Summary: This code is modifying a support file list after it has been created. This makes it hard to

[Lldb-commits] [PATCH] D62474: [CMake] Remove lldb-server from LLDB.framework

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB361947: [CMake] Remove lldb-server from LLDB.framework (authored by stefan.graenitz, committed by ). Changed prior to commit: https://reviews.llvm.org/D62474?vs=201480&id=201862#toc Repository: rL

[Lldb-commits] [PATCH] D62517: Revert "D11003: Tolerate DWARF compile unit without filename."

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB361948: Revert "D11003: Tolerate DWARF compile unit without filename." (authored by labath, committed by ). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D62517?vs=2

[Lldb-commits] [PATCH] D62472: [CMake] LLDB.framework tools handling

This revision was automatically updated to reflect the committed changes. Closed by commit rL361946: [CMake] LLDB.framework tools handling (authored by stefan.graenitz, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://review

[Lldb-commits] [PATCH] D62547: (lldb-vscode) Evaluate expressions as LLDB commands when in REPL mode.

ivanhernandez13 added a comment. clayborg - I see the issue that this change would introduce and I’m not certain of a solution. Also, I’m not sure I understand what we get from keeping track of the selected thread. Isn’t the issue that the behavior is dependent on what thread is selected, and w

[Lldb-commits] [PATCH] D62547: (lldb-vscode) Evaluate expressions as LLDB commands when in REPL mode.

labath added a comment. In D62547#1520849 , @ivanhernandez13 wrote: > labath - As an Xcode user I was used to simply typing an lldb command, I made > this change locally to better replicate Xcode’s behavior. I do however, see > the issue with inconsiste

[Lldb-commits] [PATCH] D62547: (lldb-vscode) Evaluate expressions as LLDB commands when in REPL mode.

ivanhernandez13 added a comment. Yep you're right, Xcode doesn't have that capability. Unfortunately there is no standard way of doing this. Lanza filed a feature request to add a standard way to the DAP. Also looks like he looked into how other extensions do this: > vscode-cpptools - Prefix t

[Lldb-commits] [lldb] r361962 - Clean up DWARFDebugInfoEntry

Author: maskray Date: Wed May 29 07:36:11 2019 New Revision: 361962 URL: http://llvm.org/viewvc/llvm-project?rev=361962&view=rev Log: Clean up DWARFDebugInfoEntry Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFD

[Lldb-commits] [PATCH] D62221: [lldb-server][LLGS] Support 'g' packets

guiandrade added a comment. In D62221#1520586 , @labath wrote: > BTW, do you have commit access, or you need someone to commit this for you? I do not, I would need someone to help me commit that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[Lldb-commits] [PATCH] D62562: [Target] Introduce Process::GetLanguageRuntimes

xiaobai updated this revision to Diff 201959. xiaobai added a comment. Address review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62562/new/ https://reviews.llvm.org/D62562 Files: include/lldb/Target/Language.h include/lldb/Target/Process.h source/Target/Language.cpp

[Lldb-commits] [PATCH] D61235: Add more information to the log timer dump

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL361987: Add more information to the log timer dump (authored by aadsm, committed by ). Herald added a project: LLVM. Heral

[Lldb-commits] [lldb] r361995 - Fixed source header [NFC]

Author: gclayton Date: Wed May 29 10:25:03 2019 New Revision: 361995 URL: http://llvm.org/viewvc/llvm-project?rev=361995&view=rev Log: Fixed source header [NFC] Modified: lldb/trunk/unittests/SymbolFile/DWARF/SymbolFileDWARFTests.cpp Modified: lldb/trunk/unittests/SymbolFile/DWARF/SymbolFil

[Lldb-commits] [PATCH] D62472: [CMake] LLDB.framework tools handling

jingham added a comment. The typical trick for doing argument substitution before debugging was roughly to debug: exec /bin/sh executable arg1 arg2 ... then follow through the shell to the executable. That failed when SIP made it impossible to debug any of the shells, so we had to come up wit

[Lldb-commits] [PATCH] D62562: [Target] Introduce Process::GetLanguageRuntimes

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62562/new/ https://reviews.llvm.org/D62562 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [lldb] r361999 - [Target] Introduce Process::GetLanguageRuntimes

Author: xiaobai Date: Wed May 29 11:08:22 2019 New Revision: 361999 URL: http://llvm.org/viewvc/llvm-project?rev=361999&view=rev Log: [Target] Introduce Process::GetLanguageRuntimes Summary: Currently there's not really a good way to iterate over the language runtimes a process has. This is somet

[Lldb-commits] [PATCH] D62562: [Target] Introduce Process::GetLanguageRuntimes

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB361999: [Target] Introduce Process::GetLanguageRuntimes (authored by xiaobai, committed by ). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D62562?vs=201959&id=20199

[Lldb-commits] [PATCH] D61921: [Target] Generalize language-specific behavior in ThreadPlanStepThrough

xiaobai updated this revision to Diff 202013. xiaobai added a comment. Update to reflect the recently added method Process::GetLanguageRuntimes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61921/new/ https://reviews.llvm.org/D61921 Files: include/lldb/Target/CPPLanguageRuntime.h i

[Lldb-commits] [PATCH] D62499: Create a generic handler for Xfer packets

krytarowski added a comment. In D62499#1520654 , @labath wrote: > In D62499#1520610 , @krytarowski > wrote: > > > > One time just before it's loaded (so lldb can check which modules are > > > loaded) and another r

[Lldb-commits] [PATCH] D62626: Remove length modifier when using assignment suppression in TimerTest

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62626/new/ https://reviews.llvm.org/D62626 _

[Lldb-commits] [PATCH] D62626: Remove length modifier when using assignment suppression in TimerTest

aadsm created this revision. aadsm added a reviewer: xiaobai. Herald added subscribers: lldb-commits, krytarowski. Herald added a project: LLDB. xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. lgtm This is useless and it's giving warnings

[Lldb-commits] [lldb] r362032 - [Target] Sink some asserts into Process::GetLanguageRuntime

Author: xiaobai Date: Wed May 29 14:07:53 2019 New Revision: 362032 URL: http://llvm.org/viewvc/llvm-project?rev=362032&view=rev Log: [Target] Sink some asserts into Process::GetLanguageRuntime Modified: lldb/trunk/source/Target/Process.cpp Modified: lldb/trunk/source/Target/Process.cpp URL:

[Lldb-commits] [PATCH] D61921: [Target] Generalize language-specific behavior in ThreadPlanStepThrough

xiaobai added a comment. @jingham @JDevlieghere Mind giving this a quick look? I modified it to use the new method I added earlier and wanted to make sure there were no outstanding issues here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61921/new/ https://reviews.llvm.org/D61921

[Lldb-commits] [lldb] r362033 - Fix Xcode project lldb unit test target so it compiles.

Author: gclayton Date: Wed May 29 14:22:54 2019 New Revision: 362033 URL: http://llvm.org/viewvc/llvm-project?rev=362033&view=rev Log: Fix Xcode project lldb unit test target so it compiles. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxp

[Lldb-commits] [PATCH] D62630: Fix a regression in DWARF access speed caused by svn revision 356190

clayborg created this revision. clayborg added reviewers: labath, JDevlieghere, zturner, aadsm. Herald added a subscriber: aprantl. The issue was caused by the error checking code that was added. It was incorrectly adding an extra abbreviation when DWARFEnumState::Complete was received since it

[Lldb-commits] [PATCH] D62570: [WIP] Use LLVM's debug line parser in LLDB

aprantl added a comment. Very nice! Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:874 + data.GetByteOrder() == eByteOrderLittle, data.GetAddressByteSize()); +} should this be a `getAsLLVM()` member function or even an `operator()`?

[Lldb-commits] [PATCH] D62547: (lldb-vscode) Evaluate expressions as LLDB commands when in REPL mode.

lanza added a comment. Yup, clayborg and I talked about the solution I discuss in that request. The hopeful eventual goal is for this communication: - DAP host: can you support attaching to a pty? - lldb-vscode: yes - DAP host: okay, use `/dev/pty123` - lldb-vscode: `Debugger:RunCommandInterpre

[Lldb-commits] [PATCH] D62477: DWARFASTParserClang: Move attribute parsing into a single function

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. As long as the perf is similar I am good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62477/new/ https://reviews.llvm.org/D62477 _

[Lldb-commits] [PATCH] D62570: [WIP] Use LLVM's debug line parser in LLDB

clayborg added a comment. overall looks good. See inlined comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:929-938 + llvm::DWARFDebugLine line; + llvm::Expected line_table = + line.getOrParseLineTable( + data, offset, *ctx, ctx->get

[Lldb-commits] [PATCH] D62634: Improve DWARF parsing and accessing by 1% to 2%

clayborg created this revision. clayborg added reviewers: labath, JDevlieghere, aprantl. When LLDB first started we didn't have our mmap of the DWARF data done correctly and if the backing file would change we would get live changes as the file changed and it would cause problems. We now mmap co

[Lldb-commits] [lldb] r362042 - [Commands] Remove commented out code

Author: xiaobai Date: Wed May 29 16:25:44 2019 New Revision: 362042 URL: http://llvm.org/viewvc/llvm-project?rev=362042&view=rev Log: [Commands] Remove commented out code Modified: lldb/trunk/source/Commands/CommandObjectType.cpp Modified: lldb/trunk/source/Commands/CommandObjectType.cpp URL

[Lldb-commits] [PATCH] D62630: Fix a regression in DWARF access speed caused by svn revision 356190

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugAbbrev.cpp:32 dw_uleb128_t prev_abbr_code = 0; - DWARFEnumState state = DWARFEnumState::MoreItems; - while (s

[Lldb-commits] [PATCH] D62634: Improve DWARF parsing and accessing by 1% to 2%

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Out of curiosity, what was that change in the mmap call that fixed this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62634/new/ https://reviews.llvm.org/D62634

[Lldb-commits] [PATCH] D62634: Improve DWARF parsing and accessing by 1% to 2%

JDevlieghere accepted this revision. JDevlieghere added a comment. Great! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62634/new/ https://reviews.llvm.org/D62634 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.

[Lldb-commits] [lldb] r362044 - [crashlog] Add a missing call to decode.

Author: davide Date: Wed May 29 17:35:43 2019 New Revision: 362044 URL: http://llvm.org/viewvc/llvm-project?rev=362044&view=rev Log: [crashlog] Add a missing call to decode. Modified: lldb/trunk/examples/python/crashlog.py Modified: lldb/trunk/examples/python/crashlog.py URL: http://llvm.

[Lldb-commits] [lldb] r362049 - DWARFDebugInfoEntry: delete unused Extract() and rename FastExtract() to Extract()

Author: maskray Date: Wed May 29 18:51:16 2019 New Revision: 362049 URL: http://llvm.org/viewvc/llvm-project?rev=362049&view=rev Log: DWARFDebugInfoEntry: delete unused Extract() and rename FastExtract() to Extract() The function Extract() is almost a duplicate of FastExtract() but is not used.

[Lldb-commits] [PATCH] D62593: DWARFDebugInfoEntry: delete unused Extract() and rename FastExtract() to Extract()

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB362049: DWARFDebugInfoEntry: delete unused Extract() and rename FastExtract() to… (authored by MaskRay, committed by ). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed pr

[Lldb-commits] [PATCH] D62500: Add support to read aux vector values

aadsm marked an inline comment as done. aadsm added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:2091-2093 +DataExtractor auxv_data(buffer_or_error.get()->getBufferStart(), +buffer_or_error.get()->getBufferS