[Lldb-commits] [PATCH] D62715: [NativeProcessLinux] Reuse memory read by process_vm_readv before calling ptrace

aadsm created this revision. aadsm added reviewers: clayborg, xiaobai, labath. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I'm putting this up as discussed per D62503 . Today when process_vm_readv fails to read the entire range we

[Lldb-commits] [PATCH] D62714: [FormatEntity] Ignore ASCII escape sequences when colors are disabled.

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/lit/Settings/TestFrameFormatColor.test:12 +# Check the ASCII escape code +# CHECK:  xiaobai wrote: > I don't see any escape code here, I assume phabricator is

[Lldb-commits] [PATCH] D62714: [FormatEntity] Ignore ASCII escape sequences when colors are disabled.

xiaobai added a comment. Seems good to me. Comment at: lldb/lit/Settings/TestFrameFormatColor.test:12 +# Check the ASCII escape code +# CHECK:  I don't see any escape code here, I assume phabricator is just not showing them?  Repository: rLLDB LLDB

[Lldb-commits] [PATCH] D62714: [FormatEntity] Ignore ASCII escape sequences when colors are disabled.

JDevlieghere created this revision. JDevlieghere added reviewers: labath, jingham, xiaobai, teemperor. Herald added a project: LLDB. This patch makes the FormatEntity honor the debugger's color settings by not inserting ASCII escape sequences when colors are disabled. Repository: rLLDB LLDB

[Lldb-commits] [PATCH] D62702: [ABI] Fix SystemV ABI to handle nested aggregate type returned in register

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Thanks, this looks much better. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62702/new/ https://reviews.llvm.org/D62702

[Lldb-commits] [PATCH] D62702: [ABI] Fix SystemV ABI to handle nested aggregate type returned in register

kusmour updated this revision to Diff 202340. kusmour added a comment. simplify the method in 'FlattenAggregateType' added test for nested struct returned in registers Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62702/new/ https://reviews.llvm.org/D62702

[Lldb-commits] [lldb] r362177 - Make CPlusPlusNameParser robust against nullptr StringRefs.

Author: adrian Date: Thu May 30 17:18:42 2019 New Revision: 362177 URL: http://llvm.org/viewvc/llvm-project?rev=362177=rev Log: Make CPlusPlusNameParser robust against nullptr StringRefs. There is likely also an underlying bug in all code that calls CPlusPlusNameParser with nullptrs, but this

[Lldb-commits] [PATCH] D62702: [ABI] Fix SystemV ABI to handle nested aggregate type returned in register

compnerd added inline comments. Comment at: lldb/source/Plugins/ABI/SysV-x86_64/ABISysV_x86_64.cpp:1563 +// The compiler will faltten the nested aggregate type into single +// layer and push the value to stack NIT: `faltten` -> `flatten`

[Lldb-commits] [PATCH] D62089: Make ConnectionFileDescription work with all sockets

This revision was automatically updated to reflect the committed changes. Closed by commit rL362173: Make ConnectionFileDescription work with all sockets (authored by aadsm, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D62503: Add ReadCStringFromMemory for faster string reads

aadsm updated this revision to Diff 202329. aadsm added a comment. Moved ReadCStringFromMemory to NativeProcessProtocol and address some other comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62503/new/ https://reviews.llvm.org/D62503

[Lldb-commits] [PATCH] D62502: Implement xfer:libraries-svr4:read packet

aadsm updated this revision to Diff 202328. aadsm added a comment. Update with the correct commit... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62502/new/ https://reviews.llvm.org/D62502 Files:

[Lldb-commits] [PATCH] D62502: Implement xfer:libraries-svr4:read packet

aadsm updated this revision to Diff 202326. aadsm added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62502/new/ https://reviews.llvm.org/D62502 Files: lldb/include/lldb/Host/common/NativeProcessProtocol.h

[Lldb-commits] [PATCH] D62501: Implement GetSharedLibraryInfoAddress

aadsm updated this revision to Diff 202325. aadsm added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62501/new/ https://reviews.llvm.org/D62501 Files: lldb/include/lldb/Host/common/NativeProcessProtocol.h

[Lldb-commits] [PATCH] D62500: Add support to read aux vector values

aadsm updated this revision to Diff 202324. aadsm added a comment. Rnamed ELFAuxVector to AuxVector and got rid of the one that existed in the POSIX-DYLD plugin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62500/new/

[Lldb-commits] [PATCH] D62499: Create a generic handler for Xfer packets

aadsm updated this revision to Diff 202323. aadsm added a comment. - Introduce better error handling by creating 2 new error classes, one for generic packet errors that contain a number and another for unimplemented features. - The logic for reading the xfer object was moved into its own

Re: [Lldb-commits] [PATCH] D62505: Fix multiple module loaded with the same UUID

> On May 28, 2019, at 7:59 AM, Pavel Labath via Phabricator > wrote: > > labath added a comment. > > In D62505#1519166 , @aadsm wrote: > >> Interesting, I did miss that comment when I checked that class. This is >> something @clayborg was concerned

[Lldb-commits] [PATCH] D61921: [Target] Generalize language-specific behavior in ThreadPlanStepThrough

This revision was automatically updated to reflect the committed changes. Closed by commit rL362164: [Target] Generalize language-specific behavior in ThreadPlanStepThrough (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository:

[Lldb-commits] [lldb] r362164 - [Target] Generalize language-specific behavior in ThreadPlanStepThrough

Author: xiaobai Date: Thu May 30 15:00:18 2019 New Revision: 362164 URL: http://llvm.org/viewvc/llvm-project?rev=362164=rev Log: [Target] Generalize language-specific behavior in ThreadPlanStepThrough Summary: When creating a ThreadPlan to step through a trampoline, we ask the ObjC language

[Lldb-commits] [PATCH] D62702: [ABI] Fix SystemV ABI to handle nested aggregate type returned in register

kusmour added a comment. @jingham working on the unit test rn. will upload soon Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62702/new/ https://reviews.llvm.org/D62702 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D62702: [ABI] Fix SystemV ABI to handle nested aggregate type returned in register

jingham added a comment. There should be a test to go along with this. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62702/new/ https://reviews.llvm.org/D62702 ___ lldb-commits mailing list

[Lldb-commits] [lldb] r362154 - [Target] Generalize Process::IsPossibleDynamicValue

Author: xiaobai Date: Thu May 30 14:03:53 2019 New Revision: 362154 URL: http://llvm.org/viewvc/llvm-project?rev=362154=rev Log: [Target] Generalize Process::IsPossibleDynamicValue Modified: lldb/trunk/source/Target/Process.cpp Modified: lldb/trunk/source/Target/Process.cpp URL:

[Lldb-commits] [PATCH] D62702: [ABI] Fix SystemV ABI to handle nested aggregate type returned in register

kusmour created this revision. kusmour added reviewers: xiaobai, compnerd. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add a function to flatten the nested aggregate type Repository: rLLDB LLDB https://reviews.llvm.org/D62702 Files:

[Lldb-commits] [PATCH] D61921: [Target] Generalize language-specific behavior in ThreadPlanStepThrough

jingham accepted this revision. jingham added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61921/new/ https://reviews.llvm.org/D61921 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D62654: [Docs] Modernize references to macOS

This revision was automatically updated to reflect the committed changes. Closed by commit rL362113: [Docs] Modernize references to macOS (authored by jryans, committed by ). Changed prior to commit: https://reviews.llvm.org/D62654?vs=202161=202247#toc Repository: rL LLVM CHANGES SINCE

[Lldb-commits] [PATCH] D62626: Remove length modifier when using assignment suppression in TimerTest

This revision was automatically updated to reflect the committed changes. Closed by commit rL362107: Remove length modifier when using assignment suppression in TimerTest (authored by aadsm, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [lldb] r362116 - Code and comment cleanups [NFC]

Author: gclayton Date: Thu May 30 10:03:35 2019 New Revision: 362116 URL: http://llvm.org/viewvc/llvm-project?rev=362116=rev Log: Code and comment cleanups [NFC] Changes: - update comments to detail the info can come from .debug_info or .debug_types - Rename "debug_info_data" to "data" now that

[Lldb-commits] [lldb] r362113 - [Docs] Modernize references to macOS

Author: jryans Date: Thu May 30 09:46:22 2019 New Revision: 362113 URL: http://llvm.org/viewvc/llvm-project?rev=362113=rev Log: [Docs] Modernize references to macOS Summary: This updates all places in documentation that refer to "Mac OS X", "OS X", etc. to instead use the modern name "macOS"

[Lldb-commits] [PATCH] D62654: [Docs] Modernize references to macOS

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62654/new/ https://reviews.llvm.org/D62654

[Lldb-commits] [PATCH] D62634: Improve DWARF parsing and accessing by 1% to 2%

clayborg closed this revision. clayborg added a comment. r362103 | gclayton | 2019-05-30 08:21:23 -0700 (Thu, 30 May 2019) | 9 lines Improve DWARF parsing and accessing by 1% to 2% When LLDB first started we didn't have our mmap of the DWARF data done correctly and if the backing file would

[Lldb-commits] [PATCH] D62630: Fix a regression in DWARF access speed caused by svn revision 356190

clayborg closed this revision. clayborg marked an inline comment as done. clayborg added a comment. r362105 | gclayton | 2019-05-30 08:32:33 -0700 (Thu, 30 May 2019) | 13 lines Fix a regression in DWARF access speed caused by svn revision 356190 The issue was caused by the error checking code

[Lldb-commits] [PATCH] D62649: CompileUnit: Use shared_ptr for storing support file lists

labath abandoned this revision. labath added a comment. Ok, abandoning this patch in that case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62649/new/ https://reviews.llvm.org/D62649 ___ lldb-commits mailing list

[Lldb-commits] [lldb] r362105 - Fix a regression in DWARF access speed caused by svn revision 356190

Author: gclayton Date: Thu May 30 08:32:33 2019 New Revision: 362105 URL: http://llvm.org/viewvc/llvm-project?rev=362105=rev Log: Fix a regression in DWARF access speed caused by svn revision 356190 The issue was caused by the error checking code that was added. It was incorrectly adding an

[Lldb-commits] [PATCH] D62649: CompileUnit: Use shared_ptr for storing support file lists

clayborg added a comment. In D62649#1523074 , @labath wrote: > Actually, I've run into a bit of a snag while trying to implement the full > line table sharing. The thing is, before DWARF5, the line tables are not > fully independent, and require the

[Lldb-commits] [PATCH] D62649: CompileUnit: Use shared_ptr for storing support file lists

labath added a comment. Actually, I've run into a bit of a snag while trying to implement the full line table sharing. The thing is, before DWARF5, the line tables are not fully independent, and require the DW_AT_comp_dir of the compile unit in order to resolve the relative paths correctly.

[Lldb-commits] [lldb] r362103 - Improve DWARF parsing and accessing by 1% to 2%

Author: gclayton Date: Thu May 30 08:21:23 2019 New Revision: 362103 URL: http://llvm.org/viewvc/llvm-project?rev=362103=rev Log: Improve DWARF parsing and accessing by 1% to 2% When LLDB first started we didn't have our mmap of the DWARF data done correctly and if the backing file would change

[Lldb-commits] [PATCH] D62634: Improve DWARF parsing and accessing by 1% to 2%

clayborg added a comment. In D62634#1522249 , @aprantl wrote: > Out of curiosity, what was that change in the mmap call that fixed this? We switched to mapping things private and shared. This might be been before open sourcing happened so there might

[Lldb-commits] [PATCH] D62634: Improve DWARF parsing and accessing by 1% to 2%

clayborg added a comment. In D62634#1522631 , @labath wrote: > BTW, how do you measure these things? > > When I tried to benchmark something I got a difference of at least 5% on what > should be identical runs. I'd have to make hundreds of runs in order

[Lldb-commits] [PATCH] D62570: [WIP] Use LLVM's debug line parser in LLDB

labath added a comment. BTW, how good is the llvm debug_line parser when it comes to handling invalid input? Looking through the asserts in the file, it looks like at least two of them can be tripped by feeding it bad data: - I'm pretty sure the DW_LNCT_*** handling code can blow up if the

[Lldb-commits] [PATCH] D62654: [Docs] Modernize references to macOS

mclow.lists added a comment. I'm fine with the libc++ changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62654/new/ https://reviews.llvm.org/D62654 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D62654: [Docs] Modernize references to macOS

jryans created this revision. jryans added a reviewer: JDevlieghere. Herald added subscribers: llvm-commits, libcxx-commits, lldb-commits, cfe-commits, arphaman, christof, mgorny. Herald added projects: clang, LLDB, libc++, LLVM. This updates all places in documentation that refer to "Mac OS X",

[Lldb-commits] [lldb] r362086 - DWARFASTParserClang: Delete dead code

Author: labath Date: Thu May 30 04:24:16 2019 New Revision: 362086 URL: http://llvm.org/viewvc/llvm-project?rev=362086=rev Log: DWARFASTParserClang: Delete dead code This removes places where DW_AT_decl_file/line/column was being parsed, but not used. Modified:

[Lldb-commits] [PATCH] D62477: DWARFASTParserClang: Move attribute parsing into a single function

This revision was automatically updated to reflect the committed changes. Closed by commit rL362075: DWARFASTParserClang: Move attribute parsing into a single function (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [lldb] r362075 - DWARFASTParserClang: Move attribute parsing into a single function

Author: labath Date: Thu May 30 02:39:36 2019 New Revision: 362075 URL: http://llvm.org/viewvc/llvm-project?rev=362075=rev Log: DWARFASTParserClang: Move attribute parsing into a single function Summary: The ParseTypeFromDWARF function consists of a huge switch on the kind of type being parsed.

[Lldb-commits] [PATCH] D62634: Improve DWARF parsing and accessing by 1% to 2%

labath added a comment. BTW, how do you measure these things? When I tried to benchmark something I got a difference of at least 5% on what should be identical runs. I'd have to make hundreds of runs in order for a 1% difference in average to show up as statistically significant.. CHANGES

[Lldb-commits] [PATCH] D62649: CompileUnit: Use shared_ptr for storing support file lists

labath added a comment. This isn't strictly necessary. I could just have SymbolFileDWARF keep one copy a file list for each line table. That way each list would be stored exactly twice. However, it seemed like it would be nice to avoid that (though I don't have any data about how much this

[Lldb-commits] [PATCH] D62649: CompileUnit: Use shared_ptr for storing support file lists

labath created this revision. labath added reviewers: JDevlieghere, clayborg, aprantl. Herald added a subscriber: jdoerfert. This patch refactors the CompileUnit class to store the support files in a shared_ptr, and changes the SymbolFiles to hand them out as such. This allows the file lists to

[Lldb-commits] [PATCH] D62570: [WIP] Use LLVM's debug line parser in LLDB

grimar added inline comments. Comment at: lldb/include/lldb/Core/FileSpecList.h:29 + typedef std::vector collection; + typedef collection::iterator iterator; + typedef collection::const_iterator const_iterator; Seems you don't use `iterator` anywhere?

[Lldb-commits] [lldb] r362069 - Make CompileUnit::GetSupportFiles return a const list

Author: labath Date: Thu May 30 01:21:25 2019 New Revision: 362069 URL: http://llvm.org/viewvc/llvm-project?rev=362069=rev Log: Make CompileUnit::GetSupportFiles return a const list There's no reason for anyone to modify a list from outside of a symbol file (as that would break a lot of

[Lldb-commits] [PATCH] D62634: Improve DWARF parsing and accessing by 1% to 2%

labath accepted this revision. labath added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:724 uint32_t curr_depth) const { - const DWARFAbbreviationDeclaration *abbrevDecl = nullptr; - lldb::offset_t offset = 0; - if (cu) -

[Lldb-commits] [lldb] r362063 - [lldb-server] Support 'g' packets

Author: labath Date: Thu May 30 00:25:22 2019 New Revision: 362063 URL: http://llvm.org/viewvc/llvm-project?rev=362063=rev Log: [lldb-server] Support 'g' packets Differential Revision: https://reviews.llvm.org/D62221 Patch by Guilherme Andrade . Added:

[Lldb-commits] [PATCH] D62221: [lldb-server][LLGS] Support 'g' packets

This revision was automatically updated to reflect the committed changes. Closed by commit rL362063: [lldb-server] Support g packets (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D62500: Add support to read aux vector values

aadsm marked an inline comment as done. aadsm added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:2091-2093 +DataExtractor auxv_data(buffer_or_error.get()->getBufferStart(), +