[Lldb-commits] [PATCH] D62504: Avoid calling LoadModules twice when modules change

2019-06-09 Thread António Afonso via Phabricator via lldb-commits
aadsm updated this revision to Diff 203761. aadsm added a comment. Do not try to use LoadModules again if they failed in the past Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62504/new/ https://reviews.llvm.org/D62504 Files:

[Lldb-commits] [PATCH] D63052: [Target] Remove Process::GetObjCLanguageRuntime

2019-06-09 Thread Saleem Abdulrasool via Phabricator via lldb-commits
compnerd added inline comments. Comment at: include/lldb/Target/ObjCLanguageRuntime.h:202 + static ObjCLanguageRuntime *GetObjCLanguageRuntime(Process ) { +return llvm::cast_or_null( I think it would be nice to just call this `Get` (and we could have

[Lldb-commits] [PATCH] D63054: [lldb] [Process/NetBSD] Fix error handling in register operations

2019-06-09 Thread Michał Górny via Phabricator via lldb-commits
mgorny created this revision. mgorny added reviewers: krytarowski, labath. Ensure that errors are passed through correctly when performing register read/write operations. Currently, any ptrace() errors are silently discarded and LLDB behaves as if operation was successful. // NB: This is a