[Lldb-commits] [PATCH] D63679: [lit] Make lit-lldb-init configurable by CMake

This revision was automatically updated to reflect the committed changes. Closed by commit rL364112: [lit] Make lit-lldb-init configurable by CMake (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r364113 - [lit] Deduplicate logic in toolchain.py

Author: jdevlieghere Date: Fri Jun 21 16:12:25 2019 New Revision: 364113 URL: http://llvm.org/viewvc/llvm-project?rev=364113=rev Log: [lit] Deduplicate logic in toolchain.py No need to compute the path of lit-lldb-init twice. Modified: lldb/trunk/lit/helper/toolchain.py Modified:

[Lldb-commits] [lldb] r364112 - [lit] Make lit-lldb-init configurable by CMake

Author: jdevlieghere Date: Fri Jun 21 16:12:22 2019 New Revision: 364112 URL: http://llvm.org/viewvc/llvm-project?rev=364112=rev Log: [lit] Make lit-lldb-init configurable by CMake This makes the `lit-lldb-init` file configurable by CMake. This matters to us downstream in Swift, where we want to

[Lldb-commits] [PATCH] D63679: [lit] Make lit-lldb-init configurable by CMake

davide accepted this revision. davide added a comment. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63679/new/ https://reviews.llvm.org/D63679 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D63679: [lit] Make lit-lldb-init configurable by CMake

JDevlieghere updated this revision to Diff 206095. JDevlieghere added a comment. Undo reformatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63679/new/ https://reviews.llvm.org/D63679 Files: lldb/lit/CMakeLists.txt lldb/lit/helper/toolchain.py lldb/lit/lit-lldb-init

[Lldb-commits] [PATCH] D63679: [lit] Make lit-lldb-init configurable by CMake

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. LGTM. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63679/new/ https://reviews.llvm.org/D63679

[Lldb-commits] [PATCH] D63679: [lit] Make lit-lldb-init configurable by CMake

JDevlieghere created this revision. JDevlieghere added reviewers: davide, stella.stamenova, sgraenitz. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. This makes the `lit-lldb-init` file configurable by CMake. This matters to us downstream in swift, where we want to

[Lldb-commits] [PATCH] D63622: [Target] Hoist LanguageRuntime::GetDeclVendor

jingham added inline comments. Comment at: source/API/SBTarget.cpp:1854-1859 + if (vendor->FindDecls(const_typename, /*append*/ true, +/*max_matches*/ 1, decls) > 0) { +if (CompilerType type = +

[Lldb-commits] [PATCH] D63667: Support __kernel_rt_sigreturn in frame initialization

jasonmolenda added a comment. This looks good. Over in RegisterContextLLDB::GetFullUnwindPlanForFrame there's a behaves_like_zeroth_frame bool with similar setup -- in that case, it's trying to decide what type of UnwindPlan to pick for the frame, either one that is synchronous ("valid only

[Lldb-commits] [PATCH] D63622: [Target] Hoist LanguageRuntime::GetDeclVendor

xiaobai marked an inline comment as done. xiaobai added inline comments. Comment at: source/API/SBTarget.cpp:1854-1859 + if (vendor->FindDecls(const_typename, /*append*/ true, +/*max_matches*/ 1, decls) > 0) { +if

[Lldb-commits] [PATCH] D63643: DWARF: Add support for type units+split dwarf combo

JDevlieghere added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwo.cpp:77 +llvm::dyn_cast(debug_info->GetUnitAtIndex(i))) { + if (cu) +return nullptr; Is this here to ensure that there's no two candidates?

[Lldb-commits] [PATCH] D63667: Support __kernel_rt_sigreturn in frame initialization

JosephTremoulet added a comment. FYI, I sent mail about this to lldb-dev.. I'll copy the contents here for the benefit of anybody who didn't see it there but could use the context: > Hi, > > I'm trying to use lldb in a project where I need to report stack traces from > signal handlers, and

[Lldb-commits] [PATCH] D63622: [Target] Hoist LanguageRuntime::GetDeclVendor

jingham added inline comments. Comment at: source/API/SBTarget.cpp:1854-1859 + if (vendor->FindDecls(const_typename, /*append*/ true, +/*max_matches*/ 1, decls) > 0) { +if (CompilerType type = +

[Lldb-commits] [PATCH] D63667: Support __kernel_rt_sigreturn in frame initialization

JosephTremoulet created this revision. JosephTremoulet added reviewers: labath, jankratochvil, compnerd. Herald added subscribers: kristof.beyls, javed.absar. Herald added a reviewer: jfb. Herald added a project: LLDB. Add __kernel_rt_sigreturn to the list of trap handlers for Linux (it's used as

[Lldb-commits] [PATCH] D63622: [Target] Hoist LanguageRuntime::GetDeclVendor

xiaobai updated this revision to Diff 206054. xiaobai added a comment. Add a few autos CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63622/new/ https://reviews.llvm.org/D63622 Files: include/lldb/Target/LanguageRuntime.h include/lldb/Target/ObjCLanguageRuntime.h

[Lldb-commits] [PATCH] D63622: [Target] Hoist LanguageRuntime::GetDeclVendor

xiaobai marked an inline comment as done. xiaobai added inline comments. Comment at: source/API/SBTarget.cpp:1851 +if (ProcessSP process_sp = target_sp->GetProcessSP()) { + for (auto *runtime : process_sp->GetLanguageRuntimes()) { +if (auto vendor =

[Lldb-commits] [PATCH] D63622: [Target] Hoist LanguageRuntime::GetDeclVendor

xiaobai marked an inline comment as done. xiaobai added inline comments. Comment at: source/API/SBTarget.cpp:1854-1859 + if (vendor->FindDecls(const_typename, /*append*/ true, +/*max_matches*/ 1, decls) > 0) { +if

[Lldb-commits] [PATCH] D63181: [Target] Decouple ObjCLanguageRuntime from LanguageRuntime

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG7f9c9f226423: [Target] Decouple ObjCLanguageRuntime from LanguageRuntime (authored by xiaobai). Herald added a project:

[Lldb-commits] [lldb] r364098 - [Target] Decouple ObjCLanguageRuntime from LanguageRuntime

Author: xiaobai Date: Fri Jun 21 12:43:07 2019 New Revision: 364098 URL: http://llvm.org/viewvc/llvm-project?rev=364098=rev Log: [Target] Decouple ObjCLanguageRuntime from LanguageRuntime Summary: ObjCLanguageRuntime was being pulled into LanguageRuntime because of Breakpoint Preconditions. If

[Lldb-commits] [PATCH] D63622: [Target] Hoist LanguageRuntime::GetDeclVendor

jingham added a subscriber: labath. jingham added a comment. In D63622#1553121 , @labath wrote: > Seems like a reasonable thing to do, but I don't really know what this code > does... The runtime DeclVendor gives runtimes a way to produce type

[Lldb-commits] [PATCH] D63622: [Target] Hoist LanguageRuntime::GetDeclVendor

jingham added inline comments. Comment at: include/lldb/Target/LanguageRuntime.h:137 + virtual DeclVendor *GetDeclVendor() { return nullptr; } + compnerd wrote: > Can this not be `const`? Seems like retrieving the vendor should not mutate > the runtime. The

[Lldb-commits] [PATCH] D63622: [Target] Hoist LanguageRuntime::GetDeclVendor

jingham added inline comments. Comment at: source/API/SBTarget.cpp:1854-1859 + if (vendor->FindDecls(const_typename, /*append*/ true, +/*max_matches*/ 1, decls) > 0) { +if (CompilerType type = +

[Lldb-commits] [PATCH] D63165: Initial support for native debugging of x86/x64 Windows processes

Hui added inline comments. Comment at: source/Plugins/Process/Windows/Common/NativeProcessWindows.h:31 +class NativeProcessWindows : public NativeProcessProtocol, + public ProcessDebugger { + labath wrote: > Hui wrote: > > labath

[Lldb-commits] [PATCH] D63622: [Target] Hoist LanguageRuntime::GetDeclVendor

compnerd added inline comments. Comment at: include/lldb/Target/LanguageRuntime.h:137 + virtual DeclVendor *GetDeclVendor() { return nullptr; } + Can this not be `const`? Seems like retrieving the vendor should not mutate the runtime.

[Lldb-commits] [PATCH] D63591: DWARFDebugLoc: Make parsing and error reporting more robust

dblaikie added a comment. Given figuring out error handling for DataExtractor is perhaps a wider issue - if you want to go ahead with this change (continue with the review & defer error handling improvements for later, leave a FIXME, etc) that seems fine. Repository: rL LLVM CHANGES SINCE

[Lldb-commits] [PATCH] D63165: Initial support for native debugging of x86/x64 Windows processes

labath added inline comments. Comment at: source/Plugins/Process/Windows/Common/NativeProcessWindows.h:31 +class NativeProcessWindows : public NativeProcessProtocol, + public ProcessDebugger { + Hui wrote: > labath wrote: > > I'm not

[Lldb-commits] [PATCH] D63165: Initial support for native debugging of x86/x64 Windows processes

Hui added inline comments. Comment at: source/Plugins/Process/Windows/Common/NativeProcessWindows.h:31 +class NativeProcessWindows : public NativeProcessProtocol, + public ProcessDebugger { + labath wrote: > I'm not sure this multiple

[Lldb-commits] [PATCH] D63545: [lldb] [Process/NetBSD] Support reading YMM registers via PT_*XSTATE [DO NOT MERGE]

mgorny updated this revision to Diff 205999. mgorny added a comment. …and removed stale declarations. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63545/new/ https://reviews.llvm.org/D63545 Files: lldb/source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD_x86_64.cpp

[Lldb-commits] [PATCH] D63545: [lldb] [Process/NetBSD] Support reading YMM registers via PT_*XSTATE [DO NOT MERGE]

mgorny updated this revision to Diff 205998. mgorny added a comment. Updated to use new XState conversion methods. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63545/new/ https://reviews.llvm.org/D63545 Files:

[Lldb-commits] [PATCH] D63591: DWARFDebugLoc: Make parsing and error reporting more robust

probinson added a comment. Pick whatever mechanism you like, we should debate it in that patch not here. :-) Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63591/new/ https://reviews.llvm.org/D63591 ___ lldb-commits

[Lldb-commits] [PATCH] D63591: DWARFDebugLoc: Make parsing and error reporting more robust

labath added a comment. In D63591#1553600 , @probinson wrote: > Ah, hadn't considered statefulness. But if you layer another class on top of > DataExtractor to handle the error flag, it would have to be replicating all > the offset-is-valid checks,

[Lldb-commits] [PATCH] D63591: DWARFDebugLoc: Make parsing and error reporting more robust

probinson added a comment. Ah, hadn't considered statefulness. But if you layer another class on top of DataExtractor to handle the error flag, it would have to be replicating all the offset-is-valid checks, because of course DataExtractor itself doesn't return errors. I have a couple more

[Lldb-commits] [PATCH] D63610: [lldb] [Process] Introduce common helpers to split/recombine YMM data

labath added a comment. In D63610#1553461 , @mgorny wrote: > In D63610#1553143 , @labath wrote: > > > It's not much, but it definitely does help. > > > > > // NB: I have no clue why FreeBSD code claims to belong in

[Lldb-commits] [PATCH] D63610: [lldb] [Process] Introduce common helpers to split/recombine YMM data

This revision was automatically updated to reflect the committed changes. mgorny marked an inline comment as done. Closed by commit rL364042: [lldb] [Process] Introduce common helpers to split/recombine YMM data (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a

[Lldb-commits] [PATCH] D63610: [lldb] [Process] Introduce common helpers to split/recombine YMM data

mgorny marked 2 inline comments as done. mgorny added a comment. In D63610#1553143 , @labath wrote: > It's not much, but it definitely does help. > > > // NB: I have no clue why FreeBSD code claims to belong in 'POSIX', and > > Linux does not. > > I

[Lldb-commits] [PATCH] D63591: DWARFDebugLoc: Make parsing and error reporting more robust

labath added a comment. In D63591#1553416 , @probinson wrote: > The idea for error handling for DataExtractor sounds reasonable, looks like > adding an error flag wouldn't even increase the size. Hmm... Originally I was thinking of building something

[Lldb-commits] [lldb] r364042 - [lldb] [Process] Introduce common helpers to split/recombine YMM data

Author: mgorny Date: Fri Jun 21 06:19:34 2019 New Revision: 364042 URL: http://llvm.org/viewvc/llvm-project?rev=364042=rev Log: [lldb] [Process] Introduce common helpers to split/recombine YMM data Introduce two common helpers to take care of splitting and recombining YMM registers to/from

[Lldb-commits] [PATCH] D63591: DWARFDebugLoc: Make parsing and error reporting more robust

probinson added a comment. Removing that llvm_unreachable is fine, in that case. The idea for error handling for DataExtractor sounds reasonable, looks like adding an error flag wouldn't even increase the size. Repository: rL LLVM CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D63591: DWARFDebugLoc: Make parsing and error reporting more robust

labath added inline comments. Comment at: lib/DebugInfo/DWARF/DWARFDebugLoc.cpp:31 + +static llvm::Error createOverflowError(const char *Section) { + return createError("location list overflows the %s section", Section); dblaikie wrote: > Should this be

[Lldb-commits] [PATCH] D63591: DWARFDebugLoc: Make parsing and error reporting more robust

labath updated this revision to Diff 205973. labath marked 7 inline comments as done. labath added a comment. - remove fancy references - remove llvm_unreachable Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63591/new/ https://reviews.llvm.org/D63591 Files:

[Lldb-commits] [PATCH] D63544: Use object library if cmake supports it

This revision was automatically updated to reflect the committed changes. Closed by commit rL364035: [unittests] Simplify CMakeLists with object library (authored by tkrasnukha, committed by ). Changed prior to commit: https://reviews.llvm.org/D63544?vs=205816=205971#toc Repository: rL LLVM

[Lldb-commits] [lldb] r364035 - [unittests] Simplify CMakeLists with object library

Author: tkrasnukha Date: Fri Jun 21 04:46:46 2019 New Revision: 364035 URL: http://llvm.org/viewvc/llvm-project?rev=364035=rev Log: [unittests] Simplify CMakeLists with object library The solution suggested by Chris Bieneman works for all versions of CMake. Differential Revision:

[Lldb-commits] [PATCH] D63544: Use object library if cmake supports it

tatyana-krasnukha reopened this revision. tatyana-krasnukha added a comment. This revision is now accepted and ready to land. @beanz you're absolutely right, thank you. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63544/new/ https://reviews.llvm.org/D63544

[Lldb-commits] [PATCH] D63643: DWARF: Add support for type units+split dwarf combo

labath created this revision. labath added reviewers: clayborg, JDevlieghere, aprantl. Herald added a subscriber: arphaman. With the last round of refactors, supporting type units in dwo files becomes almost trivial. This patch contains a couple of small fixes, which taken as a whole make type

[Lldb-commits] [PATCH] D63428: DWARF: Add "dwo_num" field to the DIERef class

This revision was automatically updated to reflect the committed changes. Closed by commit rL364009: DWARF: Add dwo_num field to the DIERef class (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST

[Lldb-commits] [lldb] r364009 - DWARF: Add "dwo_num" field to the DIERef class

Author: labath Date: Fri Jun 21 00:56:50 2019 New Revision: 364009 URL: http://llvm.org/viewvc/llvm-project?rev=364009=rev Log: DWARF: Add "dwo_num" field to the DIERef class Summary: When dwo support was introduced, it used a trick where debug info entries were referenced by the offset of the

[Lldb-commits] [PATCH] D63610: [lldb] [Process] Introduce common helpers to split/recombine YMM data

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. It's not much, but it definitely does help. > // NB: I have no clue why FreeBSD code claims to belong in 'POSIX', and Linux > does not. I think that somehow fell out of the fact that FreeBSD

[Lldb-commits] [PATCH] D62504: Avoid calling LoadModules twice when modules change

labath added a comment. Sorry, I missed this patch. Overall, this seems fine to me. I have only two comments about it: - I'm not sure the `CanLoadModules` functions is really needed. It seems like we could just call `LoadModules` directly and check for error result. The `XMLEnabled() && ...`

[Lldb-commits] [PATCH] D63622: [Target] Hoist LanguageRuntime::GetDeclVendor

labath edited reviewers, added: jingham; removed: labath. labath added a comment. Seems like a reasonable thing to do, but I don't really know what this code does... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63622/new/ https://reviews.llvm.org/D63622

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

labath resigned from this revision. labath added a comment. I'm not familiar with the code enough to make the calls here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63240/new/ https://reviews.llvm.org/D63240 ___ lldb-commits mailing