[Lldb-commits] [PATCH] D63745: [CMake] Check that a certificate for lldb is present at build time.

xiaobai added a comment. In D63745#1556941 , @labath wrote: > This code should go to `tools/debugserver/source/CMakeLists.txt` so that it > is next to the code which performs the actual code signing. Doing that will > make it easier to keep it in sync wi

[Lldb-commits] [PATCH] D63745: [CMake] Check that a certificate for lldb is present at build time.

xiaobai added a comment. In D63745#1556773 , @JDevlieghere wrote: > On second thought, let's check that LLDB_CODESIGN_IDENTITY equals > `lldb_codesign` before doing this check. This question isn't important but I'm kind of curious: Does it have to be

[Lldb-commits] [PATCH] D63745: [CMake] Check that a certificate for lldb is present at build time.

labath added a comment. This code should go to `tools/debugserver/source/CMakeLists.txt` so that it is next to the code which performs the actual code signing. Doing that will make it easier to keep it in sync with changes to code signing, as well as make it obvious that it is not in sync with

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

xiaobai updated this revision to Diff 206351. xiaobai added a comment. Address feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63240/new/ https://reviews.llvm.org/D63240 Files: include/lldb/Target/CPPLanguageRuntime.h include/lldb/Target/LanguageRuntime.h include/lldb/Targ

[Lldb-commits] [lldb] r364260 - Reapply "Fix a crash in option parsing."

Author: adrian Date: Mon Jun 24 17:55:27 2019 New Revision: 364260 URL: http://llvm.org/viewvc/llvm-project?rev=364260&view=rev Log: Reapply "Fix a crash in option parsing." with an additional read-out-of-bounds bugfix applied. Differential Revision: https://reviews.llvm.org/D63110 Added: l

[Lldb-commits] [PATCH] D63745: [CMake] Check that a certificate for lldb is present at build time.

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. On second thought, let's check that LLDB_CODESIGN_IDENTITY equals `lldb_codesign` before doing this check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

xiaobai marked an inline comment as done. xiaobai added inline comments. Comment at: include/lldb/Target/LanguageRuntime.h:157 + virtual bool IsRuntimeSupportValue(ValueObject &valobj) { +return valobj.GetVariable() && valobj.GetVariable()->IsArtificial(); + } -

[Lldb-commits] [PATCH] D63745: [CMake] Check that a certificate for lldb is present at build time.

davide added a comment. rdar://problem/52078735 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63745/new/ https://reviews.llvm.org/D63745 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:

[Lldb-commits] [PATCH] D63745: [CMake] Check that a certificate for lldb is present at build time.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63745/new/ https://reviews.llvm.org/D63745 ___

[Lldb-commits] [PATCH] D63745: [CMake] Check that a certificate for lldb is present at build time.

davide created this revision. davide added reviewers: JDevlieghere, sgraenitz, aprantl, friss. Herald added a subscriber: mgorny. Herald added a project: LLDB. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D63745 Files: lldb/CMakeLists.txt Index: lldb/CMakeLists.txt

[Lldb-commits] [PATCH] D62183: [Windows] Fix race condition between state changes

amccarth added a comment. zturner is not a regular here anymore. I think he pops in from time-to-time, but I wouldn't depend on just him for a review. Are you still wanting to land this? If you rebase and add me as a reviewer, I'd be happy to take a look. Repository: rLLDB LLDB CHANGES S

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

aprantl added inline comments. Comment at: include/lldb/Target/LanguageRuntime.h:157 + virtual bool IsRuntimeSupportValue(ValueObject &valobj) { +return valobj.GetVariable() && valobj.GetVariable()->IsArtificial(); + } I think this function should not be pa

[Lldb-commits] [lldb] r364243 - Don't link against the DebugSymbols private framework; try to dlopen

Author: jmolenda Date: Mon Jun 24 15:08:43 2019 New Revision: 364243 URL: http://llvm.org/viewvc/llvm-project?rev=364243&view=rev Log: Don't link against the DebugSymbols private framework; try to dlopen + dlsym the two functions we need from there at runtime. I'm not maintaining a negative cache

[Lldb-commits] [lldb] r364240 - Add windows abi plugin, breakpointprecondition.

Author: jmolenda Date: Mon Jun 24 14:48:13 2019 New Revision: 364240 URL: http://llvm.org/viewvc/llvm-project?rev=364240&view=rev Log: Add windows abi plugin, breakpointprecondition. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

[Lldb-commits] [PATCH] D63622: [Target] Hoist LanguageRuntime::GetDeclVendor

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL364229: [Target] Hoist LanguageRuntime::GetDeclVendor (authored by xiaobai, committed by ). Herald added a project: LLVM.

[Lldb-commits] [lldb] r364229 - [Target] Hoist LanguageRuntime::GetDeclVendor

Author: xiaobai Date: Mon Jun 24 13:33:09 2019 New Revision: 364229 URL: http://llvm.org/viewvc/llvm-project?rev=364229&view=rev Log: [Target] Hoist LanguageRuntime::GetDeclVendor Summary: It's possible that each LanguageRuntime could have its own DeclVendor, so let's hoist that out of ObjCLangua

[Lldb-commits] [lldb] r364223 - [ABI] Remove unused variables in ABIWindows_x86_64

Author: xiaobai Date: Mon Jun 24 12:43:22 2019 New Revision: 364223 URL: http://llvm.org/viewvc/llvm-project?rev=364223&view=rev Log: [ABI] Remove unused variables in ABIWindows_x86_64 Modified: lldb/trunk/source/Plugins/ABI/Windows-x86_64/ABIWindows_x86_64.cpp Modified: lldb/trunk/source/Pl

Re: [Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

Hi Alex, It seems that the two variables in file ABIWindows_x86_64.cpp are unused: Line 1656: field_bit_width Line 1666: field_byte_flags On Mon, Jun 24, 2019 at 11:23 AM Alex Langford via Phabricator via lldb-commits wrote: > This revision was automatically updated to reflect the committed ch

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

This revision was automatically updated to reflect the committed changes. Closed by commit rL364216: [ABI] Implement Windows ABI for x86_64 (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

[Lldb-commits] [lldb] r364216 - [ABI] Implement Windows ABI for x86_64

Author: xiaobai Date: Mon Jun 24 11:21:05 2019 New Revision: 364216 URL: http://llvm.org/viewvc/llvm-project?rev=364216&view=rev Log: [ABI] Implement Windows ABI for x86_64 Summary: Implement the ABI for WIndows-x86_64 including register info and calling convention. Handled nested struct returne

[Lldb-commits] [PATCH] D63730: Remove core loading timeout

labath created this revision. labath added reviewers: jingham, clayborg. Herald added a subscriber: aprantl. If target.preload-symbols is false, waiting for the process to "stop" can take an arbitrarily long amount of time, because it will cause all the debug info to be parsed (to compute the stop

[Lldb-commits] [lldb] r364210 - Move common functionality from processwindows into processdebugger

Author: asmith Date: Mon Jun 24 10:43:47 2019 New Revision: 364210 URL: http://llvm.org/viewvc/llvm-project?rev=364210&view=rev Log: Move common functionality from processwindows into processdebugger Summary: This change extracts functionalities from processwindows into a introduced processdebugg

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

clayborg added inline comments. Comment at: source/Core/ValueObject.cpp:1719 +// artificial. return GetVariable() && GetVariable()->IsArtificial(); } jingham wrote: > clayborg wrote: > > Things brings the questions: do we really need to filter these v

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

jingham added inline comments. Comment at: source/Core/ValueObject.cpp:1719 +// artificial. return GetVariable() && GetVariable()->IsArtificial(); } clayborg wrote: > Things brings the questions: do we really need to filter these variables? I > would

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

clayborg added inline comments. Comment at: source/Core/ValueObject.cpp:1719 +// artificial. return GetVariable() && GetVariable()->IsArtificial(); } Things brings the questions: do we really need to filter these variables? I wouldn't mind seeing "_c

[Lldb-commits] [PATCH] D63591: DWARFDebugLoc: Make parsing and error reporting more robust

clayborg added a comment. DataExtractor is a copy of the one from LLDB from a while back and changes have been made to adapt it to llvm. DataExtractor was designed so that you can have one of them (like for .debug_info or any other DWARF section) and use this same extractor from multiple thread

[Lldb-commits] [PATCH] D63591: DWARFDebugLoc: Make parsing and error reporting more robust

labath added a comment. In D63591#1553757 , @dblaikie wrote: > Given figuring out error handling for DataExtractor is perhaps a wider issue > - if you want to go ahead with this change (continue with the review & defer > error handling improvements for l

[Lldb-commits] [PATCH] D63591: DWARFDebugLoc: Make parsing and error reporting more robust

labath updated this revision to Diff 206205. labath added a comment. Leave a TODO in the code. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63591/new/ https://reviews.llvm.org/D63591 Files: include/llvm/DebugInfo/DWARF/DWARFDebugLoc.h lib/DebugInfo/DWARF/DWA

[Lldb-commits] [PATCH] D63643: DWARF: Add support for type units+split dwarf combo

labath updated this revision to Diff 206168. labath marked an inline comment as done. labath added a comment. Add some comments in SymbolFileDWARFDwo::ComputeCompileUnit CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63643/new/ https://reviews.llvm.org/D63643 Files: lit/SymbolFile/DWA

[Lldb-commits] [PATCH] D63643: DWARF: Add support for type units+split dwarf combo

labath marked 2 inline comments as done. labath added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwo.cpp:77 +llvm::dyn_cast(debug_info->GetUnitAtIndex(i))) { + if (cu) +return nullptr; JDevlieghere wrote:

[Lldb-commits] [PATCH] D63165: Initial support for native debugging of x86/x64 Windows processes

labath added inline comments. Comment at: lldb/source/Plugins/Process/Windows/Common/NativeProcessWindows.h:45-49 + NativeProcessWindows(ProcessLaunchInfo &launch_info, NativeDelegate &delegate, + llvm::Error &E); + + NativeProcessWindows(lldb::pid_t pid

[Lldb-commits] [PATCH] D63622: [Target] Hoist LanguageRuntime::GetDeclVendor

labath added a comment. In D63622#1553978 , @jingham wrote: > The runtime DeclVendor gives runtimes a way to produce type information from > runtime metadata. For instance, the ObjC runtime tables actually have fairly > good type information for all Obj