[Lldb-commits] [PATCH] D62503: Add ReadCStringFromMemory for faster string reads

jankratochvil added a comment. I was debugging it yesterday but I have no real result yet. There is/was a problem that initially it is run with: intern-state ProcessGDBRemote::GetLoadedModuleList intern-state parsing: intern-state found (link_map:0x77ffd990, base:0x77f

[Lldb-commits] [PATCH] D62503: Add ReadCStringFromMemory for faster string reads

teemperor added a comment. It seems to break looking up symbols from shared libraries. A simple reproducer is debugging a simple "Hello World" program in C on Linux (Arch Linux in my case, but it seems to also affect other distributions) #include int main() { printf("Hello World\n")

[Lldb-commits] [PATCH] D63802: Handle nested register definition xml files from the remote serial protocol stub

jasonmolenda created this revision. jasonmolenda added a reviewer: clayborg. Herald added a project: LLDB. I was looking at adding support for lldb connecting to qemu's x86_64 RSP stub. The target definition file we get back from it has a few wrinkles that complicate this, I'm thinking of handl

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

clayborg added a comment. In D63540#1556989 , @labath wrote: > In D63540#1550858 , @clayborg wrote: > > > So I am fine with symbols having zero size being in the symbol table. I > > would be fine not changing anyth

[Lldb-commits] [lldb] r364361 - Fix a typo in help text.

Author: amccarth Date: Tue Jun 25 16:13:16 2019 New Revision: 364361 URL: http://llvm.org/viewvc/llvm-project?rev=364361&view=rev Log: Fix a typo in help text. Modified: lldb/trunk/source/Interpreter/CommandInterpreter.cpp Modified: lldb/trunk/source/Interpreter/CommandInterpreter.cpp URL:

[Lldb-commits] [PATCH] D63790: [dotest] Add the ability to set environment variables for the inferior.

amccarth added a comment. The LGTM, but I wasn't nominated as a reviewer, and I was mostly looking at it from the point of Windows compatibility. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63790/new/ https://reviews.llvm.org/D63790 ___

[Lldb-commits] [PATCH] D63790: [dotest] Add the ability to set environment variables for the inferior.

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:1861 +if lldbtest_config.inferior_env: +self.runCmd('env {}'.format(lldbtest_config.inferior_env)) +

[Lldb-commits] [PATCH] D63790: [dotest] Add the ability to set environment variables for the inferior.

JDevlieghere updated this revision to Diff 206541. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63790/new/ https://reviews.llvm.org/D63790 Files: lldb/packages/Python/lldbsuite/test/dotest.py lldb/packages/Python/lldbsuite/test/dotest_args.py lldb/packages/Python/lldbsuite/test/ll

[Lldb-commits] [PATCH] D62503: Add ReadCStringFromMemory for faster string reads

aadsm added a comment. Reverted here: https://reviews.llvm.org/rG9c10b620c0619611dfe062216459431955ac4801 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62503/new/ https://reviews.llvm.org/D62503 ___ lldb-commits mail

[Lldb-commits] [PATCH] D63790: [dotest] Add the ability to set environment variables for the inferior.

amccarth added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:1861 +if lldbtest_config.inferior_env: +self.runCmd('env {}'.format(lldbtest_config.inferior_env)) + `env` or `settings set target.env-vars`? On Windo

[Lldb-commits] [PATCH] D62503: Add ReadCStringFromMemory for faster string reads

aadsm added a comment. I can't repro it right now so I prefer to revert it (I'm curious how this new function could influence those tests though). I actually thought this was sorted, sorry about that. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62503/new/ http

[Lldb-commits] [PATCH] D62503: Add ReadCStringFromMemory for faster string reads

teemperor added a comment. @aadsm Is there any update on the regression fix? This patch also breaks the C++ module test suite, so i would prefer if we could revert it if the fix takes longer. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62503/new/ https://revie

[Lldb-commits] [lldb] r364351 - [dotest] Remove unused function

Author: jdevlieghere Date: Tue Jun 25 14:19:44 2019 New Revision: 364351 URL: http://llvm.org/viewvc/llvm-project?rev=364351&view=rev Log: [dotest] Remove unused function The function `EnvArray` has no used. Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py Modified: lldb/trun

[Lldb-commits] [PATCH] D63792: [lldb] [Process/NetBSD] Use global enable bits for watchpoints

mgorny created this revision. mgorny added reviewers: krytarowski, labath, joerg. Set global enable bits (i.e. bits 1, 3, 5, 7) to enable watchpoints on NetBSD rather than the local enable bits (0, 2, 4, 6). The former are necessary for watchpoints to be correctly recognized by the NetBSD kernel.

[Lldb-commits] [PATCH] D63791: [lldb] [Process/NetBSD] Fix segfault when handling watchpoint

mgorny created this revision. mgorny added reviewers: krytarowski, labath. Fix the watchpoint/breakpoint code to search for matching thread entry in m_threads explicitly rather than assuming that it will be present at specified index. The previous code segfault since it wrongly assumed that the i

[Lldb-commits] [PATCH] D63790: [dotest] Add the ability to set environment variables for the inferior.

JDevlieghere created this revision. JDevlieghere added reviewers: davide, jingham. Herald added a project: LLDB. This patch adds a dotest flag for setting environment variables for the inferior. This is different from the current `--env` flag, which sets variables in the debugger's environment.

[Lldb-commits] [PATCH] D63667: Support __kernel_rt_sigreturn in frame initialization

JosephTremoulet updated this revision to Diff 206516. JosephTremoulet added a comment. - fix copy pasta Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63667/new/ https://reviews.llvm.org/D63667 Files: lldb/include/lldb/Symbol/UnwindPlan.h lldb

[Lldb-commits] [PATCH] D63667: Support __kernel_rt_sigreturn in frame initialization

JosephTremoulet added a comment. I've updated this with code to recognize the 'S' in the eh_frame augmentation and record it in a new bool member of UnwindPlan, `m_plan_is_for_signal_trap`. I haven't hooked up any consumers of the new bit; as you say, with the current code flow we don't parse

[Lldb-commits] [lldb] r364344 - Add a defensive check for nullptr as in the block above.

Author: adrian Date: Tue Jun 25 12:50:12 2019 New Revision: 364344 URL: http://llvm.org/viewvc/llvm-project?rev=364344&view=rev Log: Add a defensive check for nullptr as in the block above. Unfortunately I had to work backwards from a crash log, so I don't have a good testcase at this point in ti

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

xiaobai updated this revision to Diff 206506. xiaobai added a comment. Address feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63240/new/ https://reviews.llvm.org/D63240 Files: include/lldb/Target/CPPLanguageRuntime.h include/lldb/Target/LanguageRuntime.h include/lldb/Targ

[Lldb-commits] [PATCH] D63667: Support __kernel_rt_sigreturn in frame initialization

JosephTremoulet updated this revision to Diff 206505. JosephTremoulet added a comment. Herald added subscribers: jsji, atanasyan, jrtc27, kbarton, nemanjai. - Fix typos - Convey 'S' eh_frame augmentation to UnwindPlan Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[Lldb-commits] [PATCH] D63110: Fix a crash in option parsing.

aprantl added a comment. Thanks! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63110/new/ https://reviews.llvm.org/D63110 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

guiandrade added a comment. Just checking the status of this change. Are we still considering enabling 'g' packets unconditionally, or are we better off using the setting for safety? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62931/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

aprantl added inline comments. Comment at: source/Core/ValueObject.cpp:1699 if (process) { -LanguageRuntime *runtime = -process->GetLanguageRuntime(GetObjectRuntimeLanguage()); -if (!runtime) - runtime = ObjCLanguageRuntime::Get(*process); -if (runtime

[Lldb-commits] [lldb] r364335 - [Python] Flush prompt before reading input

Author: jdevlieghere Date: Tue Jun 25 10:27:38 2019 New Revision: 364335 URL: http://llvm.org/viewvc/llvm-project?rev=364335&view=rev Log: [Python] Flush prompt before reading input Make sure the prompt has been flushed before reading commands. Buffering is different in Python 3, which led to the

[Lldb-commits] [PATCH] D63745: [CMake] Check that a certificate for lldb is present at build time.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL364334: [CMake] Check that a certificate for lldb is present at build time. (authored by davide, committed by ). Herald ad

[Lldb-commits] [lldb] r364334 - [CMake] Check that a certificate for lldb is present at build time.

Author: davide Date: Tue Jun 25 10:13:24 2019 New Revision: 364334 URL: http://llvm.org/viewvc/llvm-project?rev=364334&view=rev Log: [CMake] Check that a certificate for lldb is present at build time. Reviewers: JDevlieghere, sgraenitz, aprantl, friss Subscribers: mgorny, lldb-commits Tags: #ll

[Lldb-commits] [PATCH] D63745: [CMake] Check that a certificate for lldb is present at build time.

sgraenitz added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63745/new/ https://reviews.llvm.org/D63745 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org

[Lldb-commits] [PATCH] D63745: [CMake] Check that a certificate for lldb is present at build time.

davide updated this revision to Diff 206475. davide added a comment. Address feedback from many. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63745/new/ https://reviews.llvm.org/D63745 Files: lldb/tools/debugserver/source/CMakeLists.txt Index

[Lldb-commits] [PATCH] D61233: Refactor ObjectFile::GetSDKVersion

teemperor updated this revision to Diff 206451. teemperor added a comment. - Rewrote patch to use llvm::VersionTuple (thanks Pavel) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61233/new/ https://reviews.llvm.org/D61233 Files: lldb/include/lldb/Symbol/ObjectFile.h lldb/source/Plug

[Lldb-commits] [PATCH] D61233: Refactor ObjectFile::GetSDKVersion

teemperor marked an inline comment as done. teemperor added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp:211 "SDKs/MacOSX%u.%u.sdk", - xcode_contents_path.c_str(), versions[0], -

[Lldb-commits] [PATCH] D63770: Options: Reduce code duplication

labath created this revision. labath added reviewers: mgorny, aprantl. While investigating breakages caused by D63110 , I noticed we were building the short options strings in three places. Some of them used a leading ':' to detect missing arguments, and some didn

[Lldb-commits] [PATCH] D63745: [CMake] Check that a certificate for lldb is present at build time.

davide added a comment. In D63745#1556941 , @labath wrote: > This code should go to `tools/debugserver/source/CMakeLists.txt` so that it > is next to the code which performs the actual code signing. Doing that will > make it easier to keep it in sync wit

[Lldb-commits] [PATCH] D63110: Fix a crash in option parsing.

labath added a comment. BTW, the new version was now failing on linux for a change. I believe r364317 ought to implement this in a way that is compatible with all getopt implementations that we are using... Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63110/new/

[Lldb-commits] [lldb] r364317 - Options: Correctly check for missing arguments

Author: labath Date: Tue Jun 25 07:02:39 2019 New Revision: 364317 URL: http://llvm.org/viewvc/llvm-project?rev=364317&view=rev Log: Options: Correctly check for missing arguments Relying on the value of optind for detecting missing arguments is unreliable because its value after a failed parse i

[Lldb-commits] [PATCH] D63745: [CMake] Check that a certificate for lldb is present at build time.

sgraenitz added a comment. > In D63745#1556941 , @labath wrote: > This code should go to tools/debugserver/source/CMakeLists.txt +1 More precisely, this is the condition where you want to do your check: https://github.com/llvm/llvm-project/blob/287f0403e

[Lldb-commits] [PATCH] D63745: [CMake] Check that a certificate for lldb is present at build time.

friss added a comment. In D63745#1556943 , @xiaobai wrote: > In D63745#1556773 , @JDevlieghere > wrote: > > > On second thought, let's check that LLDB_CODESIGN_IDENTITY equals > > `lldb_codesign` before doing this

[Lldb-commits] [PATCH] D63730: Remove core loading timeout

This revision was automatically updated to reflect the committed changes. Closed by commit rL364276: Remove core loading timeout (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://r

[Lldb-commits] [lldb] r364276 - Remove core loading timeout

Author: labath Date: Tue Jun 25 00:14:29 2019 New Revision: 364276 URL: http://llvm.org/viewvc/llvm-project?rev=364276&view=rev Log: Remove core loading timeout Summary: If target.preload-symbols is false, waiting for the process to "stop" can take an arbitrarily long amount of time, because it w

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

labath added a comment. In D63540#1550858 , @clayborg wrote: > So I am fine with symbols having zero size being in the symbol table. I would > be fine not changing anything in the sorting and leaving some symbols with > zero size, we just need to fix: >

[Lldb-commits] [PATCH] D63643: DWARF: Add support for type units+split dwarf combo

This revision was automatically updated to reflect the committed changes. Closed by commit rL364274: DWARF: Add support for type units+split dwarf combo (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE

[Lldb-commits] [lldb] r364274 - DWARF: Add support for type units+split dwarf combo

Author: labath Date: Mon Jun 24 23:59:48 2019 New Revision: 364274 URL: http://llvm.org/viewvc/llvm-project?rev=364274&view=rev Log: DWARF: Add support for type units+split dwarf combo Summary: With the last round of refactors, supporting type units in dwo files becomes almost trivial. This patch