[Lldb-commits] [PATCH] D62504: Avoid calling LoadModules twice when modules change

aadsm added a comment. I looked into this a bit today and at one point in time (when the list of modules is being processed) it seems that some previously loaded modules are somehow removed (at least I stop seeing them in the `image list`) including the one where the rendezvous breakpoint is so

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

xiaobai updated this revision to Diff 206994. xiaobai added a comment. Herald added a subscriber: jdoerfert. - Implement @jingham's suggestion - Change Function::GetLanguage to first guess the language from the name of the function you're in. - Fix a bug in DWARFASTParserClang::ParseFunctionFromD

[Lldb-commits] [PATCH] D62887: Update the thread list before setting stop reasons with an OS plugin

jingham marked 2 inline comments as done. jingham added inline comments. Comment at: source/Target/Process.cpp:3037-3041 + // Somebody might have gotten threads before now, but we need to force the + // update after we've loaded the OperatingSystem plugin or it won't get a + /

[Lldb-commits] [PATCH] D62887: Update the thread list before setting stop reasons with an OS plugin

jingham updated this revision to Diff 206980. jingham added a comment. Addresses Greg's question about what happens when we load a new OS plugin. Indeed we should limit the work we do only to the case where we didn't have an OS plugin, then tried to load one and succeeded. Only then do we need

[Lldb-commits] [PATCH] D63914: Make the expression parser work for missing weak symbols

jingham created this revision. jingham added reviewers: JDevlieghere, clayborg. Herald added subscribers: lldb-commits, teemperor, abidh. Herald added a project: LLDB. lldb wasn't handling weak symbols, so if you were debugging a binary that used a weak symbol, and the symbol was missing, any ref

Re: [Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

> On Jun 27, 2019, at 3:28 PM, Alex Langford via Phabricator > wrote: > > xiaobai added a comment. > > In D63240#1561531 , @jingham wrote: > >> In D63240#1561488 , @xiaobai wrote: >> >>> @jingham: Okay, so I t

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

xiaobai added a comment. In D63240#1561531 , @jingham wrote: > In D63240#1561488 , @xiaobai wrote: > > > @jingham: Okay, so I tried to do what you suggested and that solution > > doesn't work because of ObjC++. Aft

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

jingham added a comment. In D63240#1561488 , @xiaobai wrote: > @jingham: Okay, so I tried to do what you suggested and that solution doesn't > work because of ObjC++. After looking into it, it looks like Variable and > Function just ask the CompileUnit f

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

xiaobai added a comment. @jingham: Okay, so I tried to do what you suggested and that solution doesn't work because of ObjC++. After looking into it, it looks like Variable and Function just ask the CompileUnit for the language type instead of determining it themselves meaning that we determini

[Lldb-commits] [PATCH] D63667: Support __kernel_rt_sigreturn in frame initialization

JosephTremoulet added a comment. In D63667#1561365 , @jankratochvil wrote: > Shouldn't you add also symbol `__restore_rt` (Fedora 30 x86_64)? Thanks, yes, looks like I should. Updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D63667: Support __kernel_rt_sigreturn in frame initialization

JosephTremoulet updated this revision to Diff 206931. JosephTremoulet added a comment. - Include __restore_rt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63667/new/ https://reviews.llvm.org/D63667 Files: lldb/include/lldb/Symbol/UnwindPlan.h

[Lldb-commits] [PATCH] D63667: Support __kernel_rt_sigreturn in frame initialization

jankratochvil added a comment. Shouldn't you add also symbol `__restore_rt` (Fedora 30 x86_64)? (gdb) bt #0 handler (sig=6) at sigtest2.c:7 #1 #2 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50 #3 0x77dea895 in __GI_abort () at abort.c:79 #4 0x0

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

jankratochvil added a comment. In D63540#1558347 , @clayborg wrote: > I am saying to leave symbols with zero size as is _if_ there is another > symbol that does have a valid size with the same start address. This is what this patch does. > Exactly. The

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

jankratochvil updated this revision to Diff 206905. jankratochvil marked 2 inline comments as done. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63540/new/ https://reviews.llvm.org/D63540 Files: lldb/lit/SymbolFile/Inputs/sizeless-symbol.s lldb/lit/SymbolFi

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

jankratochvil marked 4 inline comments as done. jankratochvil added a comment. In D63540#1549977 , @labath wrote: > Why was it necessary to change the iteration order here? No, it was an accidental leftover. Thanks for the review. Co

[Lldb-commits] [PATCH] D63545: [lldb] [Process/NetBSD] Support reading YMM registers via PT_*XSTATE

mgorny added a comment. This is ready to be reviewed now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63545/new/ https://reviews.llvm.org/D63545 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[Lldb-commits] [lldb] r364562 - Add a sanity check to the domain socket tests.

Author: adrian Date: Thu Jun 27 09:45:23 2019 New Revision: 364562 URL: http://llvm.org/viewvc/llvm-project?rev=364562&view=rev Log: Add a sanity check to the domain socket tests. rdar://problem/52062631 Modified: lldb/trunk/unittests/Host/SocketTest.cpp Modified: lldb/trunk/unittests/Host/

[Lldb-commits] [PATCH] D63868: Unify+fix remote XML libraries handling with the legacy one

aadsm added a comment. The `library` is part of the GDB protocol itself: https://sourceware.org/gdb/onlinedocs/gdb/Stop-Reply-Packets.html#Stop-Reply-Packets and it's to be used with conjunction of `qXfer:libraries:read` (or libraries-svr4 like we do here). Interesting, I'm not familiar with S

[Lldb-commits] [PATCH] D63868: Unify+fix remote XML libraries handling with the legacy one

jankratochvil added a comment. In D63868#1560872 , @aadsm wrote: > I don't think we can stop loading/unloading the libraries in > `ProcessGDBRemote::LoadModules`. The windows dynamic loader relies on this Then it could be Windows-specific. > and the `l

[Lldb-commits] [PATCH] D62504: Avoid calling LoadModules twice when modules change

aadsm added a comment. @jankratochvil I imagine the first test to be failing because this patch doesn't handle correctly the unload (or rather as soon as it unloads one shared object it stops working as expected). I'm going to look at this today (right now it's 9am for me). Repository: rG LL

[Lldb-commits] [PATCH] D62504: Avoid calling LoadModules twice when modules change

jankratochvil added a comment. So it does fix the massive regression of D62503 similarly as my D63868 but it still has 2 regressions there (=Fedora 30 x86_64, after reapplication of D62503 ), I

[Lldb-commits] [PATCH] D63868: Unify+fix remote XML libraries handling with the legacy one

aadsm added a comment. I'm not sure why `DynamicLoaderPOSIXDYLD::RendezvousBreakpointHit` happens only once, I thought I had fixed that here: D62168 . I don't think we can stop loading/unloading the libraries in `ProcessGDBRemote::LoadModules`. The windows dynami

[Lldb-commits] [PATCH] D63868: Unify+fix remote XML libraries handling with the legacy one

jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp:185 - // If we can't get the SO info from the remote, return failure. - if (fromRemote && m_process->LoadModules(mo

[Lldb-commits] [PATCH] D63868: Unify+fix remote XML libraries handling with the legacy one

jankratochvil created this revision. jankratochvil added reviewers: aadsm, labath, xiaobai, clayborg. jankratochvil added a project: LLDB. Herald added a subscriber: abidh. jankratochvil marked an inline comment as done. jankratochvil added inline comments. jankratochvil retitled this revision from

[Lldb-commits] [lldb] r364503 - [lldb] [Plugins/SysV-x86_64] NetBSD is also using SysV ABI

Author: mgorny Date: Thu Jun 27 00:09:51 2019 New Revision: 364503 URL: http://llvm.org/viewvc/llvm-project?rev=364503&view=rev Log: [lldb] [Plugins/SysV-x86_64] NetBSD is also using SysV ABI Reenable SysV x86_64 ABI usage on NetBSD that was accidentally removed in r364216. This fixes numerous t

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

mgorny added inline comments. Comment at: lldb/trunk/source/Plugins/ABI/SysV-x86_64/ABISysV_x86_64.cpp:231 + case llvm::Triple::OSType::Solaris: + case llvm::Triple::OSType::UnknownOS: +return ABISP(new ABISysV_x86_64(process_sp)); There's NetBS