[Lldb-commits] [PATCH] D64194: [lldb] Fix crash due to unicode characters and dollars in variable names.

teemperor updated this revision to Diff 208569. teemperor retitled this revision from "[lldb] Fix crash due to dollar character in variable names." to "[lldb] Fix crash due to unicode characters and dollars in variable names.". teemperor edited the summary of this revision. teemperor added a comm

[Lldb-commits] [lldb] r365421 - Fix ASCII art header

Author: jdevlieghere Date: Mon Jul 8 18:35:34 2019 New Revision: 365421 URL: http://llvm.org/viewvc/llvm-project?rev=365421&view=rev Log: Fix ASCII art header Modified: lldb/trunk/source/Host/common/ThreadLauncher.cpp Modified: lldb/trunk/source/Host/common/ThreadLauncher.cpp URL: http://l

[Lldb-commits] [lldb] r365420 - [Windows] Include ErrorHandling.h

Author: jdevlieghere Date: Mon Jul 8 18:35:31 2019 New Revision: 365420 URL: http://llvm.org/viewvc/llvm-project?rev=365420&view=rev Log: [Windows] Include ErrorHandling.h Include ErrorHandling.h for mapWindowsError. Modified: lldb/trunk/source/Host/common/ThreadLauncher.cpp Modified: lldb

[Lldb-commits] [lldb] r365416 - [crashlog] Fix a mismatch between bytes and strings.

Author: davide Date: Mon Jul 8 18:05:12 2019 New Revision: 365416 URL: http://llvm.org/viewvc/llvm-project?rev=365416&view=rev Log: [crashlog] Fix a mismatch between bytes and strings. The functions in read_plist() want bytes as input, not strings. Modified: lldb/trunk/examples/python/cra

[Lldb-commits] [PATCH] D64365: [lldb] Let table gen create command option initializers.

teemperor marked an inline comment as done. teemperor added a comment. In D64365#1574785 , @jingham wrote: > Do you know how you are going to do enum option values? We could implement the enums in our table gen file, but then we would have the enums dup

[Lldb-commits] [PATCH] D64365: [lldb] Let table gen create command option initializers.

jingham added a comment. Do you know how you are going to do enum option values? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64365/new/ https://reviews.llvm.org/D64365 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://list

[Lldb-commits] [PATCH] D64365: [lldb] Let table gen create command option initializers.

teemperor marked 5 inline comments as done. teemperor added a comment. Thanks for the feedback! Comment at: lldb/source/Commands/BreakpointList.td:1 +include "Options.td" + xiaobai wrote: > Is BreakpointList.td used? I noticed `hide_aliases` is also implemented

[Lldb-commits] [PATCH] D64365: [lldb] Let table gen create command option initializers.

teemperor updated this revision to Diff 208539. teemperor marked 3 inline comments as done. teemperor added a comment. - Addressed feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64365/new/ https://reviews.llvm.org/D64365 Files: lldb/CMakeLists.txt lldb/cmake/modules/AddLLDB

[Lldb-commits] [PATCH] D64373: Don't use PyInt on Python 3

cbiesinger abandoned this revision. cbiesinger added a comment. It seems this wasn't necessary, I had just misconfigured my build. (I don't understand how this works though...) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64373/new/ https://revie

Re: [Lldb-commits] [lldb] r365390 - [Windows] Convert GetLastError to std::error_code

Thank you for the comments. Addressed in r365403. On Mon, Jul 8, 2019 at 3:40 PM Jim Ingham wrote: > Why is the thread ID getting checked against -1L? Did Windows not define > LLDB_INVALID_HOST_THREAD? > > Jim > > > On Jul 8, 2019, at 3:06 PM, Pavel Labath via lldb-commits < > lldb-commits@lists

[Lldb-commits] [lldb] r365403 - [ThreadLauncher] Use mapWindowsError and LLDB_INVALID_HOST_THREAD

Author: jdevlieghere Date: Mon Jul 8 15:45:59 2019 New Revision: 365403 URL: http://llvm.org/viewvc/llvm-project?rev=365403&view=rev Log: [ThreadLauncher] Use mapWindowsError and LLDB_INVALID_HOST_THREAD Address post-commit feedback from Pavel and Jim. Modified: lldb/trunk/source/Host/commo

Re: [Lldb-commits] [lldb] r365390 - [Windows] Convert GetLastError to std::error_code

Why is the thread ID getting checked against -1L? Did Windows not define LLDB_INVALID_HOST_THREAD? Jim > On Jul 8, 2019, at 3:06 PM, Pavel Labath via lldb-commits > wrote: > > Are you sure this will actually produce something meaningful? I know > llvm usually uses llvm::mapWindowsError for th

[Lldb-commits] [PATCH] D64373: Don't use PyInt on Python 3

cbiesinger created this revision. cbiesinger added a reviewer: clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In Python 3, PyInt doesn't exist (all integers are PyLongs). This patch makes LLVM not use PyInt when compiling for Python 3. (Some code already had such

[Lldb-commits] [PATCH] D64366: Add lldb type unit support to the release notes

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. 🎉 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64366/new/ https://reviews.llvm.org/D64366 ___ lldb-c

[Lldb-commits] [lldb] r365400 - [lldb, windows] When StartMonitoring fails, return a proper error

Author: stella.stamenova Date: Mon Jul 8 15:09:08 2019 New Revision: 365400 URL: http://llvm.org/viewvc/llvm-project?rev=365400&view=rev Log: [lldb, windows] When StartMonitoring fails, return a proper error This is possible now that the function returns an llvm::Expected Modified: lldb/tru

Re: [Lldb-commits] [lldb] r365390 - [Windows] Convert GetLastError to std::error_code

Are you sure this will actually produce something meaningful? I know llvm usually uses llvm::mapWindowsError for this kind of thing... On Mon, 8 Jul 2019 at 14:18, Jonas Devlieghere via lldb-commits wrote: > > Author: jdevlieghere > Date: Mon Jul 8 14:19:02 2019 > New Revision: 365390 > > URL: h

[Lldb-commits] [PATCH] D64365: [lldb] Let table gen create command option initializers.

JDevlieghere added inline comments. Comment at: lldb/cmake/modules/AddLLDB.cmake:16 + + if( NOT LTG_SOURCE ) +message(FATAL_ERROR "SOURCE source-file required by clang_tablegen") nit: remove the spaces to be consistent. Comment at: lldb/u

[Lldb-commits] [PATCH] D64365: [lldb] Let table gen create command option initializers.

xiaobai added a comment. This is awesome, thanks for doing this! I was also thinking about doing something like this at some point as well. :) Comment at: lldb/cmake/modules/AddLLDB.cmake:17 + if( NOT LTG_SOURCE ) +message(FATAL_ERROR "SOURCE source-file required by clang

[Lldb-commits] [PATCH] D57880: Add assert for 'bad' code path in GetUniqueNamespaceDeclaration

davide added inline comments. Comment at: lldb/trunk/source/Symbol/ClangASTContext.cpp:1957 } else { -// BAD!!! +assert(false && "GetUniqueNamespaceDeclaration called with no name and " +"no namespace as decl_ctx");

[Lldb-commits] [PATCH] D64042: [Symbol] Improve Variable::GetLanguage

xiaobai added a comment. In D64042#1574438 , @jingham wrote: > Why did you make this a function of Variable, rather than SymbolContextScope? After thinking about it more, I realized that the implementation inside of SymbolContextScope would be identical

[Lldb-commits] [PATCH] D64159: [Core] Generalize ValueObject::MaybeCalculateCompleteType

jingham added inline comments. Comment at: source/Target/ObjCLanguageRuntime.cpp:403 +CompilerType +ObjCLanguageRuntime::CalculateCompleteType(CompilerType base_type) { + CompilerType type_to_return; xiaobai wrote: > clayborg wrote: > > So a main question for Ob

[Lldb-commits] [lldb] r365392 - Remove install-headers

Author: jdevlieghere Date: Mon Jul 8 14:53:22 2019 New Revision: 365392 URL: http://llvm.org/viewvc/llvm-project?rev=365392&view=rev Log: Remove install-headers After discussing this internally, it is my understanding this was used for building LLDB internally at Apple, and is no longer used or

[Lldb-commits] [PATCH] D57880: Add assert for 'bad' code path in GetUniqueNamespaceDeclaration

davide added inline comments. Comment at: lldb/trunk/source/Symbol/ClangASTContext.cpp:1957 } else { -// BAD!!! +assert(false && "GetUniqueNamespaceDeclaration called with no name and " +"no namespace as decl_ctx");

[Lldb-commits] [lldb] r365391 - Remove lldb-perf

Author: jdevlieghere Date: Mon Jul 8 14:38:34 2019 New Revision: 365391 URL: http://llvm.org/viewvc/llvm-project?rev=365391&view=rev Log: Remove lldb-perf As discussed offline, this tool is no longer used or maintained, and doesn't provide the right abstraction for performance tracking in lldb.

[Lldb-commits] [PATCH] D64042: [Symbol] Improve Variable::GetLanguage

jingham added a comment. Why did you make this a function of Variable, rather than SymbolContextScope? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64042/new/ https://reviews.llvm.org/D64042 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [PATCH] D64159: [Core] Generalize ValueObject::MaybeCalculateCompleteType

xiaobai marked 2 inline comments as done. xiaobai added inline comments. Comment at: include/lldb/Target/ObjCLanguageRuntime.h:253 + CompilerType CalculateCompleteType(CompilerType base_type) override; + clayborg wrote: > Is this named correctly? Maybe this sh

[Lldb-commits] [PATCH] D57880: Add assert for 'bad' code path in GetUniqueNamespaceDeclaration

shafik added inline comments. Comment at: lldb/trunk/source/Symbol/ClangASTContext.cpp:1957 } else { -// BAD!!! +assert(false && "GetUniqueNamespaceDeclaration called with no name and " +"no namespace as decl_ctx");

[Lldb-commits] [PATCH] D64365: [lldb] Let table gen create command option initializers.

teemperor marked 3 inline comments as done. teemperor added inline comments. Comment at: lldb/utils/TableGen/LLDBOptionDefEmitter.cpp:26 +/// Map of command names to their associated records. +typedef std::map> RecordsByCommand; + labath wrote: > llvm::StringMap

[Lldb-commits] [PATCH] D64362: Remove lldb-perf

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Thanks Jonas, yes we need to come up with a perf testing infrastructure in lldb but there isn't a lot of value in this original attempt from c. 2013. Repository: rLLDB LLDB CHA

[Lldb-commits] [PATCH] D64365: [lldb] Let table gen create command option initializers.

teemperor updated this revision to Diff 208506. teemperor added a comment. - Added comment that std::map is also used to make sure our commands are sorted. - anonymous namespace -> static CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64365/new/ https://reviews.llvm.org/D64365 Files:

[Lldb-commits] [lldb] r365390 - [Windows] Convert GetLastError to std::error_code

Author: jdevlieghere Date: Mon Jul 8 14:19:02 2019 New Revision: 365390 URL: http://llvm.org/viewvc/llvm-project?rev=365390&view=rev Log: [Windows] Convert GetLastError to std::error_code Create a std::error_code from the result of GetLastError, which in turn we can use to return an llvm::Error.

[Lldb-commits] [PATCH] D64042: [Symbol] Improve Variable::GetLanguage

xiaobai added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64042/new/ https://reviews.llvm.org/D64042 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r365388 - [lldb] Fix two more issues in Windows following rL365226: Change LaunchThread interface to return an expected

Author: stella.stamenova Date: Mon Jul 8 14:17:58 2019 New Revision: 365388 URL: http://llvm.org/viewvc/llvm-project?rev=365388&view=rev Log: [lldb] Fix two more issues in Windows following rL365226: Change LaunchThread interface to return an expected A couple of the function signatures changed

[Lldb-commits] [PATCH] D64163: Change LaunchThread interface to return an expected.

labath added inline comments. Comment at: lldb/trunk/source/Core/Debugger.cpp:1652 +} else { + LLDB_LOG(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_HOST), + "failed to launch host thread: {}", I'm sorry to be such a nag, but this is

[Lldb-commits] [PATCH] D64365: [lldb] Let table gen create command option initializers.

labath added a comment. I like this, though I am not really familiar with details of implementing a tablegen backend. This should make it easier to migrate to the llvmOption library, once we arrive to that point. Comment at: lldb/utils/TableGen/LLDBOptionDefEmitter.cpp:26 +//

[Lldb-commits] [PATCH] D64267: lldb_assert: abort when assertions are enabled.

labath added a comment. `lldbassert(x)` already expands to `assert(x)` in a debug (LLDB_CONFIGURATION_DEBUG) build. It sounds like you want this to assert in a non-debug build which has assertions enabled (Release+Assertions) ? If that's the case, then I think we should just change the `#ifdef

[Lldb-commits] [PATCH] D64366: Add lldb type unit support to the release notes

labath created this revision. labath added reviewers: JDevlieghere, teemperor. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D64366 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst ==

[Lldb-commits] [PATCH] D64365: [lldb] Let table gen create command option initializers.

teemperor created this revision. teemperor added reviewers: JDevlieghere, davide, sgraenitz. Herald added subscribers: lldb-commits, abidh, mgorny. Herald added a project: LLDB. teemperor marked an inline comment as done. teemperor added inline comments. Comment at: lldb/source/C

[Lldb-commits] [PATCH] D64365: [lldb] Let table gen create command option initializers.

teemperor marked an inline comment as done. teemperor added inline comments. Comment at: lldb/source/Commands/OptionsBase.td:11 + // *.inc file. + string Command; +} I'm open to renaming this if anyone has a better name for this. Repository: rLLDB LLDB CHA

[Lldb-commits] [PATCH] D64254: Add lldb-mi deprecation to the release notes

labath added a comment. Random idea: Should we force the user to pass something like -DLLDB_TEMPORARILY_ENABLE_LLDB_MI to cmake to make sure it gets noticed that it is going away (I don't know how many people read release notes). And yeah, I should write something about type units in the releas

[Lldb-commits] [PATCH] D64194: [lldb] Fix crash due to dollar character in variable names.

teemperor added a comment. So the actual code that hit his use case was when one steps into the expression wrapper function we create in LLDB (which uses these dollar signs). So we (luckily) don't have any user code that triggers this. I should note that I anyway discovered that the variable lo

[Lldb-commits] [PATCH] D64194: [lldb] Fix crash due to dollar character in variable names.

clayborg added a comment. Do we really expect users to actually write code where variables start with '$'? We will need to make some clear rules of the lookup order if so. I would suggest the following order - look for real variables by exact name match first - look for expression global variab

[Lldb-commits] [lldb] r365371 - Revert "Move common functionality from processwindows into processdebugger"

Author: stella.stamenova Date: Mon Jul 8 11:53:32 2019 New Revision: 365371 URL: http://llvm.org/viewvc/llvm-project?rev=365371&view=rev Log: Revert "Move common functionality from processwindows into processdebugger" This reverts commit 9c01eaff6aa3f59d91530f47b85bb470377a7780. The changes in

[Lldb-commits] [PATCH] D64118: [lldb_test_suite] Fix lldb test suite targeting remote Android

kusmour updated this revision to Diff 208465. kusmour edited the summary of this revision. kusmour added a comment. added method skipIfTargetAndroid Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64118/new/ https://reviews.llvm.org/D64118 Files: lldb/package

[Lldb-commits] [PATCH] D64255: Remove lldb-mi

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Herald added a subscriber: dexonsmith. This was discussed on the mailing list and the consensus was that developers want

[Lldb-commits] [lldb] r365358 - [Host] Fix out-of-line definition on Windows

Author: jdevlieghere Date: Mon Jul 8 10:45:11 2019 New Revision: 365358 URL: http://llvm.org/viewvc/llvm-project?rev=365358&view=rev Log: [Host] Fix out-of-line definition on Windows Add missing interface changes after r365295. Modified: lldb/trunk/source/Host/windows/Host.cpp lldb/trun

[Lldb-commits] [lldb] r365344 - [Host] Fix out-of-line definition of StartMonitoringChildProcess

Author: jdevlieghere Date: Mon Jul 8 09:31:37 2019 New Revision: 365344 URL: http://llvm.org/viewvc/llvm-project?rev=365344&view=rev Log: [Host] Fix out-of-line definition of StartMonitoringChildProcess Modified: lldb/trunk/source/Host/macosx/objcxx/Host.mm Modified: lldb/trunk/source/Host/

[Lldb-commits] [lldb] r365338 - [lldb] [test] Update NetBSD XFAILs in test suite

Author: mgorny Date: Mon Jul 8 09:16:07 2019 New Revision: 365338 URL: http://llvm.org/viewvc/llvm-project?rev=365338&view=rev Log: [lldb] [test] Update NetBSD XFAILs in test suite Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/watchpoint/hello_watchlocation/TestWatchLo

Re: [Lldb-commits] [lldb] r365295 - Change LaunchThread interface to return an Expected for non-Apple-non-Windows

This looks to be broken on Windows: SeverityCodeDescription Project FileLineSuppression State Error C2555 'lldb_private::HostProcessWindows::StartMonitoring': overriding virtual function return type differs and is not covariant from 'lldb_private::HostNativeProcessB

[Lldb-commits] [lldb] r365295 - Change LaunchThread interface to return an Expected for non-Apple-non-Windows

Author: maskray Date: Mon Jul 8 00:07:05 2019 New Revision: 365295 URL: http://llvm.org/viewvc/llvm-project?rev=365295&view=rev Log: Change LaunchThread interface to return an Expected for non-Apple-non-Windows Fixes Linux build errors after D64163/r365226 Modified: lldb/trunk/include/lldb/