xiaobai abandoned this revision.
xiaobai added a comment.
Actually from the looks of it, I completely misunderstood what's going on here.
It looks like `AddToMap` should only be called by things that hold the mutex,
meaning that this change isn't actually necessary. I do think that makes this
c
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
No brainer.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64989/new/
https://reviews.llvm.org/D64989
___
lldb-
davide requested changes to this revision.
davide added a comment.
This revision now requires changes to proceed.
See if you can write a pexpect test, as Pavel suggested.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64995/new/
https://reviews.llvm.org/D64995
xiaobai added a comment.
ping
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64042/new/
https://reviews.llvm.org/D64042
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
xiaobai created this revision.
xiaobai added reviewers: JDevlieghere, clayborg, davide, labath, jingham.
Relying on m_clear_in_progress is dangerous for modifying m_map. It's
entirely possible for one thread to invoke TypeSystemMap::Clear(), lock
the mutex, and copy the map for finalization while
xiaobai accepted this revision.
xiaobai added a comment.
Excellent, thanks for taking care of this! :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64994/new/
https://reviews.llvm.org/D64994
___
lldb-
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb45853f17313: [lldb][NFC] Cleanup mentions and code related
to lldb-mi (authored by teemperor).
Herald added subscribers: krytarowski, srhines.
Changed prior to commit:
https://reviews.llvm.org/D64992?v
Author: teemperor
Date: Fri Jul 19 08:55:23 2019
New Revision: 366590
URL: http://llvm.org/viewvc/llvm-project?rev=366590&view=rev
Log:
[lldb][NFC] Cleanup mentions and code related to lldb-mi
Summary: lldb-mi has been removed, but there are still a bunch of references in
the code base. This pat
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: dexonsmith.
Thanks Raphael! I think I landed an older patch or something, I'm sure I
grep'ed for references when I was preparing the removal.
Repository
sgraenitz marked an inline comment as done.
sgraenitz added inline comments.
Comment at: lldb/test/CMakeLists.txt:113
+list(APPEND LLDB_TEST_COMMON_ARGS --server ${lldb_server_path})
+add_dependencies(lldb-test-deps lldb-server)
+ else()
Not sure if this
sgraenitz marked 2 inline comments as done.
sgraenitz added inline comments.
Comment at: lldb/trunk/tools/debugserver/source/CMakeLists.txt:50
-
-option(LLDB_NO_DEBUGSERVER "Disable the debugserver target" OFF)
-option(LLDB_USE_SYSTEM_DEBUGSERVER "Use the system's debugserver ins
labath added a comment.
This looks like a good opportunity to unleash pexpect.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64995/new/
https://reviews.llvm.org/D64995
___
lldb-commits mailing list
lldb-commits@lis
JosephTremoulet marked 2 inline comments as done.
JosephTremoulet added inline comments.
Comment at: lldb/source/Plugins/Process/Utility/RegisterContextLLDB.cpp:1760
+void RegisterContextLLDB::PropagateTrapHandlerFlag(
+lldb::UnwindPlanSP unwind_plan) {
+ if (unwind_plan->Ge
teemperor added a comment.
> I don't see any way to test this as the *multiline* expression completion is
> completely untested at the moment and I don't think we have any existing code
> for testing infrastructure for it.
Correct me if I'm wrong with this. I know we never test this functionali
teemperor created this revision.
teemperor added a reviewer: shafik.
Herald added subscribers: lldb-commits, abidh.
Herald added a project: LLDB.
teemperor added a comment.
> I don't see any way to test this as the *multiline* expression completion is
> completely untested at the moment and I don
sgraenitz created this revision.
sgraenitz added reviewers: xiaobai, JDevlieghere, davide.
Herald added a subscriber: mgorny.
Herald added a project: LLDB.
Make debugserver a tool like lldb-server, so it can be included/excluded via
`LLDB_TOOL_DEBUGSERVER_BUILD`. This replaces the old `LLDB_NO_DE
JosephTremoulet created this revision.
JosephTremoulet added reviewers: jasonmolenda, clayborg.
Herald added a reviewer: jfb.
Herald added a project: LLDB.
Update StackFrame::GetSymbolContext to mirror the logic in
RegisterContextLLDB::InitializeNonZerothFrame that knows not to do the
pc decrement
This revision was automatically updated to reflect the committed changes.
Closed by commit rL366580: Support Linux signal return trampolines in frame
initialization (authored by josepht, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit
teemperor created this revision.
teemperor added reviewers: davide, shafik.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
We assume in LLDB that every type comes from an ASTContext with an associated
ClangASTContext.
However the types inside the ClangModuleDeclVendor don'
sgraenitz marked an inline comment as done.
sgraenitz added inline comments.
Comment at: lldb/trunk/tools/debugserver/source/CMakeLists.txt:50
-
-option(LLDB_NO_DEBUGSERVER "Disable the debugserver target" OFF)
-option(LLDB_USE_SYSTEM_DEBUGSERVER "Use the system's debugserver ins
sgraenitz marked 2 inline comments as done.
sgraenitz added inline comments.
Comment at: lldb/trunk/tools/debugserver/source/CMakeLists.txt:50
-
-option(LLDB_NO_DEBUGSERVER "Disable the debugserver target" OFF)
-option(LLDB_USE_SYSTEM_DEBUGSERVER "Use the system's debugserver ins
Author: teemperor
Date: Fri Jul 19 03:23:22 2019
New Revision: 366561
URL: http://llvm.org/viewvc/llvm-project?rev=366561&view=rev
Log:
[lldb][NFC] Tablegenify target
Modified:
lldb/trunk/source/Commands/CommandObjectTarget.cpp
lldb/trunk/source/Commands/Options.td
lldb/trunk/source/C
Author: stefan.graenitz
Date: Fri Jul 19 03:20:35 2019
New Revision: 366560
URL: http://llvm.org/viewvc/llvm-project?rev=366560&view=rev
Log:
[NFC] Remove indent after r366433
Modified:
lldb/trunk/tools/debugserver/source/CMakeLists.txt
Modified: lldb/trunk/tools/debugserver/source/CMakeList
labath added inline comments.
Comment at:
lldb/source/Plugins/Process/Utility/RegisterContextWindows_x86_64.cpp:141
+GetRegisterInfo_WoW64(const lldb_private::ArchSpec &arch) {
+ // A WoW64 register info is the same as the i386's.
+ std::vector &g_register_infos =
Okay, merged in r366553.
On Thu, Jul 18, 2019 at 3:38 PM Stefan Gränitz
wrote:
>
> Hello Hans
>
> This commit would be very good to have on release/9.x. It simplifies a lot of
> code in the code-sign and testing logic for LLDB on Darwin. This would be
> useful for people who build their own LL
25 matches
Mail list logo
