[Lldb-commits] [PATCH] D65185: Let tablegen generate property definitions

JDevlieghere created this revision. JDevlieghere added reviewers: teemperor, friss, xiaobai, labath, clayborg. Herald added a subscriber: mgorny. Herald added a reviewer: jdoerfert. Herald added a project: LLDB. Property definitions are currently defined in a `PropertyDefinition` array and have a

[Lldb-commits] [PATCH] D65171: [LLDB] Find debugserver in Command Line Tools as well

jasonmolenda added a comment. LGTM. There was another problem I was discussing with someone the other week (I can't remember exactly the details) where we'd need to retrieve the Xcode install path so this would have been needed there too. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[Lldb-commits] [PATCH] D65171: [LLDB] Find debugserver in Command Line Tools as well

aadsm created this revision. aadsm added reviewers: clayborg, JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This might be an edge case in regular use but if you're shipping an lldb version with no debugserver lldb will try to use the System one. However, lld

[Lldb-commits] [PATCH] D65122: [Symbol] Use llvm::Expected when getting TypeSystems

xiaobai marked 4 inline comments as done. xiaobai added inline comments. Comment at: source/Core/ValueObjectRegister.cpp:261 + if (auto *exe_module = target->GetExecutableModulePointer()) { +if (auto type_system_or_err = +exe_module->GetTypeSystemForL

[Lldb-commits] [lldb] r366863 - [lldb] Fix enum value description

Author: jdevlieghere Date: Tue Jul 23 15:46:16 2019 New Revision: 366863 URL: http://llvm.org/viewvc/llvm-project?rev=366863&view=rev Log: [lldb] Fix enum value description Modified: lldb/trunk/utils/TableGen/LLDBTableGen.cpp Modified: lldb/trunk/utils/TableGen/LLDBTableGen.cpp URL: http://

[Lldb-commits] [PATCH] D64767: [lldb][test_suite] Update tests with unexpected pass on Android aarch64

This revision was automatically updated to reflect the committed changes. Closed by commit rL366858: [lldb][test_suite] Update tests with unexpected pass on Android aarch64 (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior t

[Lldb-commits] [lldb] r366858 - [lldb][test_suite] Update tests with unexpected pass on Android aarch64

Author: xiaobai Date: Tue Jul 23 15:12:16 2019 New Revision: 366858 URL: http://llvm.org/viewvc/llvm-project?rev=366858&view=rev Log: [lldb][test_suite] Update tests with unexpected pass on Android aarch64 Summary: update some test decorates that can actually pass on andriod aarch64 Patch by Wan

[Lldb-commits] [lldb] r366852 - [ExpressionParser] Fix formatting and whitespace (NFC)

Author: jdevlieghere Date: Tue Jul 23 14:14:23 2019 New Revision: 366852 URL: http://llvm.org/viewvc/llvm-project?rev=366852&view=rev Log: [ExpressionParser] Fix formatting and whitespace (NFC) Fix formatting and whitespace before making changes to this file. Modified: lldb/trunk/source/Plug

[Lldb-commits] [lldb] r366853 - [ExpressionParser] Handle llvm::Expected result

Author: jdevlieghere Date: Tue Jul 23 14:14:41 2019 New Revision: 366853 URL: http://llvm.org/viewvc/llvm-project?rev=366853&view=rev Log: [ExpressionParser] Handle llvm::Expected result This fixes the unchecked-error assertion at runtime. Expected must be checked before access or destruction.

[Lldb-commits] [PATCH] D65152: Fix issues with inferior stdout coming out of order

jingham added a comment. I agree with Greg, having one function that can do any of the combinations of stdout & stderr seems more convenient. Other than that, this is fine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65152/new/ https://reviews.llvm.org/D65152

[Lldb-commits] [PATCH] D65163: Fix occasional hangs of VSCode testcases

jankratochvil added a comment. One heisenbug down! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65163/new/ https://reviews.llvm.org/D65163 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.

[Lldb-commits] [PATCH] D65163: Fix occasional hangs of VSCode testcases

This revision was automatically updated to reflect the committed changes. Closed by commit rL366850: [lldb] Fix occasional hangs of VSCode testcases (authored by jankratochvil, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:

[Lldb-commits] [lldb] r366850 - [lldb] Fix occasional hangs of VSCode testcases

Author: jankratochvil Date: Tue Jul 23 13:45:03 2019 New Revision: 366850 URL: http://llvm.org/viewvc/llvm-project?rev=366850&view=rev Log: [lldb] Fix occasional hangs of VSCode testcases On slower machines the vscode testcases were sometimes hanging: 1910 ? Sl 0:00 | \_ /usr/bin/python .../

[Lldb-commits] [PATCH] D62503: Add ReadCStringFromMemory for faster string reads

aadsm added a comment. I've just done these 2 steps: - Revert rL364751 (which is a revert itself) - Revert 9c10b620c061 (will re-apply this one) Should be fine since now we have an option

[Lldb-commits] [PATCH] D64251: Don't depend on psutil on AIX

delcypher accepted this revision. delcypher added a comment. LGTM. @davide While I agree with sentiment of fixing psutil, the use of psutil was never meant to be permanent. As the owner of this code I don't mind making accommodations for other platforms provided we keep implementation details w

[Lldb-commits] [PATCH] D65123: Restore tests for lldb-server and lldb-vscode removed at rL366590

aadsm added a comment. @Hui what do you mean? the history is still there: $ git log lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py commit a61c247ce189efe7641dccb8ad7f85f60fc72220 (master) Author: Antonio Afonso Date: Mon Jul 22 23:35:05 2019 +

[Lldb-commits] [PATCH] D65165: [Symbol] Fix some botched logic in Variable::GetLanguage

xiaobai created this revision. xiaobai added a reviewer: labath. Herald added a reviewer: jdoerfert. I messed up the logic for this. Fixing with some improvements suggested by Pavel. https://reviews.llvm.org/D65165 Files: source/Symbol/Variable.cpp Index: source/Symbol/Variable.cpp

[Lldb-commits] [PATCH] D65135: SymbolVendor: Remove the type list member

JDevlieghere accepted this revision. JDevlieghere added inline comments. This revision is now accepted and ready to land. Comment at: source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp:1286 - size_t old_count = m_obj_file->GetModule()->GetTypeList()->GetSize(); + siz

[Lldb-commits] [PATCH] D65128: [Logging] Replace Log::Printf with LLDB_LOG macro (NFC)

JDevlieghere updated this revision to Diff 211350. JDevlieghere edited the summary of this revision. JDevlieghere added a comment. Introduce `LLDB_LOGF` macro to support printf-style format strings. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65128/new/ https://reviews.llvm.org/D65128

[Lldb-commits] [PATCH] D65163: Fix occasional hangs of VSCode testcases

clayborg added a comment. In D65163#1597902 , @labath wrote: > Thank you very much for tracking this down. Maybe wait a while to see if > @clayborg has any thoughts on this, but otherwise, this looks good to me. haha, I already accepted. So good to go.

[Lldb-commits] [PATCH] D65152: Fix issues with inferior stdout coming out of order

clayborg added inline comments. Comment at: include/lldb/Core/Debugger.h:350 + std::mutex m_output_flush_mutex; + void FlushProcessOutput(Process &process, bool is_stdout); What about making this function: ``` void Debugger::FlushProcessOutput(Process &proce

[Lldb-commits] [PATCH] D65109: [LLDB] Remove the Xcode project

jasonmolenda added a comment. In D65109#1597492 , @sgraenitz wrote: > Seriously, discussion for changes like this should be open for more than > 1h15min! I am in favor of the change in principle, but there's a number of > things that have been rushed ove

[Lldb-commits] [PATCH] D65163: Fix occasional hangs of VSCode testcases

labath accepted this revision. labath added a comment. Thank you very much for tracking this down. Maybe wait a while to see if @clayborg has any thoughts on this, but otherwise, this looks good to me. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65163/new/ h

[Lldb-commits] [PATCH] D65163: Fix occasional hangs of VSCode testcases

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. If all tests pass, then I am good with this. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65163/new/ https://reviews.llvm.org/D65163

[Lldb-commits] [PATCH] D65123: Restore tests for lldb-server and lldb-vscode removed at rL366590

jankratochvil added a comment. In D65123#1597229 , @jankratochvil wrote: > I was glad the `vscode` testcases are gone as they are racy causing many > false failures on our Fedora buildbot always hanging until the whole > testsuite gets killed: That sh

[Lldb-commits] [PATCH] D65163: Fix occasional hangs of VSCode testcases

jankratochvil created this revision. jankratochvil added reviewers: clayborg, labath, stella.stamenova, gkistanova. jankratochvil added a project: LLDB. Herald added a reviewer: JDevlieghere. Herald added a subscriber: lldb-commits. On slower machines the vscode testcases were sometimes hanging:

[Lldb-commits] [PATCH] D65123: Restore tests for lldb-server and lldb-vscode removed at rL366590

Hui added a comment. Any chance to restore the tracking history as well? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65123/new/ https://reviews.llvm.org/D65123 ___ lldb-commits mailing list lldb-commits@lists.llvm.o

[Lldb-commits] [PATCH] D65123: Restore tests for lldb-server and lldb-vscode removed at rL366590

jankratochvil added a comment. In D65123#1597742 , @aadsm wrote: > @jankratochvil interesting, we're also not able to run the lldb-vscode tests > and it was on my todo list to take a look. It is hanging in `vscode.py` function `recv_packet` somehow desp

[Lldb-commits] [lldb] r366833 - [utils] Remove sync-source (with SVN)

Author: jdevlieghere Date: Tue Jul 23 11:09:13 2019 New Revision: 366833 URL: http://llvm.org/viewvc/llvm-project?rev=366833&view=rev Log: [utils] Remove sync-source (with SVN) Removed: lldb/trunk/utils/sync-source/ ___ lldb-commits mailing list ll

[Lldb-commits] [PATCH] D65109: [LLDB] Remove the Xcode project

JDevlieghere added a comment. In D65109#1597492 , @sgraenitz wrote: > Seriously, discussion for changes like this should be open for more than > 1h15min! We discussed this and came to an agreement only a few hours before in the team meeting, which you

[Lldb-commits] [PATCH] D65155: [lldb] Remove Xcode project legacy

JDevlieghere added a comment. In D65155#1597750 , @JDevlieghere wrote: > In D65155#1597744 , @xiaobai wrote: > > > In D65155#1597710 , @JDevlieghere > > wrote: > > > > > In

[Lldb-commits] [PATCH] D65155: [lldb] Remove Xcode project legacy

JDevlieghere added a comment. In D65155#1597744 , @xiaobai wrote: > In D65155#1597710 , @JDevlieghere > wrote: > > > In D65155#1597657 , @lanza wrote: > > > > > Not directly

[Lldb-commits] [PATCH] D65155: [lldb] Remove Xcode project legacy

xiaobai added a comment. In D65155#1597710 , @JDevlieghere wrote: > In D65155#1597657 , @lanza wrote: > > > Not directly related, but there's some other legacy cruft I figure are > > valid for removal. e.g. > > >

[Lldb-commits] [PATCH] D65123: Restore tests for lldb-server and lldb-vscode removed at rL366590

aadsm added a comment. @jankratochvil interesting, we're also not able to run the lldb-vscode tests and it was on my todo list to take a look. Although I didn't realize it was a common think I thought it was specific to the environment where I was trying to run them. /cc @xiaobai. Thanks for lo

[Lldb-commits] [PATCH] D64042: [Symbol] Improve Variable::GetLanguage

xiaobai marked an inline comment as done. xiaobai added inline comments. Comment at: lldb/trunk/source/Symbol/Variable.cpp:61-69 + if (auto *func = m_owner_scope->CalculateSymbolContextFunction()) { +if ((lang = func->GetLanguage()) && lang != lldb::eLanguageTypeUnknown) +

[Lldb-commits] [PATCH] D65152: Fix issues with inferior stdout coming out of order

labath updated this revision to Diff 211328. labath added a comment. Remove sleep, left over from testing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65152/new/ https://reviews.llvm.org/D65152 Files: include/lldb/Core/Debugger.h include/lldb/Interpreter/CommandInterpreter.h so

[Lldb-commits] [PATCH] D65155: [lldb] Remove Xcode project legacy

JDevlieghere added a comment. In D65155#1597657 , @lanza wrote: > Not directly related, but there's some other legacy cruft I figure are valid > for removal. e.g. > > utils/sync-source > misc/grep-svn-log.py > git-svn/convert.py r366827. Reposit

[Lldb-commits] [lldb] r366827 - [Utils] Remove legacy scripts

Author: jdevlieghere Date: Tue Jul 23 10:23:36 2019 New Revision: 366827 URL: http://llvm.org/viewvc/llvm-project?rev=366827&view=rev Log: [Utils] Remove legacy scripts As pointed out by Nathan in D65155, these scrips don't seem to serve any real need anymore. Removed: lldb/trunk/utils/ ___

[Lldb-commits] [lldb] r366824 - [Logging] Fix format strings

Author: jdevlieghere Date: Tue Jul 23 10:03:37 2019 New Revision: 366824 URL: http://llvm.org/viewvc/llvm-project?rev=366824&view=rev Log: [Logging] Fix format strings Change format strings to use the `{}` syntax instead of the printf syntax when using LLDB_LOG. Modified: lldb/trunk/source/C

[Lldb-commits] [PATCH] D65155: [lldb] Remove Xcode project legacy

lanza accepted this revision. lanza added a comment. utils/sync-source misc/grep-svn-log.py Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65155/new/ https://reviews.llvm.org/D65155 ___ lldb-commits mai

[Lldb-commits] [PATCH] D64881: [Cmake] Use the modern way to find Python when possible

hans added a comment. In D64881#1596920 , @labath wrote: > I think setting > -DPYTHON_EXECUTABLE=C:\Users\hwennborg\AppData\Local\Programs\Python\Python36-32\python.exe > (or something) should be enough to get cmake to select python3 for the > interpret

[Lldb-commits] [PATCH] D65109: [LLDB] Remove the Xcode project

sgraenitz added a comment. [lldb] Remove Xcode project legacy: https://reviews.llvm.org/D65155 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65109/new/ https://reviews.llvm.org/D65109 ___ lldb-commits mailing list lld

[Lldb-commits] [PATCH] D65155: [lldb] Remove Xcode project legacy

sgraenitz created this revision. sgraenitz added reviewers: JDevlieghere, jasonmolenda, clayborg, jingham, lanza, teemperor. Herald added a subscriber: mgorny. Herald added a project: LLDB. Since D65109 removed the manually maintained Xcode project, there's a fe

[Lldb-commits] [PATCH] D65152: Fix issues with inferior stdout coming out of order

labath created this revision. labath added reviewers: clayborg, jingham. Herald added a subscriber: jfb. We've had a bug where two pieces of code, executing on two threads were attempting to write inferior output simultaneously. The first one was in Debugger::HandleProcessEvent, which handled the

[Lldb-commits] [PATCH] D65114: [LLDB] Add utility to streamline Xcode project generation.

sgraenitz resigned from this revision. sgraenitz added a comment. > Can we just use the mono-repo style build and use "cmake -G Xcode"? Yes you can, but then you have all of llvm/clang/libcxx/lldb in one project. For LLDB development that's usually not necessary. (And also, for Xcode it's a bit

[Lldb-commits] [PATCH] D64251: Don't depend on psutil on AIX

daltenty added a comment. Ping for an explicit acceptance. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64251/new/ https://reviews.llvm.org/D64251 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [PATCH] D65109: [LLDB] Remove the Xcode project

sgraenitz added a comment. Herald added a subscriber: ormris. Seriously, discussion for changes like this should be open for more than 1h15min! I am in favor of the change in principle, but there's a number of things that have been rushed over here, e.g.: cmake/XcodeHeaderGenerator/CMakeLists

[Lldb-commits] [PATCH] D65128: [Logging] Replace Log::Printf with LLDB_LOG macro (NFC)

JDevlieghere added a comment. In D65128#1596964 , @labath wrote: > I don't think you can make a change like this mechanically, and the reason is > not the file-function prepending, but the fact that the two styles use a > different format specifier synta

[Lldb-commits] [PATCH] D65123: Restore tests for lldb-server and lldb-vscode removed at rL366590

jyknight added a comment. In D65123#1596983 , @labath wrote: > In D65123#1596935 , @teemperor wrote: > > > Thanks for restoring this, but I'm a bit confused how this has happened. My > > original diff

[Lldb-commits] [lldb] r366804 - [lldb][NFC] Tablegenify process

Author: teemperor Date: Tue Jul 23 05:54:33 2019 New Revision: 366804 URL: http://llvm.org/viewvc/llvm-project?rev=366804&view=rev Log: [lldb][NFC] Tablegenify process Modified: lldb/trunk/source/Commands/CommandObjectProcess.cpp lldb/trunk/source/Commands/Options.td Modified: lldb/trunk

[Lldb-commits] [lldb] r366803 - ProcessMachCore: Fix a -Wmisleading-indentation warning

Author: labath Date: Tue Jul 23 05:53:45 2019 New Revision: 366803 URL: http://llvm.org/viewvc/llvm-project?rev=366803&view=rev Log: ProcessMachCore: Fix a -Wmisleading-indentation warning Modified: lldb/trunk/source/Plugins/Process/mach-core/ProcessMachCore.cpp Modified: lldb/trunk/source/P

[Lldb-commits] [PATCH] D65123: Restore tests for lldb-server and lldb-vscode removed at rL366590

jankratochvil added subscribers: kwk, jankratochvil. jankratochvil added a comment. I was glade the `vscode` testcases are gone as they are racy causing many false failures on our Fedora buildbot always hanging until the whole testsuite gets killed: 1910 ?Sl 0:00 | \_ /

[Lldb-commits] [lldb] r366798 - Fix windows build after r366791

Author: labath Date: Tue Jul 23 05:26:09 2019 New Revision: 366798 URL: http://llvm.org/viewvc/llvm-project?rev=366798&view=rev Log: Fix windows build after r366791 A side effect of this commit was that it exchanged the order of types and compile units in the output of SymbolVendor::Dump. A coupl

[Lldb-commits] [lldb] r366795 - [lldb][NFC] Tablegenify source

Author: teemperor Date: Tue Jul 23 04:08:12 2019 New Revision: 366795 URL: http://llvm.org/viewvc/llvm-project?rev=366795&view=rev Log: [lldb][NFC] Tablegenify source Modified: lldb/trunk/source/Commands/CommandObjectSource.cpp lldb/trunk/source/Commands/Options.td Modified: lldb/trunk/s

[Lldb-commits] [PATCH] D64042: [Symbol] Improve Variable::GetLanguage

labath added inline comments. Herald added a reviewer: jdoerfert. Comment at: lldb/trunk/source/Symbol/Variable.cpp:61-69 + if (auto *func = m_owner_scope->CalculateSymbolContextFunction()) { +if ((lang = func->GetLanguage()) && lang != lldb::eLanguageTypeUnknown) + ret

[Lldb-commits] [PATCH] D65135: SymbolVendor: Remove the type list member

labath created this revision. labath added reviewers: clayborg, JDevlieghere, jingham. Similarly to the compile unit lists, the list of types can also be managed by the symbol file itself. Since the only purpose of this list seems to be to maintain an owning reference to all the types a symbol fi

[Lldb-commits] [PATCH] D65089: SymbolVendor: Move compile unit handling into the SymbolFile class

This revision was automatically updated to reflect the committed changes. Closed by commit rL366791: SymbolVendor: Move compile unit handling into the SymbolFile class (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM

[Lldb-commits] [lldb] r366791 - SymbolVendor: Move compile unit handling into the SymbolFile class

Author: labath Date: Tue Jul 23 02:24:02 2019 New Revision: 366791 URL: http://llvm.org/viewvc/llvm-project?rev=366791&view=rev Log: SymbolVendor: Move compile unit handling into the SymbolFile class Summary: SymbolFile classes are responsible for creating CompileUnit instances and they already n

[Lldb-commits] [PATCH] D65089: SymbolVendor: Move compile unit handling into the SymbolFile class

labath updated this revision to Diff 211265. labath added a comment. Herald added a reviewer: jdoerfert. - Make the compile unit list an Optional to have an explicit way of saying "we've already tried to compute the number of units and it was zero" CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D65123: Restore tests for lldb-server and lldb-vscode removed at rL366590

labath added subscribers: jyknight, mehdi_amini. labath added a comment. In D65123#1596935 , @teemperor wrote: > Thanks for restoring this, but I'm a bit confused how this has happened. My > original diff didn't

[Lldb-commits] [PATCH] D65129: Test load unloading of modules with libraries-svr4

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This is python, so there are always ways to make this work without copy-pasting, but I'm not sure that's such a good idea in this case. Doing things this way is probably fine... Repository:

[Lldb-commits] [PATCH] D65128: [Logging] Replace Log::Printf with LLDB_LOG macro (NFC)

labath added a comment. I don't think you can make a change like this mechanically, and the reason is not the file-function prepending, but the fact that the two styles use a different format specifier syntax (printf vs. the llvm formatv thingy). If you change the function without changing the

[Lldb-commits] [PATCH] D65123: Restore tests for lldb-server and lldb-vscode removed at rL366590

teemperor added a comment. Thanks for restoring this, but I'm a bit confused how this has happened. My original diff didn't remove these folders, but it seems when I committed the diff via arcanist and `git llvm` it also removed these other folders. I

[Lldb-commits] [PATCH] D65122: [Symbol] Use llvm::Expected when getting TypeSystems

labath added a comment. Herald added a reviewer: jdoerfert. The intention is for the pointer in `Expected` to be non-null in the success case, right? If that's true, then I'd suggest to make that explicit by returning a reference (`Expected`) instead. Comment at: source/Core/

[Lldb-commits] [PATCH] D65123: Restore tests for lldb-server and lldb-vscode removed at rL366590

labath added a comment. Herald added a subscriber: ormris. Thanks. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65123/new/ https://reviews.llvm.org/D65123 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [lldb] r366783 - [lldb][NFC] Tablegenify disassemble

Author: teemperor Date: Tue Jul 23 00:15:54 2019 New Revision: 366783 URL: http://llvm.org/viewvc/llvm-project?rev=366783&view=rev Log: [lldb][NFC] Tablegenify disassemble Modified: lldb/trunk/source/Commands/CommandObjectDisassemble.cpp lldb/trunk/source/Commands/Options.td Modified: ll

[Lldb-commits] [PATCH] D64881: [Cmake] Use the modern way to find Python when possible

labath added a comment. I think setting -DPYTHON_EXECUTABLE=C:\Users\hwennborg\AppData\Local\Programs\Python\Python36-32\python.exe (or something) should be enough to get cmake to select python3 for the interpreter as well. As for the version mismatch, the one of the reasons why the mismatched