[Lldb-commits] [PATCH] D48704: [ExecutionContext] Return the target/process byte order.

labath accepted this revision. labath added a comment. Thanks for setting this up. The infrastructure is a bit overkill for a simple test like this, but hopefully this can be useful for other tests too. I have a bunch of comments, but hopefully none of them are major, so if you agree with all o

[Lldb-commits] [PATCH] D48704: [LLDB] Fix for "Bug 37950: ExecutionContext::GetByteOrder() always returns endian::InlHostByteOrder()"

JDevlieghere updated this revision to Diff 213797. JDevlieghere added a comment. Herald added a subscriber: mgorny. Add unit test Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48704/new/ https://reviews.llvm.org/D48704 Files: lldb/source/Target/ExecutionCont

[Lldb-commits] [PATCH] D65822: Detect HAVE_SYS_TYPES_H in lldb

This revision was automatically updated to reflect the committed changes. Closed by commit rL368125: Detect HAVE_SYS_TYPES_H in lldb (authored by hhb, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D65822?

[Lldb-commits] [PATCH] D65822: Detect HAVE_SYS_TYPES_H in lldb

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Woops, this is quite embarrassing. :/ One day we should audit these to check which of these files really needs to include this header, but since there are at least some files that definitely

[Lldb-commits] [PATCH] D65798: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly

labath added inline comments. Comment at: lldb/cmake/modules/LLDBStandalone.cmake:6 + # next to LLVM's module directory. + set(Clang_DIR ${LLVM_DIR}/../clang) + message(STATUS "Inferred Clang_DIR: ${Clang_DIR}") sgraenitz wrote: > compnerd wrote: > > sgraenitz

[Lldb-commits] [lldb] r368118 - Upstream a few small Apple changes to debugserver - arm64_32, Catalyst

Author: jmolenda Date: Tue Aug 6 19:06:06 2019 New Revision: 368118 URL: http://llvm.org/viewvc/llvm-project?rev=368118&view=rev Log: Upstream a few small Apple changes to debugserver - arm64_32, Catalyst Adrian's changes to support Catalyst processes and my changes to support debugserver runnin

[Lldb-commits] [lldb] r368116 - [Gardening] Remove more dead code from IOHandler

Author: jdevlieghere Date: Tue Aug 6 18:50:03 2019 New Revision: 368116 URL: http://llvm.org/viewvc/llvm-project?rev=368116&view=rev Log: [Gardening] Remove more dead code from IOHandler Remove more dead code and reformat the file. Modified: lldb/trunk/source/Core/IOHandler.cpp Modified: l

[Lldb-commits] [PATCH] D65826: Add support for deterministically linked binaries on macOS to lldb.

JDevlieghere added inline comments. Comment at: lldb/lit/SymbolFile/DWARF/deterministic-build.cpp:1 +// Test that binaries linked deterministically (N_OSO has timestamp 0) can still +// have their object files loaded by lldb. Note that the env var ZERO_AR_DATE Y

[Lldb-commits] [PATCH] D65826: Add support for deterministically linked binaries on macOS to lldb.

erikchen added a comment. Okay, this is ready for another round of review when you have time. Thanks :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65826/new/ https://reviews.llvm.org/D65826 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D65826: Add support for deterministically linked binaries on macOS to lldb.

erikchen updated this revision to Diff 213758. erikchen added a comment. Added a test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65826/new/ https://reviews.llvm.org/D65826 Files: lldb/lit/SymbolFile/DWARF/Inputs/deterministic-build.lldbinit lldb/lit/SymbolFile/DWARF/determinist

[Lldb-commits] [PATCH] D65566: [lldb][CMake] Workaround debugserver code-signing issue in generated Xcode project

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Okay, sounds like the best possible solution. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65566/new/ https://reviews.llvm.org/D655

[Lldb-commits] [PATCH] D65822: Detect HAVE_SYS_TYPES_H in lldb

hhb updated this revision to Diff 213726. hhb added a comment. Fix comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65822/new/ https://reviews.llvm.org/D65822 Files: lldb/cmake/modules/LLDBGenerateConfig.cmake lldb/include/lldb/Host/Conf

[Lldb-commits] [PATCH] D65646: [lldb] Print better diagnostics for user expressions.

JDevlieghere added a comment. LGTM, but you might want to have someone with more functional knowledge give the go-ahead. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65646/new/ https://reviews.llvm.org/D65646 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D65798: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly

sgraenitz added inline comments. Comment at: lldb/cmake/modules/LLDBStandalone.cmake:6 + # next to LLVM's module directory. + set(Clang_DIR ${LLVM_DIR}/../clang) + message(STATUS "Inferred Clang_DIR: ${Clang_DIR}") compnerd wrote: > sgraenitz wrote: > > compne

[Lldb-commits] [PATCH] D65826: Add support for deterministically linked binaries on macOS to lldb.

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. I agree with Reid, change looks fine but this definitely needs a test. The Python-style tests in `packages/Python/lldbsuite/test` give you the most freedom as they use ma

[Lldb-commits] [PATCH] D65646: [lldb] Print better diagnostics for user expressions.

teemperor updated this revision to Diff 213705. teemperor added a comment. - Addressed some feedback I forgot. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65646/new/ https://reviews.llvm.org/D65646 Files: clang/include/clang/Basic/DiagnosticOptions.def clang/lib/Frontend/TextDiag

[Lldb-commits] [PATCH] D65646: [lldb] Print better diagnostics for user expressions.

teemperor marked 4 inline comments as done. teemperor added a comment. Fixed some of the unrelated comments in a separate commit (that is already upstreamed). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65646/new/ https://reviews.llvm.org/D65646 ___

[Lldb-commits] [PATCH] D65826: Add support for deterministically linked binaries on macOS to lldb.

rnk added a comment. Code seems fine, I think this is probably the right fix, but this probably deserves a test along the lines of what's in the commit message. I'm not familiar with LLDB's test suite, so I can't give much guidance there. Let's see if @JDevlieghere has input. Repository: rL

[Lldb-commits] [PATCH] D65646: [lldb] Print better diagnostics for user expressions.

teemperor updated this revision to Diff 213703. teemperor added a comment. - Addressed feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65646/new/ https://reviews.llvm.org/D65646 Files: clang/include/clang/Basic/DiagnosticOptions.def clang/lib/Frontend/TextDiagnostic.cpp l

[Lldb-commits] [PATCH] D65826: Add support for deterministically linked binaries to lldb.

erikchen created this revision. erikchen added a reviewer: rnk. Herald added a reviewer: JDevlieghere. Herald added subscribers: lldb-commits, abidh, mgrang. Herald added a reviewer: jdoerfert. Herald added a project: LLDB. When ld64 links a binary deterministically using the flag ZERO_AR_DATE, it

[Lldb-commits] [lldb] r368082 - [lldb][NFC] Minor refactorings to (Clang)ExpressionSourceCode

Author: teemperor Date: Tue Aug 6 13:25:02 2019 New Revision: 368082 URL: http://llvm.org/viewvc/llvm-project?rev=368082&view=rev Log: [lldb][NFC] Minor refactorings to (Clang)ExpressionSourceCode Modified: lldb/trunk/include/lldb/Expression/ExpressionSourceCode.h lldb/trunk/source/Plugi

[Lldb-commits] [PATCH] D65611: [Driver] Expand the executable path in the target create output

clayborg added a comment. I am fine with full path as long as argv[0] still behaves correctly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65611/new/ https://reviews.llvm.org/D65611 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [PATCH] D65798: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly

compnerd added inline comments. Comment at: lldb/cmake/modules/LLDBStandalone.cmake:6 + # next to LLVM's module directory. + set(Clang_DIR ${LLVM_DIR}/../clang) + message(STATUS "Inferred Clang_DIR: ${Clang_DIR}") sgraenitz wrote: > compnerd wrote: > > What ha

[Lldb-commits] [lldb] r368075 - [SymbolFile] Remove commented out method

Author: xiaobai Date: Tue Aug 6 12:47:08 2019 New Revision: 368075 URL: http://llvm.org/viewvc/llvm-project?rev=368075&view=rev Log: [SymbolFile] Remove commented out method Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugLine.cpp lldb/trunk/source/Plugins/SymbolFile/DWARF

[Lldb-commits] [PATCH] D65822: Detect HAVE_SYS_TYPES_H in lldb

srhines added inline comments. Comment at: lldb/include/lldb/Host/windows/PosixApi.h:56 #endif #endif // __MINGW32__ Update comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65822/new/ https://reviews.llv

[Lldb-commits] [PATCH] D65822: Detect HAVE_SYS_TYPES_H in lldb

hhb updated this revision to Diff 213689. hhb added a comment. Herald added a subscriber: mstorsjo. Add one more place Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65822/new/ https://reviews.llvm.org/D65822 Files: lldb/cmake/modules/LLDBGenerat

[Lldb-commits] [PATCH] D65822: Detect HAVE_SYS_TYPES_H in lldb

hhb added a comment. I'm not really know how this works before, given no one includes Config.h. Or maybe sys/types.h is never needed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65822/new/ https://reviews.llvm.org/D65822 _

[Lldb-commits] [PATCH] D65822: Detect HAVE_SYS_TYPES_H in lldb

hhb updated this revision to Diff 213688. hhb added a comment. Remove test code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65822/new/ https://reviews.llvm.org/D65822 Files: lldb/cmake/modules/LLDBGenerateConfig.cmake lldb/include/lldb/Host/

[Lldb-commits] [PATCH] D65822: Detect HAVE_SYS_TYPES_H in lldb

hhb updated this revision to Diff 213687. hhb added a comment. Remove a test code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65822/new/ https://reviews.llvm.org/D65822 Files: lldb/cmake/modules/LLDBGenerateConfig.cmake lldb/include/lldb/Ho

[Lldb-commits] [PATCH] D65822: Detect HAVE_SYS_TYPES_H in lldb

hhb created this revision. hhb added a reviewer: labath. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. After rL368069 I noticed that HAVE_SYS_TYPES_H is not defined in Platform.h, or anywhere else in lldb. This change fixes that.

[Lldb-commits] [PATCH] D65691: Various build fixes for lldb on MinGW

This revision was automatically updated to reflect the committed changes. Closed by commit rL368069: Various build fixes for lldb on MinGW (authored by hhb, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D65611: [Driver] Expand the executable path in the target create output

jingham added a comment. Given that we do some work to find executables (like search along the path for "ls" -> /bin/ls") which work might not end up with the result you expected, printing the full path seems useful. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65611/new/ https://rev

[Lldb-commits] [PATCH] D65611: [Driver] Expand the executable path in the target create output

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I don't know if anyone has strong opinions on how we should print this, but I think I slightly prefer the seeing the full path. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65611/new

[Lldb-commits] [PATCH] D65797: [lldb][CMake] Generating Xcode projects

This revision was automatically updated to reflect the committed changes. Closed by commit rL368066: [lldb][CMake] Generating Xcode projects (authored by stefan.graenitz, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revi

[Lldb-commits] [lldb] r368066 - [lldb][CMake] Generating Xcode projects

Author: stefan.graenitz Date: Tue Aug 6 10:21:34 2019 New Revision: 368066 URL: http://llvm.org/viewvc/llvm-project?rev=368066&view=rev Log: [lldb][CMake] Generating Xcode projects Summary: Print a warning if the wrong cache script is used when generating a Xcode project, because it's too easy

[Lldb-commits] [PATCH] D65566: [lldb][CMake] Workaround debugserver code-signing issue in generated Xcode project

sgraenitz added a comment. Solutions are clearly favorable over workarounds like this, but I couldn't find one. Xcode has a mechanism called `sign on copy` which seems to be the native way to avoid this problem, but I couldn't get it to work with LLDB, because I want to copy the build output of

[Lldb-commits] [PATCH] D65691: Various build fixes for lldb on MinGW

jingham added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:55 #define PATH_MAX MAX_PATH +#endif typedef int socklen_t; labath wrote: > amccarth wrote: > > hhb wrote: > > > amccarth wrote: > > > > Nothing in the rest of this .cpp file uses

[Lldb-commits] [PATCH] D65797: [lldb][CMake] Generating Xcode projects

jingham added a comment. Thanks for doing this. Looks okay to me just one typo... But I don't know CMake well enough to comment on substance... Comment at: lldb/cmake/modules/LLDBConfig.cmake:78 + "When building with Xcode, we recommend using the corresponding cache sc

[Lldb-commits] [PATCH] D65611: [Driver] Expand the executable path in the target create output

JDevlieghere updated this revision to Diff 213640. JDevlieghere retitled this revision from "[Driver] Expand the target in the driver." to "[Driver] Expand the executable path in the target create output". JDevlieghere edited the summary of this revision. CHANGES SINCE LAST ACTION https://revie

[Lldb-commits] [PATCH] D65797: [lldb][CMake] Generating Xcode projects

sgraenitz updated this revision to Diff 213637. sgraenitz marked an inline comment as done. sgraenitz added a comment. Improve warning message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65797/new/ https://reviews.llvm.org/D65797 Files: lldb/c

[Lldb-commits] [PATCH] D65797: [lldb][CMake] Generating Xcode projects

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Small comment about the working, but the change itself LGTM. Comment at: lldb/cmake/modules/LLDBConfig.cmake:77 +message(WARNING + "When building with Xc

[Lldb-commits] [PATCH] D65646: [lldb] Print better diagnostics for user expressions.

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:267 : ExpressionParser(exe_scope, expr, generate_debug_info), m_compiler(), - m_pp_callbacks(nullptr), + m_pp_callbacks(nullptr), m_filename(filena

[Lldb-commits] [PATCH] D65798: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly

sgraenitz added inline comments. Comment at: lldb/cmake/modules/LLDBStandalone.cmake:6 + # next to LLVM's module directory. + set(Clang_DIR ${LLVM_DIR}/../clang) + message(STATUS "Inferred Clang_DIR: ${Clang_DIR}") compnerd wrote: > What happens in the standal

[Lldb-commits] [PATCH] D65798: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly

compnerd added inline comments. Comment at: lldb/cmake/modules/LLDBStandalone.cmake:6 + # next to LLVM's module directory. + set(Clang_DIR ${LLVM_DIR}/../clang) + message(STATUS "Inferred Clang_DIR: ${Clang_DIR}") What happens in the standalone clang build sce

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

asmith added a comment. Do you need some help fixing the build? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62213/new/ https://reviews.llvm.org/D62213 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:

[Lldb-commits] [PATCH] D65640: Update LLDB to follow changes in llvm::DWARFDebugNames::NameIndex (4/5)

This revision was automatically updated to reflect the committed changes. Closed by commit rL368033: Update LLDB to follow changes in llvm::DWARFDebugNames::NameIndex (4/5) (authored by ikudrin, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior t

[Lldb-commits] [PATCH] D65646: [lldb] Print better diagnostics for user expressions.

teemperor updated this revision to Diff 213587. teemperor edited the summary of this revision. teemperor added a comment. - We now enumerate the fake expression files. E.g. ``. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65646/new/ https://reviews.llvm.org/D65646 Files: clang/inclu

[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Support encoding a current working directory in a VFS mapping.

sammccall added a comment. > I'd like to know if you tried other approaches and why they failed. +1. In particular, what goes wrong if you try to make the working directory a sibling of VFS (within the reproducer container) rather than a child of it (within shared infrastructure)? Repository:

[Lldb-commits] [PATCH] D65798: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly

sgraenitz created this revision. sgraenitz added reviewers: JDevlieghere, jingham, xiaobai, compnerd, labath. Herald added a subscriber: mgorny. Herald added a project: LLDB. This shrinks standalone configuration lines by one more parameter. In the provided build-tree, the default structure of CM

[Lldb-commits] [PATCH] D65797: [lldb][CMake] Generating Xcode projects

sgraenitz created this revision. sgraenitz added reviewers: JDevlieghere, jingham, clayborg. Herald added a subscriber: mgorny. Herald added a project: LLDB. Print a warning if the wrong cache script is used when generating a Xcode project, because it's too easy to confuse with Apple-lldb-macOS.c

[Lldb-commits] [PATCH] D65282: ObjectFileELF: permit thread-local sections with overlapping file addresses

This revision was automatically updated to reflect the committed changes. Closed by commit rL368010: ObjectFileELF: permit thread-local sections with overlapping file addresses (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository:

[Lldb-commits] [lldb] r368010 - ObjectFileELF: permit thread-local sections with overlapping file addresses

Author: labath Date: Tue Aug 6 03:04:27 2019 New Revision: 368010 URL: http://llvm.org/viewvc/llvm-project?rev=368010&view=rev Log: ObjectFileELF: permit thread-local sections with overlapping file addresses Summary: In an attempt to make file-address-based lookups more predictable, in D55998 we

[Lldb-commits] [PATCH] D65611: [Driver] Expand the target in the driver.

labath added a comment. In D65611#1615161 , @JDevlieghere wrote: > We definitely need the VFS change for the reproducers, no argument there. My > earlier comment was more about the change in general, orthogonal to the > reproducers. Ah, I see. Thanks

[Lldb-commits] [PATCH] D65789: A more robust way of testing debug_line parser near the end of module

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: lit/SymbolFile/DWARF/Inputs/debug-line-basic.script:6 + .shstrtab : { *(.shstrtab) } + .debug_info0 : { *(.debug_info ) } + .debug_line0 : { *(.

[Lldb-commits] [lldb] r368001 - SymbolVendor: Remove passthrough methods

Author: labath Date: Tue Aug 6 02:12:42 2019 New Revision: 368001 URL: http://llvm.org/viewvc/llvm-project?rev=368001&view=rev Log: SymbolVendor: Remove passthrough methods After the recent refactorings the SymbolVendor passthrough no longer serve any purpose. This patch removes those methods, a

[Lldb-commits] [PATCH] D65561: SymbolVendorELF: Perform build-id lookup even without a debug link

This revision was automatically updated to reflect the committed changes. Closed by commit rL367994: SymbolVendorELF: Perform build-id lookup even without a debug link (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to comm

[Lldb-commits] [lldb] r367994 - SymbolVendorELF: Perform build-id lookup even without a debug link

Author: labath Date: Tue Aug 6 01:18:39 2019 New Revision: 367994 URL: http://llvm.org/viewvc/llvm-project?rev=367994&view=rev Log: SymbolVendorELF: Perform build-id lookup even without a debug link Summary: The debug link and build-id lookups are two independent ways one can search for a separa

[Lldb-commits] [PATCH] D65789: A more robust way of testing debug_line parser near the end of module

labath created this revision. labath added a reviewer: MaskRay. While removing -z separate-code makes lld produce place the code at the end of a segment right now, it's possible that future changes to the linker will change that, thereby removing the coverage for the changes in r367983. This patch

[Lldb-commits] [lldb] r367989 - [lldb][NFC] Remove unnecessary cast in ClangUserExpression

Author: teemperor Date: Tue Aug 6 01:07:45 2019 New Revision: 367989 URL: http://llvm.org/viewvc/llvm-project?rev=367989&view=rev Log: [lldb][NFC] Remove unnecessary cast in ClangUserExpression Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp Modified: lld