[Lldb-commits] [lldb] r368249 - [Materializer] Remove wrong SetSizeAndAlignmentFromType().

Author: davide Date: Wed Aug 7 20:15:48 2019 New Revision: 368249 URL: http://llvm.org/viewvc/llvm-project?rev=368249=rev Log: [Materializer] Remove wrong SetSizeAndAlignmentFromType(). This function is unused. It's also wrong, because it computes the size and the alignment of the type without

[Lldb-commits] [lldb] r368243 - [Utility] Remove unused function 'GetMatchSpanningIndices'

Author: jdevlieghere Date: Wed Aug 7 18:44:03 2019 New Revision: 368243 URL: http://llvm.org/viewvc/llvm-project?rev=368243=rev Log: [Utility] Remove unused function 'GetMatchSpanningIndices' Modified: lldb/trunk/include/lldb/Utility/RegularExpression.h

[Lldb-commits] [PATCH] D65493: Modernize atomic detection and usage

Bigcheese added a comment. This looks like a good simplification, but I think `call_once` could be simplified more. Comment at: llvm/cmake/modules/CheckAtomic.cmake:46 + if (NOT HAVE_ATOMICS_WITH_LIB) + message(FATAL_ERROR "Host compiler must support atomic!")

[Lldb-commits] [lldb] r368233 - [Docs] Fix (incorrect) code highlighting

Author: jdevlieghere Date: Wed Aug 7 16:12:40 2019 New Revision: 368233 URL: http://llvm.org/viewvc/llvm-project?rev=368233=rev Log: [Docs] Fix (incorrect) code highlighting Modified: lldb/trunk/docs/use/symbolication.rst Modified: lldb/trunk/docs/use/symbolication.rst URL:

[Lldb-commits] [PATCH] D65910: Remove unused and undocumented data_offset parameter

aprantl created this revision. aprantl added reviewers: jingham, clayborg, labath, jasonmolenda. Herald added a project: LLDB. aprantl updated this revision to Diff 214024. Value::GetValueAsData() takes an undocumented parameter called data_offset that is always 0. I couldn't figure out what it

[Lldb-commits] [PATCH] D65910: Remove unused and undocumented data_offset parameter

aprantl updated this revision to Diff 214024. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65910/new/ https://reviews.llvm.org/D65910 Files: lldb/include/lldb/Core/Value.h lldb/source/Core/Value.cpp lldb/source/Core/ValueObject.cpp lldb/source/Core/ValueObjectCast.cpp

[Lldb-commits] [PATCH] D65492: Adjust a ValueObjectChild's offset when the child is a bitfield

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL368226: Adjust a ValueObjectChilds offset when the child is a bitfield (authored by adrian, committed by ). Herald added

[Lldb-commits] [lldb] r368226 - Adjust a ValueObjectChild's offset when the child is a bitfield

Author: adrian Date: Wed Aug 7 15:40:05 2019 New Revision: 368226 URL: http://llvm.org/viewvc/llvm-project?rev=368226=rev Log: Adjust a ValueObjectChild's offset when the child is a bitfield If a bitfield doesn't fit into the child_byte_size'd window at child_byte_offset, move the window

[Lldb-commits] [lldb] r368208 - [CommandObject] Remove unused function

Author: jdevlieghere Date: Wed Aug 7 13:56:17 2019 New Revision: 368208 URL: http://llvm.org/viewvc/llvm-project?rev=368208=rev Log: [CommandObject] Remove unused function Modified: lldb/trunk/source/Commands/CommandObjectCommands.cpp Modified:

[Lldb-commits] [lldb] r368205 - [Symbol] Remove commented out code from CompileUnit

Author: xiaobai Date: Wed Aug 7 13:51:21 2019 New Revision: 368205 URL: http://llvm.org/viewvc/llvm-project?rev=368205=rev Log: [Symbol] Remove commented out code from CompileUnit Modified: lldb/trunk/source/Symbol/CompileUnit.cpp Modified: lldb/trunk/source/Symbol/CompileUnit.cpp URL:

[Lldb-commits] [PATCH] D65784: [lldb] delete "--platform-path" option from "target create"

kusmour added a comment. In D65784#1616118 , @jasonmolenda wrote: > Yeah, it's not currently hooked up to anything; I'm returning to > remote-platform testing soon, if we've lost some necessary functionality I > can re-add it, but this option right now

[Lldb-commits] [PATCH] D64993: Fix PC adjustment in StackFrame::GetSymbolContext

JosephTremoulet marked an inline comment as done. JosephTremoulet added inline comments. Comment at: lldb/source/Plugins/Process/Utility/RegisterContextLLDB.cpp:1760 +void RegisterContextLLDB::PropagateTrapHandlerFlag( +lldb::UnwindPlanSP unwind_plan) { + if

[Lldb-commits] [PATCH] D65826: Add support for deterministically linked binaries on macOS to lldb.

This revision was automatically updated to reflect the committed changes. Closed by commit rL368199: Add support for deterministically linked binaries on macOS to lldb. (authored by nico, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [lldb] r368199 - Add support for deterministically linked binaries on macOS to lldb.

Author: nico Date: Wed Aug 7 12:29:04 2019 New Revision: 368199 URL: http://llvm.org/viewvc/llvm-project?rev=368199=rev Log: Add support for deterministically linked binaries on macOS to lldb. When ld64 links a binary deterministically using the flag ZERO_AR_DATE, it sets a timestamp of 0 for

[Lldb-commits] [PATCH] D65826: Add support for deterministically linked binaries on macOS to lldb.

erikchen added a comment. I do not have commit access. Can someone land the change for me? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65826/new/ https://reviews.llvm.org/D65826 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D65826: Add support for deterministically linked binaries on macOS to lldb.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks, this LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65826/new/ https://reviews.llvm.org/D65826 ___

[Lldb-commits] [PATCH] D65826: Add support for deterministically linked binaries on macOS to lldb.

erikchen marked 3 inline comments as done. erikchen added inline comments. Comment at: lldb/lit/SymbolFile/DWARF/deterministic-build.cpp:6 +// RUN: ZERO_AR_DATE=1 %clang %t.o -g -o %t +// RUN: %lldb %t -s %S/Inputs/deterministic-build.lldbinit -o exit | FileCheck %s +// CHECK:

[Lldb-commits] [PATCH] D65826: Add support for deterministically linked binaries on macOS to lldb.

erikchen updated this revision to Diff 213962. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65826/new/ https://reviews.llvm.org/D65826 Files: lldb/lit/SymbolFile/DWARF/deterministic-build.cpp lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp Index:

[Lldb-commits] [PATCH] D65826: Add support for deterministically linked binaries on macOS to lldb.

labath added inline comments. Comment at: lldb/lit/SymbolFile/DWARF/deterministic-build.cpp:6 +// RUN: ZERO_AR_DATE=1 %clang %t.o -g -o %t +// RUN: %lldb %t -s %S/Inputs/deterministic-build.lldbinit -o exit | FileCheck %s +// CHECK: int main() { return 0; }

[Lldb-commits] [PATCH] D65826: Add support for deterministically linked binaries on macOS to lldb.

erikchen marked an inline comment as done. erikchen added inline comments. Comment at: lldb/lit/SymbolFile/DWARF/deterministic-build.cpp:6 +// RUN: ZERO_AR_DATE=1 %clang %t.o -g -o %t +// RUN: %lldb %t -s %S/Inputs/deterministic-build.lldbinit -o exit | FileCheck %s +// CHECK:

[Lldb-commits] [PATCH] D65826: Add support for deterministically linked binaries on macOS to lldb.

erikchen updated this revision to Diff 213960. erikchen marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65826/new/ https://reviews.llvm.org/D65826 Files: lldb/lit/SymbolFile/DWARF/Inputs/deterministic-build.lldbinit

[Lldb-commits] [PATCH] D65864: Remove Module::GetSymbolVendor

clayborg accepted this revision. clayborg added a comment. Optional rename in inline comments, but looks good. Comment at: include/lldb/Core/Module.h:1006 std::atomic m_did_load_objfile{false}; - std::atomic m_did_load_symbol_vendor{false}; + std::atomic

[Lldb-commits] [PATCH] D65872: [lldb][NFC] Check in test case for testing virtual function calls in pointers and references.

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. I seem to remember there was a bug where you run the expression twice and the second time it crashes/it's not evaluated correctly [at least this is what I remember talking to Lang ~18 months

[Lldb-commits] [lldb] r368182 - [Driver] Expand the executable path in the target create output

Author: jdevlieghere Date: Wed Aug 7 09:21:40 2019 New Revision: 368182 URL: http://llvm.org/viewvc/llvm-project?rev=368182=rev Log: [Driver] Expand the executable path in the target create output Resolve the path in the target create output. This is nice when passing relative paths to the lldb

[Lldb-commits] [PATCH] D65611: [Driver] Expand the executable path in the target create output

This revision was automatically updated to reflect the committed changes. Closed by commit rL368182: [Driver] Expand the executable path in the target create output (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [PATCH] D65874: [lldb][CMake] Disable modules in Xcode projects

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. You might want to check with Argyrios, maybe file a rdar against SourceKit. Otherwise, this is fine to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D48704: [ExecutionContext] Return the target/process byte order.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL368181: [ExecutionContext] Return the target/process byte order. (authored by JDevlieghere, committed by ). Herald added

[Lldb-commits] [PATCH] D48704: [ExecutionContext] Return the target/process byte order.

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/unittests/Target/ExecutionContextTest.cpp:77 +TEST_F(ExecutionContextTest, GetByteOrderTarget) { + ArchSpec arch = Target::GetDefaultArchitecture(); +

[Lldb-commits] [lldb] r368181 - [ExecutionContext] Return the target/process byte order.

Author: jdevlieghere Date: Wed Aug 7 09:09:35 2019 New Revision: 368181 URL: http://llvm.org/viewvc/llvm-project?rev=368181=rev Log: [ExecutionContext] Return the target/process byte order. Currently ExecutionContext::GetByteOrder() always returns the host byte order. This seems like a simple

[Lldb-commits] [PATCH] D48704: [ExecutionContext] Return the target/process byte order.

JDevlieghere updated this revision to Diff 213922. JDevlieghere marked 5 inline comments as done. JDevlieghere added a comment. Code review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48704/new/ https://reviews.llvm.org/D48704 Files:

[Lldb-commits] [PATCH] D65874: [lldb][CMake] Disable modules in Xcode projects

sgraenitz created this revision. sgraenitz added reviewers: aprantl, jingham, davide, teemperor. Herald added a subscriber: mgorny. Herald added a project: LLDB. Apparently, module-enabled builds clash with Xcode's analysis. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D65874

[Lldb-commits] [PATCH] D65872: [lldb][NFC] Check in test case for testing virtual function calls in pointers and references.

teemperor created this revision. teemperor added a reviewer: lhames. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. rdar://38048657 says that the following test case was broken. It seems to have been fixed since then, so this patch just adds the test case to our test

[Lldb-commits] [lldb] r368168 - ProcessElfCore: Remove linux and freebsd NT_*** constants

Author: labath Date: Wed Aug 7 06:12:59 2019 New Revision: 368168 URL: http://llvm.org/viewvc/llvm-project?rev=368168=rev Log: ProcessElfCore: Remove linux and freebsd NT_*** constants These are already defined in llvm/BinaryFormat/ELF.h. Leaving the NetBSD and OpenBSD constants as-is, as they

[Lldb-commits] [PATCH] D65864: Remove Module::GetSymbolVendor

labath created this revision. labath added reviewers: clayborg, JDevlieghere, jingham. Herald added a subscriber: jfb. Herald added a reviewer: jdoerfert. This patch removes the GetSymbolVendor function, and the various mentions of the SymbolVendor in the Module class. The implementation of

[Lldb-commits] [PATCH] D65862: Remove xcode-specific Config.h

sgraenitz accepted this revision. sgraenitz added a comment. This revision is now accepted and ready to land. Right CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65862/new/ https://reviews.llvm.org/D65862 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D65862: Remove xcode-specific Config.h

labath added a comment. In D65862#1618740 , @sgraenitz wrote: > Originally introduced with D31969 . LGTM. > Maybe we can remove even more? (here or in future commits) I don't see what more could be removed here. Most of

[Lldb-commits] [PATCH] D65862: Remove xcode-specific Config.h

sgraenitz added a comment. Originally introduced with D31969 . LGTM. Maybe we can remove even more? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65862/new/ https://reviews.llvm.org/D65862 ___ lldb-commits

[Lldb-commits] [lldb] r368159 - ObjectFileELF: Remove NT_*** constants

Author: labath Date: Wed Aug 7 05:13:48 2019 New Revision: 368159 URL: http://llvm.org/viewvc/llvm-project?rev=368159=rev Log: ObjectFileELF: Remove NT_*** constants llvm now has definitions of those in BinaryFormat/ELF.h. Use those instead. Modified:

[Lldb-commits] [PATCH] D65862: Remove xcode-specific Config.h

labath created this revision. labath added reviewers: sgraenitz, beanz. Herald added a subscriber: mgorny. Now that the xcode project is removed, we no longer need/use the hand-maintained Config.h file, as everything is configured through cmake. This patch deletes that file and reverts some of

[Lldb-commits] [PATCH] D65798: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly

sgraenitz added a comment. In D65798#1618609 , @labath wrote: > Making it so that the clang is automatically found it if happens to be next > to llvm seems like a reasonable thing to me. I have no idea what would be the > canonical cmake way to do

[Lldb-commits] [PATCH] D65789: A more robust way of testing debug_line parser near the end of module

This revision was automatically updated to reflect the committed changes. Closed by commit rL368154: A more robust way of testing debug_line parser near the end of module (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL

[Lldb-commits] [lldb] r368154 - A more robust way of testing debug_line parser near the end of module

Author: labath Date: Wed Aug 7 04:33:56 2019 New Revision: 368154 URL: http://llvm.org/viewvc/llvm-project?rev=368154=rev Log: A more robust way of testing debug_line parser near the end of module Summary: While removing -z separate-code makes lld produce place the code at the end of a segment

[Lldb-commits] [PATCH] D65789: A more robust way of testing debug_line parser near the end of module

labath updated this revision to Diff 213845. labath added a comment. - remove output section addresses CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65789/new/ https://reviews.llvm.org/D65789 Files: lit/SymbolFile/DWARF/Inputs/debug-line-basic.script

[Lldb-commits] [PATCH] D65798: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly

sgraenitz updated this revision to Diff 213842. sgraenitz added a comment. Update documentation to mention multiple provided build trees and the usage of `Clang_DIR` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65798/new/

[Lldb-commits] [PATCH] D65798: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly

labath added a comment. Making it so that the clang is automatically found it if happens to be next to llvm seems like a reasonable thing to me. I have no idea what would be the canonical cmake way to do that... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D65566: [lldb][CMake] Workaround debugserver code-signing issue in generated Xcode project

This revision was automatically updated to reflect the committed changes. Closed by commit rL368151: [lldb][CMake] Workaround debugserver code-signing issue in generated Xcode… (authored by stefan.graenitz, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[Lldb-commits] [lldb] r368151 - [lldb][CMake] Workaround debugserver code-signing issue in generated Xcode project

Author: stefan.graenitz Date: Wed Aug 7 04:02:04 2019 New Revision: 368151 URL: http://llvm.org/viewvc/llvm-project?rev=368151=rev Log: [lldb][CMake] Workaround debugserver code-signing issue in generated Xcode project Summary: Explicitly code-sign the LLDB.framework copy of debugserver in the

[Lldb-commits] [lldb] r368150 - [lldb][NFC] Remove commented out code in ClangASTContext::AddMethodToCXXRecordType

Author: teemperor Date: Wed Aug 7 03:59:34 2019 New Revision: 368150 URL: http://llvm.org/viewvc/llvm-project?rev=368150=rev Log: [lldb][NFC] Remove commented out code in ClangASTContext::AddMethodToCXXRecordType Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp Modified:

[Lldb-commits] [lldb] r368148 - [lldb][CMake] Fix one more detail in r368066

Author: stefan.graenitz Date: Wed Aug 7 03:47:49 2019 New Revision: 368148 URL: http://llvm.org/viewvc/llvm-project?rev=368148=rev Log: [lldb][CMake] Fix one more detail in r368066 Differential Revision: https://reviews.llvm.org/D65797 Modified:

[Lldb-commits] [PATCH] D65798: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly

sgraenitz added inline comments. Comment at: lldb/cmake/modules/LLDBStandalone.cmake:6 + # next to LLVM's module directory. + set(Clang_DIR ${LLVM_DIR}/../clang) + message(STATUS "Inferred Clang_DIR: ${Clang_DIR}") labath wrote: > sgraenitz wrote: > >

[Lldb-commits] [PATCH] D65798: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly

sgraenitz added a comment. What do you think? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65798/new/ https://reviews.llvm.org/D65798 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D65798: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly

sgraenitz updated this revision to Diff 213834. sgraenitz added a comment. Change comment and condition to only infer Clang_DIR if it exists. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65798/new/ https://reviews.llvm.org/D65798 Files:

[Lldb-commits] [lldb] r368143 - [lldb][NFC] Fix typo in 368066

Author: stefan.graenitz Date: Wed Aug 7 03:03:11 2019 New Revision: 368143 URL: http://llvm.org/viewvc/llvm-project?rev=368143=rev Log: [lldb][NFC] Fix typo in 368066 Differential Revision: https://reviews.llvm.org/D65797 Modified: lldb/trunk/cmake/modules/LLDBConfig.cmake Modified:

[Lldb-commits] [PATCH] D61565: Ignore generated @import statements in the expression evaluator

teemperor updated this revision to Diff 213803. teemperor retitled this revision from "Ignore generated @import statements in the expression evaluator to fix import-std-module tests on macOS" to "Ignore generated @import statements in the expression evaluator". teemperor edited the summary of

[Lldb-commits] [PATCH] D61565: Ignore generated @import statements in the expression evaluator

teemperor marked 3 inline comments as done. teemperor added a comment. - Moved from macro to source file name filtering. No longer enable the tests with this patch as we still have the include path bug to fix. Comment at:

[Lldb-commits] [PATCH] D48704: [ExecutionContext] Return the target/process byte order.

labath accepted this revision. labath added a comment. Thanks for setting this up. The infrastructure is a bit overkill for a simple test like this, but hopefully this can be useful for other tests too. I have a bunch of comments, but hopefully none of them are major, so if you agree with all

[Lldb-commits] [PATCH] D48704: [LLDB] Fix for "Bug 37950: ExecutionContext::GetByteOrder() always returns endian::InlHostByteOrder()"

JDevlieghere updated this revision to Diff 213797. JDevlieghere added a comment. Herald added a subscriber: mgorny. Add unit test Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48704/new/ https://reviews.llvm.org/D48704 Files:

[Lldb-commits] [PATCH] D65822: Detect HAVE_SYS_TYPES_H in lldb

This revision was automatically updated to reflect the committed changes. Closed by commit rL368125: Detect HAVE_SYS_TYPES_H in lldb (authored by hhb, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D65822: Detect HAVE_SYS_TYPES_H in lldb

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Woops, this is quite embarrassing. :/ One day we should audit these to check which of these files really needs to include this header, but since there are at least some files that definitely

[Lldb-commits] [PATCH] D65798: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly

labath added inline comments. Comment at: lldb/cmake/modules/LLDBStandalone.cmake:6 + # next to LLVM's module directory. + set(Clang_DIR ${LLVM_DIR}/../clang) + message(STATUS "Inferred Clang_DIR: ${Clang_DIR}") sgraenitz wrote: > compnerd wrote: > >