asmith added a comment.
This is done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63165/new/
https://reviews.llvm.org/D63165
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co
Author: teemperor
Date: Tue Aug 13 05:12:19 2019
New Revision: 368679
URL: http://llvm.org/viewvc/llvm-project?rev=368679&view=rev
Log:
[lldb][NFC] Add basic IOHandler completion test
We have no test coverage for the IOHandler code that is doing the
completion in the command line. This is adding
kwk requested changes to this revision.
kwk added inline comments.
This revision now requires changes to proceed.
Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:789
+ signal_threads = signaled)
+test.fail("Stopped for another reaso
kwk added inline comments.
Comment at: llvm/lib/Demangle/MicrosoftDemangle.cpp:737
TagTypeNode *Demangler::parseTagUniqueName(StringView &MangledName) {
+ if (!MangledName.consumeFront(".?A")) {
Why not change the return type to `llvm::Expected`? Then you hav
Author: teemperor
Date: Tue Aug 13 06:09:18 2019
New Revision: 368688
URL: http://llvm.org/viewvc/llvm-project?rev=368688&view=rev
Log:
[lldb] Reland "Refactor guard variable checks in IRForTarget"
It seems the broken guard variable check for Windows was a feature(TM)
and not a bug, so let's keep
Author: teemperor
Date: Tue Aug 13 07:13:39 2019
New Revision: 368695
URL: http://llvm.org/viewvc/llvm-project?rev=368695&view=rev
Log:
[lldb] Fix Microsoft guard variable detection
Apparently we need to check for a suffix, not a prefix. This broke
probably broke expression evaluation on Windows.
labath accepted this revision.
labath added a comment.
This looks great to me. Thank you for your patience.
Comment at:
lldb/source/Plugins/Process/Utility/RegisterContextWindows_x86_64.cpp:10
+#include "RegisterContextWindows_x86_64.h"
+#include "RegisterContextWindows_i386.h
labath added a comment.
Any thoughts on this one? The fix seems quite straight-forward, but I know
there was a lot of discussion about None vs "" in the past (and I unfortunately
don't remember the outcome of that, nor I was able to find those discussions),
so I want to make sure I'm doing the
On 05/08/2019 22:21, Greg Clayton wrote:
so I can crash LLDB now with:
$ clang -c main.s
$ lldb main.o
(lldb) target create "main.o"
Current executable set to 'main.o' (x86_64).
(lldb) image lookup --verbose --address 0x0008
I can make a python test that can easily do this. Is there
thakis added inline comments.
Comment at: llvm/lib/Demangle/MicrosoftDemangle.cpp:737
TagTypeNode *Demangler::parseTagUniqueName(StringView &MangledName) {
+ if (!MangledName.consumeFront(".?A")) {
kwk wrote:
> Why not change the return type to `llvm::Expecte
clayborg added a comment.
Thanks for running the perf tests, that will be great to keep handy somewhere.
Might be good to check this test in somewhere. I still think that making
changes to the llvm line parser might be a good idea where we can get a
callback when a row is to be pushed with the
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
Two percent is a noticeable price tag, but since we are doing extra work with
error handling and building a copy of the line table in memory first;
understandable, I'm moderately optimistic
jingham updated this revision to Diff 214865.
jingham added a comment.
Fixed the inverted call order.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65682/new/
https://reviews.llvm.org/D65682
Files:
packages/Python/lldbsuite/test/lldbutil.py
Index: packages
jingham added a comment.
Thanks for pointing that out.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65682/new/
https://reviews.llvm.org/D65682
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://list
clayborg added a comment.
I agree with Adrian, this isn't something that needs to hold up this patch, but
I do think it is worth doing soon in LLVM. The line table parsing code just
needs to take a std::function (or llvm equivalent) that gets called like a
lambda when a row is to be pushed. The
JDevlieghere added a comment.
After some brainstorming I've identified a few other approaches that should
better reflect the transience of the current working directory:
- We can modify the VFS to have a notion of //search paths//. The `adjustPath`
function could iterate over the search paths u
JDevlieghere added a comment.
Thank you! I agree that extending the LLVM parser is a good idea, especially if
it's already using a callback internally. I'll add a comment in the code and
spend some time looking at that in the coming days.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D6
This revision was automatically updated to reflect the committed changes.
Closed by commit rL368741: [Symbol] Decouple clang from CompilerType (authored
by xiaobai, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.ll
Author: jdevlieghere
Date: Tue Aug 13 12:51:51 2019
New Revision: 368742
URL: http://llvm.org/viewvc/llvm-project?rev=368742&view=rev
Log:
[DWARF} Use LLVM's debug line parser in LLDB.
The line number table header was substantially revised in DWARF 5 and is
not fully supported by LLDB's current d
This revision was automatically updated to reflect the committed changes.
Closed by commit rL368742: [DWARF} Use LLVM's debug line parser in LLDB.
(authored by JDevlieghere, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D62570?vs=214464&id=214903#toc
Repository:
rL LLVM
Author: jdevlieghere
Date: Tue Aug 13 14:00:27 2019
New Revision: 368746
URL: http://llvm.org/viewvc/llvm-project?rev=368746&view=rev
Log:
[DWARF] Guess the path style
Try to guess the FileSpec path style before defaulting to native.
Modified:
lldb/trunk/source/Plugins/SymbolFile/DWARF/Symbo
JDevlieghere created this revision.
JDevlieghere added a reviewer: LLDB.
JDevlieghere added a project: LLDB.
Herald added a subscriber: abidh.
I want to remove the RegularExpression class in Utility and replace it with
llvm::Regex.
This is something I'd do incrementally on the side when I have s
shafik created this revision.
shafik added reviewers: aprantl, teemperor.
Currently the heuristic used in `ClangASTContext::CreateRecordType` to identify
an anonymous class is that there is that `name` is a `nullptr` or simply a null
terminator. This heuristic is not accurate since it will also
Author: jdevlieghere
Date: Tue Aug 13 16:30:11 2019
New Revision: 368772
URL: http://llvm.org/viewvc/llvm-project?rev=368772&view=rev
Log:
[DebugLine] Be more robust in geussing the path style
My previous change didn't fix the Windows bot. This patch is an attempt
to make guessing the path style
aprantl added inline comments.
Comment at:
packages/Python/lldbsuite/test/expression_command/completion-crash-lambda/TestCompletionCrashInLambda.py:4
-lldbinline.MakeInlineTest(__file__, globals(),
[decorators.skipIf(bugnumber="rdar://53755023")])
+lldbinline.MakeInlineTest(_
aprantl added inline comments.
Comment at: source/Symbol/ClangASTContext.cpp:1521
+//
+// This fix will unfortunately still mislabel unnamed classes within a
class
+// but this improves the situation greatly since getting this wrong in the
// FIXME:
Author: asmith
Date: Tue Aug 13 16:50:54 2019
New Revision: 368774
URL: http://llvm.org/viewvc/llvm-project?rev=368774&view=rev
Log:
Enable lldb-server on Windows
Summary:
This commit contains three small changes to enable lldb-server on Windows.
- Add lldb-server for Windows to the build
- Disa
asmith updated this revision to Diff 214979.
asmith edited the summary of this revision.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61686/new/
https://reviews.llvm.org/D61686
Files:
cmake/modules/LLDBConfig.cmake
source/Host/windows/Host.cpp
source/Plugins/Process/gdb-remote/GDB
asmith updated this revision to Diff 214985.
asmith edited the summary of this revision.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61687/new/
https://reviews.llvm.org/D61687
Files:
packages/Python/lldbsuite/test/dotest.py
packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRe
asmith added a comment.
Any more comments on the tests for Windows?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61687/new/
https://reviews.llvm.org/D61687
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cg
Author: asmith
Date: Tue Aug 13 17:14:15 2019
New Revision: 368776
URL: http://llvm.org/viewvc/llvm-project?rev=368776&view=rev
Log:
Update Python tests for lldb-server on Windows
Summary: Thanks to Hui Huang and reviewers for all the help with this patch!
Reviewers: labath, jfb, clayborg
Revie
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL368776: Update Python tests for lldb-server on Windows
(authored by asmith, committed by ).
Herald added a project: LLVM.
Author: jdevlieghere
Date: Tue Aug 13 18:25:10 2019
New Revision: 368782
URL: http://llvm.org/viewvc/llvm-project?rev=368782&view=rev
Log:
Fix warning: suggest braces around initialization of subobject
This patch adds braces to the DEFINE_XMM macro.
Modified:
lldb/trunk/source/Plugins/Proces
JDevlieghere updated this revision to Diff 215022.
JDevlieghere retitled this revision from "[Utility] Phase out RegularExpression
and use llvm::Regex instead." to "[Utility] Reimplement RegularExpression on
top of llvm::Regex".
JDevlieghere edited the summary of this revision.
JDevlieghere added
Author: teemperor
Date: Tue Aug 13 22:52:33 2019
New Revision: 368802
URL: http://llvm.org/viewvc/llvm-project?rev=368802&view=rev
Log:
[lldb] Reinstate original guard variable check
The isGuardVariableSymbol option for ignoring Microsoft's ABI
was originally added to get the bots green, but now
teemperor added a comment.
This commit seems to have broken the windows bot:
http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/7780
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63165/new/
https://reviews.llvm.org/D63165
_
teemperor added a comment.
Could you expand the test (or add another test) for completing in an anonymous
classes? Otherwise this LGTM beside Adrian comments assuming this fixes the
crash.
Comment at:
packages/Python/lldbsuite/test/expression_command/completion-crash-lambda/
37 matches
Mail list logo
