[Lldb-commits] [PATCH] D66628: [Symbol] Decouple clang from DeclVendor

This revision was automatically updated to reflect the committed changes. Closed by commit rL369735: [Symbol] Decouple clang from DeclVendor (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

[Lldb-commits] [lldb] r369735 - [Symbol] Decouple clang from DeclVendor

Author: xiaobai Date: Thu Aug 22 23:11:32 2019 New Revision: 369735 URL: http://llvm.org/viewvc/llvm-project?rev=369735&view=rev Log: [Symbol] Decouple clang from DeclVendor Summary: This removes DeclVendor's dependency on clang (and ClangASTContext). DeclVendor has no need to know about specific

[Lldb-commits] [PATCH] D66250: [JIT][Unwinder] Add Trampoline ObjectFile and UnwindPlan support for FCB

jasonmolenda added inline comments. Comment at: lldb/source/Target/ABI.cpp:10 #include "lldb/Target/ABI.h" +#include "Plugins/ObjectFile/Trampoline/ObjectFileTrampoline.h" +#include "lldb/Core/Module.h" mib wrote: > labath wrote: > > If this is going to be somet

[Lldb-commits] [lldb] r369731 - [LLDB] Address post-commit code review feedback.

Author: jdevlieghere Date: Thu Aug 22 21:11:38 2019 New Revision: 369731 URL: http://llvm.org/viewvc/llvm-project?rev=369731&view=rev Log: [LLDB] Address post-commit code review feedback. This patch addresses Adrian McCarthy's code review feedback in https://reviews.llvm.org/D66447 Modified:

[Lldb-commits] [PATCH] D66248: [JIT][Command] Add "inject-condition" flag to conditional breakpoints

JDevlieghere accepted this revision as: JDevlieghere. JDevlieghere added a comment. This revision is now accepted and ready to land. A few small nits, but otherwise this LGTM. Comment at: lldb/include/lldb/Breakpoint/BreakpointOptions.h:120 + /// BreakpointOptions(const cha

[Lldb-commits] [PATCH] D66250: [JIT][Unwinder] Add Trampoline ObjectFile and UnwindPlan support for FCB

mib marked an inline comment as done. mib added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/fast_conditional_breakpoints/TestFastConditionalBreakpoints.py:159 +#self.assertEqual(var.GetValue(), "9") + def inject_invali

[Lldb-commits] [PATCH] D66628: [Symbol] Decouple clang from DeclVendor

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66628/new/ https://reviews.llvm.org/D66628 _

[Lldb-commits] [PATCH] D66250: [JIT][Unwinder] Add Trampoline ObjectFile and UnwindPlan support for FCB

mib added inline comments. Comment at: lldb/source/Target/ABI.cpp:10 #include "lldb/Target/ABI.h" +#include "Plugins/ObjectFile/Trampoline/ObjectFileTrampoline.h" +#include "lldb/Core/Module.h" labath wrote: > If this is going to be something that is called dire

[Lldb-commits] [PATCH] D66628: [Symbol] Decouple clang from DeclVendor

xiaobai created this revision. xiaobai added reviewers: JDevlieghere, clayborg, jingham, teemperor. Herald added subscribers: kadircet, arphaman, mgorny. Herald added a project: LLDB. This removes DeclVendor's dependency on clang (and ClangASTContext). DeclVendor has no need to know about specific

[Lldb-commits] [PATCH] D66249: [JIT][Breakpoint] Add "BreakpointInjectedSite" and FCB Trampoline

mib updated this revision to Diff 216749. mib added a comment. Add error handling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66249/new/ https://reviews.llvm.org/D66249 Files: lldb/include/lldb/API/SBBreakpoint.h lldb/include/lldb/API/SBBrea

[Lldb-commits] [PATCH] D66249: [JIT][Breakpoint] Add "BreakpointInjectedSite" and FCB Trampoline

mib updated this revision to Diff 216747. mib marked 16 inline comments as done. mib added a comment. Add doxygen documentation. Move `ArgumentMetadata` struct inside `BreakpointInjectedSite`. Change string format for logging. Make `$__lldb_create_args_struct` generation architecture-independen

[Lldb-commits] [PATCH] D66249: [JIT][Breakpoint] Add "BreakpointInjectedSite" and FCB Trampoline

mib added inline comments. Comment at: lldb/include/lldb/Breakpoint/BreakpointSite.h:54-56 + static bool classof(const BreakpointSite *bp_site) { + return bp_site->getKind() == eKindBreakpointSite; + } labath wrote: > This is weird. So, in OO terminology,

[Lldb-commits] [PATCH] D66248: [JIT][Command] Add "inject-condition" flag to conditional breakpoints

mib updated this revision to Diff 216745. mib added a comment. Rename `cli` to `use_interpreter` in test. Use early returns on SB API classes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66248/new/ https://reviews.llvm.org/D66248 Files: lldb/

[Lldb-commits] [PATCH] D66357: Fix GetDIEForDeclContext so it only returns entries matching the provided context

guiandrade added a comment. Sounds good, thank you! Can someone please merge this for me? ninja check-lldb Testing Time: 163.56s Expected Passes: 1603 Expected Failures : 4 Unsupported Tests : 85 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[Lldb-commits] [lldb] r369712 - Add missing dot.

Author: adrian Date: Thu Aug 22 15:28:18 2019 New Revision: 369712 URL: http://llvm.org/viewvc/llvm-project?rev=369712&view=rev Log: Add missing dot. Modified: lldb/trunk/include/lldb/lldb-enumerations.h Modified: lldb/trunk/include/lldb/lldb-enumerations.h URL: http://llvm.org/viewvc/llvm-

[Lldb-commits] [PATCH] D66357: Fix GetDIEForDeclContext so it only returns entries matching the provided context

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Now that obj2yaml is a library, we might be able to make some real DWARF to exercise this? I can custom make any DWARF you want as I have a DWARF generator. Though this test does verify th

Re: [Lldb-commits] [PATCH] D66445: Explicitly Cast Constants to DWORD

The reason for the define is it’s not possible currently to include winnt.h without build errors. Definitely something to cleanup. > On Aug 22, 2019, at 9:47 AM, Gwen Mittertreiner via Phabricator > wrote: > > jmittert added a comment. > > I believe it's using the one in ntstatus.h > > 10.0

[Lldb-commits] [lldb] r369710 - Extend FindTypes with CompilerContext to allow filtering by language.

Author: adrian Date: Thu Aug 22 14:45:58 2019 New Revision: 369710 URL: http://llvm.org/viewvc/llvm-project?rev=369710&view=rev Log: Extend FindTypes with CompilerContext to allow filtering by language. This patch is also motivated by the Swift branch and is effectively NFC for the single-TypeSy

[Lldb-commits] [lldb] r369709 - TestAppleSimulatorOSType: Pass the --standalone argument to simctl

Author: friss Date: Thu Aug 22 14:44:10 2019 New Revision: 369709 URL: http://llvm.org/viewvc/llvm-project?rev=369709&view=rev Log: TestAppleSimulatorOSType: Pass the --standalone argument to simctl It looks like running without this argument was supported for legacy reasons, but a Xcode 11 beta

[Lldb-commits] [PATCH] D66447: Add char8_t support (C++20)

amccarth added a comment. A couple inline comments. I think this is looking pretty good. Comment at: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/char8_t/main.cpp:1 +#include + Is this include necessary? Comment at: lldb/trunk/source

[Lldb-commits] [PATCH] D66546: Extend FindTypes w/ CompilerContext to allow filtering by language

aprantl added a comment. Turns out I accidentally deleted the constructor of LanguageSet in my very last refactoring. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66546/new/ https://reviews.llvm.org/D66546 ___ lldb-

[Lldb-commits] [lldb] r369706 - Revert [heap.py] Add missing declaration for malloc_get_all_zones

Author: vedantk Date: Thu Aug 22 14:01:45 2019 New Revision: 369706 URL: http://llvm.org/viewvc/llvm-project?rev=369706&view=rev Log: Revert [heap.py] Add missing declaration for malloc_get_all_zones This reverts r369684 (git commit cc62e38d258f414c196b566374c606e83a85a034) Adding a declaration

Re: [Lldb-commits] [PATCH] D66546: Extend FindTypes w/ CompilerContext to allow filtering by language

Thanks! Thanks, - Stella From: Adrian Prantl via Phabricator Sent: Thursday, August 22, 2019 1:42:13 PM To: apra...@apple.com ; pa...@labath.sk ; clayb...@gmail.com ; jmole...@apple.com ; jo...@devlieghere.com Cc: Stella Stamenova ; llvm-comm...@lists.llvm.org

[Lldb-commits] [PATCH] D66546: Extend FindTypes w/ CompilerContext to allow filtering by language

aprantl added a comment. Looks like this also broke other platforms, which is good because I can debug it! I reverted the patch for now. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66546/new/ https://reviews.llvm.org/D66546 __

[Lldb-commits] [PATCH] D66546: Extend FindTypes w/ CompilerContext to allow filtering by language

aprantl added a comment. Yeah, I'm trying to get behind what happened there, but I may need some help later on. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66546/new/ https://reviews.llvm.org/D66546 ___ lldb-commit

[Lldb-commits] [lldb] r369702 - Revert Extend FindTypes with CompilerContext to allow filtering by language.

Author: adrian Date: Thu Aug 22 13:41:16 2019 New Revision: 369702 URL: http://llvm.org/viewvc/llvm-project?rev=369702&view=rev Log: Revert Extend FindTypes with CompilerContext to allow filtering by language. This reverts r369690 (git commit aa3a564efa6b5fff2129f81a4041069a0233168f) Modified:

[Lldb-commits] [PATCH] D66546: Extend FindTypes w/ CompilerContext to allow filtering by language

stella.stamenova added a comment. It looks like this broke the windows build bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/8120 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66546/new/ https://reviews.llvm.org/D66546

[Lldb-commits] [lldb] r369699 - Rename lldb/source/Interpreter/OptionValueFileSpecListTmp.cpp to

Author: adrian Date: Thu Aug 22 13:10:24 2019 New Revision: 369699 URL: http://llvm.org/viewvc/llvm-project?rev=369699&view=rev Log: Rename lldb/source/Interpreter/OptionValueFileSpecListTmp.cpp to lldb/source/Interpreter/OptionValueFileSpecList.cpp (NFC) Added: lldb/trunk/source/Inter

[Lldb-commits] [lldb] r369698 - Rename lldb/source/Interpreter/OptionValueFileSpecLIst.cpp to

Author: adrian Date: Thu Aug 22 13:08:46 2019 New Revision: 369698 URL: http://llvm.org/viewvc/llvm-project?rev=369698&view=rev Log: Rename lldb/source/Interpreter/OptionValueFileSpecLIst.cpp to lldb/source/Interpreter/OptionValueFileSpecListTmp.cpp (NFC) Added: lldb/trunk/source/Inter

[Lldb-commits] [lldb] r369692 - Add missing include

Author: adrian Date: Thu Aug 22 12:32:24 2019 New Revision: 369692 URL: http://llvm.org/viewvc/llvm-project?rev=369692&view=rev Log: Add missing include Modified: lldb/trunk/include/lldb/Core/PluginManager.h Modified: lldb/trunk/include/lldb/Core/PluginManager.h URL: http://llvm.org/viewvc/

[Lldb-commits] [lldb] r369691 - Add missing include

Author: adrian Date: Thu Aug 22 12:30:10 2019 New Revision: 369691 URL: http://llvm.org/viewvc/llvm-project?rev=369691&view=rev Log: Add missing include Modified: lldb/trunk/include/lldb/Target/Language.h Modified: lldb/trunk/include/lldb/Target/Language.h URL: http://llvm.org/viewvc/llvm-p

[Lldb-commits] [PATCH] D66546: Extend FindTypes w/ CompilerContext to allow filtering by language

This revision was automatically updated to reflect the committed changes. Closed by commit rL369690: Extend FindTypes with CompilerContext to allow filtering by language. (authored by adrian, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to c

[Lldb-commits] [lldb] r369690 - Extend FindTypes with CompilerContext to allow filtering by language.

Author: adrian Date: Thu Aug 22 12:24:55 2019 New Revision: 369690 URL: http://llvm.org/viewvc/llvm-project?rev=369690&view=rev Log: Extend FindTypes with CompilerContext to allow filtering by language. This patch is also motivated by the Swift branch and is effectively NFC for the single-TypeSy

[Lldb-commits] [PATCH] D66546: Extend FindTypes w/ CompilerContext to allow filtering by language

aprantl marked an inline comment as done. aprantl added inline comments. Comment at: lldb/include/lldb/Symbol/SymbolFile.h:197 + virtual size_t FindTypes(llvm::ArrayRef pattern, + llvm::SmallBitVector languages, bool append,

[Lldb-commits] [lldb] r369684 - [heap.py] Add missing declaration for malloc_get_all_zones

Author: vedantk Date: Thu Aug 22 11:51:03 2019 New Revision: 369684 URL: http://llvm.org/viewvc/llvm-project?rev=369684&view=rev Log: [heap.py] Add missing declaration for malloc_get_all_zones The evaluation context isn't guaranteed to have this declaration. Fixes "error: use of undeclared ident

[Lldb-commits] [PATCH] D66546: Extend FindTypes w/ CompilerContext to allow filtering by language

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This sounds like a good compromise. Comment at: lldb/include/lldb/Symbol/SymbolFile.h:197 + virtual size_t FindTypes(llvm::ArrayRef pattern, + llvm

[Lldb-commits] [PATCH] D65952: SymbolVendor: Have plugins return symbol files directly

clayborg added a comment. In D65952#1624799 , @labath wrote: > In D65952#1623297 , @clayborg wrote: > > > So I am confused. Are we keeping SymbolVendor around for locating symbols > > files or are we getting rid of

[Lldb-commits] [PATCH] D66546: Extend FindTypes w/ CompilerContext to allow filtering by language

aprantl added a comment. In D66546#1641534 , @aprantl wrote: > No, the most "expensive" function is > ClangASTContext::GetSupportedLanguagesForTypes() which is called once by the > ClangASTContext constructor. ... "expensive" in quotes, because a suffi

[Lldb-commits] [PATCH] D66546: Extend FindTypes w/ CompilerContext to allow filtering by language

aprantl added a comment. In D66546#1641492 , @clayborg wrote: > Sounds good about LanguageSet being cheap to pass by value. Are there any > paths that will call this over and over where we still will be calculating > the LangaugeSet over and over in a ty

[Lldb-commits] [PATCH] D66546: Extend FindTypes w/ CompilerContext to allow filtering by language

clayborg added a comment. Sounds good about LanguageSet being cheap to pass by value. Are there any paths that will call this over and over where we still will be calculating the LangaugeSet over and over in a type system? We might benefit from using llvm::once and a static LanguageSet in the s

[Lldb-commits] [PATCH] D66546: Extend FindTypes w/ CompilerContext to allow filtering by language

aprantl added a comment. In D66546#1641435 , @aprantl wrote: > > Looks good overall. Just a question of it we want to return "const > > LanguageSet &" to avoid copies. Also switch static functions that currently > > return "LanguageSet" over to use stati

[Lldb-commits] [PATCH] D66546: Extend FindTypes w/ CompilerContext to allow filtering by language

aprantl added a comment. > Looks good overall. Just a question of it we want to return "const > LanguageSet &" to avoid copies. Also switch static functions that currently > return "LanguageSet" over to use static variables and llvm::once to init them > and then return "const LanguageSet &". T

[Lldb-commits] [PATCH] D66546: Extend FindTypes w/ CompilerContext to allow filtering by language

clayborg added a comment. Looks good overall. Just a question of it we want to return "const LanguageSet &" to avoid copies. Also switch static functions that currently return "LanguageSet" over to use static variables and llvm::once to init them and then return "const LanguageSet &". ==

[Lldb-commits] [PATCH] D66581: [lldb] Construct the dummy target when the first Dummy object is constructed

jingham accepted this revision. jingham added a comment. You can go a long time without actually using the Dummy target, which is why I made it lazily. Thinking of lldb as the command line program, we tend to think "I'll only ever make one debugger" so making one extra per-debugger thing doesn'

[Lldb-commits] [lldb] r369670 - Remove redundant curly braces.

Author: adrian Date: Thu Aug 22 09:58:56 2019 New Revision: 369670 URL: http://llvm.org/viewvc/llvm-project?rev=369670&view=rev Log: Remove redundant curly braces. Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp lldb/trunk/tools/lldb-test/lldb-test.cpp Modifi

[Lldb-commits] [lldb] r369669 - Doxygenify comments.

Author: adrian Date: Thu Aug 22 09:52:37 2019 New Revision: 369669 URL: http://llvm.org/viewvc/llvm-project?rev=369669&view=rev Log: Doxygenify comments. Modified: lldb/trunk/include/lldb/lldb-enumerations.h Modified: lldb/trunk/include/lldb/lldb-enumerations.h URL: http://llvm.org/viewvc/l

[Lldb-commits] [PATCH] D66445: Explicitly Cast Constants to DWORD

jmittert added a comment. I believe it's using the one in ntstatus.h 10.0.16299.0\shared\ntstatus.h #define STATUS_BREAKPOINT((NTSTATUS)0x8003L)// winnt And `NTSTATUS` is defined as a `LONG` in powerbase.h 10.0.16299.0\um\powerbase.h #define NTSTATUS LONG which

[Lldb-commits] [PATCH] D66546: Extend FindTypes w/ CompilerContext to allow filtering by language

aprantl updated this revision to Diff 216644. aprantl added a comment. Here's an improved version: - got rid of the completely unnecessary optimization that use memcpy - made the struct have a SmallBitVector member instead of inheriting from it. The new struct has an LLVM-like interface for many

[Lldb-commits] [PATCH] D66445: Explicitly Cast Constants to DWORD

amccarth added a comment. Is this necessary? I see C++ #define STATUS_BREAKPOINT((DWORD )0x8003L) #define STATUS_SINGLE_STEP ((DWORD )0x8004L) in C:\Program Files (x86)\Windows Kits\8.1\Include\um\winnt.h Repository: rLLDB LLDB CHANGES SINCE

Re: [Lldb-commits] [lldb] r369652 - [lldb][NFC] Fix indentation in CommandObjectProcess

Thanks for the quick fix! On Thu, Aug 22, 2019 at 5:29 PM Raphael “Teemperor” Isemann < teempe...@gmail.com> wrote: > Fix is already committed as 369660, sorry for that. > - Raphael > > On Aug 22, 2019, at 5:28 PM, Alexander Kornienko via lldb-commits < > lldb-commits@lists.llvm.org> wrote: > > T

Re: [Lldb-commits] [lldb] r369652 - [lldb][NFC] Fix indentation in CommandObjectProcess

Fix is already committed as 369660, sorry for that. - Raphael > On Aug 22, 2019, at 5:28 PM, Alexander Kornienko via lldb-commits > wrote: > > This commit breaks buildbots: > http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/8107 >

Re: [Lldb-commits] [lldb] r369652 - [lldb][NFC] Fix indentation in CommandObjectProcess

This commit breaks buildbots: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/8107 On Thu, Aug 22, 2019 at 3:49 PM Raphael Isemann via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: teemperor > Date: Thu Aug 22 06:50:54 2019 > New Revision: 369652 > > URL: http://llv

[Lldb-commits] [lldb] r369660 - [lldb] Remove ')' to fix the build

Author: teemperor Date: Thu Aug 22 08:18:40 2019 New Revision: 369660 URL: http://llvm.org/viewvc/llvm-project?rev=369660&view=rev Log: [lldb] Remove ')' to fix the build That ')' slipped in by accident in the reformatting commit. Modified: lldb/trunk/source/Commands/CommandObjectProcess.cpp

[Lldb-commits] [PATCH] D66398: 2/2: Fix `TestDataFormatterStdList` regression

jankratochvil added a comment. In D66398#1640871 , @labath wrote: > because these kinds of regular are horrid. Yes, they are. So let's link with PCRE (BSD licensed). > What was the problem with the dispatching solution? I do not

[Lldb-commits] [PATCH] D66398: 2/2: Fix `TestDataFormatterStdList` regression

This revision was automatically updated to reflect the committed changes. Closed by commit rL369655: [lldb] Fix `TestDataFormatterStdList` regression (authored by jankratochvil, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https

[Lldb-commits] [lldb] r369655 - [lldb] Fix `TestDataFormatterStdList` regression

Author: jankratochvil Date: Thu Aug 22 07:29:52 2019 New Revision: 369655 URL: http://llvm.org/viewvc/llvm-project?rev=369655&view=rev Log: [lldb] Fix `TestDataFormatterStdList` regression Since D66174 I see failures of TestDataFormatterStdList in about 50% of runs on Fedora 30 x86_64 libstdc++.

[Lldb-commits] [lldb] r369652 - [lldb][NFC] Fix indentation in CommandObjectProcess

Author: teemperor Date: Thu Aug 22 06:50:54 2019 New Revision: 369652 URL: http://llvm.org/viewvc/llvm-project?rev=369652&view=rev Log: [lldb][NFC] Fix indentation in CommandObjectProcess Modified: lldb/trunk/source/Commands/CommandObjectProcess.cpp Modified: lldb/trunk/source/Commands/Comma

[Lldb-commits] [lldb] r369646 - [lldb][NFC] Add test for target stop-hook disable/enable/delete

Author: teemperor Date: Thu Aug 22 06:09:02 2019 New Revision: 369646 URL: http://llvm.org/viewvc/llvm-project?rev=369646&view=rev Log: [lldb][NFC] Add test for target stop-hook disable/enable/delete Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/target_command/TestTarge

[Lldb-commits] [PATCH] D66398: 2/2: Fix `TestDataFormatterStdList` regression

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D66398#1640840 , @jankratochvil wrote: > It just makes now the regexes unambiguous. I think this is fine too, but I would also only consider it a

[Lldb-commits] [PATCH] D66398: 2/2: Fix `TestDataFormatterStdList` regression

jankratochvil added a comment. In D66398#1635344 , @labath wrote: > Since it seems that there is a need for disambiguation (libc++ can be > configured to have any name for the inline namespace, so there's no way to > make its regex not match the libstdc+

[Lldb-commits] [PATCH] D66398: 2/2: Fix `TestDataFormatterStdList` regression

jankratochvil updated this revision to Diff 216585. jankratochvil edited the summary of this revision. jankratochvil added a comment. It just makes now the regexes unambiguous. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66398/new/ https://reviews.llvm.org/D6

[Lldb-commits] [PATCH] D66581: [lldb] Construct the dummy target when the first Dummy object is constructed

teemperor updated this revision to Diff 216581. teemperor added a comment. - Fix variable name. - Move GetDummyTarget to header as it's only a one-liner. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66581/new/ https://reviews.llvm.org/D66581 Files: lldb/include/lldb/Core/Debugger.h

[Lldb-commits] [PATCH] D66581: [lldb] Construct the dummy target when the first Dummy object is constructed

labath added a reviewer: jingham. labath accepted this revision. labath added a subscriber: jingham. labath added a comment. This revision is now accepted and ready to land. This looks good to me (I wanted to do something like that myself at one point), but maybe let @jingham have a say too. (Ove

[Lldb-commits] [PATCH] D66581: [lldb] Construct the dummy target when the first Dummy object is constructed

teemperor created this revision. teemperor added a reviewer: labath. Herald added subscribers: lldb-commits, abidh. Herald added a project: LLDB. We should always have a dummy target, so we might as well construct it directly when we create a Debugger object. The idea is that if this patch doesn

[Lldb-commits] [lldb] r369635 - [lldb][NFC] Remove unused return value from HandleOptionArgumentCompletion

Author: teemperor Date: Thu Aug 22 02:14:42 2019 New Revision: 369635 URL: http://llvm.org/viewvc/llvm-project?rev=369635&view=rev Log: [lldb][NFC] Remove unused return value from HandleOptionArgumentCompletion Modified: lldb/trunk/include/lldb/Interpreter/Options.h lldb/trunk/source/Comm

[Lldb-commits] [lldb] r369632 - [lldb][NFC] NFC cleanup for the completion code

Author: teemperor Date: Thu Aug 22 02:02:54 2019 New Revision: 369632 URL: http://llvm.org/viewvc/llvm-project?rev=369632&view=rev Log: [lldb][NFC] NFC cleanup for the completion code Modified: lldb/trunk/source/Commands/CommandObjectHelp.cpp lldb/trunk/source/Commands/CommandObjectMultiw

[Lldb-commits] [PATCH] D66522: [lldb][NFC] Remove dead code that is supposed to handle invalid command options

This revision was automatically updated to reflect the committed changes. Closed by commit rL369625: [lldb][NFC] Remove dead code that is supposed to handle invalid command options (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chang

[Lldb-commits] [lldb] r369625 - [lldb][NFC] Remove dead code that is supposed to handle invalid command options

Author: teemperor Date: Thu Aug 22 01:08:05 2019 New Revision: 369625 URL: http://llvm.org/viewvc/llvm-project?rev=369625&view=rev Log: [lldb][NFC] Remove dead code that is supposed to handle invalid command options Summary: We currently have a bunch of code that is supposed to handle invalid com

[Lldb-commits] [PATCH] D66536: [lldb][NFC] Remove WordComplete mode, make result array indexed from 0 and remove any undocumented/redundant return values

This revision was automatically updated to reflect the committed changes. Closed by commit rL369624: [lldb][NFC] Remove WordComplete mode, make result array indexed from 0 and… (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed p

[Lldb-commits] [PATCH] D66546: Extend FindTypes w/ CompilerContext to allow filtering by language

labath added a comment. The functionality seems fine, and I like how you got rid of the extra callbacks in the plugin manager in favour of passing the sets explicitly. I'm not really a fan of inheriting from standard containers. And though the motivation here is stronger than in the previous ca