[Lldb-commits] [lldb] r369827 - [NFC] Fix comments and formatting.

Author: jdevlieghere Date: Fri Aug 23 16:56:19 2019 New Revision: 369827 URL: http://llvm.org/viewvc/llvm-project?rev=369827&view=rev Log: [NFC] Fix comments and formatting. Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/HashedNameToDIE.cpp lldb/trunk/source/Plugins/SymbolFile/DWARF

[Lldb-commits] [lldb] r369821 - Skip tail call frame tests when dwarf_version < 4

Author: vedantk Date: Fri Aug 23 15:28:46 2019 New Revision: 369821 URL: http://llvm.org/viewvc/llvm-project?rev=369821&view=rev Log: Skip tail call frame tests when dwarf_version < 4 rdar://problem/54656572 Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/tail_call_frame

[Lldb-commits] [lldb] r369814 - Upstream support for macCatalyst Mach-O binaries.

Author: adrian Date: Fri Aug 23 14:28:14 2019 New Revision: 369814 URL: http://llvm.org/viewvc/llvm-project?rev=369814&view=rev Log: Upstream support for macCatalyst Mach-O binaries. On macOS one Mach-O slice can contain multiple load commands: One load command for being loaded into a macOS proce

[Lldb-commits] [PATCH] D66248: [JIT][Command] Add "inject-condition" flag to conditional breakpoints

mib updated this revision to Diff 216947. mib added a comment. Rename BreakpointOption name to "InjectCondition" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66248/new/ https://reviews.llvm.org/D66248 Files: lldb/include/lldb/API/SBBreakpoint.h

[Lldb-commits] [PATCH] D66248: [JIT][Command] Add "inject-condition" flag to conditional breakpoints

mib marked 3 inline comments as done. mib added inline comments. Comment at: lldb/include/lldb/Breakpoint/BreakpointOptions.h:364 + void SetInjectCondition(bool inject_condition) { +m_inject_condition = inject_condition; +m_set_flags.Set(eInjectCondition); --

[Lldb-commits] [PATCH] D66249: [JIT][Breakpoint] Add "BreakpointInjectedSite" and FCB Trampoline

mib marked 2 inline comments as done. mib added a comment. In D66249#1642316 , @labath wrote: > A bunch more comments from me. So far, I've only tried to highlight the most > obvious problems or style issues. > > It's not clear to me whether this is sti

[Lldb-commits] [PATCH] D66633: Breakpad: Add support for parsing STACK WIN records

markmentovai accepted this revision. markmentovai added a comment. LGTM too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66633/new/ https://reviews.llvm.org/D66633 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [PATCH] D66633: Breakpad: Add support for parsing STACK WIN records

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66633/new/ https://reviews.llvm.org/D66633 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D66445: Explicitly Cast Constants to DWORD

compnerd closed this revision. compnerd added a comment. SVN r369788 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66445/new/ https://reviews.llvm.org/D66445 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [lldb] r369788 - Windows: explicitly cast constants to `DWORD`

Author: compnerd Date: Fri Aug 23 10:58:53 2019 New Revision: 369788 URL: http://llvm.org/viewvc/llvm-project?rev=369788&view=rev Log: Windows: explicitly cast constants to `DWORD` STATUS_SINGLE_STEP and STATUS_BREAKPOINT are defined as 0x8-- which is negative and thus can't be implicitly nar

[Lldb-commits] [PATCH] D66654: Prevent D66398 `TestDataFormatterStdList`-like regressions in the future

granata.enrico resigned from this revision. granata.enrico added a comment. I'm not working on LLDB anymore. Sorry about that. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66654/new/ https://reviews.llvm.org/D66654 __

[Lldb-commits] [PATCH] D66654: Prevent D66398 `TestDataFormatterStdList`-like regressions in the future

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. > I understand one could pass some better abstracted error-reporting interface > instead of ValueObject itself but that would require some more code > (interface definiti

[Lldb-commits] [PATCH] D66655: [lldb] Fix x86 compilation

leonid.mashinskiy created this revision. leonid.mashinskiy added a reviewer: asmith. leonid.mashinskiy added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rLLDB LLDB https://reviews.llvm.org/D66655 Files: source/Plugins/Process/Windows/Common/NativeRegisterContextWind

[Lldb-commits] [PATCH] D66654: Prevent D66398 `TestDataFormatterStdList`-like regressions in the future

jankratochvil created this revision. jankratochvil added reviewers: labath, JDevlieghere, granata.enrico. jankratochvil added a project: LLDB. Herald added a subscriber: lldb-commits. The sanity checking part is improved here to use some

[Lldb-commits] [PATCH] D66634: Postfix: move more code out of the PDB plugin

labath created this revision. labath added reviewers: amccarth, aleksandr.urakov. Herald added a subscriber: aprantl. Previously we moved the code which parses a single expression out of the PDB plugin, because that was useful for DWARF expressions in breakpad. However, FPO programs are used in br

[Lldb-commits] [PATCH] D66633: Breakpad: Add support for parsing STACK WIN records

labath created this revision. labath added reviewers: amccarth, markmentovai. The fields that aren't useful for us right now are simply ignored. https://reviews.llvm.org/D66633 Files: source/Plugins/ObjectFile/Breakpad/BreakpadRecords.cpp source/Plugins/ObjectFile/Breakpad/BreakpadRecords.h

[Lldb-commits] [PATCH] D65952: SymbolVendor: Have plugins return symbol files directly

labath updated this revision to Diff 216782. labath added a comment. merge m_old_symfiles and m_symfiles_up. I am not entirely satisfied with how I implemented that, but then again the original implementation wasn't totally clean either. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65

[Lldb-commits] [PATCH] D65952: SymbolVendor: Have plugins return symbol files directly

labath added a comment. In D65952#1641539 , @clayborg wrote: > In D65952#1624799 , @labath wrote: > > > In D65952#1623297 , @clayborg > > wrote: > > > > > So I am confused.

[Lldb-commits] [PATCH] D66250: [JIT][Unwinder] Add Trampoline ObjectFile and UnwindPlan support for FCB

labath added a comment. In D66250#1638338 , @jasonmolenda wrote: > In D66250#1633455 , @clayborg wrote: > > > Why are we not just using ObjectFileJIT? I am guessing these breakpoint > > expressions create one of t

[Lldb-commits] [PATCH] D66249: [JIT][Breakpoint] Add "BreakpointInjectedSite" and FCB Trampoline

labath added a comment. A bunch more comments from me. So far, I've only tried to highlight the most obvious problems or style issues. It's not clear to me whether this is still prototype code or not... If it isn't, I'll have a bunch more.. :) Comment at: lldb/include/lldb/B