[Lldb-commits] [lldb] r371015 - [dotest] Delete trivial inline test makefiles

Author: labath Date: Wed Sep 4 23:55:23 2019 New Revision: 371015 URL: http://llvm.org/viewvc/llvm-project?rev=371015&view=rev Log: [dotest] Delete trivial inline test makefiles inline tests are able to generate these automatically Removed: lldb/trunk/packages/Python/lldbsuite/test/command

[Lldb-commits] [PATCH] D67168: [Windows] Add support of watchpoints to `ProcessWindows`

labath added inline comments. Comment at: lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp:852 +RegisterContextWindows *reg_ctx = static_cast( +thread->GetRegisterContext().get()); +if (!reg_ctx->AddHardwareBreakpoint(info.slot, info.address, info.siz

[Lldb-commits] [PATCH] D67168: [Windows] Add support of watchpoints to `ProcessWindows`

aleksandr.urakov marked 5 inline comments as done. aleksandr.urakov added inline comments. Comment at: lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp:397 +if (slot != LLDB_INVALID_INDEX32) { + int id = m_watchpoint_slots[slot]; + LLDB_LOG(log, ---

[Lldb-commits] [PATCH] D67168: [Windows] Add support of watchpoints to `ProcessWindows`

aleksandr.urakov updated this revision to Diff 218840. aleksandr.urakov marked an inline comment as done. aleksandr.urakov added a comment. Check bitness of the target when checking the watchpoint size. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67168/new/ h

[Lldb-commits] [PATCH] D67168: [Windows] Add support of watchpoints to `ProcessWindows`

aleksandr.urakov updated this revision to Diff 218838. aleksandr.urakov added a comment. Address the requested changes. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67168/new/ https://reviews.llvm.org/D67168 Files: lldb/packages/Python/lldbsuite/test/comma

[Lldb-commits] [PATCH] D67168: [Windows] Add support of watchpoints to `ProcessWindows`

aleksandr.urakov updated this revision to Diff 218837. aleksandr.urakov added a comment. Address the requested changes. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67168/new/ https://reviews.llvm.org/D67168 Files: lldb/packages/Python/lldbsuite/test/comma

[Lldb-commits] [lldb] r370998 - [Disassembler] Simplify a few methods (2/2) (NFC)

Author: jdevlieghere Date: Wed Sep 4 16:05:32 2019 New Revision: 370998 URL: http://llvm.org/viewvc/llvm-project?rev=370998&view=rev Log: [Disassembler] Simplify a few methods (2/2) (NFC) Use early returns to highlight preconditions and make the code easier to follow. Modified: lldb/trunk/s

[Lldb-commits] [PATCH] D67168: [Windows] Add support of watchpoints to `ProcessWindows`

zturner added inline comments. Comment at: lldb/source/Plugins/Process/Windows/Common/RegisterContextWindows.cpp:82 -bool RegisterContextWindows::ClearHardwareBreakpoint(uint32_t hw_idx) { - return false; -} + if (!size || size > 8 || size & (size - 1)) +return false; --

[Lldb-commits] [PATCH] D67111: Adding caching to libc++ std::function formatter for lookups that require scanning symbols

friss added inline comments. Comment at: packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/function/TestLibCxxFunction.py:49-59 +self.runCmd("log timers reset") +self.expect("frame variable foo2_f", +subst

[Lldb-commits] [lldb] r370994 - [Disassembler] Simplify a few methods (NFC)

Author: jdevlieghere Date: Wed Sep 4 15:38:20 2019 New Revision: 370994 URL: http://llvm.org/viewvc/llvm-project?rev=370994&view=rev Log: [Disassembler] Simplify a few methods (NFC) Use early returns to highlight preconditions and make the code easier to follow. Modified: lldb/trunk/include

[Lldb-commits] [PATCH] D67168: [Windows] Add support of watchpoints to `ProcessWindows`

amccarth added inline comments. Comment at: lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp:397 +if (slot != LLDB_INVALID_INDEX32) { + int id = m_watchpoint_slots[slot]; + LLDB_LOG(log, The names here are a bit confusing: `GetTriggere

[Lldb-commits] [PATCH] D67111: Adding caching to libc++ std::function formatter for lookups that require scanning symbols

shafik updated this revision to Diff 218797. shafik marked 2 inline comments as done. shafik added a comment. Addressing comments - Using log timers to verify whether we are using the cache or not - Switched to llvm::StringMap CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67111/new/ ht

[Lldb-commits] [lldb] r370983 - [test] Escape path to match the literal string

Author: jdevlieghere Date: Wed Sep 4 14:18:46 2019 New Revision: 370983 URL: http://llvm.org/viewvc/llvm-project?rev=370983&view=rev Log: [test] Escape path to match the literal string This test was failing when you had things like `+` in your build path. Modified: lldb/trunk/packages/Pyth

[Lldb-commits] [PATCH] D67022: Enhance SymbolFileDWARF::ParseDeclsForContext performance

guiandrade added inline comments. Comment at: lldb/unittests/SymbolFile/DWARF/DWARFASTParserClangTests.cpp:27 // defining here, causing this test to fail, feel free to delete it. -TEST(DWARFASTParserClangTests, - TestGetDIEForDeclContextReturnsOnlyMatchingEntries) { - Clang

[Lldb-commits] [PATCH] D67022: Enhance SymbolFileDWARF::ParseDeclsForContext performance

guiandrade updated this revision to Diff 218779. guiandrade added a comment. Migrating to EnsureAllDIEsInDeclContextHaveBeenParsed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67022/new/ https://reviews.llvm.org/D67022 Files: lldb/source/Plugin

[Lldb-commits] [PATCH] D67022: Enhance SymbolFileDWARF::ParseDeclsForContext performance

guiandrade added a comment. In D67022#1658057 , @clayborg wrote: > In D67022#1656874 , @labath wrote: > > > Thanks for the clarification Greg. > > > > Functionally, this patch seems fine, but I am still wondering if

[Lldb-commits] [lldb] r370963 - Revert "[test] Address TestConcurrentMany*.py flakiness on macOS"

Author: jdevlieghere Date: Wed Sep 4 12:36:29 2019 New Revision: 370963 URL: http://llvm.org/viewvc/llvm-project?rev=370963&view=rev Log: Revert "[test] Address TestConcurrentMany*.py flakiness on macOS" This reverts my change to pseudo_barrier.h which isn't necessary anymore after Fred's fix to

[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Make the RedirectingFileSystem hold on to its own working directory.

JDevlieghere updated this revision to Diff 218768. JDevlieghere retitled this revision from "[VirtualFileSystem] Support encoding working directories in a VFS mapping." to "[VirtualFileSystem] Make the RedirectingFileSystem hold on to its own working directory.". JDevlieghere edited the summary o

[Lldb-commits] [PATCH] D67184: [Python] Implement __next__ for value_iter

This revision was automatically updated to reflect the committed changes. Closed by commit rL370954: [Python] Implement __next__ for value_iter (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revi

[Lldb-commits] [PATCH] D67183: [Python] Implement truth testing for lldb.value

This revision was automatically updated to reflect the committed changes. Closed by commit rL370953: [Python] Implement truth testing for lldb.value (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[Lldb-commits] [lldb] r370954 - [Python] Implement __next__ for value_iter

Author: jdevlieghere Date: Wed Sep 4 11:59:13 2019 New Revision: 370954 URL: http://llvm.org/viewvc/llvm-project?rev=370954&view=rev Log: [Python] Implement __next__ for value_iter Python 3 iteration calls the next() method instead of next() and value_iter only implemented the Python 2 version.

[Lldb-commits] [lldb] r370953 - [Python] Implement truth testing for lldb.value

Author: jdevlieghere Date: Wed Sep 4 11:59:10 2019 New Revision: 370953 URL: http://llvm.org/viewvc/llvm-project?rev=370953&view=rev Log: [Python] Implement truth testing for lldb.value Python 3 calls __bool__() instead of __len__() and lldb.value only implemented the __len__ method. This adds t

[Lldb-commits] [lldb] r370952 - [Python] Fix whitespace before making changes (NFC)

Author: jdevlieghere Date: Wed Sep 4 11:59:06 2019 New Revision: 370952 URL: http://llvm.org/viewvc/llvm-project?rev=370952&view=rev Log: [Python] Fix whitespace before making changes (NFC) Modified: lldb/trunk/scripts/Python/python-extensions.swig Modified: lldb/trunk/scripts/Python/python

[Lldb-commits] [PATCH] D67022: Enhance SymbolFileDWARF::ParseDeclsForContext performance

labath added a comment. In D67022#1658057 , @clayborg wrote: > Great idea, but this idea gave me the idea to use "m_decl_ctx_to_die" as is, > and just remove the entry once we have parse all decls. Then we free the > memory and don't need a bit. If ther

[Lldb-commits] [PATCH] D67184: [Python] Implement __next__ for value_iter

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67184/new/ https://reviews.llvm.org/D67184 ___ lldb-commits

[Lldb-commits] [PATCH] D67183: [Python] Implement truth testing for lldb.value

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67183/new/ https://reviews.llvm.org/D67183 ___ lldb-commits

[Lldb-commits] [PATCH] D67022: Enhance SymbolFileDWARF::ParseDeclsForContext performance

clayborg added a comment. In D67022#1656874 , @labath wrote: > Thanks for the clarification Greg. > > Functionally, this patch seems fine, but I am still wondering if we shouldn't > make this more efficient. std::set is not the most memory-efficient > st

[Lldb-commits] [lldb] r370931 - Upstream macCatalyst support in debugserver and the macOS dynamic loader

Author: adrian Date: Wed Sep 4 10:23:15 2019 New Revision: 370931 URL: http://llvm.org/viewvc/llvm-project?rev=370931&view=rev Log: Upstream macCatalyst support in debugserver and the macOS dynamic loader plugin. Unfortunately the test is currently XFAILed because of missing changes to the clang

Re: [Lldb-commits] [lldb] r370848 - [lldb][NFC] Add a simple test for thread_local storage.

It seems like it would also be useful to test that threads actually see their own copy as well. > On Sep 4, 2019, at 1:02 AM, Raphael Isemann via lldb-commits > wrote: > > Author: teemperor > Date: Wed Sep 4 01:02:52 2019 > New Revision: 370848 > > URL: http://llvm.org/viewvc/llvm-project?re

[Lldb-commits] [PATCH] D67123: [lldb] Early exit in RangeDataVector:FindEntryIndexesThatContain

amccarth added a comment. Disregard my last comment. Phabricator wasn't showing me that latest, nor that the patch had already been submitted, which seems to be happening with increasing frequency. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67123/new/ https:

[Lldb-commits] [PATCH] D67123: [lldb] Early exit in RangeDataVector:FindEntryIndexesThatContain

amccarth added inline comments. Comment at: lldb/include/lldb/Utility/RangeMap.h:739 +auto end = std::lower_bound(m_entries.begin(), m_entries.end(), +Entry(addr, 1), BaseLessEqual); +for (auto I = m_entries.begin(); I != end; ++I) { --

[Lldb-commits] [PATCH] D67067: Breakpad: Basic support for STACK WIN unwinding

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. LGTM. Please consider adding a comment to the assert that summarizes what you explained in the thread. Comment at: source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad

[Lldb-commits] [PATCH] D67173: [dotest] Centralize initialization commands even more

JDevlieghere accepted this revision. JDevlieghere added inline comments. This revision is now accepted and ready to land. Comment at: packages/Python/lldbsuite/test/lldbtest.py:709 +if lldbtest_config.inferior_env: +commands.append('settings set target.env-var

[Lldb-commits] [lldb] r370916 - Workaround TestConcurrentMany* flakiness in a more pricipled way

Author: friss Date: Wed Sep 4 09:13:12 2019 New Revision: 370916 URL: http://llvm.org/viewvc/llvm-project?rev=370916&view=rev Log: Workaround TestConcurrentMany* flakiness in a more pricipled way The flakiness on our local machines seems to come for a race in the kernel between task_suspend and

[Lldb-commits] [PATCH] D67184: [Python] Implement __next__ for value_iter

JDevlieghere created this revision. JDevlieghere added reviewers: friss, LLDB. Herald added a project: LLDB. Python 3 iteration calls the next() method instead of next() and value_iter only implemented the Python 2 version. Repository: rLLDB LLDB https://reviews.llvm.org/D67184 Files: lldb

[Lldb-commits] [PATCH] D67183: [Python] Implement truth testing for lldb.value

JDevlieghere created this revision. JDevlieghere added reviewers: friss, LLDB. Herald added a project: LLDB. Python 3 calls __bool__() instead of __len__() and lldb.value only implemented the __len__ method. This adds the __bool__() implementation. Repository: rLLDB LLDB https://reviews.llvm.

[Lldb-commits] [PATCH] D66742: Obliterate LLDB_CONFIGURATION_BUILDANDINTEGRATION

friss accepted this revision. friss added a comment. This revision is now accepted and ready to land. I don't see reason to keep this around. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66742/new/ https://reviews.llvm.org/D66742 ___ lldb-

Re: [Lldb-commits] [lldb] r370848 - [lldb][NFC] Add a simple test for thread_local storage.

> On Sep 4, 2019, at 1:02 AM, Raphael Isemann via lldb-commits > wrote: > > Author: teemperor > Date: Wed Sep 4 01:02:52 2019 > New Revision: 370848 > > URL: http://llvm.org/viewvc/llvm-project?rev=370848&view=rev > Log: > [lldb][NFC] Add a simple test for thread_local storage. > > Seems we

[Lldb-commits] [PATCH] D67173: [dotest] Centralize initialization commands even more

labath created this revision. labath added reviewers: JDevlieghere, jankratochvil. In r367234 we introduced a central place to hold the set up commands for the various ways we have of launching lldb. However, a number of commands still remained outside of that. This patch moves the remaining set

[Lldb-commits] [PATCH] D67168: [Windows] Add support of watchpoints to `ProcessWindows`

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: asmith, stella.stamenova, amccarth. aleksandr.urakov added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieghere, abidh. aleksandr.urakov added a subscriber: leonid.mashinskiy. This patch adds support of watc

[Lldb-commits] [lldb] r370898 - disassemble command: fix error message when disassembly fails

Author: labath Date: Wed Sep 4 06:26:41 2019 New Revision: 370898 URL: http://llvm.org/viewvc/llvm-project?rev=370898&view=rev Log: disassemble command: fix error message when disassembly fails We were printing the start_addr field, which is not correct, as in this branch we are processing the m

[Lldb-commits] [lldb] r370887 - [lldb] Fix log statement in Socket::Write

Author: teemperor Date: Wed Sep 4 05:38:43 2019 New Revision: 370887 URL: http://llvm.org/viewvc/llvm-project?rev=370887&view=rev Log: [lldb] Fix log statement in Socket::Write We change num_bytes in this method, so this doesn't actually log the parameter that we called the function with. No tes

[Lldb-commits] [PATCH] D67001: [lldb] Limit the amount of zeroes we use for padding when printing small floats

This revision was automatically updated to reflect the committed changes. Closed by commit rL370880: [lldb] Limit the amount of zeroes we use for padding when printing small floats (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chang

[Lldb-commits] [lldb] r370880 - [lldb] Limit the amount of zeroes we use for padding when printing small floats

Author: teemperor Date: Wed Sep 4 04:41:23 2019 New Revision: 370880 URL: http://llvm.org/viewvc/llvm-project?rev=370880&view=rev Log: [lldb] Limit the amount of zeroes we use for padding when printing small floats Summary: We got a radar that printing small floats is not very user-friendly in L

[Lldb-commits] [PATCH] D67123: [lldb] Early exit in RangeDataVector:FindEntryIndexesThatContain

teemperor updated this revision to Diff 218644. teemperor marked an inline comment as done. teemperor added a comment. - remove empty check CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67123/new/ https://reviews.llvm.org/D67123 Files: lldb/include/lldb/Utility/RangeMap.h Index: ll

[Lldb-commits] [lldb] r370879 - [lldb] Early exit in RangeDataVector:FindEntryIndexesThatContain

Author: teemperor Date: Wed Sep 4 04:40:29 2019 New Revision: 370879 URL: http://llvm.org/viewvc/llvm-project?rev=370879&view=rev Log: [lldb] Early exit in RangeDataVector:FindEntryIndexesThatContain Summary: We currently spend a lot of time in this function (around 27% of the br-by-regex bench

[Lldb-commits] [PATCH] D67123: [lldb] Early exit in RangeDataVector:FindEntryIndexesThatContain

This revision was automatically updated to reflect the committed changes. Closed by commit rL370879: [lldb] Early exit in RangeDataVector:FindEntryIndexesThatContain (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to co

[Lldb-commits] [PATCH] D66742: Obliterate LLDB_CONFIGURATION_BUILDANDINTEGRATION

labath added a comment. Any thoughts on this one? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66742/new/ https://reviews.llvm.org/D66742 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

labath added a comment. I think we're getting pretty close. I have a couple of extra comments inline, but they're all pretty minor, I hope. I'd just like to add some more tests, per our discussion on the IRC, and I have some doubts about what exactly is the test you've written actually testing,

[Lldb-commits] [PATCH] D67049: 1/2: Code cleanup: Change FormattersContainer::KeyType from SP to rvalue

This revision was automatically updated to reflect the committed changes. Closed by commit rL370863: Code cleanup: Change FormattersContainer::KeyType from SP to rvalue (authored by jankratochvil, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[Lldb-commits] [lldb] r370863 - Code cleanup: Change FormattersContainer::KeyType from SP to rvalue

Author: jankratochvil Date: Wed Sep 4 02:47:18 2019 New Revision: 370863 URL: http://llvm.org/viewvc/llvm-project?rev=370863&view=rev Log: Code cleanup: Change FormattersContainer::KeyType from SP to rvalue There is now std::shared_ptr passed around which is expensive for manycore CPUs. Most of

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218623. kwk added a comment. squashed and rebased on top of master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files: lldb/CMakeLists.txt lldb/cmake/modules/LLDBCon

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218621. kwk added a comment. - remove not needed include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files: lldb/CMakeLists.txt lldb/cmake/modules/LLDBConfig.cmake

[Lldb-commits] [PATCH] D67082: Port TestBatchMode to PExpectTest class

This revision was automatically updated to reflect the committed changes. Closed by commit rL370858: Port TestBatchMode to PExpectTest class (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218618. kwk marked an inline comment as done. kwk added a comment. Herald added a reviewer: alexshap. - add lit test for minidebuginfo - Fixup - test - Fiddle with the lit test - Fix binary in lit test - Working lit test - still need to only run it when minidebugi

[Lldb-commits] [lldb] r370858 - Port TestBatchMode to PExpectTest class

Author: labath Date: Wed Sep 4 02:20:08 2019 New Revision: 370858 URL: http://llvm.org/viewvc/llvm-project?rev=370858&view=rev Log: Port TestBatchMode to PExpectTest class Summary: I'm doing this mainly for consistency, but there are also other cleanups that will be enabled by this (e.g., the au

[Lldb-commits] [lldb] r370856 - [lldb][NFC] Rename ReadRegisterValue to PrintRegisterValue

Author: teemperor Date: Wed Sep 4 02:18:10 2019 New Revision: 370856 URL: http://llvm.org/viewvc/llvm-project?rev=370856&view=rev Log: [lldb][NFC] Rename ReadRegisterValue to PrintRegisterValue That was the actual name I had in mind, but it seems git didn't pick that change up when committing my

[Lldb-commits] [lldb] r370854 - [lldb][NFC] Remove WriteRegister copy-pasta from ObjectFileMachO

Author: teemperor Date: Wed Sep 4 02:10:28 2019 New Revision: 370854 URL: http://llvm.org/viewvc/llvm-project?rev=370854&view=rev Log: [lldb][NFC] Remove WriteRegister copy-pasta from ObjectFileMachO The function had the same name as one of the member function, so it was just copied to all class

[Lldb-commits] [PATCH] D67067: Breakpad: Basic support for STACK WIN unwinding

labath added a comment. We always need more tests. I've now added more tests for various boundary conditions. Comment at: source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:549 + llvm::Optional record = StackWinRecord::parse(*It); + assert(record.hasValue()); + --

[Lldb-commits] [PATCH] D67067: Breakpad: Basic support for STACK WIN unwinding

labath updated this revision to Diff 218611. labath marked 3 inline comments as done. labath added a comment. add more tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67067/new/ https://reviews.llvm.org/D67067 Files: lit/SymbolFile/Breakpad/Inputs/unwind-via-stack-win.syms lit/

[Lldb-commits] [lldb] r370848 - [lldb][NFC] Add a simple test for thread_local storage.

Author: teemperor Date: Wed Sep 4 01:02:52 2019 New Revision: 370848 URL: http://llvm.org/viewvc/llvm-project?rev=370848&view=rev Log: [lldb][NFC] Add a simple test for thread_local storage. Seems we fail to read TLS data on Linux, so the test only runs on macOS for now. We will see how this tes

[Lldb-commits] [PATCH] D67123: [lldb] Early exit in RangeDataVector:FindEntryIndexesThatContain

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm Comment at: lldb/include/lldb/Utility/RangeMap.h:728-729 -if (!m_entries.empty()) { - for (const auto &entry : m_entries) { -if (entry.Contains(addr))

[Lldb-commits] [PATCH] D67123: [lldb] Early exit in RangeDataVector:FindEntryIndexesThatContain

teemperor marked 3 inline comments as done. teemperor added inline comments. Comment at: lldb/include/lldb/Utility/RangeMap.h:739 +auto end = std::lower_bound(m_entries.begin(), m_entries.end(), +Entry(addr, 1), BaseLessEqual); +for (auto I

[Lldb-commits] [PATCH] D67123: [lldb] Early exit in RangeDataVector:FindEntryIndexesThatContain

teemperor updated this revision to Diff 218602. teemperor retitled this revision from "[lldb] Use binary search in RangeDataVector:FindEntryIndexesThatContain" to "[lldb] Early exit in RangeDataVector:FindEntryIndexesThatContain". teemperor edited the summary of this revision. teemperor added a c

[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Support encoding working directories in a VFS mapping.

sammccall added a comment. (I replied by email, it seems phabricator doesn't pick it up.) In D65677#1649731 , @JDevlieghere wrote: > In D65677#1649329 , @sammccall wrote: > > > In D65677#1649291

[Lldb-commits] [PATCH] D67083: [dotest] Avoid the need for LEVEL= makefile boilerplate

labath marked an inline comment as done. labath added inline comments. Comment at: packages/Python/lldbsuite/test/lldbinline.py:116 -makefile.write("include $(LEVEL)/Makefile.rules\n") +makefile.write("include Makefile.rules\n") makefile.write("\ncleanu

[Lldb-commits] [PATCH] D67022: Enhance SymbolFileDWARF::ParseDeclsForContext performance

labath added a comment. Thanks for the clarification Greg. Functionally, this patch seems fine, but I am still wondering if we shouldn't make this more efficient. std::set is not the most memory-efficient structure, and so creating a std::set entry just to store one bit seems wasteful, particu