[Lldb-commits] [lldb] r371172 - [lldb] Remove xcode bot from website listing and fix link to sanitized

Author: teemperor Date: Fri Sep 6 00:11:14 2019 New Revision: 371172 URL: http://llvm.org/viewvc/llvm-project?rev=371172&view=rev Log: [lldb] Remove xcode bot from website listing and fix link to sanitized Modified: lldb/trunk/docs/resources/bots.rst Modified: lldb/trunk/docs/resources/bots

[Lldb-commits] [lldb] r371176 - [lldb][NFC] Remove unused Args::GetArgumentQuoteCharAtIndex

Author: teemperor Date: Fri Sep 6 00:54:47 2019 New Revision: 371176 URL: http://llvm.org/viewvc/llvm-project?rev=371176&view=rev Log: [lldb][NFC] Remove unused Args::GetArgumentQuoteCharAtIndex Modified: lldb/trunk/include/lldb/Utility/Args.h lldb/trunk/source/Utility/Args.cpp Modified

[Lldb-commits] [lldb] r371180 - [lldb][NFC] Extend ArgsTest

Author: teemperor Date: Fri Sep 6 01:39:53 2019 New Revision: 371180 URL: http://llvm.org/viewvc/llvm-project?rev=371180&view=rev Log: [lldb][NFC] Extend ArgsTest Modified: lldb/trunk/unittests/Utility/ArgsTest.cpp Modified: lldb/trunk/unittests/Utility/ArgsTest.cpp URL: http://llvm.org/vi

[Lldb-commits] [lldb] r371181 - [lldb][NFC] Remove Args::StripSpaces

Author: teemperor Date: Fri Sep 6 01:40:31 2019 New Revision: 371181 URL: http://llvm.org/viewvc/llvm-project?rev=371181&view=rev Log: [lldb][NFC] Remove Args::StripSpaces This just reimplemented llvm::StringRef::[r/l]trim(). Modified: lldb/trunk/include/lldb/Utility/Args.h lldb/trunk/s

[Lldb-commits] [PATCH] D67230: Remove call to obsolete gethostbyname, using getaddrinfo

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Sounds like a good idea, particularly as gethostbyname is not thread safe. It seems getaddrinfo is already used in lldb, so it should be supported by all OSs that we care about. Repository:

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

labath added a comment. Thank you for adding the tests, and for adding the `xz` detection to lit in particular. We're getting _reaally_ close now. I have a bunch more comments, including highlighting some you seems to have missed from earlier, but they are all just about polishing. The only som

[Lldb-commits] [PATCH] D67227: [lldb] Extend and document TestIRInterpreter.py

teemperor updated this revision to Diff 219059. teemperor added a comment. - Relaxed can_handle_operands that it allows shifting unsigned large values (produced by initialising them with negative signed values). - Now checking for 32bit instead of 7 (thanks Shafik!) CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D67230: Remove call to obsolete gethostbyname, using getaddrinfo

This revision was automatically updated to reflect the committed changes. Closed by commit rL371195: Remove call to obsolete gethostbyname, using getaddrinfo (authored by serge_sans_paille, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

[Lldb-commits] [PATCH] D66638: Unwind: Add a stack scanning mechanism to support win32 unwinding

labath added a comment. Thanks for the quick reply. My responses are inline: In D66638#1659866 , @amccarth wrote: > I don't have any specific code comments, but I do have a couple general > questions and points to consider. > > 1. `isFoundHeuristically`

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

labath marked an inline comment as done. labath added inline comments. Comment at: lldb/lit/Breakpoint/minidebuginfo-corrupt-xz.yaml:13 + +# RUN: %lldb -x -b -o 'image dump symtab' %t.obj 2>&1 | FileCheck %s + labath wrote: > You shouldn't need an explicit `-x` i

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk added a comment. I've tackled the easy comments now and will come back to the more detailed ones as well. I'm not ignoring them. Comment at: lldb/CMakeLists.txt:101 - set(LLDB_TEST_DEPS lldb) + set(LLDB_TEST_DEPS lldb llvm-nm llvm-strip) labath wrot

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 219064. kwk marked 16 inline comments as done. kwk added a comment. - Removed not needed test dependencies - Changed return type of lzma::getUncompressedSize - Moved minidebuginfo to subtree that deals with ELF - Apply review comments Repository: rG LLVM Githu

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

labath marked an inline comment as done. labath added inline comments. Comment at: lldb/include/lldb/Host/LZMA.h:24-25 + +llvm::Error getUncompressedSize(llvm::ArrayRef InputBuffer, +uint64_t &uncompressedSize); + kwk wrote: > laba

[Lldb-commits] [PATCH] D66638: Unwind: Add a stack scanning mechanism to support win32 unwinding

labath updated this revision to Diff 219071. labath marked an inline comment as done. labath edited the summary of this revision. labath added a comment. - s/FoundHeuristically/RaSearch - max_iterations:=256 - tweak the handling of "own frame size" instead of having the unwinder ask for it, it is

[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Make the RedirectingFileSystem hold on to its own working directory.

labath added a comment. Thanks Jonas. This looks fine to me, but someone who actually works on VFS (/me looks at @sammccall) will need to ack that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65677/new/ https://reviews.llvm.org/D65677 _

[Lldb-commits] [PATCH] D67230: Remove call to obsolete gethostbyname, using getaddrinfo

davezarzycki added a comment. This code is trying too hard and failing. Either the result of gethostname() is canonical or it is not. If it is not, then trying to canonicalize it is – for various reasons – a lost cause. For example, a given machine might have multiple network interfaces with mu

[Lldb-commits] [PATCH] D66638: Unwind: Add a stack scanning mechanism to support win32 unwinding

clayborg added a comment. So made a "sbt" command in a Python module as a way to get a backtrace when our backtracing fails because Android almost never makes it back to the first frame for any stacks. This code just grabs the current SP, looks up the memory region using the SP, and then it use

[Lldb-commits] [PATCH] D66638: Unwind: Add a stack scanning mechanism to support win32 unwinding

clayborg added inline comments. Comment at: source/Plugins/Process/Utility/RegisterContextLLDB.cpp:1875 + if (addr.SetLoadAddress(candidate, &process.GetTarget()) && + addr.GetSection()->GetPermissions() & lldb::ePermissionsExecutable) { +address = candidate

[Lldb-commits] [PATCH] D67022: Enhance SymbolFileDWARF::ParseDeclsForContext performance

clayborg added a comment. This looks like a good approach to me. Pavel? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67022/new/ https://reviews.llvm.org/D67022 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D67022: Enhance SymbolFileDWARF::ParseDeclsForContext performance

guiandrade added a comment. In D67022#1660901 , @clayborg wrote: > This looks like a good approach to me. Pavel? Even without tests? Just to clarify my last comment, I could not find a way to use the command "target modules dump as" to ensure we won't h

[Lldb-commits] [PATCH] D67022: Enhance SymbolFileDWARF::ParseDeclsForContext performance

clayborg added a comment. In D67022#1660945 , @guiandrade wrote: > In D67022#1660901 , @clayborg wrote: > > > This looks like a good approach to me. Pavel? > > > Even without tests? Just to clarify my last comment,

[Lldb-commits] [PATCH] D67022: Enhance SymbolFileDWARF::ParseDeclsForContext performance

guiandrade added a comment. In D67022#1660979 , @clayborg wrote: > In D67022#1660945 , @guiandrade > wrote: > > > In D67022#1660901 , @clayborg > > wrote: > > > > > This lo

[Lldb-commits] [PATCH] D67230: Remove call to obsolete gethostbyname, using getaddrinfo

serge-sans-paille added a comment. @davezarzycki I tend to agree with you. We can just remove 35:44 and just keep the hostname. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67230/new/ https://reviews.llvm.org/D67230 ___

[Lldb-commits] [PATCH] D67227: [lldb] Extend and document TestIRInterpreter.py

shafik added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/commands/expression/ir-interpreter/TestIRInterpreter.py:48 +self.type = type +self.decl_expr = type + " " + self.name + " = " + str(self.value) +self.unsigned_type =

[Lldb-commits] [lldb] r371234 - [lldb] Small optimization of FormatMap::Delete and FormatMap::Get

Author: jankratochvil Date: Fri Sep 6 10:52:27 2019 New Revision: 371234 URL: http://llvm.org/viewvc/llvm-project?rev=371234&view=rev Log: [lldb] Small optimization of FormatMap::Delete and FormatMap::Get Modified: lldb/trunk/include/lldb/DataFormatters/FormattersContainer.h Modified: lldb/

[Lldb-commits] [PATCH] D67239: [Core] Remove use of ClangASTContext in DumpDataExtractor

xiaobai updated this revision to Diff 219145. xiaobai added a comment. Refactored slightly to be a bit safer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67239/new/ https://reviews.llvm.org/D67239 Files: lldb/include/lldb/Symbol/ClangASTContext

[Lldb-commits] [PATCH] D66654: 2/2: Process formatters in reverse-chronological order

jankratochvil updated this revision to Diff 219147. jankratochvil added a comment. I have tried the `MapVector` with `RegularExpressionSP` as its key as suggested by @labath but that would be even more code than the `std::list` I provided here, both for its custom shared-pointer sorting and for

[Lldb-commits] [lldb] r371258 - [Core] Remove use of ClangASTContext in DumpDataExtractor

Author: xiaobai Date: Fri Sep 6 14:05:21 2019 New Revision: 371258 URL: http://llvm.org/viewvc/llvm-project?rev=371258&view=rev Log: [Core] Remove use of ClangASTContext in DumpDataExtractor Summary: DumpDataExtractor uses ClangASTContext in order to get the proper llvm fltSemantics for the type

[Lldb-commits] [PATCH] D67239: [Core] Remove use of ClangASTContext in DumpDataExtractor

This revision was automatically updated to reflect the committed changes. Closed by commit rL371258: [Core] Remove use of ClangASTContext in DumpDataExtractor (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: ht

[Lldb-commits] [lldb] r371259 - [test] Add a FIXME test for stop-command-source-on-error

Author: jdevlieghere Date: Fri Sep 6 14:43:33 2019 New Revision: 371259 URL: http://llvm.org/viewvc/llvm-project?rev=371259&view=rev Log: [test] Add a FIXME test for stop-command-source-on-error Modifying the interpreter settings is tricky because they don't take effect until we create a new com

[Lldb-commits] [lldb] r371280 - Long timeouts for the MacOSX SystemRuntime plugins under ASAN; else quick.

Author: jmolenda Date: Fri Sep 6 18:38:37 2019 New Revision: 371280 URL: http://llvm.org/viewvc/llvm-project?rev=371280&view=rev Log: Long timeouts for the MacOSX SystemRuntime plugins under ASAN; else quick. In April via r357829, Adrian unified timeouts across lldb and set the default value hig